- 08 Dec, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c0eca5f..53a11922 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb66213aa84c62e839b496576ad2c4cef60dc121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577702Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834594}
-
Greg Kerr authored
Bug: 1025993 Change-Id: I780717cffbdd5d18f030667e52874d58d21439b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572785 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#834593}
-
Joshua Peraza authored
bccb9504d1fb Roll crashpad/third_party/edo/edo/ 97121c640..6ffbf8331 (19 commits) 70f1ec86f95d ios: Fix setup_ios_gn.py after gn roll 0917d31d19ef Update lss README.crashpad to point to corrected name for license ed132d5ec247 [syslog] Expect logsink client includes 121d92ca3f1a Roll crashpad/third_party/mini_chromium/mini_chromium/ cb82d7129..c748b289b (2 commits) 6c270cf239df linux: Refactor test modules 20cbfa49719c linux: Use mmap for attachments in PtraceBroker 00491d58ee29 linux: Correct handling of load bias 83f194ee8544 linux: Add linux-gate.so to valid vdso prefixes Bug: chromium:1147922, chromium:1128441 Change-Id: If032f0e3c81b5fc1452867ecab4211fa713c276c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573518 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#834592}
-
Michael Bai authored
Adds PropagateAutofillPredictions method in AutofillHandler, it is invoked by ContentAutofillDriver, this seems detour, but reasonable consider AutofillDriver::PropagateAutofillPrediction also applies to ios. Adds OnServerPredictionsAvailable to AutofillProvider and test. Add parameter to enable the autofill download in AutofillHandlerProxy, the download still disabled. Bug: 1151542 Change-Id: I2feb36d57f17ee04bd152ce02f493074ba99419d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574532 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#834591}
-
Tal Pressman authored
These functions are unused. Change-Id: I5cb37b52bf5518490a96d533ffe417cbc920993b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578222Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#834590}
-
Leo Lai authored
This issue can be reproduced with enable_nacl = false on top of linux chromos build. Bug: 1126359 Change-Id: I35feda29e79ccb8758e41fe1bb693bfed79c4575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577392Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834589}
-
Josiah K authored
Before: https://screenshot.googleplex.com/6QKNdedpCna7U8k After: https://screenshot.googleplex.com/97xdZg4vCkbPsVd AX-Relnotes: Move switch assignments from right side of assignments link, to below main label, to match mocks. Bug: 1156233 Change-Id: I3b59a3f2bf94af2e3a8017c421444ce71e452477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576230 Commit-Queue: Josiah Krutz <josiahk@google.com> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Auto-Submit: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#834588}
-
Meredith Lane authored
This patch has no functional difference, it is just a refactor. This completes the work and removes the remaining pieces of the AXSparseAttributeClients from various places, reducing complexity. The function map has now been renamed to AXSparseAttributeSetterMap, replacing the previous one. AX-Relnotes: N/A Bug: 1068668 Change-Id: Ie76dc4d3bc4f75b863af3877e3034c7417a34378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434419Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#834587}
-
Harry Cutts authored
isherman@ pointed out that this should be set since these names are only ever reported with suffixes. Bug: 1114828 Change-Id: I8d015e50cfbcb23592a28a4f19ec70fdbb02e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577836 Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#834586}
-
Morten Stenshorne authored
There was some old code that wasn't needed anymore, and it was causing trouble for nested multicol. We need to break before a multicol container if it doesn't fit. The column layout algorithm always tries to limit the block size of an inner multicol container, so that it will fit in the outer fragmentation context. If that's not possible, though, we need to break before it and retry in the next outer fragmentainer. So for multicol container children we needed the code path that we previously only ran for child.IsMonolithic(), but we can in fact always do that (if it doesn't fit, and we're allowed to break, let's break!), so just delete the unnecessary code, and fix 5 tests. :) Bug: 829028 Change-Id: I93b6b10c8b427055e69f094b460c13fa68a49fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575031 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#834585}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c5f0baa72f1..1742f98791c9 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia536fd245755a8c847c59a28439391bc72f94e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578191 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834584}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/4E0Kat64Xt3-kQkf_9Z8eXNVVOdY-Dm0TKYMn0bV9SEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/164161478,b/174637068 Tbr: media-app@grotations.appspotmail.com Change-Id: If8c77cd67cb4daf04634b96acc8604b2808da0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578165Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834583}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607363880-ba632ae780cc1bebf61d324b0c586630719677ae.profdata to chrome-win64-master-1607374595-d12d27ca344e18f0b40a9dc8f54420fe6b49bde9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibdb83918b30c0576bc41ff4ca52348994f686695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577765Reviewed-by:
-
Morten Stenshorne authored
If we're doing nested column balancing (a column-fill:balance multicol container with another column-fill:balance multicol container descendant), we may need to stretch the outer multicol container to make the inner one fit. Just propagate the space shortage detected while laying out the inner column row, so that the outer multicol container can use this to stretch itself. Bug: 829028 Change-Id: I0b45d6f5d02f0f597f2d2de3442e728eb2abbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574754Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f639a24c5041..554e7574e960 2020-12-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 7c84426d2abe to 84b9bb6621c7 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Iab52d2347eb67beb9e093b806b10cdcb30e07cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578398Reviewed-by:
-
Joel Hockey authored
Modify TrashRootEntry DirectoryReader to not create directories if they don't already exist since creating the directories causes unexpected FileWatcher directory rescans which interferes with tests. Downloads no longer shows the dialog for deleting - it shows only the toast. Drive will show the dialog. So for tests that are explicitly testing things about the dialog interaction, I moved the files into Drive. Bug: 953310 Change-Id: I7e155739fc2f694797e904898519336915c0a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574641Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#834579}
-
cfredric authored
This cl also converts a portion of CanonicalCookie unit tests to use matcher-based code, in order to be able to more easily assert multiple things about multiple parts of the return value of IsSetPermittedInContext. (E.g., being able to make assertions about both the |status| and the |is_allowed_to_access_secure_cookies| fields of the |CookieAccessResult|. This also has the benefit of being more declarative and avoiding declaring temp variables, which are error-prone. In particular, this fixes bugs where the wrong temp variable was accidentally used (lines 2785, 2899). This cl also fixes a bug (in test) where the LEGACY access semantics were accidentally unused, with UNKNOWN being redundantly used instead (lines 2967-2987). Change-Id: I09b981f5f0819807ff5dd769022e4d6baa5f50a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571806Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#834578}
-
Bao-Duy Tran authored
input_methods.txt [1] is the legacy config file from before the migration to extension-based input methods circa 2011. Almost all of its contents are obsolete and should no longer be used for reference. [1] https://source.chromium.org/chromium/chromium/src/+/master:chromeos/ime/input_methods.txt;drc=8cbe6597e4cc8457f4e33ef2ad189f0553f59f54 Bug: 1134526 Change-Id: I4d6023e396b7e44eda47882a33dd093ed10e5dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576993 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834577}
-
Archie Pusaka authored
In Bluetooth, the UUIDs are given in little endian order. Therefore, the byte array must be reversed before it is encoded into strings. Bug: None Change-Id: I0aeca5a1159566b674638ce3451a33665a5382ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561960Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#834576}
-
Josiah K authored
Change-Id: I36822be0c3d4e7159780605b2d2902e5aa0ca0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578397 Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Josiah Krutz <josiahk@google.com> Cr-Commit-Position: refs/heads/master@{#834575}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7af16c5f6fe..8ae45db84a78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nancylingwang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nancylingwang@google.com Change-Id: Ie2b9f1390c465220e0f86f5203f4bd6cc6f8fff5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577014Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607353071-d7cc2aeaf74b32bdf69634e0f6483d7e4b0ffed2.profdata to chrome-win32-master-1607374595-14878fd6c473cc4aebbe55be6f54c0ff79c3ed8e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4567f19fc485db05ea7cd23391df1973fc27cc93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577811Reviewed-by:
-
Bao-Duy Tran authored
For folders shared with non-CrOS, ideally we should leave the old Monorail component config there, but unfortunately only a single component is allowed, so leave a comment instead. Bug: None Change-Id: I0e8c235e29bffff1ea295d5bb8ff090b6a0a7545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569192Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834572}
-
Shik Chen authored
Bug: b/172879638 Test: Manually in expert mode Change-Id: I382cd06c1c9fb06a80c82d783d3ca023a3e82542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570837 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834571}
-
Jeffrey Cohen authored
[Project Code Inclusion] Remove all uses of whitelist/blacklist in chrome/android/.../contextualsearch Bug: 1151331 Change-Id: I73e1bc80116e40a43071d316dd2f72d9e882ffc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576955 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#834570}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5921e781cd6d..2b3b0f567d42 2020-12-08 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0f52d0f2fd63c0e2fa7b764722a7956bbd4ea0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578257Reviewed-by:
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination from ExtensionsBrowserClient::AllowCrossRendererResourceLoad() since blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I848b468f064f4ea938aad9450483ee91fb0bd6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562002Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#834568}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd204543. With Chromium commits locally applied on WPT: 86af9c78 "Revert "[blinkpy] Re-enable four css-background/ tests that need fuzzy reftest"" 79440c3a "Fail gracefully if |parameter| object has an invalid array topology" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I5c0a77726746b4f7010e6a860d8594c3dd452b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575580Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834567}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/48b2aad780bf..3bf980426002 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I74be0a6920c53ef98b541752bb54771ca6bf5f4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577895Reviewed-by:
-
Ryan Keane authored
This CL defines a layer in between the gRPC Channel and the CmaBackend, which is responsible for converting between internal and external entity types, and ensuring that calls to the CmaBackend occur on the proper thread. Bug: b/167426091 Change-Id: I7bf46475f147a62500f155eb670b4983de4ba824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519156 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
-
Patti authored
Cherry-pick of change to fix incorrect "Date modified" metadata for RAW files. CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/63ygjtmacn3rLs5DIX3qYrJpb5lK-y2kDmejad9ymXwC Release_Notes: http://go/media_app-x20/relnotes/Branch/media_app_202011120600_RC02.html click the "information" icon at the top. The date shown under 'Date modified' should match the date modified shown in Files app (and not the current date/time). Test: Open a RAW file via the files app. It will open in Backlight. Then, Bug: b/174603791 Change-Id: Ie0b49e01a4263658c2f151ffcd05f6d9c4fcd291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577391Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#834564}
-
Daniel Rubery authored
This metric is expected to be generally useful in case of any debugging reliability with Safe Browsing's download protection endpoint. We have a Chirp elert on SBClientDownload.CheckDownloadStats, and any rise in the SERVER_PING_FAILED bucket would cause us to check this metric. Fixed: 1153861 Change-Id: I82cd811869549976c9eef5358c0a41e37b9d7db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577486 Auto-Submit: Daniel Rubery <drubery@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
This is the counterpart of crrev.com/c/2572783, for M88+, to ensure the new GraphicsLayer created for an iframe will be collected. This is mainly to add the test, but to make the test pass, similar code is added in BeginLifecycleUpdates() to ensure safety. Bug: 1152920 Change-Id: I4098bdbce87c7354cd1f157047a6475ee7bd46fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577612Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834562}
-
Ian Barkley-Yeung authored
Gives the browser the ability to tell the renderer that it wants stack traces on error-level console messages. Useful if we are sending error reports about those messages back to Google. Empirically, both console.error messages and unhandled exceptions get stack traces; unhandled promise rejections do not. Bug: chromium:1121816 Change-Id: I63768696dbd120522d7b5fb1e7133d8c233b213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556008Reviewed-by:
dstockwell <dstockwell@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#834561}
-
chrome://flagsElaine Chien authored
Bug: 1145666 Change-Id: Ieb06cd829b7c7eb0170a1af5de121661a430f4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575430 Commit-Queue: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#834560}
-
Alexander Timin authored
Back-forward cache is in the process of being shipped and under active further development, so this flag is going to be useful for the foreseeable future. R=fergal@chromium.org Change-Id: I5c72a74dd7f7f7ed015ef4dd2942eb75718f9733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574983 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834559}
-
Nancy Wang authored
This reverts commit bc24c252. Reason for revert: <INSERT REASONING HERE> It looks like this CL breaks below tests: GpuDataManagerImplPrivateTest.FallbackFromVulkanToGL GpuDataManagerImplPrivateTest.VulkanInitializationFails GpuDataManagerImplPrivateTest.FallbackFromVulkanWithGLDisabled GpuDataManagerImplPrivateTest.GpuStartsWithVulkanFeatureFlag https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/5190 https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel Original change's description: > Disable Vulkan for LACROS > > Bug: 1155622 > Change-Id: I8def57cef648ec4881f666aec614200d13eac972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577815 > Auto-Submit: Peng Huang <penghuang@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834507} TBR=penghuang@chromium.org,rjkroege@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I249afa54900b08acbd75b37ac3e15d853b6bb32c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578418Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834558}
-
Alan Screen authored
Incorporate support for retrieving a printer's semantic capabilities and defaults from the utility service instead of within the browser process. This protects the browser from potential crashes as well as reducing jank by not having the UI thread blocked waiting on the call to return. Bug: 809738 Change-Id: I900939877679fe09a245b4796e6b1bb0110eec71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441668Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834557}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3b055d329e60..5c5f0baa72f1 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-12-08 nodir@chromium.org Revert "[dirmd] Roll dirmd" 2020-12-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-12-08 sokcevic@google.com Add change HEAD cli option to gerrit_client 2020-12-08 nodir@chromium.org [dirmd] Roll dirmd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154541 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib66c98267321fb14b9f4bb477c4edc3aa198c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578160Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I0b653cc0888a98faa504656b288f6c2c4ad1502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578163Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834555}
-
