GitLab

This is for reuse by RasterDecoder in a subsequent CL. The test added
for GLES2DecoderImpl is similar to what will be added for
RasterDecoderImpl.

Changes:
- made CopyTextureMethod an enum class for easy forward decl
- moved ValidateCopyTexFormatHelper and GetCopyTextureCHROMIUMMethod for
  future reuse
- added mock for texture copying
- added unittest to make sure that texture copying clears source and
  destination textures appropriately

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I44a1ca37ad48d065acfd9d94b737ac1d925d99e5
Reviewed-on: https://chromium-review.googlesource.com/993592
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548228}

https://skia.googlesource.com/skia.git/+log/42f8bc40fd37..bf74a460814a

$ git log 42f8bc40f..bf74a4608 --date=short --no-merges --format='%ad %ae %s'
2018-03-22 liyuqian Fix drawBitmapRect in the threaded backend
2018-04-03 mtklein add Mac ASAN bots
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 7dd7eed65..d26d270c8 (1 commit)
2018-04-04 djsollen Tag the unique keys of lazy images.
2018-04-04 robertphillips Add SkSurfaceCharacterization operator== && !=
2018-04-04 bsalomon Revert "Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.""
2018-04-04 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5d232d53b..bc54342bf (6 commits)
2018-04-04 egdaniel Don't use the inner radius when not stroking in DIEllipse
2018-04-04 bsalomon Revert "Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used."
2018-04-03 benjaminwagner Add mips64el_toolchain_linux asset.
2018-04-03 bsalomon Make SkSL GLSL generator declare sk_FragColor inout when EXT fb fetch is used.
2018-04-04 egdaniel Handle perspective scales in GrPathUtil scaleToleranceToSrc
2018-04-03 robertphillips Hide GrPixelConfig in SkSurfaceCharacterization
2018-04-04 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 770177dc9..7dd7eed65 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Id7caf5d1cb7c734bf9e1874ef87e4897d045e822
Reviewed-on: https://chromium-review.googlesource.com/996179Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548227}

BUG=827826

Change-Id: I6b91c4a9691f19df11f39a0799df5d5a4703681f
Reviewed-on: https://chromium-review.googlesource.com/996251Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548226}

This CL will early-out on a bad URL or there are too many requests inflight. This
avoids allocating and freeing a BitmapFetcherRequest (which is unnecessary).
This is a minor optimization for an uncommon case, but I plan to increase
the use of the bitmap fetcher - so this may become more common.

Bug: None
Change-Id: I3d498008a78faf622fcee68d20c4e9234e581e80
Reviewed-on: https://chromium-review.googlesource.com/994116
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548225}

Bug: internal b/77586397

Change-Id: I1a40b631bc3666e38008a367458737a4564f93a7
Reviewed-on: https://chromium-review.googlesource.com/994135Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548224}

Removes the was_focused_by_mouse_ flag implemented by a number of form elements,
and replaces it with a check for Node::WasFocusedByMouse().

R=tkent@chromium.org

Bug: 817199
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibd8477732d5646f928c010a5c1cef853bafc38ee
Reviewed-on: https://chromium-review.googlesource.com/988352
Commit-Queue: Rob Dodson <robdodson@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548223}

Bug: 822951
Change-Id: If213f5703c966868778cd00511f222eba6ff5191
Reviewed-on: https://chromium-review.googlesource.com/990575
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548222}

Before playing media using the MediaPlayerBridge, we try to parse the
metadata, using the MediaResourceGetter. This class uses the Android
MediaMetadataRetriever API, which can be be resource intensive. We
eventually get all of the metadata we need from the Android
MediaPlayer, and pre-parsing the metadata sometimes does nothing but
delay the start of playback.

This CL removes the java MediaResourceGetter, and removes metadata
extraction capabilities from the C++ portion of the
MediaResourceGetter interface.

NB: This is unlikely to have a performance effect on HLS playback,
since the MediaResourceGetter did not support parsing HLS.

Bug: 739914
Change-Id: I460d5aea02bf1a0bf099f66a781a40ca6374d4d0
Reviewed-on: https://chromium-review.googlesource.com/988681Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548221}

BUG=829047

Change-Id: I3ff5012311bac36cef7636030e988143f47c3339
Reviewed-on: https://chromium-review.googlesource.com/996471Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548220}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: Ibfe71ea6fdd860fc83234fa31b3223339d0b71dc
Reviewed-on: https://chromium-review.googlesource.com/988847Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548219}

These tests have become especially flaky lately on one platform.
Disabling until the underlying problem can be fixed.

BUG=828780

Change-Id: Id6b56d76217a469641f13bb9be7e49d5bdc2e47e
Reviewed-on: https://chromium-review.googlesource.com/996017Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548218}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: I50409e8e4198a0b0e281cd6889c90935ca872402
Reviewed-on: https://chromium-review.googlesource.com/988846Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548217}

Bug: 828951
No-Try: True
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I75de3b418241c9b97cda622cd9798f06e0e08f3d
Reviewed-on: https://chromium-review.googlesource.com/996240
Commit-Queue: Menglu Huang <huangml@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548216}

When running gn gen with filters for the IDE output from ninja,
the gn gen command used the working directory (//out/foo) as the
base for resolving the filters, rather than "//" as is done when
running gn gen directly.

This CL fixes that by always using "//" as the root_dir. It also
fixes filter labels that have had the leading "/" in "//" removed
by Git Bash.

R=dpranke@chromium.org

Change-Id: I6c6e6f5e720d50b325d8b368f94ee1b3b5931627
Reviewed-on: https://chromium-review.googlesource.com/941209Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Yngve Pettersen <yngve@vivaldi.com>
Cr-Commit-Position: refs/heads/master@{#548215}

Impose a limit on the depth of the embedding, to avoid a stack overflow
during the generation of the hit-test data phase.

BUG=820835

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I07f3dbb5422458db703661b421b315e1ca4784dd
Reviewed-on: https://chromium-review.googlesource.com/993033Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548214}

- RemoteViewHost derived from NativeViewHost on embedder side to embed
  a window and host the embedding window in view hierarchy;
- RemoteViewProvider on the embedded side to prepare an aura::Window
  to be embedded;

Bug: 812434
Test: views_mus_unittests --gtest_filter=RemoteView*
Change-Id: I1c999bf07d16330cf8b97df5e7f55b5bbcaa377a
Reviewed-on: https://chromium-review.googlesource.com/989014Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548213}

Change-Id: Iefcc1aeee3ce71147d2d5fe8255ca61707feb12b
Reviewed-on: https://chromium-review.googlesource.com/994710Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: David Tu <dtu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548212}

For a non-self-painting layer having self-painting descendants, the
non-stacked layers are painted through the non-self-painting layer's
parent, which may be different from the non-self-painting layer's
container through which the non-self-painting layer is painted. We
need to invalidate both path to ensure correct subsequence caching.

Bug: 826659
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic0d0745a50f34b7b7e23da226e62e8599de68aa5
Reviewed-on: https://chromium-review.googlesource.com/990718Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548211}

There are a few further cleanups still to land, but this removes most of the
code needed to compute/draw infobar arrows, as well as code that is "fallout"
from having them.

Now that arrows are never drawn, all this complexity is unnecessary.

BUG=none
TEST=none

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib8d9f83c56e98321b8a7f65e5503d849cd2e0d9d
Reviewed-on: https://chromium-review.googlesource.com/991056Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548210}

Change TextInputClientMac from using NS types to using types that can
go through IPC.

The goal of this is to allow TextInputClientMac to exist in the
browser process, while the RenderWidgetHostViewCocoa exists in the
AppShim process. The problematic type here is NSAttributedString, which
will need to be kept in encoded form until it reaches the AppShim.

Change NSPoint, NSRect, and NSRange to the gfx types. This ends up
letting us delete lots of convert-then-convert-back code (in addition
to allowing IPC).

Change NSUInteger to uint32_t (and NSNotFound to UINT32_MAX, as is done
elsewhere).

Change objective C blocks to base::OnceCallbacks. This may end up not
being necessary, but seems a good fit (we will likely need to use weak
pointers for them in the future).

Change-Id: I32a1ef9017a089c26c20132dfc6843a1dbb6ace7
Reviewed-on: https://chromium-review.googlesource.com/991601
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548209}

Bug: 706795
Change-Id: I524a968de6e1d41d920fc8e70dcda0cdf778a380
Reviewed-on: https://chromium-review.googlesource.com/993239Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548208}

Bug: 776495,790130
Change-Id: Ib0e99ee9d6bf22d1ffcfd78e3ae85507368c4de2
Reviewed-on: https://chromium-review.googlesource.com/996409Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548207}

Bug: 827510
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2a2f730de3ac0973c826672bfb9486e3630d7292
Reviewed-on: https://chromium-review.googlesource.com/988245Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548206}

Bug: 806996
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5ffa57b0a4231917e3d3a227cb986c8f5a5f3827
Reviewed-on: https://chromium-review.googlesource.com/996313Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548205}

The original version of the test used base::SimpleThread, which uses Chrome TLS
behind the scenes. This ends up tickling a difference between Fuchsia and other
POSIX implementations with respect to the order in which pthread keys are
destroyed.

The new version of the test uses pthread APIs to avoid this, which fixes the
bug.

Change-Id: I8eaf3230a31f96f9ee03afa88a1b7ee8b770bb42
BUG: 828897, 825218
Reviewed-on: https://chromium-review.googlesource.com/996038Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548204}

Bug: 820962
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6fba6413a7ad3668e792efd988304747a0e13701
Reviewed-on: https://chromium-review.googlesource.com/994234Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548203}

All other logging in that file is DVLOG(1), so be consistent

R=satorux@chromium.org

Change-Id: I1c0dc9128cc3c681b6c26dd169fe73a7323af97b
Reviewed-on: https://chromium-review.googlesource.com/975602Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548202}

Only record in OnError if callback_ is still set. Otherwise every
success case will also result in recording "Aborted", via the destructor
of the class calling OnError.

Bug: 712693
Change-Id: I0d73119017b6d88fca4378687d5187ed96919b49
Reviewed-on: https://chromium-review.googlesource.com/994232
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548201}

Bug: 825771
Change-Id: I98e174f29538fadd104c61706766b28ab0b9db7d
Reviewed-on: https://chromium-review.googlesource.com/994377Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548200}

The flag removal would allow Skia to choose the better
AA algorithm for a better performance.

bug: chromium:817942 chromium:819185 chromium:817110

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I57f5b1c1ef88eb97172f8aa24be85b9f29c07b84
Reviewed-on: https://chromium-review.googlesource.com/976622Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548199}

- Some interfaces had separate functions for click and button click, while
  some used parameters to distinguish. Consolidate on shared functions.
- Update some notifications to use HandleClickNotificationDelegate or
  ThunkNotificationDelegate.

BUG=776205,755413

Change-Id: Ib133bdf93277c84c99311256c47a250d2b8e571f
Reviewed-on: https://chromium-review.googlesource.com/963619
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548198}

Bug: 820783
Change-Id: I267abfb965803de16b5f06d434b0c93783e10d8d
Reviewed-on: https://chromium-review.googlesource.com/990729Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548197}

Move associated logic over to the browser process side, from the Cocoa
side.

Bug: 821651
Change-Id: I9c7ef8c3af841af6bfd855fc2982be277398b94a
Reviewed-on: https://chromium-review.googlesource.com/991123Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548196}

|is_posix| will be switched to false for Fuchsia, this is a preliminary change.

Bug: 812974
Change-Id: I682e0aca08051f4c930ea7b3435bdf3ca0c91d2b
Reviewed-on: https://chromium-review.googlesource.com/988811Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548195}

This updates webkit, services and sandbox.

Targets go from foo_features to foo_buildflags
And similarly the header now has buildflags in the name.

BUG=814485
TEST=covered by build

Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Change-Id: If082636e3f84033a3345d135847d5847436b6814
Reviewed-on: https://chromium-review.googlesource.com/992999Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548194}

With this CL, the NetworkContext owns URLLoaderFactories which own
URLLoaders.  Each class informs its parent when it can safely be
destroyed.  URLLoaderFactory::Clone() now adds another binding to the
current factory, instead of creating a new one.  URLLoaderFactories
now stay alive as long as either they have at least one live binding
or one live URLLoader.

This change will allow a single URLLoaderFactory to own all shared
starts URLLoaders created using it need, such as a URLLoader-specific
side channel.  The previous arrangement, where URLLoaderFactories
could be destroyed before URLLoaders created by them, and Clone()
created a new URLLoaderFactory, would have required reference
counting all shared data, which can make code harder to follow, and
lead to a wide array of lifetime issues.

This change will also make it trivial to remove the use of
URLRequestContextGetter from services/network.

Bug: TODO
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I256743b79c333b2648964b03daf7105743d6c55e
Reviewed-on: https://chromium-review.googlesource.com/988475
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548193}

Screenshots of what the updated UI looks like on a device:

 - After the user tries to supply invalid PPD (https://screenshot.googleplex.com/omvyD9dhUNp)

Bug: 820359
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie4651ab9437a5f18b95e5240040e80e6e0ac271a
Reviewed-on: https://chromium-review.googlesource.com/971469Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548192}

As part of PIN sign-in there is going to be an associated PinStorageCryptohome
which calls into cryptohome to do authentication.

TBR=battre@chromium.org

Bug: 826773
Change-Id: Iaef1c0f669d620290e9a2503d1c46d69bafd0419
Reviewed-on: https://chromium-review.googlesource.com/990935
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548191}

Bug: 783000,783001
Change-Id: I690ed41e7a6151f92d1253284a6b66ab87266672
Reviewed-on: https://chromium-review.googlesource.com/982388
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548190}

DraggedNodeImageBuilder::CreateImage calculates the size and paint offset for
drag images. After [1], the paint offset was the position of the dragged
layout object in the enclosing layer's space. This was incorrect because a
positioned descendant of the dragged object is painted in the drag image so
the paint offset needs to be adjusted to the top-left of the bounding box of
all content in the drag image (in the enclosing layer's space). This is easy
to compute because we already have the bounding box in the enclosing layer's
space, so this patch just uses the bounding box's location.

[1] http://crrev.com/16b3d20c33

Bug: 820114
Change-Id: Idc634b3ddc79d0a47003362463b0c3d58f6f516c
Reviewed-on: https://chromium-review.googlesource.com/996376Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548189}