GitLab

The browser updates the overlay video mode flag before the renderer can
send a new frame. This means that when switching from fullscreen to
non-fullscreen the browser was expecting the renderer the fill the frame
completely and wasn't drawing the background, but it was accidentally
leaving part of the frame corrupted and uncleared.

BUG=631866
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2302023003
Cr-Commit-Position: refs/heads/master@{#417131}

* Provide a single jumping off point that avoids memory leaks when using
  the OfflinePageDownloadBridge from the menus.

* Provide a single function for determining whether the offline pages button
  should be clickable.

BUG=616324

Review-Url: https://codereview.chromium.org/2322773002
Cr-Commit-Position: refs/heads/master@{#417130}

We're going to start with just NVIDIA Maxwell and Pascal GPUs enabled,
then gradually expand to earlier GPUs once we're sure everything's stabilized.

BUG=643850
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2316873002
Cr-Commit-Position: refs/heads/master@{#417129}

BUG=chromedriver:1497
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2315363003
Cr-Commit-Position: refs/heads/master@{#417128}

Revert of Allow canvases to be GPU-accelerated in Workers (patchset #5 id:80001 of https://codereview.chromium.org/2300633004/ )

Reason for revert:
This makes the following tests fail on Linux MSAN bot:

virtual/gpu/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html
virtual/display_list_2d_canvas/fast/canvas/canvas-createImageBitmap-invalid-blob-in-workers.html

Build link:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12091

Original issue's description:
> Allow canvases to be GPU-accelerated in Workers
>
> This change sets up a per-thread shared GPU context that is managed by
> a thread-specific singleton SharedGpuContext.  This means that all 2D
> contexts on a given worker will use the same context, which avoids
> having to rely on mailboxes all the time.  Also this CL makes deep changes
> to AcceleratedStaticBitmapImage in order to support the use of
> the current thread's shared context, and it handles transfers
> between threads in order to support the transferrable behavior of
> ImageBitmap objects.
>
> BUG=593514
>
> Committed: https://crrev.com/83ac5ff37da4ea1c6d052649ccea46dd4bd453d6
> Cr-Commit-Position: refs/heads/master@{#416929}

TBR=kbr@chromium.org,haraken@chromium.org,junov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=593514

Review-Url: https://codereview.chromium.org/2323573002
Cr-Commit-Position: refs/heads/master@{#417127}

Implements three orthogonal changes to the public bindings API:

 1. Adds the ability to remove bindings from a binding set. Uses
    a new mojo::BindingId integer alias to identify added bindings.

 2. Adds the ability to set a pre-dispatch hook on binding sets.
    In some cases simply making the dispatch_context() available
    is insufficient, for example when a consumer owns multiple
    binding sets and wants a common path for establishing context
    among any of them.

 3. Adds mojo::GetDummyProxy, a helper that can bind an
    AssociatedInterfacePtr<T> so that it has some valid internal
    state and silently drops all outgoing messages. Unlike
    regular message pipe interfaces, without this feature
    associated interfaces are difficult to stub out in test
    environments.

Part a series of CLs to enable and demonstrate WebContents associated
interfaces:

  1. https://codereview.chromium.org/2301123004
  2. This CL
  3. https://codereview.chromium.org/2310563002
  4. https://codereview.chromium.org/2310583002

BUG=612500
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2309513002
Cr-Commit-Position: refs/heads/master@{#417126}

Found these eslint errors on the new devtools buildbot I setup!

Right now, the buildbot is configured to be non-blocking (i.e. the errors
don't prevent commits from landing), but eventually it will be.

Eslint errors from buildbot:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_DevTools_Linux%2F475%2F%2B%2Frecipes%2Fsteps%2Frun_eslint%2F0%2Fstdout

BUG=none

Review-Url: https://codereview.chromium.org/2319823002
Cr-Commit-Position: refs/heads/master@{#417125}

This allows the user to disable the magnifier and use the palette while the magnifier is active.

TEST=ash_unittests
BUG=642535

Review-Url: https://codereview.chromium.org/2303963002
Cr-Commit-Position: refs/heads/master@{#417124}

R=nasko@chromium.org
BUG=510836

Review-Url: https://codereview.chromium.org/2312003006
Cr-Commit-Position: refs/heads/master@{#417123}

BUG=635611,635151

Review-Url: https://codereview.chromium.org/2322653002
Cr-Commit-Position: refs/heads/master@{#417122}

BUG=644664
R=dcheng@chromium.org

Review-Url: https://codereview.chromium.org/2321683003
Cr-Commit-Position: refs/heads/master@{#417121}

BUG=640375

Review-Url: https://codereview.chromium.org/2314503005
Cr-Commit-Position: refs/heads/master@{#417120}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/391b9e37..5cc438d6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2319313002
Cr-Commit-Position: refs/heads/master@{#417119}

By returning a signed simple challenge that can actually be parsed as SignedData, we allow callers of the FakeCryptohomeClient to extract the original data back and process it, making for better fake behavior and simpler tests.

Note that the signature is purposedly not verifiable in the FakeCryptohomeClient.

BUG=643245
TEST=chromeos_unittests; unit_tests and components_unittests also pass

Review-Url: https://codereview.chromium.org/2297193006
Cr-Commit-Position: refs/heads/master@{#417118}

Ensure that |Thread::id_| is only accessed when an happens-after relationship has been established with its write.

In practice this mostly means only reading it while |id_event_| is signaled.

Also don't AssertWaitAllowed() in WaitableEvent::TimedWait(0) on Windows to allow
WaitableEvent::IsSignaled() to be called on threads which aren't allowed to wait.
From MSDN:
  The time-out interval, in milliseconds. If a nonzero value is specified, the function
  waits until the object is signaled or the interval elapses. If dwMilliseconds is zero,
  the function does not enter a wait state if the object is not signaled; it always returns
  immediately. If dwMilliseconds is INFINITE, the function will return only when the object
  is signaled.

BUG=638578
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Review-Url: https://codereview.chromium.org/2303943003
Cr-Commit-Position: refs/heads/master@{#417117}

fraction of the crashes is due to bad font files. This
change adds more last resort fallback fonts in the vague
hope that at least one can be loaded successfully.

BUG=561873

Review-Url: https://codereview.chromium.org/2302663002
Cr-Commit-Position: refs/heads/master@{#417116}

https://chromium.googlesource.com/skia.git/+log/ef6a9b7f9393..14fe8cc16d2a

$ git log ef6a9b7f9..14fe8cc16 --date=short --no-merges --format='%ad %ae %s'
2016-09-07 ethannicholas refactored SkSL VarDeclaration handling GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2312233002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=caryclark@google.com

Review-Url: https://codereview.chromium.org/2320623004
Cr-Commit-Position: refs/heads/master@{#417115}

Add a LayerTreeHostInterface which is implemented by the LayerTreeHost.
This change moves the public methods on the LayerTreeHost used by the
embedder to an interface, in preparation for restricting the use of the
current LayerTreeHost implementation to the case where the compositor
thread componenets run in the same process (a.k.a single threaded and
threaded compositor), and a different implementation can be used where
these are seperated by a network boundary.

Currently only the use of the threaded compositor has been hidden
behind the interface. Subsequent changes will move the single threaded
compositor and the cc_unittests to use the interface as well.

BUG=625283
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317753002
Cr-Commit-Position: refs/heads/master@{#417114}

Sometimes the normal UI font is larger (eg. Hindi text). This code will ensure the Bookmark bar takes this into account and makes the height accommodate it. This eliminates painting artifacts when the Omnibox suggestions dropdown is displayed.

BUG=622678

Review-Url: https://codereview.chromium.org/2208973003
Cr-Commit-Position: refs/heads/master@{#417113}

Official build doesn't output strings on CHECK failures.

BUG=644768
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2319283002
Cr-Commit-Position: refs/heads/master@{#417112}

Made date input field read "mm", "dd", "yyyy", or equivalents in other languages, instead of "blank" when no date has been selected.

This matches visual experience, as well as screen reader experience on many websites.
BUG=643423
R=dtseng@chromium.org, esprehn@chromium.org, keishi@chromium.org, tkent@chromium.org, avi@chromium.org
TESTED=manually with Jaws

Review-Url: https://codereview.chromium.org/2306383005
Cr-Commit-Position: refs/heads/master@{#417111}

* Ensuring OPDownloadBridge is properly destroyed in TabletToolbar.java
* Removing CHECK from DownloadUIAdapter::OnOfflinePagesChanged as in situation
  when 2 pages get saved quickly one after another, it may carry 2
  changed guids instead of one.

BUG=638897

Review-Url: https://codereview.chromium.org/2318933004
Cr-Commit-Position: refs/heads/master@{#417110}

Applying the style text to the tree element when the popover is hidden
causes the section to update, not allowing clicks to register.

It is unnecessary to apply the style text when the popover is hidden
(unless reverting back to original property text) because the change
has already been applied.

BUG=644779

Review-Url: https://codereview.chromium.org/2307463004
Cr-Commit-Position: refs/heads/master@{#417109}

BUG=639095

Review-Url: https://codereview.chromium.org/2305983002
Cr-Commit-Position: refs/heads/master@{#417108}

Conforms to https://github.com/w3c/media-source/pull/47 spec change for
certain exceptional conditions, leaving a couple pieces for later changes:
1) bug 607372 "Comply with forcing appendMode to remain 'sequence' for MSE mp3 and adts stream parsers"
2) bug 644863 "Update TrackDefault and TrackDefaultList to use TypeError correctly"

BUG=623781
TEST=updated http/tests/media/media-source tests, and current related upstream w3c MSE tests

Review-Url: https://codereview.chromium.org/2315113002
Cr-Commit-Position: refs/heads/master@{#417107}

BUG=

Review-Url: https://codereview.chromium.org/2324553003
Cr-Commit-Position: refs/heads/master@{#417106}

Delete remaining content gypi files.

TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2321743002
Cr-Commit-Position: refs/heads/master@{#417105}

I would like to share more shutdown code between cash and mash, moving
this code earlier on will make it easier to share.

BUG=none
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2321763002
Cr-Commit-Position: refs/heads/master@{#417104}

The threading issue needs to be fixed according to crbug.com/644857

R=waffles
BUG=644854

Review-Url: https://codereview.chromium.org/2322733002
Cr-Commit-Position: refs/heads/master@{#417103}

Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Xi8-y4ySjA4

BUG=624061

Review-Url: https://codereview.chromium.org/2092293002
Cr-Commit-Position: refs/heads/master@{#417102}

BUG=644841
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/2316343002 .

Cr-Commit-Position: refs/heads/master@{#417101}

These are now unused

TBR=dpranke@chromium.org
TBR=mseaborn (chrome/test/data/nacl)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2321703002
Cr-Commit-Position: refs/heads/master@{#417100}

Limits only 16 new QUIC connections can be opened per socket event for QuicSimpleServer. Fix test failure in https://codereview.chromium.org/2310543002/ which missed necessary changes to QuicSimpleServer.

This is a continuation of merging internal change: 131102299

R=rch@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2313053002
Cr-Commit-Position: refs/heads/master@{#417099}

This deletes the SwapBuffers() method in LayerTreeHostImpl and in
DelegatingRenderer, merging them into DrawLayers() and DrawFrame()
in their respective classes.

Next up is to collapse DelegatingRenderer into LayerTreeHostImpl and
remove all "renderer" and "draw and swap" terminology in
LayerTreeHostImpl, Scheduler, Proxies and friends.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2317953002
Cr-Commit-Position: refs/heads/master@{#417098}

When we make outbound GATT connections, we were immediately
letting them expire in OnGattConnected, which meant we would
disconnect remote devices as soon as they were connected to us.

BUG=644792
TEST=make GATT connections from inside the container and
  verify that they stay connected, disconnect and verify that
  the device is disconnected

Review-Url: https://codereview.chromium.org/2321693002
Cr-Commit-Position: refs/heads/master@{#417097}

We used "[Extension] is sharing the content of your screen ...", and we should use plural form for "content".

This CL fixes the bug.

BUG=644852

Review-Url: https://codereview.chromium.org/2319163002
Cr-Commit-Position: refs/heads/master@{#417096}

The bug is that after searching for a string that is not on the page, if
you then navigate to a page that DOES contain that string, find-in-page
will still find no matches.

What is actually happening in the search after navigation is that even
though TextFinder::find() is returning true (to indicate that a match is
found), the field |m_lastFindRequestCompletedWithNoMatches| is still
false (from the last page, which had no matches). This prevents any
matches from being highlighted during the subsequent scoping effort.

The simple (and correct) fix is to set
|m_lastFindRequestCompletedWithNoMatches| to false if a match is found
in TextFinder::find() (since the find request no longer has no matches).

BUG=644448

Review-Url: https://codereview.chromium.org/2316203002
Cr-Commit-Position: refs/heads/master@{#417095}

BUG=628057
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2300243004
Cr-Commit-Position: refs/heads/master@{#417094}

Textfields:
- handle disabled state for text, border

Comboboxes:
- update enabled text color (matches textfield)
- handle disabled state for text, arrow, border (matches textfield)
- draw a solid background so that subpixel aa works

BUG=644709,635164,635160

Review-Url: https://codereview.chromium.org/2319193002
Cr-Commit-Position: refs/heads/master@{#417093}

This patch asserts that the document url passed into the scanner is valid.
This fixes a fuzzer issue where the fuzzer was passing in an empty (invalid)
url.

BUG=644667

Review-Url: https://codereview.chromium.org/2318283002
Cr-Commit-Position: refs/heads/master@{#417092}