GitLab

Installation requires that the security level of the page be SECURE or
EV_SECURE, but this omitted the equivalent state on ChromeOS with a
policy-installed certificate. This CL ensures that all valid HTTPS
states permit installation.

Bug: 794256
Change-Id: I8ac7f2e6a7ca215197a32ec5ee534410d20d82b0
Reviewed-on: https://chromium-review.googlesource.com/823152Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523592}

Converts TreeNodeModel to allow an index-based removal for cases where
an index is known. This prevents a linear search in that case. A
pass-through function is provided that does the search if the index is
not known.

This requires a similar change in TreeNode. TreeNode::Add and ::Remove
used to be virtual but these were never overridden. They are changed
to non-virtual member functions.

Additional documentation is added referencing TreeNodeModel from TreeModel, and
some additional examples are provided.

Change-Id: I5c062420bada437f1ef127ce80518e37f5c2aaae
Reviewed-on: https://chromium-review.googlesource.com/820671
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523591}

Remove the --arc-start-mode=only-start-after-login flag functionality
from Chrome. Passing this flag to Chrome caused the mini-container to be
disabled.

Bug: 65548422
Test: Ensure container boots and upgrades successfully.
Change-Id: Ife77df29e6bcafaa848465a1e65350a263b40a72
Reviewed-on: https://chromium-review.googlesource.com/821711Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Christopher Morin <cmtm@google.com>
Cr-Commit-Position: refs/heads/master@{#523590}

This CL plumbs an OnSurfaceCreated over from Surface to SurfaceManager
to FrameSinkManagerImpl to HostFrameSinkManager so that the host can
assign an owner to the temporary reference. Previously we waited until
activation to assign an owner to the temporary reference but that had
the effect of taking longer for a newer fallback surface to be picked
by SurfaceManager.

This CL also simplifies GetLatestInFlightSurface by removing the parent
FrameSinkId parameter. Instead, the parent FrameSinkId is extracted from
the surface hierarchy already stored in SurfaceManager.

Bug: 672962
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I012f5feda5e3172978cc3686694362e4d85f5832
Reviewed-on: https://chromium-review.googlesource.com/820162Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523589}

https://boringssl.googlesource.com/boringssl/+log/296a61d6007688a1472798879b81517920e35dff..0c9c1aad352235db1be3bf05e769c97fcc215112

BUG=none

Change-Id: I538290c1b6389f94a11cd411b20193f5f4e58e64
Reviewed-on: https://chromium-review.googlesource.com/822777
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523588}

https://skia.googlesource.com/skia.git/+log/09757b29feeb..aeff9eaa1903

$ git log 09757b29f..aeff9eaa1 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 3c613c0d7..a98a28112 (1 commit)
2017-12-12 brianosman Push much of the SkColorSpace_Base interface up to SkColorSpace

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: I57068384a7c9d8fe8ccae2a69a1b7a7730fa32c1
Reviewed-on: https://chromium-review.googlesource.com/822920Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523587}

Grabs all permissions that have been granted or not to Chrome and adds them to
the feedback collector list of feedback.

BUG=773411

Change-Id: Iafdaaf474d3ad269ea1cc585db8068b66a5848c2
Reviewed-on: https://chromium-review.googlesource.com/806244
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523586}

Creates FileExistenceChecker with a static method to check whether
a file from a provided list is missing in the OS.

Implementation is template based, because it allow to link such file
back to the original item related to that file, such as an offline page
or a download. Types of identifiers for these items could vary.

Bug: 758690

Change-Id: I97f1701d9d8e44cc42fc8863e001401938d22965
Reviewed-on: https://chromium-review.googlesource.com/818183
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523585}

DevTools expect the "!important" modifier to be a part of the property
value. This patch brings CSSOM-generated property values in line with
the assumption.

BUG=735282
R=dgozman

Change-Id: I2b3b852c66e07799c6437dd04841b5197b6c3201
Reviewed-on: https://chromium-review.googlesource.com/820974
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523584}

This is a reland of 6745e12d
Original change's description:
> DevTools: do not report raw headers and cookies for protected subresources.
> 
> In case subresource request's site needs to have its document protected, don't
> send raw headers and cookies into the frame's renderer.
> 
> Bug: 793692
> Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969
> Reviewed-on: https://chromium-review.googlesource.com/821410
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523364}

Bug: 793692
Change-Id: Ib0bd20ae7a34c32797fee19533f597094f384c83
Reviewed-on: https://chromium-review.googlesource.com/822134Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523583}

The ET_MOUSE_CAPTURE_CHANGED event has no location, but would generate
a pointer motion event. When capture was released after ending a drag,
the client would receive an event located at (0, 0) and update the
cursor to the top-left resize sprite.

Bug: b:67384524
Test: No top-left resize cursor after ending drag.
Change-Id: I882c4e51f98c9b6e451f716fcc0057848c3b72e5
Reviewed-on: https://chromium-review.googlesource.com/823216Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523582}

This CL introduces java UserData for WebContents in order to handle
data of the lifetime of WebContents without having them directly
associated with it. GestureStateListener objects being managed by
ContentViewCore is used to show how UserData can be used. They are
now managed by GestureListenerManager that implements UserData.
It can be obtained by |GestureListenerManager.fromWebContents()|
modeled after native UserData-inherited class, though it is not
as universal i.e. no SupportsUserData but only for WebContents.

Bug: 789000

Change-Id: Icfbd3480314d261d90454f585d181e56f64aa8da
Reviewed-on: https://chromium-review.googlesource.com/792575Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523581}

crrev.com/804597 accidentally set gmb id for anonymous surfaces to 0 to
use it as a hint for whether to clear surfaces. This causes a memory
regression similar to the one before unique ids were introduced.

Instead, client_id, which is 0 for anonymous images and non-zero
otherwise, can be used for the same purpose.

R=ccameron
BUG=793445

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I76b2fa6cf498b0f2727bef7983ebc063cfb5e9d0
Reviewed-on: https://chromium-review.googlesource.com/820618Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523580}

https://pdfium.googlesource.com/pdfium.git/+log/ebcbb85ea364..1228ae247f21

$ git log ebcbb85ea..1228ae247 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 npm Roll pdfium/third_party/freetype/src/ bec14f688..2c048a8a6 (25 commits)
2017-12-12 dsinclair Move Script_Som_*Message methods to CJX_Object
2017-12-12 dsinclair Move Script_Som_{Fill|Font}Color to CJX_Object

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I748c3ca88cd2739e2f66e5701e79c77d5bdc23b7
Reviewed-on: https://chromium-review.googlesource.com/822217
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523579}

SecurityOrigin in WebKit has port=0 for ports that are default for scheme.
But url::SchemeHostPort requires effective port. This CL adds a call to
url::DefaultPortForScheme before creating url::SchemeHostPort.

Bug: 554927
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3e6ccf17d5b8fc221ff954b3ac39a8fb0d195ca9
Reviewed-on: https://chromium-review.googlesource.com/823082Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523578}

tmpfs doesn't support file attributes.

BUG=internal b/70425842
TEST=base_unittests

Change-Id: I23d0473680f3e8648971ee39f0c38cbff7fe0819
Reviewed-on: https://chromium-review.googlesource.com/821354Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523577}

Multiple improvements for UMA sequence analyzer.

Bug: 769416, 763612, 763611, 770427
Change-Id: Ib5141963cd76729ccf833bc52ffadde9b1017db7
Reviewed-on: https://chromium-review.googlesource.com/804406
Commit-Queue: Vadim Tryshev <vadimt@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523576}

We were previously only creating it once on entering VR, so if we
switched tabs, or the tab was closed, weird things could happen.

Bug: 
Change-Id: I70187cb56a2fa8e0edc5978c17a760895789ccb4
Reviewed-on: https://chromium-review.googlesource.com/823093Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523575}

The style of an element should only depend on the closest self-including link
ancestor, but we're missing to check for that while walking the ancestors in
SelectorChecker.

BUG=793298

Change-Id: I0449a4d743f9ab1b747f69679c096e96681548ad
Reviewed-on: https://chromium-review.googlesource.com/817597Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Emilio Cobos Álvarez <emilio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523574}

The Omnibox was calling SwitchToTabWithURL() directly from OpenMatch()
for tab-switch suggestions. This change creates a special disposition
for the suggestions and adds support for it within the browser stack.

Bug: 780835
Change-Id: I4f48e6a7a4b46cf9c1a88baedafc87aaf763ebef
Reviewed-on: https://chromium-review.googlesource.com/809527Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523573}

Blur (without dimming) is applied when the lock screen animation starts.
Blur is removed when unlock screen animation finishes.
Dimming is applied only on lock screen.

This cl is smoothing the transition, but wider revision and update is planned
for the future (crbug.com/793171).

Bug: 789320
Change-Id: Ib79bf348a837af7814095136155183b74aafc87a
Reviewed-on: https://chromium-review.googlesource.com/812112
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523572}

TBR=eyaich@chromium.org
NOTRY=true

Bug: 786010
Change-Id: I9d9d9d38c99537f17833fe8de0e50f95e50a8279
Reviewed-on: https://chromium-review.googlesource.com/823230Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#523571}

This CL makes sure that RenderViewImpl::GetURLForGraphicsContext3D
doesn't crash if |webview()->MainFrame()| is null.  This restores
the behavior of the code from r187650 which used to do the null check
(the check was dropped later in
https://codereview.chromium.org/444503002/patch/80001/90022).

Bug: 793999
Change-Id: I2027b69ff533fcdbc3bd7fedefc21059f032d023
Reviewed-on: https://chromium-review.googlesource.com/822911Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523570}

This lets us get rid of the last non-trival usage of
ResourceClient::SetResource in ClassicPendingScript

Bug: 793028
Change-Id: I39a4859cb1b941ff6a399fad88d40e353df4d462
Reviewed-on: https://chromium-review.googlesource.com/822176Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523569}

DevTools currently bails out when trying to autocomplete large
TypedArrays. This relaxes our condition to bail out on large regular
Arrays, too.

The original condition is introduced here:
https://crbug.com/444116

Bug: 740488
Change-Id: I65e04fc8497fe848d25a78cfad049fcc1e1919a9
Reviewed-on: https://chromium-review.googlesource.com/820935Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523568}

The feature is default enabled in crrev.com/c/794715.

Next step is to remove extension-side DIAL discovery logic.

Bug: 718154
Change-Id: I67569a9a4acf0a68c461307592b229c5b91e45d1
Reviewed-on: https://chromium-review.googlesource.com/809925
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523567}

The CHECK was introduced to trace all unexpected paths
to create OTR profile and launch incognito.
However, it didn't allow creation of system OTR profile,
e.g. for User Manager.
See crbug.com/794154 for the crash report.

BUG=794154
TEST=Run trybots

Change-Id: I4c1159fd5f25ea97fe5dacf9df3bdb4596418bb4
Reviewed-on: https://chromium-review.googlesource.com/822654Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523566}

This reverts commit ff34ceb7.

Reason for revert: Breaking downstream ExternalURLSigninTestCase test suite.

Original change's description:
> [Cronet] Populate cronet metrics object with data from net/.
> 
> Currently this only creates the an appropriater delegate in net/, calling it from there.
> There still needs to be created code in cronet which registers and appropriate delegate,
> and then populates the metrics object that will finally be given to the client.
> 
> Bug: 702796
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I33a8ce1f489a7bfb74b4c9561a57b7b5a71013e0
> Reviewed-on: https://chromium-review.googlesource.com/763934
> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
> Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
> Reviewed-by: Misha Efimov <mef@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523430}

TBR=mef@chromium.org,eugenebut@chromium.org,kapishnikov@chromium.org,lilyhoughton@chromium.org

Change-Id: Ic9cb928a24a1577c506542c18b15261aa0d96126
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 702796
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/822922Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523565}

After internal cl/170262399, the crash collector will automatically stitch
together values named "key__1"..."key__N". Chromium's existing "key-1".."key-N"
syntax is special-cased in the processor on a per-key basis.

By switching to the key syntax handled by the collector, it will make converting
to the new crash key API easier for values that have to be chunked in Breakpad
(like the active URL and variations hashes). When the crash key reaches the
processor, it will already be assembled into a single value, rather than needing
to be joined by the processor.

Bug: 598854
Change-Id: I393cc621bab61aafa4ea08602653807f448ff125
Reviewed-on: https://chromium-review.googlesource.com/822293Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523564}

When the sheet is closed, add an accessibility description to the toolbar
so that it provides useful information when focused during
swipe-explore.

BUG=748357

Change-Id: Ie7fb7221b75e86fb19423455cfe8c3449201dc67
Reviewed-on: https://chromium-review.googlesource.com/820593
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523563}

ScopedMakeCurrent and ScopedReleaseCurrent don't check for errors when
restoring the previous context. In most cases the MakeCurrent that
restores the previous context should not fail, and if it fails we don't
return errors up the stack so we CHECK that MakeCurrent succeeds.

However, for DirectComposition, we use ScopedReleaseCurrent when
reallocating the drawing surface. Restoring the context can fail in this
case. This CL adds a Restore method to both classes whose return value
must be handled. This prevents the CHECK in the destructor.

The lack of error checking is causing a crash in SetSwapInterval, due to
null-dereference of GLContext::GetCurrent. This was found by adding a
crash key to get the stack trace for SetCurrent(NULL).

BUG=724999
R=piman

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I370ff470c78afa76bd000de60a6a63295746ee1b
Reviewed-on: https://chromium-review.googlesource.com/818533Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523562}

The entire suite of externally-connectable messaging tests has been
disabled on Windows. I'm unable to reproduce any failures locally, and
all the logs have dried up. Try re-enabling one, and see how it goes.

Bug: 350517

Change-Id: Ib08941ad1b5c6fd007056d2c9af8a8c349c08e05
Reviewed-on: https://chromium-review.googlesource.com/823012
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523561}

ExtensionPrefs::GetExtensionsFrom() is never used. It was originally
exposed for the ProtectedPrefsWatcher, but that was removed in
crrev.com/102253f8.  Remove it.

Bug: None

Change-Id: Ibc1f246f81e5826762d6183cca3c37c7a6b38624
Reviewed-on: https://chromium-review.googlesource.com/822517Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523560}

This CL ensures that the base URL is properly used as the
first_party_for_cookies URL in Android WebView if it is non-null. This fixes an
issue with cookies being unproperly set for iframes if their parent was loaded
through LoadDataWithBaseURL.

BUG=793648

Change-Id: I0f7da293f1e102f7b414ae799f701d48667eefc1
Reviewed-on: https://chromium-review.googlesource.com/822572
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523559}

If a workspace root was exluded, it would instead exclude "undefined"

Change-Id: Ib82e11f2182a1fcced176735ae714212a153d5b2
Reviewed-on: https://chromium-review.googlesource.com/822457Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523558}

v8_helpers::CallFunction wraps v8::Function::Call. However, we should be
avoiding using v8::Function::Call whenever possible, since it doesn't
account for all possible state in the renderer (e.g., script suspension,
etc).

Remove v8_helpers::CallFunction and inline the v8::Function::Call at the
two places it was used, along with a TODO to update them.

Bug: None

Change-Id: If3358bfda74126c3898cea2483fc6a012bdd6f24
Reviewed-on: https://chromium-review.googlesource.com/823010Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523557}

CompletionHandler is used in CacheThread_BlockFile.
CacheThread_BlockFile is lazy + leaky instance, thus, there was race
 condition when all lazy instances are already destroyed, but message
 io pump still processes some io overlapped operation,leading to using
 IOHandler after free.
Make completion handler to be refcounted and add ref to each overlapped
 operation it participates with.

R=jkarlin@chromium.org, morlovich@chromium.org

Bug: 
Change-Id: I7bd5fbdc83aae05489d5089ee16a94857ea1b104
Reviewed-on: https://chromium-review.googlesource.com/793158Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523556}

https://chromium.googlesource.com/angle/angle.git/+log/7f5c3eb76834..3c613c0d79fa

$ git log 7f5c3eb76..3c613c0d7 --date=short --no-merges --format='%ad %ae %s'
2017-11-16 fjhenigman Update docs for GN standalone and GYP deprecation.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I56bd58391a560f0f938e0006f850a7758ddd7f24
Reviewed-on: https://chromium-review.googlesource.com/822178Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523555}

As per the Harmony spec, the arrow is removed. This patch also includes
related cleanup.

Bug: 605657
Change-Id: Icdca8e14ee135578d57840cafc4397987262a141
Reviewed-on: https://chromium-review.googlesource.com/817952Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523554}

Bug: 180722
Change-Id: I187155b0076d8f4e7d9e7c9e7b80d9686a12ad2c
Reviewed-on: https://chromium-review.googlesource.com/808929
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523553}