- 21 Jul, 2020 40 commits
-
-
Clemens Arbesser authored
Bug: b/145043394 Change-Id: I3311290b6fe2d59b9f4fedbce9f0e5bb2a06a102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309435Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#790346}
-
Andreea Costinas authored
This CL implements requesting proxy authentication credentials from the NetworkService instance of the primary user Profile's default StoragePartition when System-proxy signals that it requires credentials. System-proxy is a new system service on CrOS that performs authentication and connection setup for CrOS services and ARC apps that are proxy aware, but can't perform the authentication challenge themselves. Bug:1042642 Test:unittests, services_unittests, manually on DUT Change-Id: I1d79da46ee9537c75131ff5e734fb39e525e0d5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279193 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Cr-Commit-Position: refs/heads/master@{#790345}
-
Wez authored
The experiment is currently being reviewed, so extend the histogram lifetimes to allow data to continue to be gathered. Bug: 1053628, 1097845 Change-Id: I19771134bbdd3a5cc24ae651acf2e8f62c91f3dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270304 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790344}
-
Leo Lai authored
The default failure should not happen because of unprepared attestation; instead it should controlled by thw allowlisting mechanism. Otherwise, the retry logic could cause long testing time or even timeout. As for testing, chromeos:chromeos_unittests and all affected browser_tests are passed. Bug: 1107426 Change-Id: Ie23d2618069b0511323d0f686a64ddfe0e05a054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308625Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#790343}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a9b96ff8e9f..c1a073785503 2020-07-21 titovartem@google.com Add per source network statistics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe3a31bf54bd7850989ac45b5ec9a04bef5926f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309286Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790342}
-
Melissa Zhang authored
This CL adds targets to the sharesheet bubble and lifecycle support for those targets. Clicking on a ShareAction target now triggers the bubble to show the ShareActionView. Bug: 1097623 Change-Id: Ibbe829f3ea303588fcc90eb2ae9d7d1b662fc0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305820 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790341}
-
Mugdha Lakhani authored
Bug: 1096088 Change-Id: I6095d886525546e8cd0a44b37eb1ac9eded7e376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235717 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#790340}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e810d53b527e..57d7441b354d 2020-07-21 jacktfranklin@chromium.org Fix acorn deps 2020-07-21 mathias@chromium.org Clean up inspector overlay HTML 2020-07-21 alexrudenko@chromium.org Fix grid gap hatch fill 2020-07-21 tmathmeyer@chromium.org Fix text wrapping 2020-07-20 wolfi@chromium.org Fix frame tree persistence of selected item 2020-07-20 pfaffe@chromium.org [wasm debug] Implement auto-stepping with the experiment. 2020-07-20 aerotwist@chromium.org Migrates host to devtools_entrypoint 2020-07-20 jacktfranklin@chromium.org Update component_docs README 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function 2020-07-20 aerotwist@chromium.org Migrates a11y to devtools_entrypoint 2020-07-20 aerotwist@chromium.org Moves generated scripts to devtools_module 2020-07-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-07-17 fawazm@google.com [WebAuthn] Enable selecting active authenticator 2020-07-17 changhaohan@chromium.org Add e2e test for computed tab's "Show all" functionality 2020-07-17 sigurds@chromium.org Link to related panels from the frame details view 2020-07-17 sigurds@chromium.org Update Protocol Definitions 2020-07-17 tvanderlippe@chromium.org Stop building formatter_worker-entrypoint with build_release_applications 2020-07-17 janscheffler@chromium.org [WebAuthn] Add owners file for webauthn 2020-07-17 tvanderlippe@chromium.org Move acorn entrypoint to front_end/third_party/acorn 2020-07-17 szuend@chromium.org Don't add sourceURL comments to HTML and Markdown files 2020-07-17 szuend@chromium.org Build 'marked' module with TypeScript infrastructure If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1034663,chromium:1083146,chromium:1093247,chromium:1095617,chromium:1099162,chromium:1101738,chromium:1105765,chromium:1105770,chromium:1105808,chromium:1106251,chromium:1106681,chromium:1107681 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifba1dfedccb9867db18c3e1b2ac34d8db488b034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309284Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7169639e. With Chromium commits locally applied on WPT: 9ca607f9 "[XHR] Replace whitelist with cors-safelisted" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Id803842daa7bccafdf517d92fa8325da53b27b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309736Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790338}
-
Olya Kalitova authored
Updates Plugin VM Product Analytics string on trancparency panel (chrome://management). Test: manually using YAPS Bug: b/150908305 Change-Id: Id4d99e1b1729b9c5f6a2dcf93d47c9cb69146386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306094Reviewed-by:
Greg Levin <glevin@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#790337}
-
Saurabh Nijhara authored
This CL updates the subtitle string for update required screen in offline mode as per UI. Bug: 1106768 Change-Id: Ieb84f4439ef3fdf93d5353da9b19fa8ba3ca2ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308711Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#790336}
-
Wanchang Ryu authored
There are many places defining __has_builtin(x) to 0 if __has_builtin is not defined. When building chrom with gcc, depending on include file it can be undfined or defined to 0. So SUPPORTS_LOCATION_BUILTINS can be different depending on include header file before including base/location.h file. This patch changes checking defined(__has_builtin) to defined(__clang__) for using __has_builtin macro. This would be enough to detect clang compiler for using __has_builtin. Here is a link error what I met when compiling with gcc and this patch fixes below link error. g++ -Wl,--version-script=../../build/linux/chrome.map -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,-z,defs -Wl,--as-needed -fuse-ld=gold -Wl,--threads -Wl,--thread-count=4 -m64 -Wl,-O2 -Wl,--gc-sections -rdynamic -pie -Wl,--disable-new-dtags -o "./chrome" -Wl,--start-group @"./chrome.rsp" -Wl,--end-group -latomic -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -latk-1.0 -latk-bridge-2.0 -lcups -ldbus-1 -lresolv -lgio-2.0 -lexpat -luuid -ldrm -lxkbcommon -lm -lz -lwayland-cursor -lwayland-egl -lwayland-client -lpci -lasound -lpangocairo-1.0 -lpango-1.0 -lcairo -latspi -lgtk-3 -lgdk-3 -lcairo-gobject -lgdk_pixbuf-2.0 obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/print_dialog_gtk.o):print_dialog_gtk.cc:function PrintDialogGtk::SendDocumentToPrinter(std::__cxx11::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::allocator<unsigned short> > const&): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/select_file_dialog_impl_kde.o):select_file_dialog_impl_kde.cc:function gtk::SelectFileDialogImpl::CheckKDEDialogWorksOnUIThread(): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/print_dialog_gtk.o):print_dialog_gtk.cc:function PrintDialogGtk::ReleaseDialog(): error: undefined reference to 'base::Location::Current()' obj/ui/gtk/libgtk.a(obj/ui/gtk/gtk/select_file_dialog_impl_kde.o):select_file_dialog_impl_kde.cc:function gtk::SelectFileDialogImplKDE::CreateSelectFolderDialog(ui::SelectFileDialog::Type, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, base::FilePath const&, unsigned long, void*): error: undefined reference to 'base::Location::Current()' collect2: error: ld returned 1 exit status Change-Id: Ic025681762c2c4efafe6f1e972d78dcf85b89c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303232Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Aaron Tagliaboschi authored
Bug: 924047 Change-Id: Iaffbf6fd73993ea4db3cdc89f94ca9dc3710b86f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307090Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#790334}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9491204a8a8..83406a9d26a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andruud@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1101820 Tbr: andruud@google.com Change-Id: Ie4090f8c20907b24068813948d9060d85d117720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309278Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790333}
-
Anders Hartvoll Ruud authored
This flag is an remnant of the old way of resolving variables, and is no longer needed. Change-Id: I5f013b65b3fd2a653cbb98846689b0e00c48046a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306089 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790332}
-
Swapnil authored
We need to improve on installation time for the force installed extensions. For this, we first need to investigate which stage takes more time. After CRX has been downloaded, it's installation happens in several stages (verifying, unpacking etc), and now InstallStageTracker tracks these stages so that we could get a better idea that which stage is more time consuming. This is a prework for adding UMA statistics for reporting time taken for each stage. Bug: 1102806 Change-Id: I1a484363ef06f8f04787ddb8086dbb401523206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283607 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#790331}
-
Alex Chau authored
- All NearbySharingService methods should run in same sequence, adding DCHECK_CALLED_ON_VALID_SEQUENCE to enforce that - Also changed RegisterSendSurface/UnregisterSendSurface to synchronous Bug: 1084644 Change-Id: I6eac1f5ad082144b2ff3d2c366b7855c93f42592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308410 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790330}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since autofill assistant only run in regular mode, it is safe to pass always regular profile to IdentityServicesProvider functions by using |AutofillAssistantUiController#getProfile| function. Note: This CL does not make any behaviour change. Bug: 1041781, 1075562 Change-Id: I55674623478f071ae09f1469f3ed86177a71ee14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307209Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#790329}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I07beab6af27c1ed7abe51f6d593e49058d865123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309282Reviewed-by:
-
Anna Malova authored
This reverts commit b17c0966. Reason for revert: CL caused build failures on chrome/ci/android-internal-chromium-tot. Original change's description: > Remove PrefServiceBridge.java > > Port PrefServiceBridgeTest to PrefServiceTest. > Update docs. > Update OWNERS. > > Bug: 1071603 > Change-Id: I48f83e1faade5263a6b105268bfd57ded3db27e5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307609 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Reviewed-by: Natalie Chouinard <chouinard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790210} TBR=battre@chromium.org,estade@chromium.org,chouinard@chromium.org Change-Id: Ic25ffc3e2fc0b0bab9f280906afa8e4ea0ffc387 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1071603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308414Reviewed-by:
Anna Malova <amalova@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#790327}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f75b12bf..596f21fb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If1ba24fd2dac7750737c35a23565075b174119b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309733Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790326}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f6437f54c9f0..75efd91227eb 2020-07-21 dhoss@chromium.org Generate clipping path when processing the graphics of page objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I8123130ba8d24b00f3a86e942c84d769d6706ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309274Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cd5489ad46bd..d9818fd6fc72 2020-07-21 syoussefi@chromium.org Vulkan: Improve RenderTargetVk's getImage interface 2020-07-21 timvp@google.com Generate Android.bp from multiple gn descriptions 2020-07-21 timvp@google.com Use Subject/Observer pattern for Programs/Executables in PPOs 2020-07-21 syoussefi@chromium.org Vulkan: Make room in RenderPassDesc for resolve attachments 2020-07-21 ianelliott@google.com Vulkan: Make explicitly-[non-]rotated get methods 2020-07-21 cclao@google.com Vulkan: No need to add current buffer into mResourceUseList If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: CQTest: Test: Manual script execution and building in AOSP Change-Id: I6fa05299f4c886112324ce0212b5177b1e02287c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/717e7877cac1..a3b0adc306c5 2020-07-21 vasniktel@gmail.com spirv-fuzz: Add is_irrelevant parameter (#3563) 2020-07-20 vasniktel@gmail.com spirv-fuzz: Add IdIsIrrelevant fact (#3561) 2020-07-20 stefanomil@google.com spirv-fuzz: refactor to use RemoveAtRandomIndex (#3560) 2020-07-20 antonikarp@google.com spirv-fuzz: add TransformationAddRelaxedDecoration (#3545) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: I1fabd996fcd714a567284eee9cf38621a1a1e170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309276Reviewed-by:
-
Alex Rudenko authored
Previously any pointer event (e.g., pointer move) would trigger cancellation of the current inspect mode. This CL changes the logic to cancel the current inspect mode only for pointer down events (similar to how mouse events are handled). The current inspect mode is cancelled by the call `overlay_->Inspect(node)` that sends the inspectNodeRequested CDP event which makes the current node to be selected in the Elements panel and disables the inspect mode. Fixed: 1104126 Change-Id: I120a9d8ac2c4b9f6b093313344eba9fe3266d441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301970Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790322}
-
https://crrev.com/c/2304672Fergal Daly authored
Change-Id: I445c53ad6bc4c23617dfa09a8ace832df28e7519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308442Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790321}
-
Tanmoy Mollik authored
This cl creates the preference and layout for creating a button in ManageSyncSettings that will be used to sign the user out using SignOutDialogFragment Screenshot: https://crbug.com/1092410#c1 Bug: 1092410 Change-Id: If66793a3c7f2a965c68b441a32d47718bd943c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264338 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#790320}
-
Ewann Pellé authored
This reverts commit df86a3d6. Reason for revert: Toolbars remain displayed when they shouldn't. Original change's description: > [iOS] Makes bottom toolbar visible when modal view disappears > > This Cl makes the bottom toolbar visible when initiating a drag down > to close a modal setting view. > > Bug: 1106665 > Change-Id: I519fac84a18c36c6838384241af01f1c57a824b0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302633 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Ewann Pellé <ewannpv@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789454} TBR=sdefresne@chromium.org,ewannpv@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1106665 Change-Id: Ic0e6dc70ea878deb0b0be852fa84bab32b4124f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309691Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#790319}
-
Yuki Shiino authored
Replaces base::internal::DereferencedPointerType with the std templates in <type_traits>. Bug: 1073933 Change-Id: I108fc52d5f3834b0749f95342a76578ef1c10306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302880Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#790318}
-
Victor Hugo Vianna Silva authored
Chrome won't be able to decrypt the passwords for those users since they have no way of entering their passphrase, so opt-in should not be offered. We also use the occasion to remove some unnecessary clutter in passwords_section_test and passwords_device_section_test: the names in simulated stored accounts are unnecessary and irrelevant for the tests. Bug: 1106350 Change-Id: Ic349ec3088d4e829c033c48c29e65654f1dfbe54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304809 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#790317}
-
David Jean authored
Bug: 1106689 Change-Id: I9239398fc5ed9462d6c7fff4f08c2a718cfe5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303442Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#790316}
-
Yutaka Hirano authored
This is aligned with the spec. Bug: 1097231 Change-Id: Id93081fa764431917e4f6d3c3313df17535186a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309612Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#790315}
-
Abhijeet Kandalkar authored
In this CL, WritingDirection {kNatural, kLeftToRight, kRightToLeft} is replaced by TextDirection {UNKNOWN_DIRECTION, RIGHT_TO_LEFT, LEFT_TO_RIGHT} and dependant files are ported to use |TextDirection| enum. Bug: 1088377 Change-Id: Iac185f2d34eddd78127c3f59b7dc90fe380b5f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306127Reviewed-by:Koji Ishii <kojii@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#790314}
-
Kateryna Prokopenko authored
Bug: chromium:1082628 Change-Id: I485e0f9e5653794fbf2b8eec54496ee44a580ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302110Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Cr-Commit-Position: refs/heads/master@{#790313}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68e5f29d849a..e687db2bbe11 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 08c4d09493bf to 20eb9be55299 (17 revisions) 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from d0dd661f1805 to c4cebc7efae1 (3 revisions) 2020-07-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ea6f21a052c9 to 97f9923235cf (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100599 Tbr: robertphillips@google.com Test: Test: Test: CQTest: Test: Manual script execution and building in AOSPTest: Test: NBA 2K20 game playTest: Test: NBA2K20 MEC Change-Id: Ife4d9c31bafd41ca2d0f32f57c0244c3591a799c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309662Reviewed-by:
-
Kushagra Sinha authored
Some tests cannot create a proper task environment for running a real instance of Chrome OS Account Manager. Allow the creation and initialization of Chrome OS Account Manager in ephemeral mode where it will not require a task environment for initialization. Bug: 1100833 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I181dbde347f91530ded431d4f8a505f9c6c30be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283305Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#790311}
-
Matthias Körber authored
The CL introduces a data structure to manage address components that must support the duality of an structured and unstructured representation. This is a reland with a fixed DCHECK statement. Change-Id: I95ec6b67bb6681b1dec9c1eb951439e916e932ec Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307375Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#790310}
-
Kent Tamura authored
It was behind the "LayoutNGForControls" flag, of which status is "experimental". Note that this feature depends on the "LayoutNGFlexBox" flag. If the flag is disabled, menulist SELECTs are rendered with the legacy layout. Bug: 1040826 Change-Id: I30e30d1fef26adb2b661ffbbf7a5e1ad2afd7d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303735Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#790309}
-
Makoto Shimazu authored
ServiceWorkerFetchDispatcher now dispatches a fetch event without waiting for an ACK of start worker message when ServiceWorkerOnUI is enabled. However, due to the change, ServiceWorkerFetchDispatcher can invoke a callback twice when starting a worker fails - one for a failure of start worker and the other for a failure of dispatched event, and this caused crashes. This CL added a branch to ignore the latter callback when starting a worker fails because the error status for starting a worker is more detailed. Bug: 1106977 Change-Id: I4cc408a850f40fb3db101584e71eb2164a90c28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309525Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#790308}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I5b5fa1c64e4d04697424a54840a52aba5bfe7a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309809Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790307}
-
