- 17 Oct, 2019 40 commits
-
-
Roger Tawa authored
Bug: 1015065 Change-Id: I570988d8350f48aaaeca132ce3c0ec2ff80ff476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864879 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#706907}
-
Maksim Moskvitin authored
The newly introduced mechanism around PendingLocalNigoriCommit allows implementing NigoriSyncBridgeImpl::MergeSyncData(), responsible for keystore Nigori initialization (in case it receives a default NigoriSpecifics), in a way that: a) Success is only reported when the sync server acks the commit. b) Conflict-resolution becomes simple. c) Logic is factored out from NigoriSyncBridgeImpl. Bug: 922900 Change-Id: Ie6e2f2ecdb37bb6de21f57de472bfe6e6c28237a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865310 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706906}
-
Shakti Sahu authored
Change-Id: I7d24d5b4cd1f45c1ae1c268b14c6f1c779caf2fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866012 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#706905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ae1b7786b89a..48aa52f7305a git log ae1b7786b89a..48aa52f7305a --date=short --no-merges --format='%ad %ae %s' 2019-10-17 jmadill@chromium.org Fix broken GN "all_dependent_configs". 2019-10-17 shaobo.yan@intel.com Add "DIFF_LINES_OF_CONTEXT: 1" to fix format issue 2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9097eeb5359b..6652f0b64287 (11 commits) 2019-10-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 1ff0c181bb37..a959deb00750 (12 commits) 2019-10-17 jmadill@chromium.org Vulkan: Re-enable release ASSERTs. Created with: gclient setdep -r src/third_party/angle@48aa52f7305a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:None,chromium:None Change-Id: I5257425b362303da0af54151b87126b6276f1b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/572eb8c70fdc..e62dfe9064db git log 572eb8c70fdc..e62dfe9064db --date=short --no-merges --format='%ad %ae %s' 2019-10-17 phoglund@google.com Add support for WebRTC internal commit ranges. Created with: gclient setdep -r src/third_party/catapult@e62dfe9064db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1015329 Change-Id: I22a3722e302408b043ce7b58f07a28a21d71a846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864526Reviewed-by:
-
Thomas Tangl authored
Additionally, the close icon is updated. Bug: 995720 Change-Id: I3d8c0969def4483867fe3e6d985fe5026a955b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866511 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#706902}
-
Thomas Tangl authored
Bug: 995720 Change-Id: I8a430194bd97efc6de3bdd0586aa591e46310611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863931 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#706901}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/df1de01ceff3..7c836ccb431d git log df1de01ceff3..7c836ccb431d --date=short --no-merges --format='%ad %ae %s' 2019-10-17 seanabraham@chromium.org lkgm_manager: fix bug that's breaking legacy CQ Created with: gclient setdep -r src/third_party/chromite@7c836ccb431d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1fe59a85d30964ddcfd6cf14a4328cdd0a38c2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866729Reviewed-by:
-
Mohamed Amir Yosef authored
This CL removes obsolete code. Change-Id: I451253435eab20f3a04b5f10ba79ef9b22c149d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863930 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#706899}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3787dee78156..0544d1e26010 git log 3787dee78156..0544d1e26010 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 treehugger-gerrit@google.com Merge "tools(tmux): add script argument" 2019-10-17 eseckler@google.com Merge "processor: Fix handling of legacy chrome async event IDs" 2019-10-17 lalitm@google.com Merge "trace_processor: add all bits iterator" 2019-10-17 hjd@google.com Merge "Refactor LoadingManager to remove dep" Created with: gclient setdep -r src/third_party/perfetto@0544d1e26010 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I77ff285e1ccff21456dcce9689c544d87ca43159 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864527Reviewed-by:
-
Clemens Backes authored
This is a roll-back to V8 7.9.317. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. R=machenbach@chromium.org CC=hablich@chromium.org Change-Id: I18d9b5d0adf94660ea8590c2ac8c598b1814c938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866571Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706897}
-
Theresa Wellington authored
- Move OverviewModeObserver that dismisses menu when overview mode changes from appmenu/ to RootUiCoordinator. - Remove unneeded ToolbarManager import (only used in comments). - Create TranslateUtil with static utility for determining if translate is available for the current Tab. - Use ObservableSupplier to pass BookmarkBridge to AppMenuPropertiesDelegateImpl instead of using interface method. - Rename AppMenuTest to TabbedAppMenuTest since this is really an integration test shown for the app menu in ChromeTabbedActivity. - Update AppMenuTest to remove dependency on ChromeActivity and avoid exposing future internal classes. - Create javatests/res/values/ids.xml with test ids for use in modal dialog tests. BUG=966644 Change-Id: I0ae1b13e59f936100e942dd46281aaae2ddf2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859881 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
Maksim Moskvitin authored
For decryption and encryption of |keystore_decryptor_token| we need a special version of cryptographer, which contains only keystore keys and uses last keystore key as the default encryption key. To avoid heavy creation of keystore cryptographer and simplify some future error handling (crypto errors, which don't allow to create keystore cryptographer), we now maintain its cached version inside NigoriState. It's implemented as KeystoreKeysCryptographer, which wraps CryptographerImpl and provides interface specific for encryption and decryption of |keystore_decryptor_token|. Keystore keys now stored inside KeystoreKeysCryptographer. Bug: 922900 Change-Id: I905bd351f99704c07419a815c59ae7efa7b119f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865309 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1014829 Test: Verify capture event metrics is collected correctly under both intent/non-intent mode. Change-Id: I84833c4b6b58ddfe848434dcfdee0d26051b8e4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863060 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#706894}
-
kylechar authored
DevToolsFrameMetadata was just a copy of RenderFrameMetadata. Avoid creating a new class and just cache RenderFrameMetadata instead. Bug: 985009 Change-Id: Ie2451eb2bfc76e9a61253f93611dc777eeafd81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850368 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706893}
-
Fredrik Söderquist authored
In the DidMoveToNewDocument() override in HTMLImageElement and SVGImageElement, initiate the load as the last thing rather than the first, since ImageLoader::ElementDidMoveToNewDocument() will clear out the image content, thus requiring a new load to take place later on (when the element gets the "inserted into document" callback). Bug: 1000273 Change-Id: I977d63bb8e14d7f8fbd1e7004b788d09b7b897fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789394Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706892}
-
John Budorick authored
This reverts commit 2aa5da39. Reason for revert: reenabling given crrev.com/1864618 Original change's description: > Disable WelcomeScreenBrowserTest.WelcomeScreenNext. > > Bug: 1014952 > Change-Id: I1df1941c2a0a92d243cb4e4624ae920b150c7694 > Tbr: achuith@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865351 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706500} TBR=achuith@chromium.org,jbudorick@chromium.org Change-Id: I86cba6fe329f52b5bdcd7b07d04d1dfb40fa65cf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1014952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866407Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706891}
-
John Budorick authored
This reverts commit 005483fe. Reason for revert: breaks compilation: https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/11718 Original change's description: > [Trusted Types] Remove TrustedURL. > > The current Trusted Types spec no longer supports TrustedURL. This CL adapts > to the spec. > > Bug: 1002555 > Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 > Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#706886} TBR=vogelheim@chromium.org,mkwst@chromium.org Change-Id: I97a2e1e31947cf854ed52a5866166dbc894c61b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1002555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866406Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99d3067c6c30..42ac78d2d012 Created with: gclient setdep -r src-internal@42ac78d2d012 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I571c7283228c8daee497e6121da77b99b805053d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866611Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706889}
-
Alice Wang authored
Add more parameters to ProfileDataCacheRenderTests. Bug: 967770 Change-Id: Ia32abccdfd067391f685ceae6f269c8264b7a4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859964 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706888}
-
Lowell Manners authored
Bug: 1012707 Change-Id: Idd5551637b6a512f5123b24b917fde3a939f065b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856165 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706887}
-
Daniel Vogelheim authored
The current Trusted Types spec no longer supports TrustedURL. This CL adapts to the spec. Bug: 1002555 Change-Id: I35c6d8a257046558f155b9f38289457b14dcb1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834142 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#706886}
-
Oleg Davydov authored
ContentHash class was previously tested indirectly: in a more integration-like approach, for example, from ContentVerifyJobUnittest and slightly from ContentHashFetcherTest. This commit adds its own test for ContentHash. This will be used in https://crbug.com/958794 to test ContentHash work with unsigned hashes. Bug: 958794, 796395 Change-Id: Ica75dac2a48250f12d5729126ecf397a8168061e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844966 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9187f322d59f..df1de01ceff3 git log 9187f322d59f..df1de01ceff3 --date=short --no-merges --format='%ad %ae %s' 2019-10-17 chinglinyu@chromium.org usergroup_baseline: Expect metrics in debugfs-access. Created with: gclient setdep -r src/third_party/chromite@df1de01ceff3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I37126d1b8dacb5832c36378ac081e2bb228cf24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866609Reviewed-by:
-
Huanzhong Huang authored
Bug: 967668 Change-Id: I7216c1c43bfd4a24bfcf69f14d0c15100eb5e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865321Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#706883}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27c64dd97caf..572eb8c70fdc git log 27c64dd97caf..572eb8c70fdc --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org Revert "devil: add support for adb push --sync behind a flag." Created with: gclient setdep -r src/third_party/catapult@572eb8c70fdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:922145,chromium:1015280 Change-Id: I3cb42dc4941a8c394b403f73e13102d8abbae507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866610Reviewed-by:
-
Sylvain Defresne authored
Some observers of WebStateList are interested in grouping multiple mutations of the WebStateList as a single operation (e.g. "closing all tabs" or "restoring a session"). Add WillBeginBatchOperation() and BatchOperationEnded() methods to WebStateListObserver that can be used to detect those operations (and to avoid expensives UI events during the batch). Sending the notifications is managed by PerformBatchOperation that executes a callback surrounded by invoking the two methonds on the observers. Bug: 1014526 Change-Id: Ieb3ffa5ab349159b333dc651314aa594713ce94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865161 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#706881}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLSlotElement> and DynamicTo<HTMLSlotElement> as new downcast helper 2. Use IsA<HTMLSlotElement>(element) in place of IsHTMLSlotElement(element) Bug: 891908 Change-Id: I981d12a3f481d7cac8af38416619fe87d7f79481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847700 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#706880}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/562a37f926dd..a6d7b028242c git log 562a37f926dd..a6d7b028242c --date=short --no-merges --format='%ad %ae %s' 2019-10-17 thomasanderson@chromium.org Avoid g_clear_object in pipewire 2019-10-17 nisse@webrtc.org Delete unused method PacedSender::QueueSizePackets 2019-10-17 sprang@webrtc.org Set StreamDataCountersCallback on construction of RTP modules 2019-10-17 nisse@webrtc.org Delete deprecated bytes_sent/bytes_rcvd stat values Created with: gclient setdep -r src/third_party/webrtc@a6d7b028242c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1012850,chromium:1014947 Change-Id: I9dbc967757b362f6f3a824c8f5945231eb0523b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865725Reviewed-by:
-
arthursonzogni authored
After a navigation, if the old page do NOT enter the back-forward cache, it starts pending deletion. This is asynchronous, so tests shouldn't make the assumption it is deleted immediately. Bug: 1014799, 1013802 Change-Id: I446117f58970280ea5445b57469e6e6c7c37ea5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865343Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706878}
-
Nico Weber authored
This was a workaround for a toolchain problem we no longer have -- lld-link has thin static libraries and this is a no-op for it for that reason already. Bug: 857060 Change-Id: Ib16c732e3f0a6a0973feff72c7fa4bd1154e2615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865420Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#706877}
-
Igor authored
Currently there's no log on the device to understand when the enrollment was completed. In the past there was "Wizard screen exit code: ENTERPRISE_ENROLLMENT_COMPLETED" message but at some point it was removed. Also added a log for the case when we restart Chrome, so that we still have information that enrollment was successful. We need this information when investigating enterprise enrolled issues. BUG=chromium:1011375 TEST=Manually enrolled the device and checked that we have the log Change-Id: I917641840c99a6e93dbea6ccc674841032edff48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864777Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706876}
-
Friedrich Horschig authored
The Peeking state became customizable. With that, we can now show 1.5 suggestions initially and allow expanding the sheet. It is alsow prerequisite for the footer which we only show in FULL state. The flow of scrolling is now: 1) Keyboard opens in Peek state. 2) swipe up motion expands to Full state. 3) swipe up motion scrolls the list to the bottom. 4) swipe down motion scrolls the list to the top. 5) swipe down shrinks/dismisses the sheet. Btw: the minimum height of the sheet could be smarter: instead of using the fixed size of 340dp, the header size plus 1.5 suggestion heights fit better. This smartness should be added AFTER the issue 1012219 is resolved. Screenshots showing differences in states are in https://crbug.com/957532#c47. Bug: 1012219, 1013257, 957532 Change-Id: I74b7209e447b474815f21a4aafed8672fc57889a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857128 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Lowell Manners authored
We only want to add pages to the cache if the initial fetch is expected to have had no side effects on the server (HTTP GET). Before this CL, we could cache pages that were the result of an HTTP POST. There are two main cases we need to handle: 1) The last commit's http method != GET (e.g. POST): We should not cache. 2) The last commit's http method == GET: We should cache the page, if it is otherwise eligible for caching. An HTTP POST may result in a redirect, or chain of redirects, however for caching purposes we only care about the last commit in the chain of redirects (if the last commit was a successful GET, we can cache the page. Otherwise, we cannot). TBR=clamy@chromium.org Change-Id: I475eb73bf5ac50f500d760df5a947b2a8e1f5e4a Bug: 1014901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864681Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
-
Robbie Gibson authored
The feature has been ramped to 100% and enabled by default for a few months, so now the flag can be removed. Bug: 932116 Change-Id: I97a1c9f8abf59bf1db2e969443b60a2c190bbd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865225 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706873}
-
Andreas Haas authored
It seems to me that the additional step of first creating a DataHandle was used to handle the case where allocation fails. However, this is also possible by creating an ArrayBufferContents directly. In addition I changed the allocation to avoid zero initialization, since the whole memory is overwritten immediately anyways. R=sammc@chromium.org Bug: chromium:1008840 Change-Id: I43750c462e4959b3bd2b993bc177dcf56593fec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864785Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#706872}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7e14a2d69f2..99d3067c6c30 Created with: gclient setdep -r src-internal@99d3067c6c30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibbf64e0b8e4a211ffabacd3aabdc34f434481550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866550Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8df31ad1d9b8..27c64dd97caf git log 8df31ad1d9b8..27c64dd97caf --date=short --no-merges --format='%ad %ae %s' 2019-10-17 perezju@chromium.org [Telemetry] Remove json-test-results output format Created with: gclient setdep -r src/third_party/catapult@27c64dd97caf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:928275 Change-Id: Id281f78f860092435a16c46db2518999dce77b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866549Reviewed-by:
-
Roman Sorokin authored
CHECK should be used if the consequence of a failed assertion would be a security vulnerability. Which does not seem to be the case. TBR=antrim@chromium.org Bug: 984021 Change-Id: I8c2e0137881f1c3af4b48176683b587679c0998c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865348Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706869}
-
Jan Wilken Dörrie authored
Similarly to r662995 this change deprecates PasswordManager's AccountsPerSite metric and replaces it with AccountsPerSiteHiRes, which provides a finer granularity. Furthermore, it now also logs metrics to the "Overall" PasswordGenerated suffix and its affected histograms. Lastly this change performs some minor code clean-ups. Bug: 966041 Change-Id: I82ca338bc64aac53c099ae66237565e89ecc8ccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863414 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#706868}
-
