- 04 Dec, 2020 23 commits
-
-
Aga Wronska authored
Content packs feature for supervised users has never been launched - deprecate the code. Bug: 1149788 Change-Id: Ifdb8db5d7c5c482d74c8419e74ef540a000b1fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551816 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#833530}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ec57124a67c..91cf42a0759a 2020-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic81ac83108fa1e88a6dcd2480b80e364bf90726f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833529}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ba66a670730d..238470adc0e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tbergquist@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025619,chromium:1150971 Tbr: tbergquist@google.com Change-Id: I6e3bc4250f919e3d107dfb6d30be720342afc690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833528}
-
Darren Shen authored
Bug: b/174612548 Change-Id: I567f592c272f6607328f4a03de551fc4582decfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566320 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Jing Wang <jiwan@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#833527}
-
Daniel Murphy authored
Bug: 1151485, 1151483 Change-Id: I6369a73f66e6429ac1d3873760b69f089b050441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551779 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#833526}
-
Kunihiko Sakamoto authored
This reverts commit d2ee30a3. Reason for revert: Caused gl_tests_validating failure on Linux CFI bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/19128 Original change's description: > Make sure ANGLE can find the proper libraries when running tests > > This cl is in the context of replacing SwiftShader's GL libraries > with SwANGLE (ANGLE with SwiftShader Vulkan as its backend). In order > to allow ANGLE to find the proper libvulkan.so when executing tests > on the bots, we have to make sure the proper rpath is set. > > This affects all tests that depend directly or indirectly on > //ui/gl:test_support. > > The affected tests include: > app_shell_unittests > aura_unittests > cc_unittests > compositor_unittests > gpu_unittests > interactive_ui_tests > message_center_unittests > media_unittests > snapshot_unittests > unit_tests > views_unittests > viz_unittests > wm_unittests > > Bug: chromium:1060139 > Change-Id: Ida242f511599d38ad1ec16e0f4711d80a957cc8f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565490 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833354} TBR=danakj@chromium.org,dalecurtis@chromium.org,thakis@chromium.org,sugoi@chromium.org,kbr@chromium.org,rdevlin.cronin@chromium.org,grt@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,sugoi@google.com Change-Id: Icd0336a4d82b734804be88a0120ad26465f5e5e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1060139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573258Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833525}
-
Jiewei Qian authored
This is a followup to https://crrev.com/c/2569191, which the method was added. The callsite in chrome_new_window_client_browsertest.cc wasn't changed to match the return type. This caused a mismatch so EXPECT_EQ is asked to compare int with size_t, and can cause problem on certain build configurations. Change-Id: I092e0f0ea5d333359c8e11c39e7202f27e1849e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573556 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#833524}
-
Nicholas Hollingum authored
Similar to crrev.com/c/2562799, we remove the installer factory and move it to the omni-service. Bug: b/170596931 Change-Id: I182816dba38fd66d116a1d066d414d69b1503c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567276 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833523}
-
Michael Hansen authored
The "Manage Contacts" button doesn't work when viewing the contact visibility page from the sharesheet flow. We need a custom subclass of views::WebView to perform the navigation. Bug: 1138445 Change-Id: Id90e83b6e307d136bd0114ee51fc42c53b2c8510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567759 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#833522}
-
Aleks Totic authored
New table layout works fine with fractional layout sizes. Bug: 958381 Change-Id: I759c17190acd2f826a39855a1bce3dd48963af96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572788 Commit-Queue: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#833521}
-
Lan Wei authored
Use testdriver Action API to simulate mouse click actions in css/selectors/focus-visible-004.html. Bug: 1145677 Change-Id: I3715e32893f0e977226412d8ffc8b6928ff7a1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551803Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833520}
-
Marc Treib authored
Bug: 1152039 Change-Id: I1baedf226b8848951ac50f5370aa8b80feb06b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567165 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833519}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icb4316185b7972714e192d0323621453f76d0a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572898Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833518}
-
Melissa Zhang authored
Add close check so that sharesheet can't close if it's already in the process of closing. Bug: 1153284 Change-Id: I1279240e2ceb9c7769ab96244d8aa3d3393aec11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570914 Auto-Submit: Melissa Zhang <melzhang@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#833517}
-
Michael Checo authored
Screenshot: http://shortn/_fvSN9f0N5B Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I7cc40e2e25f10c700ffb92bbaefc52a5ec63be62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567930 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833516}
-
Toni Barzic authored
Some file systems are unmounted during device suspend (for example drive FS), which was causing the holding space file system delegate's file path removal detection to remove them from the holding space on device suspend. To avoid this issue, holding space keyed service now observes device suspend status and shuts down holding space delegates when the device suspends. The delegates are re-initialized when suspend ends, restoring the model from persistence again. BUG=1152924 Change-Id: Iffe4586bcb87f47d687ceeff0fc76e60a443c0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568355 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#833515}
-
Xinghui Lu authored
Bug: 1070324 Change-Id: Ibc4e8a2bf4348af27c0481de2665aa5ac5221aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573120 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#833514}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5f9ba6953f8d..b42686ad015b 2020-12-03 jlavrova@google.com Painting styled text blocks in RTL 2020-12-03 mtklein@google.com plumb register aliasing hints through on arm64 2020-12-03 jvanverth@google.com Deprecate Metal support on iOS 9. 2020-12-03 johnstiles@google.com Use `addArrayDimension` instead of manually creating array type. 2020-12-03 johnstiles@google.com Simplify addArrayDimensions by removing multi-dimensional array support. 2020-12-03 csmartdalton@google.com Add unaffectedByDstValue() to GrProcessorSet::Analysis 2020-12-03 johnstiles@google.com Remove multi-dimensional array support from the parser. 2020-12-03 mtklein@google.com factor out an `active_lanes = scalar ? 1 : K` 2020-12-03 mtklein@google.com add load128/store128 2020-12-03 fmalita@chromium.org Reland "[skottie] Add image sampling and transform options" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Id47613a6c4fd00feb65d86422e220bdc0e34595a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833513}
-
Moe Ahmadi authored
crrev.com/c/2566505 made all text in realbox dropdown unselectable. This CL extends that to the realbox placeholder as well. Note that non-placeholder text in the realbox input remains selectable after this change. Fixed: 1154576 Change-Id: I80d13521680a165c56e2a7d98eff82c885ff3da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572680 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833512}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8c8f17af..1afb97a3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3dda672470bcef7cb5d78228585baf33cf62f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572699Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833511}
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in pointerevents/pointerevent_capture_suppressing_mouse.html. Bug: 1145677 Change-Id: I329d4b814020dd3c0d22c807c36828f5e868b4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568825Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833510}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8ddf5ae4b8a5..0fdb2247e82e 2020-12-03 treehugger-gerrit@google.com Merge "Add pid to DisplayFrame proto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7da4f1e07f36c86619822d61e94d51a83042f409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572519 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833509}
-
Joel Hockey authored
Change-Id: I8354cae8082dea4257ba607a65957688557b3d5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573397Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833508}
-
- 03 Dec, 2020 17 commits
-
-
Stephen Roe authored
kmarshall, please review the //build and //fuchsia files bpastene, please review the //testing/buildbot files dpranke, please review //tools/perf/process_perf_results.py Bug: 1126177 Change-Id: Ib98c6d47a74b84e3df42c17c28585e6f8ee983d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553150Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Stephen Roe <steveroe@google.com> Cr-Commit-Position: refs/heads/master@{#833507}
-
Joel Hockey authored
Since TrashEntry is now in common, we can remove other declarations of TrashEntry. Externs can use FilesAppEntry, all others can use TrashEntry directly. Bug: 953310 Change-Id: I4a8f6904152daecf917975caa3abff14b92e189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573396Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#833506}
-
Reilly Grant authored
This adds support for an uncommon configuration in which a composite USB device has the WinUSB driver loaded for the whole device rather than using Microsoft's composite driver to create device nodes for each device function. A manual test which confirms that all calls to claimInterface() succeed or fail in a reasonable time has been added. Bug: 1150758 Change-Id: If86d2e21dbc575cadea943a9c319029a10c78b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568546Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#833505}
-
Ben Kelly authored
It contains a traceable v8 object, yet was previously always owned via a std::unique_ptr<>. Current best practice recommends a GarbageCollected<> type here instead. Bug: 1141510 Change-Id: Ia823ccc8388ed43c1ca3a90d2ecc841c07ddfe55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571810 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#833504}
-
Robert Sesek authored
AX-Relnotes: n/a. Bug: 1153883 Change-Id: Iff9f2d2dd72314f04c11b0b87ff2438655a16335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572177Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833503}
-
Lan Wei authored
Use testdriver Action API to simulate mouse click actions in css/selectors/focus-visible-003.html. Bug: 1145677 Change-Id: I18d3862d524c0a917c056891e7012c589b8252e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548197Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#833502}
-
Darwin Huang authored
Ensure that a format is valid before creating a placeholder Blob, so that clipboard.read() no longer returns nullptr blobs. In particular, filter out custom/pickled formats not supported by the Clipboard API Previously, custom/pickled formats not supported by the Clipboard API, but exposed via blink::SystemClipboard, would create nullptr Blobs when read via clipboard.read(), and return them in the output ClipboardItems. This output ClipboardItem could then be written via clipboard.write(), and cause a crash. Bug: 1153361 Change-Id: Ib57ccca0e79adb09ee51e64c324c32283c788cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568818 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#833501}
-
Bailey Berro authored
Calls the correct method when RoutineType is kBatteryCharge. Bug: 1128204 Change-Id: Ib53ee77c54bca7dd324d6bbac69ccde7d7b98f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573125 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#833500}
-
edchin authored
Removes unnecessary subclass in test file. Bug: 1147967 Change-Id: I72d5d219dd5488a1b42a1512a7de0e34d153cc18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572041Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#833499}
-
rbpotter authored
Migrate file manager from preprocess_grit (being removed) to preprocess_if_expr. Both tools copy files/generate manifests for bundling and generating grd files, and both process <if expr>, but preprocess_if_expr no longer supports the deprecated // <include in JS. file_manager uses <include> in JS, but not in any files being processed by preprocess_grit, so it can be migrated to preprocess_if_expr. Also correcting a comment about inlining images, as neither the old preprocess_grit nor the new preprocess_if_expr inline images. Change-Id: Ie2d1f669346183263250abf0613450c573d28943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570455Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#833498}
-
Clark DuVall authored
After http://crrev.com/c/2547404, native libs can now be loaded from DFMs, so we no longer need to move libs into the base module. Bug: 1150459 Change-Id: I8e33dba16932e64c3ee5b97c84a01f1adc72fee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571956 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#833497}
-
Avi Drissman authored
macOS 10.11 simplifies the NSTextAttachment API, so now that Chromium requires 10.11, clean up the New badge code. Bug: 1153883 Change-Id: I12f17b0c8da7f75346fac9ad9e6d4da12b04d8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572937 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#833496}
-
Josh Simmons authored
This is a reland of cd15c4b9 Original change's description: > Update Files.app iconography to new style > > Replaced the existing icons with new icons that have a different style. > > Test: Looked at Files.app icon in launcher, shelf and switcher > Bug: 1128673 > Change-Id: I55e3a586dd6ea9ab7f03134d4992eb6e7e2ae92d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430564 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Josh Simmons <simmonsjosh@google.com> > Cr-Commit-Position: refs/heads/master@{#810521} Bug: 1128673 Change-Id: I78cf917d7d567def61a3d8e59a07bfe3535a0f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573256Reviewed-by:
Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#833495}
-
Jimmy Gong authored
The ProfileType enum helps distinguish whether the current phone profile is a work profile or the default profile. Bug: 1155244 Change-Id: I21a5f957c31ec1a8ceb4a39080a45ee62daf3ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572703 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#833494}
-
Roger Tawa authored
This is a followup of CL 2535685 that continues the changes at the //content and //chrome layers. Bug: 1150852 Change-Id: Ia30bd4074d38dea66131592c2d655b300b72f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561025 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#833493}
-
Joon Ahn authored
Bug: 1125150 Test: browser_tests --gtest_filter=Diagnostics* Change-Id: I01ae7a5565df32b6ab555a9edbf7fcebdc298c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572000Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#833492}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/30bf3b85f1d9..38f2fff09dac 2020-12-03 brcui@microsoft.com Fix bad XML in accessibility_strings.grdp 2020-12-03 vidorteg@microsoft.com [Loc] Migrate media panel to Localization V2 2020-12-03 patrick.brosset@microsoft.com Flex: Remove temporary support for non-baseline flex overlay backend If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136655,chromium:1139949 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4ad2f9ba77cfe2607a8280899f58f80e6083aafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572126 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#833491}
-