- 08 Oct, 2018 40 commits
-
-
Bailey Berro authored
Two versions of this method were used during migration to a two parameter version. The one parameter version is no longer needed. Bug: none Change-Id: I78f2e1a25649f0377087d9c2d988549741c91722 Reviewed-on: https://chromium-review.googlesource.com/c/1265906 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#597612}
-
Mustafa Emre Acer authored
Bug: 889459 Change-Id: Id33ca6444bff1e6dd71b6000823cf6fec09746ef Reviewed-on: https://chromium-review.googlesource.com/c/1256208Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#597611}
-
Orin Jaworski authored
This CL modifies a few sections of code related to autocomplete to introduce the OmniboxPedalProvider and get its first Pedal working. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a Bug: 893183 Change-Id: I3847a7bf60768cf043da3b3b5a15e651f379dc1a Reviewed-on: https://chromium-review.googlesource.com/c/1247192 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#597610}
-
Qiyu Hu authored
This surfaces when testeris are running CtsVerifier tests. When we have two clients interacting with discovery sessions, say CtsVerifier and GMSCore. Our racy implementation could fail if StartDiscovery() follows immediately after CancelDiscovery(): - CancelDiscovery() is called. |discovery_session_| is not null. discovery_session_->Stop() is called. Note that |discovery_session_| is still not null until OnDiscoveryStopped() is called. - StartDiscovery() is called. |discovery_sessionn_| is not null. Reset timeout and return. - Now OnDiscoveryStopped() is called. Discovery session ends, and the timeout reset above doesn't help extend the session. Also merge StartDiscovery() and StartLEScan() into one StartDiscoveryImpl(). And always discard the |discovery_session_| when CancelDiscovery() is called, even in the case of error. Otherwise, the existing |discovery_session_| will hang there. And scanning is not recoverable in this case. Bug: b:113335665 Test: Manual test with CtsVerifier Change-Id: Ic70bbdc9a7e6e51d2c44965d38ac7ccd65745398 Reviewed-on: https://chromium-review.googlesource.com/c/1212098 Commit-Queue: Qiyu Hu <qiyuh@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#597609}
-
Matt Falkenhagen authored
Consider the scenario: 1. Page makes a range request 2. Service worker responds with 200 status and a big blob. Previously, S13nServiceWorker loading code returned to the page a 200 status and attempted to return only the requested bytes from the blob. This was incorrect: if a 200 status response is returned, all the bytes should be present. Furthermore, since the service worker itself didn't return a 206 status response, it is probably not correct for the loading code to attempt to convert it to one. This CL changes the code to return exactly what the service worker returned. Bug: 892227 Change-Id: Id032ba73ae0a61b300f2d45c1cbf2ba041481788 Reviewed-on: https://chromium-review.googlesource.com/c/1267057Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#597608}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ba651682ae85..8ad991da4c04 git log ba651682ae85..8ad991da4c04 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 robertphillips@google.com Fix Chrome roll 2018-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 19b51d298334..6d765b07f86f (1 commits) 2018-10-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-10-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 450bf36f7918..19b51d298334 (1 commits) 2018-10-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version 2018-10-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 78df3362ac21..450bf36f7918 (1 commits) 2018-10-05 csmartdalton@google.com ccpr: Delete the stashed atlas texture before allocating a new one 2018-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0ca09753392d..78df3362ac21 (7 commits) 2018-10-05 brianosman@google.com Cleanup bitmap/mipmap cache key structs 2018-10-05 egdaniel@google.com Revert "Remove ability to sample textures in vertex or geometry shaders." 2018-10-05 caryclark@skia.org fix bookmaker 2018-10-05 herb@google.com Remove old code by moving to new API in bitmap text 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-05 herb@google.com Less stress for chromecast 2018-10-05 kjlubick@google.com Move dumpJSON behind the SK_ENABLE_DUMP_GPU flag 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-05 robertphillips@google.com Exercise newly exposed SkYUVIndex-based SkImage factories (take 2) 2018-10-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-05 reed@google.com trim unused SkDraw functions 2018-10-05 egdaniel@google.com Remove ability to sample textures in vertex or geometry shaders. 2018-10-05 egdaniel@google.com Remove debug only clearStencil virtual on GrGpu. 2018-10-05 brianosman@google.com Revert "Exercise newly exposed SkYUVIndex-based SkImage factories" 2018-10-05 reed@google.com split out SkDraw_text functions 2018-10-05 robertphillips@google.com Exercise newly exposed SkYUVIndex-based SkImage factories 2018-10-05 reed@google.com split SkPaint into separate impl files 2018-10-05 herb@google.com Split out SkRunFont and SkPaint 2018-10-05 fmalita@chromium.org [skottie] Optional path control points Created with: gclient setdep -r src/third_party/skia@8ad991da4c04 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=stani@chromium.org Change-Id: Ifad405625a27c129466fb6607280c85a66d13165 Reviewed-on: https://chromium-review.googlesource.com/c/1268558Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597607}
-
Tommy C. Li authored
Previously, the code was copying the full URL verbatim to the clipboard when it saw that the user had not modified the display text at all. This path was meant to gracefully handle the simple case where we elide parts of the URL, but not meant for any Query in Omnibox case. This CL disables that code path for Query in Omnibox, and adds a test. Bug: 874592 Change-Id: I35dc12c55f906f078b87851803b97965ecacd6c8 Reviewed-on: https://chromium-review.googlesource.com/c/1259619Reviewed-by:
-
Carlos IL authored
Added parameters to experiment to allow only upgrading blockable content or optionally blockable content. Will be added in follow-up CLs: -LayoutTests -Fallback to HTTP (handled from //content) -Metrics Change-Id: I3d3922fc017413b5374404427deae310ecf30bb1 Reviewed-on: https://chromium-review.googlesource.com/c/1251628 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#597605}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0e0cf00798f66eacb564bbd34b9d3782ed175481 Reviewed-on: https://chromium-review.googlesource.com/c/1268898Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#597604}
-
Meilin Wang authored
Fixed this DCHECK by posting SetSystemMuted and SetSystemVolume to main thread. Test: local compile and manually test. Bug: b/117184283 Change-Id: I6386b81a9bd05f5df3688a2c890301151d03e59b Reviewed-on: https://chromium-review.googlesource.com/c/1265255Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#597603}
-
Mario Sanchez Prada authored
This CL moves AdvancedProtectionStatusManager away from using SiginManager and related APIs (e.g. SiginManagerBase::Observer), replacing those bits with calls to the IdentityManager's API instead. Likewise it moves from fetching tokens using the PO2TS APIs to building a PrimaryAccessTokenFetcher and relying on it to retrieve the tokens associated with the primary account. Bug: 887264 Change-Id: I80b55190133f05a50412d4a09613176ce24fbeaa Reviewed-on: https://chromium-review.googlesource.com/c/1250968 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#597602}
-
Mario Sanchez Prada authored
Port all calls to SigninManager::IsAuthenticated() into calls to IdentityManager::HasPrimartyAccount() instead. Bug: 890803 Change-Id: I6b6ca0aeed0dc217c3d44e2d1fdf8215acbc8be6 Reviewed-on: https://chromium-review.googlesource.com/c/1261980Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#597601}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4fc4281d2152..9ec8468cfde0 git log 4fc4281d2152..9ec8468cfde0 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 eyaich@google.com Implementing firstContfulPaint metric using navigationId when present. Created with: gclient setdep -r src/third_party/catapult@9ec8468cfde0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:850258 TBR=sullivan@chromium.org Change-Id: I232dff89dc72296dd64dcbc55bc246f7b4a41f08 Reviewed-on: https://chromium-review.googlesource.com/c/1268695Reviewed-by:
-
Wei Li authored
This is to prepare for removing ShouldHideUIForFullscreen() and the entire Cocoa integration of FullscreenControlHost. BUG=890455 Change-Id: If743e9c4d51312222d3dce1406040f5ad3b1e4f7 Reviewed-on: https://chromium-review.googlesource.com/c/1266118Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#597599}
-
Emily Hanley authored
on android nexus5x webview TBR=charliea@chromium.org NOTRY=True Bug: 893209 Change-Id: Iff61f9daf5b3e092eefb3cf86638014643685e62 Reviewed-on: https://chromium-review.googlesource.com/c/1268669Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#597598}
-
Carlos Knippschild authored
* Update content, prioritization and order of offline content to comply with the latest design decisions: * Require minimum of 4 "interesting" items to show anything in the dino page. * Stop prioritizing unread prefetched pages over read ones. * Stop treating a prefetched page also as representing a general page. * Stop treating "Document" downloaded items the same way as "Page". * Fix a potential crash when converting text using higher unicode characters. * Update tests to the conform to the changes above and improve some internal naming. * Do not call dino page Javasscript code when content list is empty. * Do not present the summary view if items count is zero. * Added missing UMA enum value for a previously added case. * Improved/fixed some doc comments. Bug: 852872 Change-Id: I01856e09016e2027b7034ba82b22a8b22922be9d Reviewed-on: https://chromium-review.googlesource.com/c/1260487 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#597597}
-
Joshua Pawlicki authored
TBR=olka@chromium.org Bug: 893015 Change-Id: Ida8106cf8d29659b3a66ed7d85d007302acfc5f6 Reviewed-on: https://chromium-review.googlesource.com/c/1268518 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#597596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a81322039bb8..39a66e9fc8df git log a81322039bb8..39a66e9fc8df --date=short --no-merges --format='%ad %ae %s' 2018-10-08 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@39a66e9fc8df The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2ac5d3056a1dbda08dc91fd178325def02a77254 Reviewed-on: https://chromium-review.googlesource.com/c/1268696Reviewed-by:
-
Tommy C. Li authored
After this CL, when the user presses Ctrl+L twice, we will reveal the full URL. Technically speaking, when the user issues a command to focus the Omnibox while it's already focused, we will interpret it as a signal that the user wants to see the full editable URL. So it works for Alt+D and F6 as well. This is gated behind the Query in Omnibox flag since it's still under active experimentation. Bug: 874592 Change-Id: I4d4a8944e4435a57be5e909f94ed65ff303be642 Reviewed-on: https://chromium-review.googlesource.com/c/1265825Reviewed-by:
-
Evan Stade authored
Bug: 887663 Change-Id: I0e5d3e16d59cf3459fde94f3ed2edb23c2ea9f0e Reviewed-on: https://chromium-review.googlesource.com/c/1260002Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Eugene But authored
This reverts commit 8719721a. Reason for revert: These tests were not flaky on iOS 10 and 11. Flakiness on iOS 12 should be fixed in crrev.com/c/1267347 If flakiness persist on iOS 12 we should disable the tests only for iOS 12. Original change's description: > Mark DownloadManagerTestCase tests as flaky. > > TBR=eugenebut@chromium.org > > Bug: 892883 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: Idd01581265d46e17f2812c1456ebe93f0d521389 > Reviewed-on: https://chromium-review.googlesource.com/c/1266879 > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597415} TBR=michaeldo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892883 Change-Id: I90a84f0606e1a97b96a27475c5b810828b37756e Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1268677Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#597592}
-
Ben Kelly authored
R=mek@chromium.org Bug: 892971 Change-Id: Iede30d552e737cacc0b85ccfa1575c43f0b82917 Reviewed-on: https://chromium-review.googlesource.com/c/1268535Reviewed-by:
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=True Bug: 893197 Change-Id: I374eb840b6a6f375b27a6a9c8974200099cbb09b Reviewed-on: https://chromium-review.googlesource.com/c/1268664Reviewed-by:
-
Mike Tsao authored
R=michaelpg@chromium.org Change-Id: Ib00ea0c25a0069cf266306a96445d509698725b8 Reviewed-on: https://chromium-review.googlesource.com/c/1265505 Commit-Queue: Mike Tsao <miket@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#597589}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6f591c9706e6..3f21fcb9bd26 git log 6f591c9706e6..3f21fcb9bd26 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 courtneygo@google.com Set ANGLE default backend to Vulkan Created with: gclient setdep -r src/third_party/angle@3f21fcb9bd26 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I8a68472b8aa45e90c0d490b2ec78768f105de00b Reviewed-on: https://chromium-review.googlesource.com/c/1268557Reviewed-by:
-
jdoerrie authored
This change adds GetAllLoginsWithAffiliationAndBrandingInformation() to the PasswordStore. Prior to this change clients had to call both GetAutofillableLoginsWithAffiliationAndBrandingInformation() and GetBlacklistLoginsWithAffiliationAndBrandingInformation() to obtain the same information. This was unnecessarily complex, in particular if knowledge about which response corresponds to which request was required. As a result of this change the password population logic in PasswordManagerPresenter can be greatly simplified. Bug: 892260, 778146 Change-Id: Ic0773c4d0337bc3be1fded6f22bda8d8ac2927bb Reviewed-on: https://chromium-review.googlesource.com/c/1268198 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597587}
-
Mikel Astiz authored
We have multiple flaky tests that complain with: java.lang.IllegalArgumentException: Can not find AccountHolder for account Account {name=test@gmail.com, type=com.google} at org.chromium.components.signin.test.util.FakeAccountManagerDelegate.getAccountHolder(FakeAccountManagerDelegate.java:341) at org.chromium.components.signin.test.util.FakeAccountManagerDelegate.getAuthToken(FakeAccountManagerDelegate.java:259) at org.chromium.components.signin.AccountManagerFacade$3.run(AccountManagerFacade.java:492) at org.chromium.components.signin.AccountManagerFacade$3.run(AccountManagerFacade.java:489) at org.chromium.components.signin.AccountManagerFacade$ConnectionRetry$1.doInBackground(AccountManagerFacade.java:829) at org.chromium.base.task.AsyncTask$1.call(AsyncTask.java:99) at java.util.concurrent.FutureTask.run(FutureTask.java:237) ... 3 more One hypothesis is that GetAccountHolder() fails during teardown of the test. Hence, let's treat it as auth error such that AccountManagerFacade.getAuthToken() treats it as a regular failed attempt (but doesn't necessarily make the test fail). Bug: 879246 Change-Id: I47c69af1af2579ec70ece468e6701f67ef065992 Reviewed-on: https://chromium-review.googlesource.com/c/1264678Reviewed-by:Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597586}
-
Devlin Cronin authored
The platform apps api_registration target builds the generated registration for all the Apps-related API functions. This results in a dependency on those API functions, defined in the chrome/browser/apps/platform_apps/api target. Add an explicit dependency from c/b/a/platform_apps/api_registration on chrome/browser/apps/platform_apps/api. This results in circular dependencies from c/b/chromeos and c/b/ui; allow these circular includes as we do for extensions. (Ideally, we can cull some of these, but for now, let's get the compile working again). Bug: 893153 TBR=dominickn@chromium.org Change-Id: Ia43c135ab6c642e47e04aa3c7f7eecedbc7b871e Reviewed-on: https://chromium-review.googlesource.com/c/1268517Reviewed-by:
-
Dominik Röttsches authored
Wait for fonts to be loaded completely, simplify test output logging code by using map() instead of loop. Bug: 708604 Change-Id: Icdca037eb20badb249d10c71b1d98bd6aaae0419 Reviewed-on: https://chromium-review.googlesource.com/c/1268275 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#597584}
-
Philip Rogers authored
A sticky transform node was added in https://crrev.com/590578 but the paint property tree printer was not updated to dump this value. This patch also synchronizes the effect node printing which was missing some values. Bug: 877196 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I26f887e12ecef4eee94b66de57c6edfa3af59648 Reviewed-on: https://chromium-review.googlesource.com/c/1268245 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#597583}
-
Stefan Zager authored
BUG=880388 Change-Id: Ie1a1c4fcf3ee6dbf7a058fdfdf88c3e84417097c Reviewed-on: https://chromium-review.googlesource.com/c/1265831Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#597582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6a8327fc823d..3a7423909164 git log 6a8327fc823d..3a7423909164 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 nisse@webrtc.org Fix compilation issues on media_transport_interface.h 2018-10-08 terelius@webrtc.org Pass HeaderExtensionMap by reference in rtc_event_log2rtp_dump. 2018-10-08 yvesg@webrtc.org Fix race condition for GetContributingSources test. 2018-10-08 titovartem@webrtc.org Rename DefaultNetworkSimulationConfig into BuiltInNetworkBehaviorConfig. Created with: gclient setdep -r src/third_party/webrtc@3a7423909164 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I1a3f95ac06f2fe41709733d18d97a6186b6481fd Reviewed-on: https://chromium-review.googlesource.com/c/1268555Reviewed-by:
-
Dmitry Gozman authored
This is dead code, since "statsCollectionObserver.tabLoadTiming" is not used anywhere. Bug: none Change-Id: Ie9891679a2e2f4987ec11c40f31b7a172535569e Reviewed-on: https://chromium-review.googlesource.com/c/1267349Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597580}
-
Harald Alvestrand authored
Bug: 893112 Change-Id: Ieb111c7bfb25d298881ed6945f74d51dc9ad07db Reviewed-on: https://chromium-review.googlesource.com/c/1268244Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#597579}
-
Joshua Pawlicki authored
TBR=olka@chromium.org Bug: 888161 Change-Id: Ie6fa29f04d0b6e129c86b6866faa5629c369d9d5 Reviewed-on: https://chromium-review.googlesource.com/c/1268595Reviewed-by:
-
John Budorick authored
Bug: 790265 Change-Id: I86aa0233e66af6ee8a98775356124e827317b5de Reviewed-on: https://chromium-review.googlesource.com/c/1263881Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#597577}
-
Yao Xiao authored
It allows us to observe mainframe download in PageLoadMetricsObserver. Bug: 881345 Change-Id: Icc5a3fb9dd645b9bdc291b64030789312614b74d Reviewed-on: https://chromium-review.googlesource.com/c/1260566Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#597576}
-
Eugene But authored
Wait until Download button is shown up before tapping it. The timeout for the button should be the same as page load timeout, because the button is shown when the server responds. Bug: 892883 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I9cc3b687a9ff8029f411e8eee02689719f1ac0ca Reviewed-on: https://chromium-review.googlesource.com/c/1267347Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63ee73a37124..3c5695530095 Created with: gclient setdep -r src-internal@3c5695530095 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4a11da9cfcc8b9e1710ca9c29052b90ccb2fb1c3 Reviewed-on: https://chromium-review.googlesource.com/c/1268556Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597574}
-
Yuri Wiitala authored
The current theory (see bug) is that somehow the member set between audio::LoopbackStream and media::LoopbackGroupCoordinator became out-of- sync. This change tests that theory by modifying the destructor to ensure the exact set of SnooperNode instances that could be in-use by LoopbackStream::FlowNetwork are cleanly "disconnected" before shutdown (with further object destruction) proceeds. Bug: 888478, 867886 Change-Id: I7b34fe168a80302c43a4333b9a181342f7b79912 Reviewed-on: https://chromium-review.googlesource.com/c/1266875 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597573}
-
