- 28 Nov, 2018 40 commits
-
-
Per Åhgren authored
This CL adds histograms to monitor the API call jitter that is observed in AEC3 in WebRTC. The WebRTC CL for adding the histograms is https://webrtc-review.googlesource.com/c/src/+/111580 The metrics for the API call jitter is the minimum and maximum calls API calls in a row (in units blocks of 8ms) observed for capture and render. Bug: chromium:907234 Change-Id: I7f6d45b9f5826f6f7706a6ec3644ec0c35a3da00 Reviewed-on: https://chromium-review.googlesource.com/c/1345012 Commit-Queue: Per Åhgren <peah@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611600}
-
Yutaka Hirano authored
The result of ContentClient::GetUserAgent is known to be incorrect in the renderer process, so get the value in the browser and pass it via IPC. Bug: 818450 Change-Id: Ia1af4c237b9d63059c634cd0bbb41ab53436b8cd Reviewed-on: https://chromium-review.googlesource.com/c/1352119Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#611599}
-
Raphael Kubo da Costa authored
This fixes the build with libstdc++ after c416f80a ("Refactor base::FuzzedDataProvider and fix the calling sites"): * CHAR_BIT is part of limits.h (or <climits>), not the C++ <limits> header * std::memcpy() needs <cstring> Bug: 819294 Change-Id: I71439bd56c68fb7600a816ce03a71711ccfb00db Reviewed-on: https://chromium-review.googlesource.com/c/1352320Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#611598}
-
Raphael Kubo da Costa authored
GCC is stricter than clang when it comes to class members' names and how they can change the meaning of a previously existing symbol with the same name: In file included from ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:5: ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.h:102:35: error: declaration of ‘blink::CallSetupState blink::CallSetupStateTracker::CallSetupState() const’ [-fpermissive] CallSetupState CallSetupState() const; ^~~~~ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker.h:79:12: error: changes meaning of ‘CallSetupState’ from ‘enum class blink::CallSetupState’ [-fpermissive] enum class CallSetupState { ^~~~~~~~~~~~~~ https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84709 contains a longer explanation, but essentially having a |CallSetupState()| method can change the meaning of references to the |CallSetupState| enum in the code depending on where it is declared, which contradicts the C++ standard. Fix it by renaming the method to |GetCallSetupState()| after commit 7b1a3d2d ("CallSetupStateTracker::CallSetupState() added"). Bug: 819294 Change-Id: I5660c7c39d107343567452a5575205090c23cae8 Reviewed-on: https://chromium-review.googlesource.com/c/1352354Reviewed-by:Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#611597}
-
Raphael Kubo da Costa authored
This fixes the libstdc++ build after 86293fce ("IndexedDB: Move content/renderer/indexed_db/ to Blink, take 2"): In file included from /usr/include/c++/8/memory:80, from ../../third_party/googletest/src/googlemock/include/gmock/gmock-actions.h:45, from ../../third_party/googletest/src/googlemock/include/gmock/gmock.h:59, from ../../testing/gmock/include/gmock/gmock.h:10, from ../../third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.h:9, from ../../third_party/blink/renderer/modules/indexeddb/mock_web_idb_callbacks.cc:5: /usr/include/c++/8/bits/unique_ptr.h: In instantiation of ‘void std::default_delete<_Tp>::operator()(_Tp*) const [with _Tp = blink::IDBKey]’: /usr/include/c++/8/bits/unique_ptr.h:274:17: required from ‘std::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = blink::IDBKey; _Dp = std::default_delete<blink::IDBKey>]’ ../../third_party/blink/public/platform/modules/indexeddb/web_idb_key.h:165:30: required from here /usr/include/c++/8/bits/unique_ptr.h:79:16: error: invalid application of ‘sizeof’ to incomplete type ‘blink::IDBKey’ static_assert(sizeof(_Tp)>0, ^~~~~~~~~~~ libstdc++'s std::unique_ptr implementation has a few static_asserts in the destructor, one of which requires that the type passed to unique_ptr is fully declared at the time. mock_web_idb_callbacks.cc is now in Blink, and it ends up indirectly including web_idb_key.h, and now WebIDBKey::ReleaseIdbKey()'s call to std::move() triggers that assert. Move the implementation to the web_idb_key.cc to fix the issue. Bug: 819294 Change-Id: Ia02ed14d4b53b3e75cad46ef8dadba8017c64d02 Reviewed-on: https://chromium-review.googlesource.com/c/1352184Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#611596}
-
Matt Falkenhagen authored
This bug has already been fixed by r583483. Bug: 804682 Change-Id: Ica4adb5b8f390a14c721f644afa69a2d394e3a69 TBR: bashi Reviewed-on: https://chromium-review.googlesource.com/c/1353054Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611595}
-
Hirokazu Honda authored
This reverts commit 843847fc. Reason for revert: VDA unittest on eve is broken. Original change's description: > ozone: drm: Re-set cursor when GPU process connects > > When the GPU process restarts we need to re-send the cursor bitmap since > all GPU process display state is lost. > > It looks like it may have been broken all the way back to d818104f > ("[Ozone-Drm] Notify cursor of channel established last"), which fixed a > different issue but also caused the message that was intended to restore > the cursor (in CommitBoundsChange) to not get delivered. > > Bug: 908682 > Test: kill $(pgrep -f type=gpu-process), cursor restored > > Change-Id: Ibacab25807995d9402c46f88a7d51b68fe8dfbfc > Reviewed-on: https://chromium-review.googlesource.com/c/1351903 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611166} TBR=spang@chromium.org,dnicoara@chromium.org Change-Id: I6b69290c0d193190a0bcecc56819b3c59872eff8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908682 Reviewed-on: https://chromium-review.googlesource.com/c/1353038Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#611594}
-
Raphael Kubo da Costa authored
This fixes the GCC build after 65be571f ("Add DNS histograms for private DNS usage, perf, and auto-upgradability"). Due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84849, having base::NoDestructor<T<U>> and passing an initializer list of Us does not work if this is not done explicitly, as GCC incorrectly fails to determine which constructor overload to use: ../../net/dns/host_resolver_impl.cc: In function ‘bool net::{anonymous}::DnsServerSupportsDoh(const net::IPAddress&)’: ../../net/dns/host_resolver_impl.cc:525:8: error: call of overloaded ‘NoDestructor(<brace-enclosed initializer list>)’ is ambiguous }); ^ In file included from ../../net/dns/host_resolver_impl.cc:42: ../../base/no_destructor.h:62:3: note: candidate: ‘base::NoDestructor<T>::NoDestructor(const base::NoDestructor<T>&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’ <deleted> NoDestructor(const NoDestructor&) = delete; ^~~~~~~~~~~~ ../../base/no_destructor.h:60:12: note: candidate: ‘base::NoDestructor<T>::NoDestructor(T&&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’ explicit NoDestructor(T&& x) { new (storage_) T(std::move(x)); } ^~~~~~~~~~~~ ../../base/no_destructor.h:59:12: note: candidate: ‘base::NoDestructor<T>::NoDestructor(const T&) [with T = std::unordered_set<std::__cxx11::basic_string<char> >]’ explicit NoDestructor(const T& x) { new (storage_) T(x); } ^~~~~~~~~~~~ See also: https://chromium-review.googlesource.com/c/chromium/src/+/1170905 Bug: 819294 Change-Id: I821c5215bf39c9c3caf50c614710dba551b0a19a Reviewed-on: https://chromium-review.googlesource.com/c/1352353Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#611593}
-
Artem Titarenko authored
This will add jar library for android 4.1.2 (API level 16). Bug: webrtc:9955 Change-Id: I2428a7b65fbd83553deddd12ca655e8242ebf234 Reviewed-on: https://chromium-review.googlesource.com/c/1348044 Commit-Queue: Artem Titarenko <artit@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#611592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a1201f66f4b..80a54408f352 Created with: gclient setdep -r src-internal@80a54408f352 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6755d12b337b60a9228f71a518a46876660c5470 Reviewed-on: https://chromium-review.googlesource.com/c/1352992Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611591}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e156070. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox domenic@chromium.org, ricea@chromium.org: external/wpt/streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/IndexedDB jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI ksakamoto@chromium.org: external/wpt/resource-timing mcasas@chromium.org: external/wpt/geolocation-API mkwst@chromium.org: external/wpt/cookies mstensho@chromium.org: external/wpt/css/css-multicol nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents rego@igalia.com: external/wpt/css/css-ui external/wpt/css/selectors external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request timvolodine@chromium.org, reillyg@chromium.org: external/wpt/orientation-event yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If45b2ee6834b9e414c200c806298065bd4999029 Reviewed-on: https://chromium-review.googlesource.com/c/1352970 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611590}
-
Alexey Baskakov authored
Output structure: <ProfileDir> WebApps Sync Data LevelDB Temp <temp_name> Icons <size1>.png <sizeN>.png <AppId1> Icons <size1>.png <sizeN>.png <AppIdN> Icons <size1>.png <sizeN>.png When all .png files written, we `mv` Temp/<temp_name> to WebApps/<AppId1> in one final file system "commit". TBR=dcheng@chromium.org Bug: 901226 Change-Id: I2e8840aa3df230d9f78f287d5a637780ef34268b Reviewed-on: https://chromium-review.googlesource.com/c/1349148Reviewed-by:Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#611589}
-
Scott Violet authored
Refactors code for creating RasterContextProvider out of content into services/ws so that can be used by window-service clients as well as content. BUG=905569 TEST=covered by tests Change-Id: Iec41d949ebd9819e597e14e194bd15ba54318527 Reviewed-on: https://chromium-review.googlesource.com/c/1347209 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#611588}
-
Leon Han authored
This CL tries to unify the definition of referrer policy enum, removing blink::ReferrerPolicy by replacing it with network::mojom::ReferrerPolicy everywhere inside Blink. BUG=860403 Change-Id: Ia14a116facf2f8a1901a9c8ea6e4fdc960aa6ae5 Reviewed-on: https://chromium-review.googlesource.com/c/1347779 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611587}
-
James Darpinian authored
This is a WebGL spec change: https://github.com/KhronosGroup/WebGL/commit/bfbe124a7bb92eed34ea7cc18694167ed66b1030 Fixes conformance2/textures/misc/tex-mipmap-levels.html Bug: 898351 Change-Id: I710edd7f189d21cf080d5b775a2c8aef30ad166c Reviewed-on: https://chromium-review.googlesource.com/c/1352494Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#611586}
-
Kent Tamura authored
Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I979d51cdf399d78aa51b2d5692b7e93df3461410 Reviewed-on: https://chromium-review.googlesource.com/c/1353029Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611585}
-
Maggie Chen authored
This finch experiment will enable Direct Composition overlay for software protected video on all GPUs including AMD and nVidia in Windows. Currently, Direct Composition overlay is only enabled for Intel GPUs. Bug:906722 Change-Id: If454f8b80f0c9cefe564b5aaa1da2232973c192a Reviewed-on: https://chromium-review.googlesource.com/c/1342399 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#611584}
-
Ken Rockot authored
Adds fuzzers for Channel and NodeChannel, the two main primitives over which Mojo transmits all IPC messages. Both objects define and parse different layers of the internal control protocol. The Channel fuzzer just fires random data at a platform-specific Channel implementation, covering the lowest protocol layer which parses a Channel::Message header. The NodeChannel fuzzer sends well-formed Channel::Message header data with a fuzzed payload to a NodeChannel receiver, which covers parsing the rest of the internal control protocol. Bug: 900440 Change-Id: I9fe9b88fc3bced17427db28daad931fb64a44280 Reviewed-on: https://chromium-review.googlesource.com/c/1352828 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611583}
-
Joel Hockey authored
Add pkedcjkdefgpdelpbcmbmeomcjbeemfm in addition to enhhojjnijigcajfphajepfemndkmdlo Bug: 873322 Change-Id: Ic584d17466bf14dbe79122878186dedb18408d4b Reviewed-on: https://chromium-review.googlesource.com/c/1353030Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#611582}
-
Nigel Tao authored
BUG=826982 Change-Id: I1feaec0eae9a0d2413ce4b2200da1d87b798ae98 Reviewed-on: https://chromium-review.googlesource.com/c/1352124 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611581}
-
Nigel Tao authored
BUG=826982 Change-Id: I9d82c8f6d4abad6dd80c6825691075e68c749b1a Reviewed-on: https://chromium-review.googlesource.com/c/1349145 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611580}
-
Nigel Tao authored
That design was introduced, some months ago (2018 July), in crrev.com/c/1127513 "Create a skeleton App Service and App Registry". The 'skeleton' App Registry wasn't actually called anywhere in production code, only in tests. Some months later (2018 November), crrev.com/c/1328626 "Add chrome/services/app_service design doc" and crrev.com/c/1338590 "Add an App Service registry implementation" gave more detail or 'flesh on the bones' about how the App Service (and the registry aspect of that service) would work. This involved a new design, also called the "App Registry". The old design was deprecated. This commit deletes that old code, removing the confusion in having both the old and new designs, both called "App Registry". The new design does not depend on the prefs service, so some dependencies were removed. In the future, some other to-be-written part of the App Service may depend on the prefs service. At that future point in time, some of these dependencies (and the 'pause incoming Mojo requests until the pref service is ready' dance in app_service.cc) may be re-introduced. But for now, YAGNI. BUG=826982 Change-Id: I4ad52c5b9ba307a3922ed6dda330b7d9aedf29a0 Reviewed-on: https://chromium-review.googlesource.com/c/1348881 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611579}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/59cfd3543875..0d007d7c4f11 git log 59cfd3543875..0d007d7c4f11 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aed90203..b04e513f (611312:611432) 2018-11-28 jeroendb@webrtc.org Fix raddr on srflx and relay candidates 2018-11-27 qingsi@webrtc.org Revert "Delay call to Destroy until after SignalDone has finished firing." 2018-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81c26a09..aed90203 (611047:611312) 2018-11-27 zstein@webrtc.org Delay call to Destroy until after SignalDone has finished firing. 2018-11-27 peah@webrtc.org AEC3: Add metrics for API call jitter 2018-11-27 jakobi@webrtc.org Add PeerConnection option to configure minimum audio jitter buffer delay. 2018-11-27 artit@webrtc.org Fix webrtc-internal configs to run perf tests on separate bots 2018-11-27 terelius@webrtc.org Batch RTC event log output if using the new wire format. 2018-11-27 jakobi@webrtc.org Expose delayed packet outage as a cumulative metric of samples in the new getStats API. Created with: gclient setdep -r src/third_party/webrtc@0d007d7c4f11 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:905690,chromium:905542,chromium:None,chromium:905542,chromium:907234 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I956aed4c208a54a3ab6446e9ab8780d9f08669f2 Reviewed-on: https://chromium-review.googlesource.com/c/1352608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611578}
-
chrome://flagsJinsuk Kim authored
Creates a new entry in chrome://flags for gesture navigation that will allow horizontal scroll gesture to navigate forward/backward. Bug: 865567 Change-Id: Id35d8ad261e2f4a29e34c4b4a73eed04029ba643 Reviewed-on: https://chromium-review.googlesource.com/c/1350411 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611577}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3b7c9d099b0d..83b2f0e8a2e0 git log 3b7c9d099b0d..83b2f0e8a2e0 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 jdarpinian@chromium.org WebGL: Forbid GenerateMipmap on zero-size textures Created with: gclient setdep -r src/third_party/angle@83b2f0e8a2e0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:898351 TBR=fjhenigman@chromium.org Change-Id: I2d031595d94047c86a380c3f2ab287def933ae5d Reviewed-on: https://chromium-review.googlesource.com/c/1351137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611576}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8640c5d4e9f9..3a1201f66f4b Created with: gclient setdep -r src-internal@3a1201f66f4b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If2d920f72d276cc5a9a1843aa1d05346187068e7 Reviewed-on: https://chromium-review.googlesource.com/c/1352990Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611575}
-
Chris Hall authored
R=dmazzoni,aboxhall BUG=889370 Change-Id: I1a3ced4e63b289bd1aa2bc4fc40e28c6a2fd7e9e Reviewed-on: https://chromium-review.googlesource.com/c/1307022Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611574}
-
Jinsuk Kim authored
This CL makes the ephemeral tab in peeked state 150% larger. Top portion of the content being loaded as well as the progress bar becomes quite visible. Bug: 894619 Change-Id: I2aa5d39a4a9592c07421136c00d74c54b9c916ae Reviewed-on: https://chromium-review.googlesource.com/c/1349150Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#611573}
-
Zhiqiang Zhang authored
This reverts commit 7c453583. Reason for revert: This introduces some regression in some cases. The old logic works just fine so it is safe to revert. Original change's description: > [Android MR] Postpone route selection until session launch > > Previously, we unselect and re-select the route due to CAF limitation. > The reason is that we need to set the receiver app ID after the user > choose a device. However CAF won't be able to know a device was selected > after the receiver app ID gets changed. > > In this CL, to solve the issue, we intercept the click event in > MediaRouteChooserDialog (which would select the route automatically). > The route selection is postponed right before session launch. Therefore > we are able to set the receiver app ID and select the route to get rid > of CAF limitation. > > Bug: 711860 > Change-Id: I5b1534d36d540b62199a6fb739c56ad5131c2711 > Reviewed-on: https://chromium-review.googlesource.com/c/1351893 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611437} TBR=zqzhang@chromium.org,tguilbert@chromium.org Change-Id: I30322daecf8c866fdda9e846d0cb37d9a319f033 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 711860 Reviewed-on: https://chromium-review.googlesource.com/c/1352973Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611572}
-
Takuto Ikuta authored
Due to too many include, v8_context_snapshot_external_references.cc has long compile time. This CL removes header files for ConstructorCallback by introducing forward declaration. That reduces compile time of v8_context_snapshot_external_references.cc from 24.6s to 4.5s in Z840 Linux. Change-Id: I247e6a92dfdec15f19a38771eb64b4a85c447c25 Reviewed-on: https://chromium-review.googlesource.com/c/1352110Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#611571}
-
Fergal Daly authored
Adds tests for manipulating it via the attribute. Renames PartNames() to Part() to match with part(), the API wrapper. This uses the same IDL as classList. Bug: 805271 Change-Id: I9715df48478510029f5d985124e46111c41cffc3 Reviewed-on: https://chromium-review.googlesource.com/c/1333014 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#611570}
-
liberato@chromium.org authored
This adds the Distribution class, which will replace the TargetDistribution typedef in Model. It provides some convenient functionality, such as += and max-finding. None of the uses of TargetDistribution are updated here. Change-Id: I0e86d9dbaddcd5421cbc65e73213329603346733 Reviewed-on: https://chromium-review.googlesource.com/c/1329881 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#611569}
-
Takashi Toyoshima authored
|response.head.headers| can be empty in some cases, e.g. ftp accesses. We previously added a null check in GetHeaderString(), but OnReceiveResponse() itself accesses it without any null check. This patch adds a check to have a status code, and uses a fallback value if it does not exist. Bug: 908261 Change-Id: I15e0e61ce39c9e7846c26ab8875485b4597ce458 Reviewed-on: https://chromium-review.googlesource.com/c/1351348Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#611568}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f2a2ae33b38..8640c5d4e9f9 Created with: gclient setdep -r src-internal@8640c5d4e9f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860880,chromium:892303 TBR=mmoss@chromium.org Change-Id: I18acbcb34b9104a93e1bcf5149a1becea85dfaa4 Reviewed-on: https://chromium-review.googlesource.com/c/1351760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611567}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Icf64d8eaa44e8d4e2a321ae831379c483a765d14 Reviewed-on: https://chromium-review.googlesource.com/c/1352069Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#611566}
-
Nigel Tao authored
BUG=826982 Change-Id: Iede4849e94bbecc9340dcd3d612e419531185fa9 Reviewed-on: https://chromium-review.googlesource.com/c/1347955 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611565}
-
Roger McFarlane authored
This CL integrates ARIA label and description parsing into the render/JS to browser communication path. This allows the browser to have knowledge of the ARIA label and description. Bug: 896719 Change-Id: If5e8d9389f10beecae102080ebcde066aae6c80a Reviewed-on: https://chromium-review.googlesource.com/c/1342673Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611564}
-
Chih-Yu Huang authored
Move the common macros to macros.h. This CL is just code refactoring, not changing any code logic. BUG=b:119794200 TEST=Run VDA unittest on Bob and Eve Change-Id: I066a5e79c58e9c95c3db714534bf9f309f8314a5 Reviewed-on: https://chromium-review.googlesource.com/c/1345751Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611563}
-
Austin Eng authored
Add additional internal formats for CopyTexImage2D Unsuppresses previously failing test # for webgl2_conformance_expectations.py Bug: 905531 Change-Id: Ib9f525afa0188def6464c9f6134efc0090825f6b TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1340369 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#611562}
-
Kent Tamura authored
A follow-up of crrev.com/611454. We had other instances of LAYOUT_TEST_PATH_PREFIX. TBR=qyesrsley@chromium.org Bug: 909012 No-Try: true Change-Id: Iec4c017f9123857f50e56ae3e8f5c6ae457af949 Reviewed-on: https://chromium-review.googlesource.com/c/1352087Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611561}
-