- 26 Aug, 2014 40 commits
-
-
mlerman authored
BUG=335086 TEST=Ensure new-profile-management and account-consistency are not enabled. Then sign in a profile. Then enable new-profile-management. The "lock" button of the avatar menu should be present but disabled. Review URL: https://codereview.chromium.org/497783002 Cr-Commit-Position: refs/heads/master@{#291896}
-
dzhioev authored
Chrome OS doesn't treat value of "login-profile" as a name for user's profile dir anymore, however ProfileManager used its value to let some old tests keep working. After removal "login-profile" from ProfileManager these tests were fixed. The significant change is that TestingProfileManager::CreateTestingProfile treats its |profile_name| argument as an user's id on CrOS, and creates profile with a correct path ("u-" + user_id_hash(profile_name)). This makes testing environment closer to real, so communication between ProfileManager <--> chromeos::ProfileHelper <--> chromeos::UserManager works without additional set up in tests. BUG=294628 TEST=all browser_tests and unit_tests are passing Review URL: https://codereview.chromium.org/442043002 Cr-Commit-Position: refs/heads/master@{#291895}
-
szager authored
BUG=263848 R=thakis@chromium.org Review URL: https://codereview.chromium.org/506743002 Cr-Commit-Position: refs/heads/master@{#291894}
-
fukino authored
BUG=none TEST=run browser_tests Review URL: https://codereview.chromium.org/483673004 Cr-Commit-Position: refs/heads/master@{#291893}
-
dpolukhin authored
List of users admitted for multi-profile should include user with NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED Value NOT_ALLOWED_PRIMARY_POLICY_CERT_TAINTED was not check in the list of know problem when user cannot be added to the session. To avoid this types of errors removed list complete because the only vale that checked separate NOT_ALLOWED_PRIMARY_USER_POLICY_FORBIDS. BUG=406278 TEST=manual Review URL: https://codereview.chromium.org/501963002 Cr-Commit-Position: refs/heads/master@{#291892}
-
hirono authored
The new class manages device states and dispatch device events property instead of EventRouter, MountedDiskMonitor, and JavaScript side's DeviceHandler. BUG=360946,396258 Review URL: https://codereview.chromium.org/490643005 Cr-Commit-Position: refs/heads/master@{#291891}
-
ankit2.kumar authored
URL suggestion popup was not dismissing when page was navigating in back direction. Added code to handle this. BUG=407070 Review URL: https://codereview.chromium.org/500043002 Cr-Commit-Position: refs/heads/master@{#291890}
-
dconnelly authored
BUG=328847 Review URL: https://codereview.chromium.org/462563002 Cr-Commit-Position: refs/heads/master@{#291889}
-
mgiuca authored
Was trying to parse a Git commit hash as an int. getos --check-version no longer compares exact revision numbers, only major version numbers (because the Git hashes can't directly be compared, unlike SVN numbers). Added a TODO to compare Cr-Commit-Position when it becomes available. BUG=406993 Review URL: https://codereview.chromium.org/502883002 Cr-Commit-Position: refs/heads/master@{#291888}
-
jansson authored
Added dataChannel.id text field to make it easier to test that Chrome/WebRTC reuses the dataChannel id on the same peerConnection. Feature added in issue: https://code.google.com/p/webrtc/issues/detail?id=2646 BUG=NONE TEST=Manual P2P call, dataChannel.id is only displayed when dataChannel.readyState = 'open'. NOTRY=TRUE Review URL: https://codereview.chromium.org/405093004 Cr-Commit-Position: refs/heads/master@{#291887}
-
skyostil authored
The requestAnimationFrame test which simulates a large jank in the first rAF callback (raf.html?heavy_first_frame) was actually adding the delay to every callback. This patch fixes the synthetic delay to use the correct one-shot mode. BUG=391005 Review URL: https://codereview.chromium.org/497173002 Cr-Commit-Position: refs/heads/master@{#291886}
-
kulkarni.a authored
Cleaning up weak_ptr_factory destruction order. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Review URL: https://codereview.chromium.org/479183002 Cr-Commit-Position: refs/heads/master@{#291885}
-
ygorshenin authored
The purpose of the CL is to simplify DeviceSettingsProvider API, as Set() path should be moved out. BUG=230018 TEST=none Review URL: https://codereview.chromium.org/502993003 Cr-Commit-Position: refs/heads/master@{#291884}
-
bauerb authored
BUG=405709 Review URL: https://codereview.chromium.org/495843003 Cr-Commit-Position: refs/heads/master@{#291883}
-
falken authored
Before this patch, ServiceWorkerRegistration had a constant script URL. The spec has a different model: .installing, .waiting, and .active workers for the same registration can be from different script URLs. This patch removes script_url from SWRegistration, in preparation for implementing the spec steps for same-scope, new-script-url registration. BUG=398355 Review URL: https://codereview.chromium.org/501453002 Cr-Commit-Position: refs/heads/master@{#291882}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#291881}
-
thestig authored
Review URL: https://codereview.chromium.org/486843004 Cr-Commit-Position: refs/heads/master@{#291880}
-
satorux authored
BUG=401192 TEST=existing tests Review URL: https://codereview.chromium.org/497453003 Cr-Commit-Position: refs/heads/master@{#291879}
-
kkinnunen authored
Add initial support for NV_path_rendering extension to gpu command buffer. This is needed in order to support NV_path_rendering implementation in Skia. Implement this by creating a new GL ES pseudo-extension called CHROMIUM_path_rendering. The CHROMIUM_path_rendering extension will be exposed to clients only if the context is not a webgl context, NV_path_rendering extension is present. Also, EXT_direct_state_access extension must be present for Open GL. Add matrix functions needed to support the feature: void glMatrixLoadfEXT(GLenum matrixMode, const GLfloat* m) void glMatrixLoadIdentityEXT(GLenum matrixMode) NV_path_rendering needs these functions to implement transformations for the path drawing. Changes the build_gles2_cmd_buffer.py to be able to generate context state variables that are arrays. The state variable is defined to be an an array when its default value is an array. Changes the build_gles2_cmd_buffer.py to round the float GL state variables with round() when querying them with GetInteger. The values GL_*_CHROMIUM tokens added match the values of corresponding GL_*_NV tokens from the NV_path_rendering extensions. This is why the values are passed after validation to the receiving GL function, without any mapping. BUG=344330 Review URL: https://codereview.chromium.org/169603002 Cr-Commit-Position: refs/heads/master@{#291878}
-
dconnelly authored
BUG= Review URL: https://codereview.chromium.org/503743002 Cr-Commit-Position: refs/heads/master@{#291877}
-
thestig authored
TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/498673005 Cr-Commit-Position: refs/heads/master@{#291876}
-
benwells authored
Now that the webstore does not require sign in for apps, the code to support the signin as part of install flow is no longer required. Some code is still needed to support paid apps. BUG=388083 Review URL: https://codereview.chromium.org/482293003 Cr-Commit-Position: refs/heads/master@{#291875}
-
fbeaufort authored
BUG= Review URL: https://codereview.chromium.org/490133002 Cr-Commit-Position: refs/heads/master@{#291874}
-
imcheng authored
Histograms in json format: * capture time * encode time * packet latency * frame latency * playout delay - Duration in ms - first event unix time - last event unix time Also improved ReceiverTimeOffsetEstimatorImpl to re-estimate every 30 seconds to account for unknown amount of clock drift between sender and receiver. BUG=403921 Review URL: https://codereview.chromium.org/482383005 Cr-Commit-Position: refs/heads/master@{#291873}
-
sammc authored
BUG=405531 Review URL: https://codereview.chromium.org/499243002 Cr-Commit-Position: refs/heads/master@{#291872}
-
Vitaly Buka authored
BUG=374321 Committed: https://chromium.googlesource.com/chromium/src/+/ee8f4e4029c09ba77e7dbb8fddd85186642b3de8 R=jschuh@chromium.org, noamsml@chromium.org, thestig@chromium.org, yzshen@chromium.org Review URL: https://codereview.chromium.org/478183005 Cr-Commit-Position: refs/heads/master@{#291871}
-
kulkarni.a authored
Cleaning up weak_ptr_factory destruction order in "src/gpu" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Review URL: https://codereview.chromium.org/468913010 Cr-Commit-Position: refs/heads/master@{#291870}
-
dcheng authored
scoped_refptr previously got this for free since it implemented operator T*, but the conversion operator is being removed. This prevents awkward looking code like *my_favorite_pointer.get(). BUG=110610 Review URL: https://codereview.chromium.org/505943002 Cr-Commit-Position: refs/heads/master@{#291869}
-
fmeawad authored
Speedometer on Android timesout, each iteration takes ~75 seconds on N7. Limiting the iterations count to 3 on android, and enabling the test. BUG=382517 Review URL: https://codereview.chromium.org/505903002 Cr-Commit-Position: refs/heads/master@{#291868}
-
sanjoy.pal authored
BUG=87553 Review URL: https://codereview.chromium.org/502993002 Cr-Commit-Position: refs/heads/master@{#291867}
-
benwells authored
A different approach will be taken, where the add to app launcher flow is initiated from the page info dialog. BUG=378171 Review URL: https://codereview.chromium.org/488373002 Cr-Commit-Position: refs/heads/master@{#291866}
-
dcheng authored
This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Review URL: https://codereview.chromium.org/507483003 Cr-Commit-Position: refs/heads/master@{#291865}
-
darin authored
With this change, it is possible to assign INFINITY, NEGATIVE_INFINITY or NAN as a default value for any double or float field. BUG=402216 Review URL: https://codereview.chromium.org/474063002 Cr-Commit-Position: refs/heads/master@{#291864}
-
lof84 authored
After issue https://codereview.chromium.org/227473009 there is no code for create OnScreen surface for Mac which is using in compositor_unittests. Result: 18 tests crashed: LayerWithDelegateTest.ConvertPointToLayer_Medium LayerWithDelegateTest.ConvertPointToLayer_Simple LayerWithDelegateTest.DelegatedLayer LayerWithDelegateTest.SchedulePaintFromOnPaintLayer LayerWithDelegateTest.SetBoundsWhenInvisible LayerWithNullDelegateTest.SetBoundsSchedulesPaint LayerWithNullDelegateTest.Visibility LayerWithRealCompositorTest.CompositorObservers LayerWithRealCompositorTest.Delegate LayerWithRealCompositorTest.Draw LayerWithRealCompositorTest.DrawPixels LayerWithRealCompositorTest.DrawTree LayerWithRealCompositorTest.Hierarchy LayerWithRealCompositorTest.HierarchyNoTexture LayerWithRealCompositorTest.ModifyHierarchy LayerWithRealCompositorTest.Opacity LayerWithRealCompositorTest.ScaleReparent LayerWithRealCompositorTest.ScaleUpDown If surface is created then all tests passed. R=sievers@chromium.org, ccameron1@chromium.org, danakj@chromium.org TEST=compositor_unittests Review URL: https://codereview.chromium.org/504933002 Cr-Commit-Position: refs/heads/master@{#291863}
-
yzshen authored
The purpose is to make those APIs have the same semantics as before. And then we can selectively turn fields into non-nullable. Mojom files that are not included in this change: - surface-related files: the owner (jamesr) has landed some non-nullable fixes. It is possible that he has fully reviewed them. (I will confirm with him.) - test files: have been examined. BUG=324170 TEST=None Review URL: https://codereview.chromium.org/502853002 Cr-Commit-Position: refs/heads/master@{#291862}
-
divya.bansal authored
In the context menu, disabled items are not required so can be removed instead of disabling them, so user donot tap on it. BUG=395551 Review URL: https://codereview.chromium.org/494093003 Cr-Commit-Position: refs/heads/master@{#291861}
-
calamity authored
This test was flaky because it modified system properties. Moving it to interactive_ui_tests should allow it the system control guarantees it needs to complete successfully. BUG=396344 Review URL: https://codereview.chromium.org/492623003 Cr-Commit-Position: refs/heads/master@{#291860}
-
yoshiki authored
BUG=397393 TEST=manually tested Review URL: https://codereview.chromium.org/506583002 Cr-Commit-Position: refs/heads/master@{#291859}
-
eroman authored
BUG=398959 Review URL: https://codereview.chromium.org/489643002 Cr-Commit-Position: refs/heads/master@{#291858}
-
machenbach authored
TBR=vogelheim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/503053004 Cr-Commit-Position: refs/heads/master@{#291857}
-