- 25 Mar, 2020 40 commits
-
-
Maksim Sisov authored
I accidentally left some lines of code that looked up for the WAYLAND_DISPLAY in a parent weston proc. This is incorrect and results in tests running in a wrong display if there are more than one Wayland compositor running (for example, running tests with the script on a local machine that has already had a Wayland session). Bug: 1029241 Change-Id: I9855b41d50790805850471176d2abf4802fb7990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111671Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#753233}
-
Thomas Lukaszewicz authored
Bug: 460513 Change-Id: Id4a48b7a270305953ca38e1e626f644306a861d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117324Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753232}
-
Friedrich Horschig authored
An alt="" tag on images hide them from screen readers. Since the banner on the leak check results page carries no additional information, it can and should be skipped. Bug: 1047726 Change-Id: I64299104ab86db6510fb4fcd199cf6d9f5c5c4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120578Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#753231}
-
Nicolas Ouellet-Payeur authored
Include credentials in the HTTP request to download the XML. This allows the server to perform e.g. Kerberos or NTLM authentication. TESTED=Hosted sitelist.xml on an IIS server with NTLM auth. Before patch: rules don't get applied. After patch: rules get applied. Also checked chrome://net-export logs to make sure the `WWW-Authenticate' and `Authorization' headers are present. Bug: 1025946, 1063457 Change-Id: Ibbc86ea3feca17b1c918493698df906656c2f904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118230 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#753230}
-
Etienne Pierre-doray authored
This will allow us to see |from_path| and |to_path| when ::ReplaceFile is called. ::ReplaceFile is suspected to cause shutdown hangs in crbug.com/1054164. Bug: 1054164 Change-Id: I6296c9fb191f12c60b1398bde3eb31bc4ae44502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115694 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753229}
-
Justin Cohen authored
6835b8e29db1 Roll buildtools/ afc5b798c..4164a3056 (9 commits) 9a31d3f8e981 Print thread state after failure to suspend 4e2a190ad6e6 [ios] Bring up first draft thread and memory snapshot 296501351816 Prepare crashpad mig stuff for -Wunreachable-code in chromium_code af2be80bdb8a android: configure a native test suite b75c5783735e linux: disable arguments test on old kernels 311a5a2fdd5b Fix chromium build Change-Id: I031f48b23b71e68eb306918240dffe3851591184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119550 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753228}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1b20c41dcbfb..d19513f3ffbb git log 1b20c41dcbfb..d19513f3ffbb --date=short --first-parent --format='%ad %ae %s' 2020-03-25 titovartem@google.com Move calculation of target_encode_bitrate to DefaultVideoQualityAnalyzer 2020-03-25 sprang@webrtc.org Fixes temporal rate allocation issues. 2020-03-25 thakis@chromium.org webrtc: Suppress a -Wunreachable-code warning on Android. Created with: gclient setdep -r src/third_party/webrtc@d19513f3ffbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:346399 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I42d17e4608f938a52a142005732ea17cd3a78f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753227}
-
Tim van der Lippe authored
For DevTools [1] we advice contributors to symlink their repository into Chromium/src/. However, when locally running the `md_browser`, any files under `third_party/devtools-frontend/src/` don't show up, as the realpath would resolve the symlink after which `md_browser` aborts the request as it detects that the top-level directory is different. Instead of using realpath (which resolves symlinks and normalizes the path) we should be using normpath, which only does the latter. [1]: https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/master/README.md R=dpranke@chromium.org Change-Id: I8b64cfc3a51caf1f5d70b1fcb1bed80f95dd587e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120577 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#753226}
-
Patrick Monette authored
The PerformanceManagerTabHelper reflects WebContents and their frame trees into the PerformanceManager graph. This CL gives the graph visibility for the WebContents created by PendingAppInstallTask. Bug: 1046881 Change-Id: I20ab2faa3d30d7501808236a1395fb8b4d47b867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093033 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#753225}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5ccc09e06b6..4de93855b203 Created with: gclient setdep -r src-internal@4de93855b203 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I46ceb0693290d5800dc42b2ee341e8b0679658a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120519Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753224}
-
Vidhan authored
const vector<autofill::Suggestion> to std::vector<autofill::Suggestion> Bug: 1045401 Change-Id: I4ccd55d0156a6daaee859f9d48187e6d2bb75386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093600 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#753223}
-
Pete Williamson authored
The experiment name needs to match finch instead of matching the name of the flag we use in chromium. Bug: 1045246 Change-Id: Ie64379eb275d3a0c51c9d3237d9e12602003cc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117914 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#753222}
-
Rohit Rao authored
Most of the files in this directory had no //content dependencies. Those that did were left in place. TBR=sky@chromium.org BUG=1061431 Change-Id: Ib0378541b92c20dded184a186c12ff22cbbb128a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102636 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
We were checking that the url of the installed PWA is a prefix of its scope. However, the url we have available from the PermissionContext is only the requesting origin, and hence this check fails if the scope is longer than the origin. This CL reverses the check to verify that the url is a prefix of the scope. A unit test has also been updated to test for this case. Bug: 1062177 Change-Id: Ic81f9b5b10fcb378cc3d65dadee947f53e8755b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107599 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#753220}
-
Paul Lewis authored
Bug: 1063051 Change-Id: I1df569551de2b81a0c7ee4824d0410fe7cda5d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107994 Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753219}
-
Michael van Ouwerkerk authored
Replace "shared" with "copied". Bug: 1064568 Change-Id: Ie11be1037089e574eae6783fead2790b30a63cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119536Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#753218}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c2e5f7968754..2ffbc3f6d5d3 git log c2e5f7968754..2ffbc3f6d5d3 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 tvanderlippe@chromium.org Check Ninja output with expected build output 2020-03-25 pfaffe@chromium.org Add a cxx+dwarf e2e test using the symbol server Created with: gclient setdep -r src/third_party/devtools-frontend/src@2ffbc3f6d5d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042636,chromium:1064287 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ieb46407bacaf3495f508a63535bd073db5ee447b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120520Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/107e4e989e94..38152bda97f5 git log 107e4e989e94..38152bda97f5 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6c11cf2ad9ca..540bdf92531d (2 commits) Created with: gclient setdep -r src/third_party/angle@38152bda97f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I1ee829ca54390950357ef052264a26386b4e87fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119926Reviewed-by:
-
Mathias Bynens authored
The test now lives in the DevTools repository, here: devtools/devtools-frontend/src/test/webtests/http/tests/devtools/a11y-axe-core/settings/locations-a11y-test.js Change-Id: I1d9cbc870cf1df97866b495cef3d0ee478f4b6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120576 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by: -
Ted Choc authored
BUG=1064397 Change-Id: I66193f5a558ed44850dea33c2b7d7c6ba48a46dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118580Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753214}
-
Tommy Martino authored
This CL replaces the default hardcoded value for last render timestamp with one tied to an Android preference. (see go/probabilistic-cryptid-renderer for design; sorry, Googlers only) Bug: 1061949 Change-Id: I5a975fbb96ea5bf24c4201f576928a3b0af33f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118810Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#753213}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5bbd1f06880..1b20c41dcbfb git log f5bbd1f06880..1b20c41dcbfb --date=short --first-parent --format='%ad %ae %s' 2020-03-25 phoglund@webrtc.org Greatly simplify flags for test binaries. 2020-03-25 phensman@webrtc.org Remove IP address logging from NetworkInformation 2020-03-25 peah@webrtc.org AEC3: Added parametrization of the comfort noise floor Created with: gclient setdep -r src/third_party/webrtc@1b20c41dcbfb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051927 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2e004c6af14e6bca975b6976081be35cba73132e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120517Reviewed-by:
-
Leonard Grey authored
- Remove some structure that was previously necessary for Cocoa browser - the visibility lock controller is vestigial: we release the lock, but never acquire it Bug: 1063417 Change-Id: I55ccc6b14b0ffed7d81beb640a54ec8b1110e831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117321Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#753211}
-
Stephen Chenney authored
The limits for the recently added HTMLParsing UMA metrics were too low. Adjust them based on UKM numbers indicating the maximum values seen in practice. Bug: 1063448 Change-Id: Idb434fdc8fa5ad2d3743338bd9b1397fa0e48815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116915 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#753210}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aafdcc7e..2fc052ae Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03623546ba053b445ce76f85ed5b768757ef2c2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119111Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753209}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9686528ac8c7..ae58199380dd git log 9686528ac8c7..ae58199380dd --date=short --first-parent --format='%ad %ae %s' 2020-03-25 fmalita@chromium.org [skottie] Initial drop shadow style support Created with: gclient setdep -r src/third_party/skia@ae58199380dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I07e6335b6f637d7e4a42300c43f947039468c7e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120516Reviewed-by:
-
Changhao Han authored
DevTools CL to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119670 Bug: chromium:1064472 Change-Id: Ic41ad67f305de042260a660d85bde5668d94cb4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120494 Auto-Submit: Changhao Han <changhaohan@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I46e4c21c15f796f9abee48f036f362b8bd4e9efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120275Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753206}
-
Rainhard Findling authored
* Adds a generalized UI status for safety check children. This status defines the default look of the child. It simplifies the code for children and prepares the safety check UI for future refactoring to achieve better encapsulation. Bug: 1015841 Change-Id: Idf88770d6bcfcf455008eddb3ca02b150d017d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117730 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#753205}
-
Mark Cogan authored
This CL removes the last (spurious) include of private web API in BVC, and removes the DEPS exceptions for private web usage in ui/ Bug: 620489, 620147 Change-Id: I244c7af56e1ec58b9eadf37300b136715fe0d0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120572 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#753204}
-
Daniel Nicoara authored
HDCP updates are asynchronous. Do not pass display state pointers between async calls since display configuration may have changed. Instead query the display state and validate that the requested displays are valid. BUG=1058030 TEST=display_unittest Change-Id: I7e037a44f06156b5b1da3f2672330ba8a18ca950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118771Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#753203}
-
Mihai Sardarescu authored
This CL add histogram Signin.SignedInAccountsViewImpression that counts the number of times the signed-in account view is shown when the application enters foreground (iOS only). Bug: 1018211 Change-Id: Iff7f8799a8ecb0b13858d3cb3b744738c01adae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106170 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#753202}
-
Guillaume Jenkins authored
Creates the policy map for simple policies (those that simply set a Chrome flag). Also adds an entry as an example (I arbitrarily picked kSearchSuggestEnabled), though unit tests will still need to be added for that policy. Also creates the simple loop that creates SimplePolicyHandlers for each policy described in the map. Change-Id: If35def703d79df367aa69a55cdd13fa27d240337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117468Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#753201}
-
Elly Fong-Jones authored
The notion of "host coordinates" comes from Aura, where it roughly means "coordinates relative to the Aura root window". This has no meaning on macOS, so they get instead mapped to window coordinates, which produces a problem: some tests assume that their *contents view* is at (0,0) in "host coordinates" (which Aura allows), but on macOS, the contents of a window aren't at (0,0) in that window unless it's frameless, and windows aren't at (0,0) in the screen - the WM won't allow them to be placed there, because they'd underlap the menu bar. To avoid that problem, rewrite these tests in terms of screen coords; these work just fine both on Mac and under Aura. Bug: 708401 Change-Id: I3cb7db2c957c786c602fce0446d400e0f14f4117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118630Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#753200}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4e1cc676b6f7..c2e5f7968754 git log 4e1cc676b6f7..c2e5f7968754 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 pfaffe@chromium.org Only send module binary to symbol server if it has embedded symbols Created with: gclient setdep -r src/third_party/devtools-frontend/src@c2e5f7968754 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf9af97d1049395aac79e56a6a2af42d1899c4ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120514Reviewed-by:
-
Aya ElAttar authored
Added a user policy to disable Chrome OS system features. The implementation of disabling the features will be added in following CLs. Bug: 1061859 Change-Id: I09d9ac48c0cae801e0d004cd431fa81f8addf73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055625 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753198}
-
Clemens Arbesser authored
This is a refactoring only and should have no user-facing changes. Bug: b/145043394 Change-Id: If820f681fefd486b7f0700800c610152339293d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120353Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#753197}
-
Mathias Bynens authored
The test was temporarily disabled (+ its expectations updated) here: https://chromium-review.googlesource.com/c/chromium/src/+/2119533 DevTools front-end CL that changed the expectations: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119672 The downstream DevTools change rolled into Chromium here: https://chromium-review.googlesource.com/c/chromium/src/+/2119928 Bug: chromium:1051186, chromium:1051822, chromium:1057096 Change-Id: I1dfa629d3c763171d577ac04e554a6dad652efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119513 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#753196}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/054d61d117f0..bdb8301ab9c1 git log 054d61d117f0..bdb8301ab9c1 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 phoglund@google.com Remove some prints I accidentally left in. Created with: gclient setdep -r src/third_party/catapult@bdb8301ab9c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Ib0dc5589f1b30436ab333ed26f78a64b2d89c433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120513Reviewed-by:
-
Mark Cogan authored
I (marq) have rewritten most of the device sharing code in the last couple of weeks, so this CL adds me as an owner. I think erikchen@ isn't active on this code any more, so removing them as an owner. Change-Id: Id3c216b106260996099aa6516ee1073318ab340a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119852 Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
-
