- 07 Sep, 2018 40 commits
-
-
Sammie Quon authored
Test: ash_unittests ShelfLayoutManagerTest.VisibleInOverview Bug: 881153 Change-Id: I2b5b8122831b5c71bc4ee4fcf4360d7626e11f0b Reviewed-on: https://chromium-review.googlesource.com/1211741 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589422}
-
Hitoshi Yoshida authored
This reverts commit da27378f. Reason for revert: This CL caused many crashes in the wild. (crbug.com/881348) Original change's description: > Split implementation of EventListener and EventHandler > > This CL add new class blink::V8EventListenerImpl which implements > ONLY EventListener (not EventHandler). It has a blink::V8EventListener > which inherits blink::CallbackInterfaceBase. As a result, EventListener > will start to handle incumbent realm. EventHandler will still be > offered by blink::V8AbstractEventListener (this class is renamed to > blink::V8AbstractEventHandler in this CL) after this CL submitted. > Also, entry realm was set to wrong one (event target's one) with > blink::V8AbstractEventLisntener so this CL set it to listener's one as > defined in standard. > > Regarding crbug.com/872138 : > Current blink::V8AbstractEventListener implements both of EventListener > and EventHandler, so I am trying to implement new class for > EventListener first to separate these. EventHandler will be modified in following CLs. > > Regarding crbug.com/878658 : > This CL modifies expectation file for layout test: > fast/events/touch/gesture/gesture-tap-frame-removed.html > This is because event listener starts to remember incumbent realm after > this CL and it results in incorrect behavior as explained in the BUG. > This is not a regression, but have to be resolved in following CLs. > > Bug: 872138, 878658, 606900, 849236 > Change-Id: I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a > Reviewed-on: https://chromium-review.googlesource.com/1172234 > Commit-Queue: Yuki Yamada <yukiy@google.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hayato Ito <hayato@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588748} TBR=peria@chromium.org,yukishiino@chromium.org,hayato@chromium.org,haraken@chromium.org,yukiy@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872138, 878658, 606900, 849236, 881348 Change-Id: Ie981df66657c8868c769cb8d18bf799605cfd004 Reviewed-on: https://chromium-review.googlesource.com/1212202 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589421}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ibfab68882fda3e5eb65b90a02a48246c2549d20f Reviewed-on: https://chromium-review.googlesource.com/1212007Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589420}
-
Kouhei Ueno authored
This should fix crash/caab6eb137e58385 This CL addresses the unhandled case in crrev.com/582126 TBR=falken@chromium.org Bug: 881126, 868592 Change-Id: I906eecc3bf21aa9900355b1f312bd5025375fa8d Reviewed-on: https://chromium-review.googlesource.com/1207781 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589419}
-
Timothy Loh authored
This CL changes the CrostiniManager from being a global singleton to a profile keyed service. This tidies up the implementation as we can now assume that we have a valid Profile, so don't need to sanity check the owner_id/cryptohome_id arguments that used to be passed into arguments, and also simplify the members by dropping the owner_id keys. Tests will now use individual CrostiniManager objects instead of re-using the same CrostiniManager, avoiding test runs influencing other test runs. This CL also removes the CrostiniRestarterServiceFactory, and moves the functionality of CrostiniRestarterService into the CrostiniManager. One side-effect of this CL is that the on-login component update will occur on each (primary profile) log-in, instead of once per Chrome restart. Change-Id: If76895cfc3994cb0bda3504e09bae452955dbe6b Reviewed-on: https://chromium-review.googlesource.com/1201646Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589418}
-
Chris Hall authored
Bug: 856209 Change-Id: Ifcb55f5e3f7e50ff94ebfe1a6e607e06c22d4add Reviewed-on: https://chromium-review.googlesource.com/1212363Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589417}
-
Mathieu Perreault authored
Bug: 881650 Test: Run chrome with --force-variations-ids=12345, look for the headers in the request to translate in chrome://net-internals Change-Id: I51cc33d4d7b0cf9d6a74a433b277f0890b990b01 Reviewed-on: https://chromium-review.googlesource.com/1212403 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589416}
-
Christopher Cameron authored
Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost interface instead of directly dereferencing views structures. Make similar changes to ViewsNSWindowDelegate. Update the mojo interfaces to include these functions. Remove the nativeWidgetMac property from ViewsNSWindowDelegate. Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which can be used to look up a corresponding - BridgedNativeWidgetImpl (in the app/viewer process) - BridgedNativeWidgetHostImpl (in the browser process) - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow in the browser process which will use this id - that window will not be visible, but will be used for state tracking and bounds computations Bug: 859152 Change-Id: I9f62aefa1d4eba9961f691b5bd9247871e121355 Reviewed-on: https://chromium-review.googlesource.com/1205477Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#589415}
-
Mina Almasry authored
Test: on audio-only device, video device, cast_media_unittests Change-Id: Ifa00a3464b84d9f95816d3b7279db5e5954ee4c9 Reviewed-on: https://chromium-review.googlesource.com/1211945 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#589414}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/106d04e907c1..b090b2b26803 git log 106d04e907c1..b090b2b26803 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 dff32a0da1de..801719235b13 (3 commits) Created with: gclient setdep -r src/third_party/skia@b090b2b26803 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I5f43b700df646a1702ea9f1fbe1cd58e2a2de801 Reviewed-on: https://chromium-review.googlesource.com/1212502Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589413}
-
Aaron Leventhal authored
The live region changed events are needed by current versions of JAWS, which do not process the text inserted events fired by Chrome in all modes. Specifically, current versions of JAWS processes text inserted events in virtual cursor mode but not in focus mode. This may change in future versions of JAWS, and so at some point the live region changed events may truly become redundant with the text inserted events. NOTRY=true Bug: 878929 Change-Id: I3286c84d1d6366735a38af19e68f4c526658b68b Reviewed-on: https://chromium-review.googlesource.com/1211508 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#589412}
-
Azeem Arshad authored
This change adds logic to retrieve and listen for changes in multidevice feature state and enables/disables establishing background connection from service worker approriately. Bug: 876163 Change-Id: I593a27f46a793678039ca40a1d0e49e97152c616 Reviewed-on: https://chromium-review.googlesource.com/1208143Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#589411}
-
Jinsuk Kim authored
Now that TabBrowserControlsOffsetHelper object can now be obtained from TabBrowserControlsOffsetHelper.from(Tab), this CL removes the API from Tab class. Also, |FullscreenManager.setTab()| takes over the task of updating the offsethelper from Tab. Tab still has a reference to offset helper object, which will go away in a couple of more CLs that move all the related tasks out of Tab. Bug: 877878 Change-Id: I416230b59ca5704c055fca6b5eb89561f62d4a07 Reviewed-on: https://chromium-review.googlesource.com/1205971Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#589410}
-
Kyoko Muto authored
In this Cl, we reuse the "backend" of the imperative Shadow DOM Distribution API for a new custom element, <my-detail>/<my-summary>. In addition, we add reftest and perftests to compare the custom element, <my-detail>/<my-summary> to built-in custom element, <detail>/<summary>. perftest result: built-in element (ave)0.635 ms/new element (ave)1.030 ms Bug: 869308 Change-Id: If3304c65382bc5ad57f4cfe59b1d1a623a22c471 Reviewed-on: https://chromium-review.googlesource.com/1192783 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589409}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb081a62dc30..ea8b6f95c763 git log bb081a62dc30..ea8b6f95c763 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 benwright@webrtc.org Adds the Java interface points for FrameEncryptor/FrameDecryptor. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/pcc. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/bbr. 2018-09-06 mbonadei@webrtc.org Fix no_global_constructors in congestion_controller/goog_cc. 2018-09-06 andersc@webrtc.org Fix paths for macOS framework’s copy actions. 2018-09-06 jonasolsson@webrtc.org Remove simple stringstream usages. 2018-09-06 mbonadei@webrtc.org Enable -Wexit-time-destructors and -Wglobal-constructors. 2018-09-06 mbonadei@webrtc.org Partial revert of: 'Bump xcode versions for WebRTC bots.' 2018-09-06 nisse@webrtc.org Reland "Refactor TestAudioDeviceModule to not depend on EventTimerWrapper." 2018-09-06 srte@webrtc.org Adds maximum burst length to InterArrival class. 2018-09-06 jonasolsson@webrtc.org Remove std::stringstream from the RTC_CHECK implementation. 2018-09-06 asapersson@webrtc.org Remove unimplemented function declarations VCMGenericDecoder::External and VCMTimestampMap::Reset. 2018-09-06 danilchap@webrtc.org Cleanup RtpPacketizerGeneric 2018-09-06 jonasolsson@webrtc.org Add a LOG macro with customizable file name and line number. 2018-09-06 nisse@webrtc.org Reland "Explicitly wrap main thread in test_main.cc." Created with: gclient setdep -r src/third_party/webrtc@ea8b6f95c763 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I22406073527ccc94e0a2e672218156896be08832 Reviewed-on: https://chromium-review.googlesource.com/1211866Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589408}
-
Kyle Qian authored
SecureChannel previously had no handlers for when the BluetoothAdapter is disabled or removed while a connection request is pending. This CL adds observer methods to PendingConnectionRequestBase that will fire when device::BluetoothAdapter detects that the adapter has been disabled or removed, causing the request to be cancelled. Bug: 854366 Change-Id: Ice45c373f42a6e9065d8c3564988904e02e7fa9e Reviewed-on: https://chromium-review.googlesource.com/1195099 Commit-Queue: Kyle Qian <kyleqian@google.com> Reviewed-by:
-
Clark DuVall authored
The bypass_redirects_check bit used to be set from the return value of WillCreateURLLoaderFactory, because the WebRequest proxy was the only proxy that would cause that to be true. Now there is also a signin proxy which can return true, so pass in a separate bool* for bypass_redirects_checks that can be set based on WebRequest. Bug: 868545 Change-Id: I361a4d89393a72552954471c8c5566bc7b1d7a17 Reviewed-on: https://chromium-review.googlesource.com/1211808Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#589406}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60e7f52377fd..dd2c588e3811 git log 60e7f52377fd..dd2c588e3811 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@dd2c588e3811 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I7653852bdf13041899492b3722ebaf83f4348f68 Reviewed-on: https://chromium-review.googlesource.com/1212146Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589405}
-
Findit authored
This reverts commit b60e5cc0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 589389 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I2MGU1Y2MwYmQ0YjM1MWM1ODk4ZGMzNjM3ZjUzN2MzNTU1NDZjMTEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/20069 Sample Failed Step: base_unittests Original change's description: > [PartitionAlloc] Add a flag to allow callers to zero-fill allocations. > > This enables callers to avoid doing it themselves (centralizing the `memset` in > 1 place, rather than duplicating it at every call site that wants it), and to > allow the PartitionAlloc implementation to avoid doing it itself if the > operating system has already zero'd the new page(s). > > Bug: 864462,680657 > Change-Id: Ibeae0bf7b9f20238334bf9bc022d0f243a77ef11 > Reviewed-on: https://chromium-review.googlesource.com/1162825 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589389} Change-Id: Ifd54700a2acb141c458df69304d7ccdce2719cc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864462,680657 Reviewed-on: https://chromium-review.googlesource.com/1212346 Cr-Commit-Position: refs/heads/master@{#589404}
-
Trent Apted authored
Metrics were added 5 years ago in r188357, but they lack metadata. Bug: 879446 Change-Id: I42daa58100bd8ed6c7c2d13542913e56d82f6f37 Reviewed-on: https://chromium-review.googlesource.com/1208999 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589403}
-
David Staessens authored
This might cause the GPU thread to block forever when shutting down the decoder, as we could be waiting for an EGL fence that will never be signaled while queuing an output buffer. See crrev.com/c/1133614. Some changes are introduced to make sure that: * Waiting for an EGL fence is no longer blocking and can be interrupted. * Any tasks queued will check whether a destroy is pending upon starting, and early-exit if required. TEST=ran VDA tests on peach-pi Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I962cbead32b050cde4f4698b6717e96972d216d4 Reviewed-on: https://chromium-review.googlesource.com/1195225 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589402}
-
Jinsuk Kim authored
Lets Tab's UserDataHost manage TabRedirectorHandler when it is used for Tab. Also saves Tab from keeping the instance of it. TabRedirectHandler now defines 3 new methods: - from(Tab): Returns an instance associated with the Tab. If not present, creates a new instance. - getOrNull(Tab): Similar to |from| but returns null if an instance is not present. - swapFor(Tab): Replaced the current TabRedirectHandler for Tab with a new one. Bug: 877878 Change-Id: I6fe3fcaaba9e5fcf4625bd74691b5a3634a31fce Reviewed-on: https://chromium-review.googlesource.com/1201630Reviewed-by: -
Jinho Bang authored
The build error occurs if using `use_jumbo_build=true` in GN configuration. The same variable name is used in the anonymous namespace of content_settings_registry.cc and website_settings_registry.cc. It can cause a name conflict during merging both files. TBR=raymes@chromium.org NOTRY=true Bug: none Change-Id: I33eeb5ff00a2ab113d28a63f0044442375b98df2 Reviewed-on: https://chromium-review.googlesource.com/1212422 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#589400}
-
Kyle Qian authored
SecureChannel previously had no checks for when the BluetoothAdapter is disabled or removed. This CL adds an additional check within SecureChannelImpl that will cancel a connection request early if the BluetoothAdapter is either disabled or removed, as well as notify the client of the failure reason. Bug: 854366 Change-Id: I021435611c8a018da3e77a9eeb9c001311adada4 Reviewed-on: https://chromium-review.googlesource.com/1194675Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Qian <kyleqian@google.com> Cr-Commit-Position: refs/heads/master@{#589399}
-
Wez authored
Bug: 859095 Change-Id: Ibe8a52dfacad07b1cb9f04e720af063f67f9a3b0 Reviewed-on: https://chromium-review.googlesource.com/1200838Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589398}
-
Jordy Greenblatt authored
Bug: 876796 Change-Id: Ie369384f218fde83ae03f21add99c0573ab97912 Reviewed-on: https://chromium-review.googlesource.com/1211915Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#589397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 16d88668. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24197 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I69b85c21b76a2e2d292464de225046888d974067 Reviewed-on: https://chromium-review.googlesource.com/1211676 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589396}
-
khmel@google.com authored
This is to support per-board configuration for uni-builds. Related CLs: crrev.com/c/1208892, crrev.com/i/673295 TEST=Manually on device, test data restructured to be covered by unit tests BUG=b:113908266 Change-Id: I56b3268390ce31e28204e53d443d465a032a84f4 Reviewed-on: https://chromium-review.googlesource.com/1208195 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by: -
John Z Wu authored
Content Security Policy does not allow the translate element.js script to download and execute additional javascript. To get around this, we redirect to the browser to download and execute the two additional scripts (main.js and element_main.js). Bug: 686364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie92f357b9809a0e4efc0ff111e8593f727b936d4 Reviewed-on: https://chromium-review.googlesource.com/1131826 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589394}
-
chcunningham authored
This re-instates the behavior where Incognito profiles have their in-memory DB seeded by the on-disk DB of the original profile. This was temporarily disabled to fix the UAF for M69 release. This CL adds a CHECK in the destructor of seed DB which will fire whenever it it is destroyed while a dependent in-memory DB is still alive. TBR: droger@chromium.org Bug: 865321 Test: new unit test, manual testing. Change-Id: I7c873369b1ffbd3259273c628190ee1cc581b45e Reviewed-on: https://chromium-review.googlesource.com/1208253 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#589393}
-
David Staessens authored
Adapted the v4l2 video decoder to make use of the GLFenceEGL wrapper, rather than using EGLSync functionality directly. Benefits: * Better code reuse and less code duplication. * Makes it easier to mock out dependencies when unit testing. * Easier to swap to different implementation if required. TEST=ran VDA tests on peach-pi Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If3f9ab3668bb9e6764b983557e8d9ccd6b3c2cf7 Reviewed-on: https://chromium-review.googlesource.com/1195203 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589392}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fe5861b..108f3e1 BUG= TBR=kbr@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I041ca25a69e441a98cc0b9168e722c2c93bbc8b5 Reviewed-on: https://chromium-review.googlesource.com/1211864Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#589391}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4d42ef39658b..801719235b13 git log 4d42ef39658b..801719235b13 --date=short --no-merges --format='%ad %ae %s' 2018-09-06 courtneygo@google.com Add rules file for ANGLE apk Created with: gclient setdep -r src/third_party/angle@801719235b13 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I64b18657bae1b18ea5b2c663053720cc736184d5 Reviewed-on: https://chromium-review.googlesource.com/1211875Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589390}
-
Chris Palmer authored
This enables callers to avoid doing it themselves (centralizing the `memset` in 1 place, rather than duplicating it at every call site that wants it), and to allow the PartitionAlloc implementation to avoid doing it itself if the operating system has already zero'd the new page(s). Bug: 864462,680657 Change-Id: Ibeae0bf7b9f20238334bf9bc022d0f243a77ef11 Reviewed-on: https://chromium-review.googlesource.com/1162825 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#589389}
-
David Grogan authored
Chrome, Safari, and Firefox pass. Edge hasn't implemented yet. The test still holds for the proposed new spec text in https://github.com/whatwg/html/pull/3686 This scenario is discussed at the end of https://github.com/whatwg/html/issues/603 but the conclusion drawn appears (to me) to be opposite what Chrome, Safari, and Firefox do. Related other issues: https://github.com/w3c/csswg-drafts/issues/2084 https://github.com/whatwg/html/issues/1839 Bug: 635282 Change-Id: Ice95225b3c9d5d90b80c657643d036490fd2e1b2 Reviewed-on: https://chromium-review.googlesource.com/1153651 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#589388}
-
Josh Nohle authored
Create a class, DeviceReenroller, that compares GcmDeviceInfo's list of supported SoftwareFeatures--eg., BETTER_TOGETHER_CLIENT or MAGIC_TETHER_CLIENT--with those stored in the local device metadata on the CryptAuth server. If a SoftwareFeature state has changed from supported to unsupported, or vice versa, then re-enroll the device with CryptAuth. Finally, after a successful re-enrollment, re-sync with CryptAuth and verify that the local device metadata was updated correctly. The flow is as follows: 1) The supported states of CrOS-relevant SoftwareFeatures are set in //src/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.cc, based on FeatureList flags. 2) This information is stored in GcmDeviceInfo, which is passed along to the MultiDeviceSetupService via a ctor argument. 3) On creation, MultiDeviceSetupImpl creates a DeviceReenroller, providing it - a DeviceSyncClient, for communicating with CryptAuth to retrieve local device metadata, to re-enroll the device, and to sync the device; - and access to GcmDeviceInfo, in order to retrieve the latest list of supported SoftwareFeatures. 4) In the DeviceReenroller constructor, the supported software features from the local device metadata are compared with the latest supported-state given by GcmDeviceInfo's supported_software_features list. 5) If any supported-state changed, a re-enrollment is attempted via the DeviceSyncClient. 6) If the re-enrollment is successful, a device sync is attempted via the DeviceSyncClient. - If the re-enrollment is unsuccessful, another attempt is scheduled to run after 5 minutes. 7) If the device sync is unsuccessful, another attempt is scheduled to run after 5 minutes. Note that DeviceReenroller logic only runs when the MultiDeviceSetupService is created, except for possibly retrying failed enrollments or syncs after some delay. It does NOT act as an observer, checking for changes to GcmDeviceInfo's supported features list, because we only expect this to change when Chrome flags change, i.e., when the Chrome binary restarts. Bug: 870770 Change-Id: I5f26a68448f3ee0e5dd8759aac12d05d1e4760a6 Reviewed-on: https://chromium-review.googlesource.com/1182419Reviewed-by:Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Matt Giuca authored
Servers set the download filename in a URL syntax (either through the Content-Disposition header, or in the filename of the requested URL itself). Previously, characters would remain percent-encoded when saved to disk, if they are deemed unsuitable for display. This criteria makes no sense for setting a filename. Cases included: - Control characters. - Path separators. - Special URL characters such as '%', '+', '&' and '#'. - Spoofing characters, such as invisible characters. Now, all characters are unescaped. Characters that are illegal in filenames (such as control characters, path separators, colons, etc) are converted into underscores. Other characters are left bare. Fixed and added tests. Bug: 849794 Change-Id: I797ee3d6aa8b803d9a7227e821fd8b4d55d0c58d Reviewed-on: https://chromium-review.googlesource.com/1209003Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#589386}
-
Kevin Bailey authored
Bookmark matches' |allowed_to_be_default_match| depends on |prevent_inline_autocomplete| being false. This field can be set and copied before |prevent| is set. The bookmark provider was returning cached results assuming |prevent| was still set. This CL changes the bookmark provider to never cache, and always generate and return fresh results. Bug: 879905 Change-Id: I909364500417cd629cead52a6f430b6d488142b9 Reviewed-on: https://chromium-review.googlesource.com/1204270Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589385}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3b0228176452a548e1c17fe8ebe6dcdb7201e538 Reviewed-on: https://chromium-review.googlesource.com/1211919Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589384}
-
Dmitry Gozman authored
We used to only check the policy on attaching, but we should also check it when navigating, similar to other session restrictions. Bug: 880476 Change-Id: I8cbfe149d67eadbc2f723652d140f2cd0925c44c Reviewed-on: https://chromium-review.googlesource.com/1211948 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
