- 15 Jan, 2011 20 commits
-
-
atwilson@chromium.org authored
Rolling this out because it breaks NoticeNotificationChanges on XP for some reason. BUG=65189 TEST=TaskManagerBrowserTest.KillBGContents Review URL: http://codereview.chromium.org/6226002 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/6310008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71536 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Adding 1 minute of waiting in discover search engine test. And moved _CallFunctionWithNewTimeout to test_utils. BUG=69619 Review URL: http://codereview.chromium.org/6354004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71535 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=61252 TEST=none Review URL: http://codereview.chromium.org/6249006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71534 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Review URL: http://codereview.chromium.org/6221007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71533 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
causes the latest IE9 developer preview version to crash. Reason being a change in the interface implementing the NavigateWithBindCtx2 method. BUG=none TEST=Covered by existing DownloadFromForm test. TBR=amit Review URL: http://codereview.chromium.org/6253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71532 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6256005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71531 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
Add methods to browser_tests which allow sharding control to be used to select the tests that are called by RunTest(). The same basic process is used by GTest to decide if a given test should be run (assuming the suite should be sharded). Reuse GTEST_TOTAL_SHARDS and GTEST_SHARD_INDEX since browser_tests is a wrapper around GTest and using the same variable names will simplify our tools. BUG=69423 TEST=browser_tests runs fine unsharded, can be run sharded Review URL: http://codereview.chromium.org/6333004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71530 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
TBR=hayato BUG=69719 TEST=none Review URL: http://codereview.chromium.org/6338006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71529 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
exists in the context menu, but now it works well enough to promote to the main placeholder UI. BUG=63695 TEST=see bug Review URL: http://codereview.chromium.org/5275007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71528 0039d316-1c4b-4281-b951-d872f2087c98
-
nfullagar@google.com authored
for this CL, also keep the old dev interface around temporarily, to avoid tree breakage. Add sample_rate to RecommendSampleFrameCount() to the non-dev audio interface. Currently ignored, but useful information to use when we need to refine RecommendSampleFrameCount() Review URL: http://codereview.chromium.org/6279003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71527 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
Before this change, it's a Singleton that gets passed a pointer to a Profile during Init(), and holds onto that pointer even after the Profile gets destroyed. With this change, it's owned by ExtensionService and is destroyed when the profile is being destructed. BUG=67927 TEST=On linux, run 'browser_tests --gtest_filter=ExtensionApiTest.BookmarkManager --gtest_repeat=100 --gtest_break_on_failure'. Before this CL, you'll occasionally get a failure because of the race condition described above. Review URL: http://codereview.chromium.org/6125003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71526 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71525 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
while processing a navigation update received for a tab loading state change. This is incorrectly treated as an internal navigation which messes up the history. Fix is to not treat the tab loading state change notification as an internal navigation. Fixes bug http://code.google.com/p/chromium/issues/detail?id=69096 BUG=69096 TEST=None at this point. Review URL: http://codereview.chromium.org/6284002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71524 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Review URL: http://codereview.chromium.org/6269001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71523 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally, trybots Review URL: http://codereview.chromium.org/6338002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71522 0039d316-1c4b-4281-b951-d872f2087c98
-
crogers@google.com authored
BUG=none TEST=none (I tested locally for Mac OS X, but we'll need further testing for Windows and Linux as we add real-time threads, etc.) Review URL: http://codereview.chromium.org/6002005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71521 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Allow printing/saving a plugin through right click menu, even if it's in a frame or an embed element. BUG=50285 Review URL: http://codereview.chromium.org/6142013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71519 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Some missing args in FillAutofillProfile() automation call are expected. Do not check for them. Review URL: http://codereview.chromium.org/6247007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71518 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Introduce RenderView::Observer interface so that RenderView doesn't have to know about the details of every feature. Observers get to filter and send IPC messages, and basic notifications of frame related events.I've moved over AutoFill related classes, and also made AutoFillManager implement the new WebAutoFillClient interface. For the rest of the classes, they implement the interface just for message filtering. Review URL: http://codereview.chromium.org/6151011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71517 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
BUG=69724 TEST=WidgetWinTest.SetBoundsForZoomedWindow Review URL: http://codereview.chromium.org/6259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71516 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Jan, 2011 20 commits
-
-
piman@google.com authored
Also force a flush when the buffer is getting full. BUG=none TEST=gpu_unittests, some webgl content, some 3d css content, pepper flash Review URL: http://codereview.chromium.org/6316002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71514 0039d316-1c4b-4281-b951-d872f2087c98
-
ctguil@chromium.org authored
BUG=none TEST=Manual Review URL: http://codereview.chromium.org/6310002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71512 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=68682 TEST=trybots Review URL: http://codereview.chromium.org/6354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71511 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
selection for instant queries. At some point I'll wire through the actual cursor position, but this is better than what we had. BUG=none TEST=none Review URL: http://codereview.chromium.org/6363001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71509 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
Use GL rather than EGL by default on linux. Debug Chromium builds display an error if they don't find EGL, even if GLX is available. This prompts people to install the EGL packages, even though that probably isn't their issue. Also, it looks like EGL, even if available, has some issues. If GLX isn't available, it still falls back to EGL. --use-gl=desktop should not be required to force use of GLX on boxes that also have EGL installed. Changed LOG(ERROR) to VLOG(1) if a shared library fails to load since this is not necessarily an error. Report an error only if no GL implementation can be initialized. Log which GL implementation was selected. TEST=launch chrome with various combinations of --use-gl switch and check the log output is correct. BUG=none Review URL: http://codereview.chromium.org/6325005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71508 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Handle this in ChromeInvalidationClient so that we don't have to handle it everywhere else. We were handling it incorrectly anyway, but it wasn't a problem since we always get all updates for all data types. BUG=None TEST=Manual Review URL: http://codereview.chromium.org/6358001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71507 0039d316-1c4b-4281-b951-d872f2087c98
-
panayiotis@google.com authored
BUG=60831 TEST=relevant unit_tests,browser_tests, go to ianfette.org. Review URL: http://codereview.chromium.org/6268001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71506 0039d316-1c4b-4281-b951-d872f2087c98
-
sunandt@chromium.org authored
1. testBlockAllPlugins 2. testAllowPluginException 3. testBlockPluginException BUG=none TEST=none Review URL: http://codereview.chromium.org/6015010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71505 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
TBR=ben@chromium.org TEST=check perms test BUG=None Review URL: http://codereview.chromium.org/6341002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71504 0039d316-1c4b-4281-b951-d872f2087c98
-
bryner@chromium.org authored
BUG=none TEST=ClientSideDetectionServiceTest Review URL: http://codereview.chromium.org/6277002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71503 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=compile and trybots Review URL: http://codereview.chromium.org/6339002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71502 0039d316-1c4b-4281-b951-d872f2087c98
-
cpu@chromium.org authored
Basically undo http://codereview.chromium.org/5306002 because with the newer sandbox policy the IME editors should not be crashing anymore. Note that this does not fix the IME problem with sandboxed flash BUG=63352 TEST=see bug for details Review URL: http://codereview.chromium.org/6279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71501 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6322001 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6291003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71500 0039d316-1c4b-4281-b951-d872f2087c98
-
levin@chromium.org authored
Now when SetBounds is called, we detect the maximized state and take the window out of this state. BUG=69618 TEST=WidgetWinTest.SetBoundsForZoomedWindow (added) Review URL: http://codereview.chromium.org/6268002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71499 0039d316-1c4b-4281-b951-d872f2087c98
-
cevans@chromium.org authored
<div>s) -- this makes the underlying page clickable where previously it may not have been. BUG=63695 TEST=see bug Review URL: http://codereview.chromium.org/6114004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71498 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Now these two classes are not templates, and just handle raw data. New ProtobufMessageReader is used to parse messages. BUG=None TEST=Unittests. Review URL: http://codereview.chromium.org/6277003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71497 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
Use WebFrame::createAssociatedURLLoader. See https://bugs.webkit.org/show_bug.cgi?id=49764 for the WebKit side of this change. R=michaeln BUG=none TEST=none Originally reviewed at: http://codereview.chromium.org/5139005 Review URL: http://codereview.chromium.org/5920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71495 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
The fix is to keep track of the original URL. BUG=69468 TEST=Manual test to verify. Review URL: http://codereview.chromium.org/6131009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71494 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71493 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
R=ben Review URL: http://codereview.chromium.org/6327005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71492 0039d316-1c4b-4281-b951-d872f2087c98
-