GitLab

R=dgozman, pfeldman
BUG=

Review-Url: https://codereview.chromium.org/2192333002
Cr-Commit-Position: refs/heads/master@{#408838}

Currently, in Ash tests, material design mode is set after call to
AshTestBase::SetUp(). This is not right as some setup in AshTestBase
might depend on material mode. This CL allows setting material mode
before calling AshTestBase::SetUp().

BUG=620093

Review-Url: https://codereview.chromium.org/2186363002
Cr-Commit-Position: refs/heads/master@{#408837}

DevTools: do not CHECK devtools messages received from renderer in the browser, issue bad_message instead.

BUG=629307

Review-Url: https://codereview.chromium.org/2198503002
Cr-Commit-Position: refs/heads/master@{#408836}

Traverse the links during building postorder iterator as well as the dominator tree.

Review-Url: https://codereview.chromium.org/2197853002
Cr-Commit-Position: refs/heads/master@{#408835}

Needed by
https://codereview.chromium.org/2163623003/

Review-Url: https://codereview.chromium.org/2188403003
Cr-Commit-Position: refs/heads/master@{#408834}

BUG=595356
R=dgozman

Review-Url: https://codereview.chromium.org/2198463003
Cr-Commit-Position: refs/heads/master@{#408833}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a6464cb626ec..e689c4714834

$ git log a6464cb62..e689c4714 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2192323002
Cr-Commit-Position: refs/heads/master@{#408832}

https://chromium.googlesource.com/skia.git/+log/848904e5b356..fe2042e60fa7

$ git log 848904e5b..fe2042e60 --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein SkRasterPipeline: new APIs for fusion
2016-07-29 mtklein simplify neon shifts
2016-07-29 bsalomon If scissor would be empty in GrClipMaskManager::SetupClipping indicate draw can be skipped.
2016-07-29 csmartdalton Add ES 3.0 fallback for instanced rendering

BUG=632185

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2201533002
Cr-Commit-Position: refs/heads/master@{#408831}

Review-Url: https://codereview.chromium.org/2091893003
Cr-Commit-Position: refs/heads/master@{#408830}

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2197723003
Cr-Commit-Position: refs/heads/master@{#408829}

Background: In order to have a mac retina layout test try bot with a
matching continuous bot, the slave for "WebKit Mac10.11 (retina)", which
was a MacBookPro11,3 with Nvidia GPU, was swapped for a MacBookPro11,5
with AMD GPU (http://crrev.com/2184313002).

After the builder came back online with the new slave,
svg/text/combining-character-queries.html was failing consistently.

See results:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__retina_/5141/layout-test-results/results.html

Review-Url: https://codereview.chromium.org/2193353004
Cr-Commit-Position: refs/heads/master@{#408828}

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482

Review-Url: https://codereview.chromium.org/2189563002
Cr-Commit-Position: refs/heads/master@{#408827}

The patch rolls CodeMirror to fix a wrong gutter background positioning.
This fixes the SourceCode-Diff experiment rendering in case of horizontal
source scroll.

BUG=none
R=einbinder

Review-Url: https://codereview.chromium.org/2201523002
Cr-Commit-Position: refs/heads/master@{#408826}

Additionally, starts tracking the 'packetsSentPerSecond' metric for WebRTC browser_tests.

BUG=631927

Review-Url: https://codereview.chromium.org/2190533002
Cr-Commit-Position: refs/heads/master@{#408825}

BUG=632915

Review-Url: https://codereview.chromium.org/2198623002
Cr-Commit-Position: refs/heads/master@{#408824}

Revert of [Android] Set platform mode as default for perf tests. (patchset #1 id:1 of https://codereview.chromium.org/2189773002/ )

Reason for revert:
https://bugs.chromium.org/p/chromium/issues/detail?id=632922

Original issue's description:
> [Android] Set platform mode as default for perf tests.
>
> BUG=615157
>
> Committed: https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159
> Cr-Commit-Position: refs/heads/master@{#408665}

TBR=mikecase@chromium.org,jbudorick@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=615157

Review-Url: https://codereview.chromium.org/2201563002
Cr-Commit-Position: refs/heads/master@{#408823}

BUG=621070

Review-Url: https://codereview.chromium.org/2142413003
Cr-Commit-Position: refs/heads/master@{#408822}

After moving geolocation to device, the presubmit
kept saying that I had to run git cl format, so here
we go. No new code, just ran:

clang-format -i -style=Chromium device/geolocation/*.h
clang-format -i -style=Chromium device/geolocation/*.cc

Review-Url: https://codereview.chromium.org/2200483002
Cr-Commit-Position: refs/heads/master@{#408821}

This should make it both show up in the "Dev APIs" section at the
bottom of the /apps/api_index page, but also have its own
standalone page at /apps/clipboard.

Review-Url: https://codereview.chromium.org/2200443002
Cr-Commit-Position: refs/heads/master@{#408820}

It was used to re-position the CBD dialog correctly, but its usage
was removed as part of migrating to native <dialog>.

BUG=625332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2193953002
Cr-Commit-Position: refs/heads/master@{#408819}

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Review-Url: https://codereview.chromium.org/2071463002
Cr-Original-Commit-Position: refs/heads/master@{#408739}
Cr-Commit-Position: refs/heads/master@{#408818}

1. Change the footer color to that of secondary text (i.e. --paper-grey-600).
2. Replace the 12px bottom margin with padding, so that this 12px high area
   at the bottom becomes a part of the scrollable region.

Screenshot: https://screenshot.googleplex.com/aodmwFZfdrq

BUG=595580
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2191283002
Cr-Commit-Position: refs/heads/master@{#408817}

alt-tab confuses translators.

BUG=b/30495226

Review-Url: https://codereview.chromium.org/2195923002
Cr-Commit-Position: refs/heads/master@{#408816}

This property is not used that much, and can be removed.

BUG=608115, 628502
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2184893002
Cr-Commit-Position: refs/heads/master@{#408815}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/395e5365f02a..a6464cb626ec

$ git log 395e5365f..a6464cb62 --date=short --no-merges --format='%ad %ae %s'

BUG=599932

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2195913002
Cr-Commit-Position: refs/heads/master@{#408814}

Just a clean up as a part of Layers cleanup.

BUG=625284
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2185973005
Cr-Commit-Position: refs/heads/master@{#408813}

This CL correctly formats the network and proxy sections of the
internet detail page.

It also introduces internet_shared_css.html for common styling.

BUG=609156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2179223004
Cr-Commit-Position: refs/heads/master@{#408812}

I checked that it worked, but not that it matched what the label says.
My bad.

R=dschuyler@chromium.org
BUG=632679
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2193353002
Cr-Commit-Position: refs/heads/master@{#408811}

(Mojo) Shell types have been renamed elsewhere in Chromium, specifically ServiceRegistry is split into two parts:

- InterfaceRegistry, for registration of interface factories in code that implements the interfaces
- InterfaceProvider, allowing binding of named interfaces in code that consumes them.

This reflects this naming scheme into Blink, which uses only the Provider half.

R=esprehn@chromium.org
http://crbug.com/632874

Review-Url: https://codereview.chromium.org/2196843003
Cr-Commit-Position: refs/heads/master@{#408810}

This CL makes use of the newly introduced Array DataViews
in cc StructTraits in order to improve serialization (and
to a lesser degree deserialization) performance.

This CL improves serialization performance by an average of
18% on an HP Z620. Deserialization performance improves
between 7 to 10%.

Prior to the ability to inspect Array and Struct DataViews
in parent StructTraits, we had to do extra work at
serialization time in order to capture state that spans
individual structs within a larger struct.

This CL addresses two of those cases:

1. Previously, QuadList maintained an extra array of
materials. This array existed so that we could preallocate
the appropriately typed DrawQuads during deserialization.
StructTraits assume a preallocated type and populated
fields in that type.

Alternatively we could have deserialized DrawQuads into
unique_ptrs, but cc required that we allocate DrawQuads
inline within a buffer in order to minimize the cost of
allocations (there can be hundreds of DrawQuads in a
CompositorFrame).

2. Previously, SharedQuadStates were serialized
independently of DrawQuads. However, in in-memory form,
DrawQuads refer to SharedQuadStates via raw pointers. In
order to allow DrawQuads and SharedQuadStates to deserialize
independently, as was required previously by StructTraits, a third
array was serialized "shared_quad_state_references" which was equal in
size to the QuadList. Each slot corresponded to an index in
the SharedQuadStateList. After the QuadList and SharedQuadStateList were
serialized,  shared_quad_state_references updated the raw
pointers in the DrawQuads in the quad list to refer to the
SharedQuadStates. This required revisiting all deserialized
DrawQuads again.

In both 1. and 2. additional state needed to be allocated on the heap
during serialization. In pprof profiling, it became apparent that much
of the cost of serialization was in SetupContext. This CL eliminates
that cost.

Performance measures are available here:
https://docs.google.com/a/google.com/spreadsheets/d/13Y0I-BVDrQC4RHIzMSs0vl0QPe8xFAhYMUAXaxoEqgg/pubhtml

BUG=624459
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2174843003
Cr-Commit-Position: refs/heads/master@{#408809}

This moves all of ResourceLoader's non-trivial response handling logic to ResourceFetcher, and changes the ordering of some steps to better match other callbacks.

Old order:
- Access control checks in ResourceLoader::didReceiveResponse()
- Resource::responseReceived()
- Access control checks in ResourceFetcher::didReceiveResponse()
- FetchContext::dispatchDidReceiveResponse()

New order:
- Access control checks in ResourceLoader::didReceiveResponse() (now in ResourceFetcher)
- Access control checks in ResourceFetcher::didReceiveResponse()
- FetchContext::dispatchDidReceiveResponse()
- Resource::responseReceived()

BUG=

Review-Url: https://codereview.chromium.org/1975373002
Cr-Commit-Position: refs/heads/master@{#408808}

TBR=dgozman

Review-Url: https://codereview.chromium.org/2197823002
Cr-Commit-Position: refs/heads/master@{#408807}

Initially broken by https://codereview.chromium.org/2150783002

BUG=629530,630030

Review-Url: https://codereview.chromium.org/2193323002
Cr-Commit-Position: refs/heads/master@{#408806}

BUG=597178

Review-Url: https://codereview.chromium.org/2191323004
Cr-Commit-Position: refs/heads/master@{#408805}

Previous change passed the sender to FontFallback init, but not
DWriteFontCollectionProxy which is what really matters. This will
ensure that both classes get the right sender.

BUG=631254

Review-Url: https://codereview.chromium.org/2196493003
Cr-Commit-Position: refs/heads/master@{#408804}

Side note: if we had just used .icon files, besides the massive proliferation of them that would have been necessary, we'd have worse rendering at fractional scales like 1.5x because we'd be filling fractional pixels. However, to actually get the better drawing at fractional scales, the network technology badges (LTE, G, etc.) will also have to be vectorized.

BUG=617306

Review-Url: https://codereview.chromium.org/2201443002
Cr-Commit-Position: refs/heads/master@{#408803}

The BlimpClientSession will be going away, so this CL takes part of it
and splits it up into smaller parts and moves them to
//blimp/client/core/session. They will be used by the
BlimpClientContextImpl.

BUG=611097

Review-Url: https://codereview.chromium.org/2187893002
Cr-Commit-Position: refs/heads/master@{#408802}

R=jrummell@chromium.org

Review-Url: https://codereview.chromium.org/2196453003
Cr-Commit-Position: refs/heads/master@{#408801}

BUG=543161, 624567

Review-Url: https://codereview.chromium.org/2196553002
Cr-Commit-Position: refs/heads/master@{#408800}

invalidation_service_android never updated its logger instance's state,
since the state is always enabled. This meant the logger only ever
reported the state as its initial value, which is transient_error. This
change causes invalidation_service_android to update the state to
enabled upon construction.

R=pavely@chromium.org

BUG=630406

[sync] re-enable SyncTest#testRename

Review-Url: https://codereview.chromium.org/2201503002
Cr-Commit-Position: refs/heads/master@{#408799}