Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 24 Sep, 2020 6 commits
    • Keishi Hattori's avatar
      Revert "Insert CheckIsNotDestroyed() in all LayoutObject Methods" · 868d2d74
      Keishi Hattori authored 
      This reverts commit 23b8809f.

Reason for revert: Showed regression even on non debug builds crbug.com/1131453

Original change's description:
> Insert CheckIsNotDestroyed() in all LayoutObject Methods
> 
> CheckIsNotDestroyed() will be used to ensure LayoutObject is not used after the Destroy() call once LayoutObject is moved to GarbageCollected.
> CheckIsNotDestroyed() should be the first statement for all methods on LayoutObject and its subclasses.
> 
> Bug: 1030176
> Change-Id: I4862ad8d068311b8cccf3881b21f0d62f787c333
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409837
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#809687}

TBR=haraken@chromium.org,keishi@chromium.org,ikilpatrick@chromium.org

Change-Id: I99213419df0c39d9d6c39e4b8117354126c4e2e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1030176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427605Reviewed-by: default avatarKeishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810027}
      868d2d74
    • Xianzhu Wang's avatar
      Revert "Enable transformed rasterization for most layers" · 5fd12ebf
      Xianzhu Wang authored 
      This reverts commit b179b125.

Reason for revert: for debugging crbug.com/1121730

Original change's description:
> Enable transformed rasterization for most layers
> 
> Background: transformed rasterization is used to render sharp text in a
> composited layer with fractional transform. It snaps the composited
> transform of the layer to whole pixels, then applies the fraction
> during rasterization.
> 
> Previously we disallowed transformed rasterization in blink for directly
> composited layers (excluding backface-visibility:hidden and trivial 3d
> transforms such as translateZ(0)), especially for will-change:transform
> because change of fractional transform would cause re-rasterization
> which would defeat the purpose of will-change:transform.
> 
> Now for a layer that was not eligible for transformed rasterization,
> calculate the initial raster translation which achieves sharp text
> rendering with the initial transform. When the transform of the layer
> changes, keep its original raster translation to avoid invalidation
> of tilings, to ensure animation performance. The rendered result will
> be blurry during animation but the initial rendering result is sharp.
> 
> Remove blink-side transformed rasterization conditions and let cc
> decide it based on screen and draw transforms of the layers.
> 
> Bug: 1111195
> Change-Id: If0455be2f29e69cd7152c951626e6e8cc143b5bd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351164
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798268}

TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,pdr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1111195, 1121630
Change-Id: Ibab42e963cab263cab062377ffa2aad38291c5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427125Reviewed-by: default avatarXianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810026}
      5fd12ebf
    • Alan Cutter's avatar
      Refactor ExternalWebAppManager config loading flow · 02f9f701
      Alan Cutter authored 
      This CL splits ExternalWebAppManager's config loading flow into discrete
steps and removes the various testing entry points that omit or
duplicate logic used by the real thing.

Tests can now inject data (file_utils, config_dir, configs) into the
config loading pipeline instead of having separate mini pipelines just
for them.

This change is in preparation for adding a new "FilterExtensionIds" step
to the config loading flow. Without this refactor there would be
duplication of logic between real and test code code paths that would be
prone to bitrot and missing real coverage.

Bug: 1128801
Change-Id: Ie5e87b26ab47782fab6589a4127df3ea5e876fec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423823Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarGlen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810025}
      02f9f701
    • Wenyu Fu's avatar
      Add empty TextView to preload Google Sans on FRE · 210f1b4a
      Wenyu Fu authored 
      Seems fonts are only loaded when it is needed. Adding empty text view to
load Google Sans to "preload" for following pages.

More context in the original bug.

Bug: 1119990
Change-Id: I026b80cf15b939c30f97a1174aad4d8259ef66b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427524Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
Reviewed-by: default avatarSky Malice <skym@chromium.org>
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810024}
      210f1b4a
    • Alexandre Courbot's avatar
      WATCHLIST: remove self · 4599f986
      Alexandre Courbot authored 
      I'm trying to watch less stuff in Chromium. Still staying owner in some
media/gpu directories.

BUG=None

Change-Id: I2678d405f083e75841cbc341e1d02752a44cf576
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426144Reviewed-by: default avatarFritz Koenig <frkoenig@chromium.org>
Reviewed-by: default avatarAlexandre Courbot <acourbot@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810023}
      4599f986
    • Natalie Chouinard's avatar
      [Android] Add vertical scrollbars on Settings · 51958411
      Natalie Chouinard authored 
      Show vertical scroll bars on settings screens, matching the Material
style. These scroll bars appear briefly when the settings screen is
opened, and again whenever the user scrolls the page to show their
current scroll position.

This change only affects settings screens that extend
PreferenceFragmentCompat. Other custom setting screens will be addressed
in follow-up bugs (i.e. https://crbug.com/998609).

Bug: 1131073
Change-Id: Ie9c9a7f118e9a00d5f5439d285fb67958b83b1d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424506
Auto-Submit: Natalie Chouinard <chouinard@chromium.org>
Reviewed-by: default avatarWenyu Fu <wenyufu@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810022}
      51958411
  3. 23 Sep, 2020 34 commits