- 21 May, 2019 40 commits
-
-
Nicholas Hollingum authored
Wrote a tool that processes wayland protocols into some useful form. As a prototype this tool just generates pretty graphviz diagrams. Going forward we will be using this tool to automatically generate a fuzz target and its client for the purpose of fuzzing components/exo/* code. Bug: 961564 Change-Id: Ia0db917746e7de1d03b6a2f83da0729eae15d617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621476 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#661981}
-
Becky Zhou authored
+ Update dark hairline color to grey 700 + Update dark elevation colors Bug: 959284, 958916 Change-Id: Iffbb9a7ddbcb2ef7844ce18d02e9e287a5c34de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623305Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#661980}
-
Eric Aleshire authored
This includes: * openNewTab * openNewIncognitoTab * closeAllTabsInCurrentMode * closeAllIncognitoTabs All four are similar and fairly routine, so they were combined in this CL. A small test is added to smoke_egtest to exercise all of them. Bug: 922813 Change-Id: I3244c1f5ce82b207e68ee5fc80a7eae014f8496b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622436Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#661979}
-
François Degros authored
Change-Id: I739a6ed2a754a17f3899e3b5716f0d0497cb2470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621790Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Auto-Submit: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#661978}
-
Avery Musbach authored
As a first step toward fixing Issue 965665, the present CL just simplifies the relevant code. Test: manual Bug: 965665 Change-Id: I371a293e8ace81e2b4e325a4e6c36b576e0a46bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623130Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#661977}
-
Matt Reynolds authored
This CL adds a chooser for HID devices based off of the existing choosers for USB, Bluetooth, and serial. Two new settings are registered: CONTENT_SETTINGS_TYPE_HID_GUARD determines whether the HID chooser can be displayed. Set to CONTENT_SETTING_ASK to enable the chooser, or CONTENT_SETTING_BLOCK to disable it. CONTENT_SETTINGS_TYPE_HID_CHOOSER_DATA will be used to store permission information for devices requested through the HID chooser. BUG=890096 Change-Id: I9fdd3866cb7765d849a26753498be3bc1129a250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1585461Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#661976}
-
Wei-Yin Chen (陳威尹) authored
Some functions are called outside of testing code despite of being marked with @VisibleForTesting. This CL stops calling the following methods: - #setValues(float, float) - #getAnimatedFraction() Removed @VisibleForTesting for #getAnimatedValue() since there's no other way for non-property animations. Removed @VisibleForTesting for #setValues to match ValueAnimator. Bug: None Change-Id: I7483b47054fa0c0df62964873046de0b420756f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621348Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#661975}
-
Mason Freed authored
Previous to this CL, backdrop-filters with pixel moving filters would cause the capture rect for the backdrop-filter to be improperly located. In those cases, the capture rect was expanded for the filter, but the bounds were not properly updated. This is now fixed. I added a unit test to capture this corner case. Bug: 964371 Change-Id: I5e9833b7d8460feaafca9dd29fe4a469fb6a55f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618304 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: enne <enne@chromium.org> Reviewed-by:
enne <enne@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#661974}
-
Yulun Wu authored
Bug: 757077 Change-Id: I245d5660a7a634c9556c8473eeed016cb12d1870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620770Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661973}
-
Maks Orlovich authored
Change-Id: I4670f9da505dd5a1e508752ecb1a6c37be2e56e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622987Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#661972}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a453ba42f72d..f4d2a446cc12 git log a453ba42f72d..f4d2a446cc12 --date=short --no-merges --format='%ad %ae %s' 2019-05-21 samans@chromium.org Add gn files for Vulkan Swiftshader Created with: gclient setdep -r src/third_party/swiftshader@f4d2a446cc12 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963988 TBR=swiftshader-team+autoroll@google.com Change-Id: Iafd74d8b680d96511b189ef9304324cd10e2ab84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661971}
-
Matt Reynolds authored
This CL updates the Stadia controller mapping function to match the HID reports generated by the release version of the firmware. BUG=965585 Change-Id: Ibf2d8ebddcc6187f165525beb27eab6de626edf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622479 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
John Budorick authored
Confusing too many sheriffs. Bug: 790202 Change-Id: Ia93bbd1e35db5258bc835c52538ee9a4f2d0ee38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622191 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#661969}
-
Victor Costan authored
The last remaining SQLite patch is 0001-Custom-shell.c-helpers-to-load-Chromium-s-ICU-data. This CL adds tests ensuring that SQLite uses ICU, creating a safety net for the removal of the SQLite patch. Bug: 945204 Change-Id: I2b5661d78fcd00e7c088fc234eeef0f981f2bb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621845 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#661968}
-
Jimmy Gong authored
Bug: none Change-Id: I6fdb6ad26db5aec08ac017483fb312709961a53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623462 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#661967}
-
Morten Stenshorne authored
Make sure that layout has happened before modifying style. This is what the test wants to test. Bug: 965137 Change-Id: I2efcae8113b693fe7d591e6eff3df3937ed4df43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623089Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#661966}
-
Clark DuVall authored
These tests were failing because Android does not have full site isolation, And the check here was returning a null origin when navigating back to about:blank: https://cs.chromium.org/chromium/src/content/browser/frame_host/render_frame_host_impl.cc?l=444&rcl=b764bb44c647dc2172781d1d19cdb3e8e83a306c Example failures: https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Android/16129 Change-Id: I7a6d862183225907ba7d03ab36541c52e83e4fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620819 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#661965}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I86e62875327683f11df9a8fda0c9a6ad2261854d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622595Reviewed-by:
-
Bailey Berro authored
This symbol should be marked CHROMEOS_EXPORT since it is used from the chrome.autotestPrivate api. Change-Id: I9aa10741682a53ba9b6263aed0d4619663609d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617560 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#661963}
-
Chris Hall authored
Somehow when rebasing my earlier change I managed to undo this and it snuck through. R=katie Bug: 950391 Change-Id: I3599e2f112eabe360309d0a705d1233635d64e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621471 Auto-Submit: Chris Hall <chrishall@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#661962}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/ca374f5112fc..4744a43b6fc4 git log ca374f5112fc..4744a43b6fc4 --date=short --no-merges --format='%ad %ae %s' 2019-05-21 dschuff@chromium.org Enable TCSM sysctl option on mac Created with: gclient setdep -r src/native_client@4744a43b6fc4 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I83726c4425cc7a5690ff4dc084eb0e584b7b13b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622631Reviewed-by:
-
Robert Sesek authored
Revert "Sheriff: mojo/bind-intercepted-interface-in-worker.html and 1 other(s) in webkit_layout_tests failing on Mac" This reverts commit b3bc88a6. Reason for revert: testing if fixed by https://crrev.com/c/1621031 Original change's description: > Sheriff: mojo/bind-intercepted-interface-in-worker.html and 1 other(s) in webkit_layout_tests failing on Mac > > - mojo/bind-intercepted-interface-in-worker.html Harness failure > - shapedetection/detection-on-worker.html Timeout > > TBR=avi@chromium.org > > Bug: 963734 > Change-Id: I81da1601c605e17d0c8f0ffc0fc2025b1a57cecb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614859 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#660279} TBR=tasak@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 963734 Change-Id: I70eee514d99017e28bdd94a323c12522cddc8698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623448Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661960}
-
Lukasz Anforowicz authored
The C++ code logging the "SiteIsolation.AllResponses" values was removed in r544769. Bug: 705801 Change-Id: I330b023782aa0335ceb6e9d51e1320c1a89c0238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623326Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#661959}
-
Alex Cooper authored
If a Windows Mixed Reality controller is connected and detected by the runtime but not tracked, currently that controller gets ignored. This changes the plumbing of mixed_reality_input_helper to allow untracked controllers to be reported up through mojo. While the controller may not be tracked, any button click events can be reported and if it was previously tracked orientation events are still reported. The controller can still be rendered with these orientation events at its most recently known location. In the case that a controller loses tracking after having previously been tracked, the blink code now explicitly nulls out the base pose if it is not provided by an XRInputSourceStatePtr. Bug: 958901 Change-Id: I106d44dbd0821cdc01826b56f4a18069d4f7f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622632Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#661958}
-
danakj authored
This is a cancellable OnceCallback as it is post-tasked and only run that way. R=boliu@chromium.org Bug: 953861 Change-Id: Ie0866ef8c202285648bc9a88bc61746df22bcac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622509Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#661957}
-
Regan Hsu authored
Remove all browser download settings. Hide OS specific download settings in Browser settings. Change-Id: Id098ee72dd67b52fd25896f06b98318e2ba6771f Bug: 950007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616999 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#661956}
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom/dom_exception.h. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: Ia999f176170d242e8db54039cb6fb2645194141f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620626Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56355ce2d52f..8908a37777ec Created with: gclient setdep -r src-internal@8908a37777ec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:803846 TBR=mbarowsky@google.com,sidereal@google.com Change-Id: Idcc1d41aaec37c010034ce8baa726c518e0135d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622411Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661954}
-
Antonio Gomes authored
CrossThreadBind was being used for passing callback instances to functions that were expecting "Once callbacks". Note that CrossThreadCopier needed to be extended to take CrossThreadOnceFunction instances (similarly to the existing logic for CrossThreadFunction). BUG=963574 R=haraken@chromium.org, hiroshige@chromium.org Change-Id: I86e46d8088763427f292d62acccfc627857ca739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621393 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#661953}
-
Nasko Oskov authored
Currently when a renderer process exits, RenderProcessHostImpl notifies objects associated with it about this via an IPC message which it dispatches to all of its listeners. This is a confusing pattern we decided should go away and RenderProcessHostObserver was introduced. This CL removes FrameHostMsg_RenderProcessGone and moves RenderFrameHostImpl to use the new pattern instead of using this IPC to detect process going away. Bug: 566116 Change-Id: I4beb9182464846053499f01dd4c74c749276d2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612854Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#661952}
-
John Williams authored
Bug: 965229 Change-Id: Id1f1c3c703f196514fb77b6362aa2c1dc33d0641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605342Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#661951}
-
Jeff Fisher authored
Today, each tool that uses the PieChart control has to implement its own legend control. This change moves the legend into PieChart and standardizes the look and feel. Screenshots: Application Storage tab: https://imgur.com/laaPFRO Heap statistics: https://imgur.com/SNwpGXt Profiler: https://imgur.com/FiKZtTx Change-Id: I61a8adab0b58fbe49298804f97208da6a6bbbce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607140 Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#661950}
-
danakj authored
The callback is only called once so it should be a OnceCallback. R=liberato@chromium.org Bug: 953861, 751838 Change-Id: I2fb5df98979b59f86df1b7d5110a266d0c807859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618309 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#661949}
-
Peter K. Lee authored
This fetches the user avatar using Authentication Service. iPhone8+ portrait https://screenshot.googleplex.com/thO3dzi6gGZ iPhone8+ landscape https://screenshot.googleplex.com/Jn08gmyJK3g iPad portrait https://screenshot.googleplex.com/T21TNZkY9jj iPad landscape https://screenshot.googleplex.com/4pxZ1Mw39DF iPad multitask https://screenshot.googleplex.com/FGGM1wUuQyP Bug: 961120 Change-Id: I9af0a59d8c4b0f205db3007d7d36a935f198cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612347 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#661948}
-
Alexander Woolf authored
This change is the next part of standing up the quarantine service. It moves the quarantine implementation from components/download/quarantine/download to components/services/quarantine. For now, QuarantineFile in download remains, but just directly calls quarantine::QuarantineFile. When the service is wired up with a follow up change, components/download/quarantine will be removed and call sites will directly call the service. Bug: 870998 Change-Id: I8e41b577db43532bdc01f67ebe54fd653530adea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617611 Commit-Queue: Alexander Woolf <alewoolf@microsoft.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#661947}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I8cf0893e6da62462a7e54f3ce462d969ae5fa670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622711 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#661946}
-
Esmael El-Moslimany authored
As part of work to replace usages of paper-icon-button with cr elements in the ChromeVox options, cr-link-row needed a slot for a label and subLabel. This is due to how the ChromeVox page loads its i18n strings. I added the link role to the button and defined static aria-labellby and aria-describedby. Here is the CL to replace paper-icon-button with cr elements: https://chromium-review.googlesource.com/c/chromium/src/+/1618564 Bug: 960564 Change-Id: I7934a13911d4c7572db8701542560859e4af7d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622476Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#661945}
-
Emil A Eklund authored
Change-Id: Ic200ff2e4bc0da8f570ba653699feb8c262d3ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623325Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#661944}
-
Cathy Li authored
Change-Id: I51d382a4222b41635689a91486bd2bdb1c44d10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618541Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#661943}
-
Henrique Nakashima authored
There are no more subclasses left, this has been completely replaced by BrowserContextKeyedServiceFactory. Bug: 937770 Change-Id: I4b9170e26123c3b79f1beb4f657f2129587bfee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1588205 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#661942}
-
