GitLab

TBR=jorlow

Review URL: http://codereview.chromium.org/6300010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72069 0039d316-1c4b-4281-b951-d872f2087c98

As of today, we have dedicated chromium trybots that can run the sync
integration tests, but it requires developers to explicitly send try
jobs to these bots via the --bot switch.

Now that the sync trybots are stable, it is time to make this process
automatic by adding a PRESUBMIT.py file to chrome/browser/sync, that
adds the sync trybots in addition to win, mac and linux to the list of
preferred trybots.

This patch adds such a PRESUBMIT.py file, that includes
win_sync, mac_sync and linux_sync to the list of preferred trybots.

BUG=70311
TEST=modify something under chrome/browser/sync and do a "git try" or "gcl try"

Review URL: http://codereview.chromium.org/6275010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72067 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=69135
TEST=none
TBR=gavinp


Review URL: http://codereview.chromium.org/6300009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72063 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6380006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70149
TEST=None

Review URL: http://codereview.chromium.org/6349007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72061 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=<this is the test>

Review URL: http://codereview.chromium.org/6338013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72059 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6272013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72058 0039d316-1c4b-4281-b951-d872f2087c98

button.

BUG=69145
TEST=none

Review URL: http://codereview.chromium.org/6241010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=67716
TEST=none

Review URL: http://codereview.chromium.org/6269014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72056 0039d316-1c4b-4281-b951-d872f2087c98

collect extra information (driver_vendor, gl_renderer, etc.) on Mac/linux.
Note that this CL takes some code from rlp's long outstandingCL (with her
permission).

BUG=49579
TEST=unittest

Review URL: http://codereview.chromium.org/6346007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6296018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72054 0039d316-1c4b-4281-b951-d872f2087c98

instance with resources and has most callers retrieve the dispatcher
according to the appropriate instance. This isn't hooked up to anything yet.

This changes some PPB_Flash interface methods to use PP_Bool.

The most challenging part of the change is in the plugin_var_tracker which
now needs to track which dispatcher each var object came from, and remap var
IDs since each renderer will be generating var IDs in its own space, which
will likely overlap. A similar system will need to be done for resources
which is not implemented yet.

I added some null checks in audio_impl because audio_ can be NULL in some
cases when using the trusted API. I discovered this when testing NaCl for
this patch.
Review URL: http://codereview.chromium.org/6282007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72053 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6339007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72051 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72050 0039d316-1c4b-4281-b951-d872f2087c98

incorrectly clearing the selection.

BUG=62872
TEST=none

Review URL: http://codereview.chromium.org/6275009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72048 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6255007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72047 0039d316-1c4b-4281-b951-d872f2087c98

pidfile.

SPDY frames were leaking when used with DataFrame and OutputList.
HUP signal will now reopen the log file.
Remote IP obtained for 'forward-ip-header' was incorrect.
Added connection idle timeout.
Fixed up pidfile handling.
Flip server now creates and locks a pid file.

Patch from Kevin Lindsay: kelindsay@gmail.com

BUG=none
TEST=self

Review URL: http://codereview.chromium.org/6332010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72046 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6340008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72045 0039d316-1c4b-4281-b951-d872f2087c98

Move the TestSink for doing IPC tests from chrome/common into IPC and create a new IPC test_support project that references it.

This is necessary because I want to make a test that uses the sink outside of chrome.

TEST=this is a test
BUG=none
Review URL: http://codereview.chromium.org/6290008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72044 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70138
TEST=none
TBR=amit

Review URL: http://codereview.chromium.org/6382005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72043 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72042 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72041 0039d316-1c4b-4281-b951-d872f2087c98

R=tony

Review URL: http://codereview.chromium.org/6279007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72039 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=brettw

Review URL: http://codereview.chromium.org/6263008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98

Code to send diagnostic messages about cloud print proxy. Currently diagnostic messages are sent if the print system fails to initialize (this can happen on Windows if the XPS Framework is not installed on XP) as well when printer registration fails because we could not get the capabilities for the printer.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6245005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72037 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=everything works as before (note, about:ipc only works in Debug builds)
R=jrg

Review URL: http://codereview.chromium.org/6265015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72035 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68307
TEST=Dr. Memory no longer complains.
Review URL: http://codereview.chromium.org/5998010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72032 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72031 0039d316-1c4b-4281-b951-d872f2087c98

The destructor of net::NetworkConfigWatcherMacThread ends up calling
PlatformThread::Join(), an operation that needs to be done only from an
IO thread. This currently causes a DCHECK to fire in base::ThreadRestrictions.

The bug was discovered by running the sync integration tests on a mac trybot.
The tests create Profile objects during setup, that indirectly call
~NetworkConfigWatcherMacThread() from their destructors.

This patch allows IO operations in ~NetworkConfigWatcherMacThread()
using a ScopedAllowIO.

BUG=70190
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6353008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72030 0039d316-1c4b-4281-b951-d872f2087c98

the NPAPI redirect notification spec.

We compare the URL received in the NewStream notification with the requested URL and if they
differ we cancel the current request and inform Chrome that this was a redirect. The sideeffect
would be that there would be two GET requests sent out.

BUG=69419
TEST=none.

Review URL: http://codereview.chromium.org/6381005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify clicks don't close sub-pages when an overlay is visible.
Review URL: http://codereview.chromium.org/6375006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compiled and viewed under linux.

Review URL: http://codereview.chromium.org/6222004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72027 0039d316-1c4b-4281-b951-d872f2087c98

Long cookie contents will now wrap earlier than they need to. CSS really doesn't want to do what we want (wrap the text at the inherited width, or anything except a hardcoded width). So I set the width to be narrower (300 instead of 520) and also set the table's layout to fixed, so that even if 300 is too wide the whole table won't overflow.

BUG=69447
TEST=LANGUAGE=fr_FR ./out/Release/chrome

Review URL: http://codereview.chromium.org/6327013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72026 0039d316-1c4b-4281-b951-d872f2087c98

If the gpu process dies, CommandBufferProxy might be the first one to find out about it.  When the context is being created, GpuChannelHost still thinks there is no error.  It will send CreateViewCommandBuffer message to establish a communication channel, which will fail, and GPU process will not restart.  To prevent that, we set GpuChannelHost state to lost as soon as CommandBufferProxy finds out about it.

BUG=58785
TEST=open a composited tab, in another tab go to about:gpucrash

Review URL: http://codereview.chromium.org/6384003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72023 0039d316-1c4b-4281-b951-d872f2087c98

 This change makes the textfield uneditable. The text can
still be updated via API (which is necessary to show URL
in popup).

BUG=none
TEST=uadded new ReadOnlyTest

Review URL: http://codereview.chromium.org/6314012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70280
TEST=none

Review URL: http://codereview.chromium.org/6338012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72021 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6265016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72019 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:430
TEST=try bots (win, linux, linux_chromeos); tested on device

Review URL: http://codereview.chromium.org/6268008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72017 0039d316-1c4b-4281-b951-d872f2087c98

Fix for:
themes.py:106: SyntaxWarning: assertion is always true, perhaps remove
parentheses?

Review URL: http://codereview.chromium.org/6309009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72016 0039d316-1c4b-4281-b951-d872f2087c98