- 04 Apr, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e04bd5bc2bff..c4b4871ed0d4 Created with: gclient setdep -r src-internal@c4b4871ed0d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id6266b8d502f80ebb5e84f7abd7410361bf7c60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136476Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756522}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16880f7e70e6..e04bd5bc2bff Created with: gclient setdep -r src-internal@e04bd5bc2bff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1c168bd3adf618471cb982abaaa6f3664c834571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136475Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f99dddd9eb99..16880f7e70e6 Created with: gclient setdep -r src-internal@16880f7e70e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iab67e9cd8a1627ec36ae76f91ab14aa8a60860db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136372Reviewed-by:
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to percentage-size-quirks-001.html. Bug: 1063749 Change-Id: I0fd18022c94cc4d539a6e8f79efbfd6e658863cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134466 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756519}
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to percentage-heights-013.html. Bug: 1063749 Change-Id: I6e8d246c6f7780dd5ee9d1ceeff3a0a173d4f6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134032Reviewed-by:
-
James Hollyer authored
The FrameConnectorDelegate is supposed to be an interface which is implemented by an object supplying platform semantics for a child frame. The recent change(https://crrev.com/c/2071788) failed to implement the ChangeMouseLock in CrossProcessFrameConnector and therefore these calls were not getting to the correct place. I also added the error handler for the rarely hit PointerLockResult::kUserRejected error. Bug: 1062702 Change-Id: I9c6aad9bac455b578b39e2aa086732f69f09fe61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116327 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756517}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96ae90c6b73f..f99dddd9eb99 Created with: gclient setdep -r src-internal@f99dddd9eb99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7ca0d190f5cf019ca057f88d66df500e24ca0ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135911Reviewed-by:
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I40d2073d697ee8e1ad41702d3d3c4d5d9e3a5574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133996Reviewed-by:
-
Antonio Gomes authored
BUG=1063749 R=dgrogan@igalia.com Change-Id: I9ad5346513e28858ea0be317aa3fb578cd08e55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135710 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2eb4bd46bdb8..10d86ab5dafa git log 2eb4bd46bdb8..10d86ab5dafa --date=short --first-parent --format='%ad %ae %s' 2020-04-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@10d86ab5dafa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I3c2d93a2e0ab8d82eff0cad916037272f6931508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756513}
-
Johnny(Jianning) Ding authored
Change-Id: Id47f14bdcac8fc8357ecd4fb5d15b2e028e9558d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132677Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Johnny (Jianning) Ding <jnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756512}
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: Ibd1c9142411012bdcc0c0da889107854b6d313c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134091 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756511}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/38cf390f9cf2..e8e12250f4d0 git log 38cf390f9cf2..e8e12250f4d0 --date=short --first-parent --format='%ad %ae %s' 2020-04-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 22aaaa25..f099852e (756379:756498) Created with: gclient setdep -r src/third_party/webrtc@e8e12250f4d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia6d4e759ed4578418dea7e65cbea683c0fab3bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135819Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d0b14303be0d..96ae90c6b73f Created with: gclient setdep -r src-internal@96ae90c6b73f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia44e7cd9d13b94a0ab6370614197f1dba62e5811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135816Reviewed-by:
-
Frank Liberato authored
When constructing |screen_info| for the renderer, display_util selected the raster color space for the color space to send. For HDR display color spaces, this turns out to be the non-HDR display P3 color space. During media playback on windows, this color space is used to notify the video decoder about the preferred format for the decoded video frames. Since it's a non-hdr space, the decoder converts to sRGB rather than scRGB. This CL switches to the output color space, rather than raster. For reference, the observed combinations are: Display type | ColorSpaceUsage | Resulting CS -- before CL -- SDR kRaster sRGB HDR kRaster Display P3 -- after CL -- SDR kHDR sRGB HDR kHDR Linear HDR -- Tried |kSRGB| just to see what would happen -- SDR kSRGB sRGB HDR kSRGB sRGB Bug: 1065869 Change-Id: I3392fb0062e0276392e0e116ddd9a57b654e795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135892Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#756508}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I460be28ef46e611fbd93abe8fd05954539ff92b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135817Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Id252e5958d2683e2120f3d27865b9d0be1694330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135818Reviewed-by:
-
Joey Arhar authored
This reverts commit 6361e1e8. Reason for revert: FidoGetAssertionTaskTest.TestSignSuccessWithFake in device_unittests has been failing on debug builds after this change. Here is the list of failing builds on the Linux Tests (dbg)(1) bot since this change: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87976 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87977 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87978 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87979 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/87980 Original change's description: > webauthn: support non-standard default credProtect levels. > > In the latest CTAP 2.1 draft, an authenticator can have a default > credProtect level other than one. Previously, Chromium couldn't > distinguish level one from not-specified thus, first, this change adds > that distinction. > > Then there are additional complexities because Chromium sets a default > credProtect level of two for discoverable credentials, but we don't want > to override an authenticator default of three. Therefore the credProtect > level for a request becomes a property that can only be resolved in the > context of the specific authenticator that will receive the request. > > We already have a property like this: the Android ClientDataJSON > extension. Thus pull these meta-level request properties into a > different structure so that MakeCredentialRequestHandler can craft > per-authenticator requests from that when needed. > > This isn't perfectly clean because the Windows API acts as an > authenticator, but is actually a front for many authenticators. So we > have to stuff |cred_protect_enforce| in the request object, despite it > being a meta-level property. > > BUG=1057126 > > Change-Id: Id1c02d4689492d597f5f29674166b97a8e720d2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130869 > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Commit-Queue: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756380} TBR=agl@chromium.org,martinkr@google.com Bug: 1057126 Change-Id: Ibc43ae6f841115ade183aab5c4fbfd2c01e90986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136280Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756505}
-
S. Ganesh authored
Omaha 4 now works with the UpdateService to service an on-demand update request. Bug: 1067348 Change-Id: Ia85ae0a245664f3c7383addee174b2d6849f4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136276Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#756504}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ie2af2917df6e7a8dce7231aacabdf0b61b8c6ddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136349Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756503}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0d8e8366806d..d0b14303be0d Created with: gclient setdep -r src-internal@d0b14303be0d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1055614,chromium:1060280,chromium:912681 Tbr: jbudorick@google.com Change-Id: I5ebd97179c51e5ec5ac91e36b77b7c57425b06c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136369Reviewed-by:
-
Changwan Ryu authored
1) Move WebServer instantiation and shutdown into setUp() and tearDown() 2) UMATestHelper to have mWebServer 3) Move field block to the beginning of UMATestHelper 4) Reformatting due to git cl format This makes the test more readable at the expense of doing additional WebServer setUp/shutDown for a couple of test cases. Otherwise, there is no other logic change. Bug: 1065160 Test: AwAutofillTest test time remains the same. Doesn't seem to add new test flakiness. Change-Id: Ideb659a20b4fb9bf998f8701c8ee6a8e182c9aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128985 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#756501}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/96c26c681bc7..1c95795f1fb3 git log 96c26c681bc7..1c95795f1fb3 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 jmadill@chromium.org Use ImageIndex in ensureSubImageInitialized. 2020-04-03 jmadill@chromium.org Track rendering feedback loops by-context. Created with: gclient setdep -r src/third_party/angle@1c95795f1fb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ide1d7e0799e8fe4d9cf195b9e24c9a9c2d52a719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136367Reviewed-by:
-
rbpotter authored
These imports were being used to ensure the elements were imported for tests while the parent elements that would normally be responsible for the imports were still being migrated. Now that all of settings has been migrated, delete the extra imports. Bug: 1026426 Change-Id: Ideb6f9646a5ac9e85916562d3580191b6cf042a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136029Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756499}
-
Xiaohan Wang authored
It's currently set to false by default and there's no bot setting it. It was used in manual testing but hasn't been used for a long time. This CL removes this gn arg. Bug: 1067786 Change-Id: Idf7c57898f335b10441eb32e1509b2bee25c5368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136310Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756498}
-
Esmael El-Moslimany authored
- Add backend support for selecting an image, selecting a collection for daily refresh and selecting no background - Implement the logic to maintain a consistent state for applying background selection as well as canceling. Follow-up CLs will include selecting an image, selecting no background and previewing the unapplied selection. Bug: 1032328, 990963 Change-Id: I4c4d1a47d67f2fb6cae5735bc7848f61b1c192ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119206Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756497}
-
Oksana Zhuravlova authored
This change removes ContentBrowserClient::BindInterfaceRequestFromFrame() overrides from AwContentBrowserClient and ChromeContentBrowserClient. This will allow us to remove ContentBrowserClient::BindInterfaceRequestFromFrame() in a follow-up CL. Bug: 1062403 Change-Id: Ic5c52f4e76fe964d547f24386366f5e3ac59f398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134927Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756496}
-
Matthew Porter authored
Removed SetImageFromVectorIcon as that function is no longer used. Also removed a not needed function off the #include statements Bug: 1056948 Change-Id: I4bb8a3146455d45bee24ef911aed7d3bb4f60cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133549 Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756495}
-
Andres Calderon Jaramillo authored
CL:2122484 overrode ProvidePictureBuffersWithVisibleRect() in VdaVideoDecoder in order to fix an issue where the coded size of a VideoFrame was not being advertised correctly to the client. This fix must also be applied to GpuVideoDecodeAccelerator. Otherwise, an AssignPictureBuffers() call can fail due to the validation in [1]. This CL makes the default implementation of ProvidePictureBuffersWithVisibleRect() behave as in VdaVideoDecoder. However, it only does so when the texture target is GL_TEXTURE_EXTERNAL_OES; otherwise, it uses the same implementation as before. In order to test, I adapted the video_decode example that comes with the Native Client SDK to use a 1920x1080 video which triggers this problem. Before this CL, no video would be rendered and we would get validation errors from [1]. After this CL, no errors are observed in the logs and the video is rendered. I tested this across multiple devices. Kukui is the only one that failed (Native Client says it's a crash) but this happens even before CL:2122484, so it's not a regression caused by the series of fixes for the referenced bug. Nyan_kitty shows a small white artifact on the bottom that will need to be addressed later. The test results are in [2]. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc;l=1275-1286;drc=2b1b0cc6e2fa7c34965c39caa561e28e9e831626?originalUrl=https:%2F%2Fcs.chromium.org%2F [2] https://drive.google.com/open?id=1ErWDq9bd3ZnLnPU3uhlGQ2zV6zJw7wyT Bug: 1062002,1067794 Test: kevin, kukui, eve, hana, nyan_kitty with procedure described above. Change-Id: I0177f63ab7d19ca196646a017ee532880ec555fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134417 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#756494}
-
Xida Chen authored
This CL adds a new throughput test story, to test the cases where the main thread is extremely jank, and that the throughput can be 0. Bug: 1048187 Change-Id: Ifdd44d165652489de8b41965921801894fba86f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134929Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756493}
-
Klaus Weidner authored
This is a workaround for an issue where the WebXR framebuffer content is displayed out of order, leading to jumpy animations and other glitches. Until the root cause is identified, disable shared buffer frame transfer, and instead use the Mailbox+Surface path. This was originally intended for use on Android N which doesn't support AHardwareBuffer, and is less efficient due to needing an extra pixel copy, but the APIs are still supported on current Android versions. Bug: 1067795 Change-Id: I256f878836eeac201934392ec6ce79f9f2fd7c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135957Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#756492}
-
Arthur Wang authored
R=hypan@chromium.org, jbudorick@chromium.org Bug: 1066503 Change-Id: I8bc1617f7ed2c2ff0b194114e5fe981075145e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135130Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b70ef7756a4d..0d8e8366806d Created with: gclient setdep -r src-internal@0d8e8366806d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1055164,chromium:912681 Tbr: jbudorick@google.com Change-Id: I00debdd0758a059f282be542087895439f18c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136271Reviewed-by:
-
Wan-Teh Chang authored
Change-Id: I7572d81f261f1f7277ec1d1fc8bf9d089174f411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134784Reviewed-by:
-
Dan Harrington authored
Added more events we'll need for metrics. Trying to organize and name these all 'Report*' to make it clear they don't have side-effects other than for reporting metrics. Bug: 1044139 Change-Id: I57931817550ae52f91df4fd10b359575efec5e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135873 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#756488}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/63f96a1f9b5e..ad392d71ebed $ git log 63f96a1f9..ad392d71e --date=short --no-merges --format='%ad %ae %s' 2020-04-03 code CI: Remove port number from registry URL 2020-04-03 code CI: style: Allow the name 'David' in connection with copyright 2020-04-03 code CI: Add debug messages to style checks 2020-04-03 victorien x86: add some explanatory comment to wiener_filter_h 2020-04-03 wtc Look up __pthread_get_minstack only in glibc 2020-04-03 wtc Update a stale comment for dav1d_alloc_aligned() 2020-04-02 martin x86: mc: Skip checks for zero leftext/rightext within the need_left_ext/need_right_ext blocks 2020-04-01 rsbultje Skip loop restoration cache buffer resize for too-small buffers 2020-03-29 rsbultje x86: add SSSE3 versions for filmgrain.fguv_32x32xn[422/444] 2020-03-30 rsbultje x86: use btc instead of xor+test or 32byte alignment in fgy_32x32xn_ssse3 2020-03-28 rsbultje x86: add AVX2 versions for filmgrain.fguv_32x32xn[422/444] 2020-04-01 rsbultje x86: use btc instead of xor+test in fgy_32x32xn_avx2 2020-03-31 gramner Align dav1d_resize_filter[] 2020-03-31 rsbultje x86: don't use vptest in SSSE3 version 2020-03-30 rsbultje x86: add SSSE3 version of mc.resize() 2020-03-27 rsbultje x86: add AVX2 version of mc.resize() 2020-03-26 rsbultje checkasm: add test for mc.resize() 2020-03-27 rsbultje Invert src_w/h argument in mc.resize() 2020-03-27 rsbultje Make dav1d_resize_filter[] negative so it fits in int8_t Created with: roll-dep src/third_party/dav1d/libdav1d Change-Id: Ieb08bddc67521175b5297ef0326700cdab132cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135897 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756487}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Since there was already a similar test already in WPT, this CL also renames it adding the -001 suffix to it, so that we can consistently add this new one as a -002 one. Bug: 1063749 Change-Id: Ibb6f0ef3783cf9805e339f70b0e7616369cbc752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133936Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/36e67aa86981..2eb4bd46bdb8 git log 36e67aa86981..2eb4bd46bdb8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 egdaniel@google.com Fix some d3d ref counting. Created with: gclient setdep -r src/third_party/skia@2eb4bd46bdb8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I2696b2c1dee1cce34e8208afeedbfae531c1502e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136202Reviewed-by:
-
Jian Li authored
ListContentManagerImpl supports both native view and external view. The methods defined in feed/v2/FeedActionHandler has been merged to xsurface/FeedActionsHandler, except navigate* methods that are already included in xsurface/SurfaceActionHandler. Bug: 1044139 Change-Id: Ic708a1295e2a0e6700f5b72195940a8bd365c76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133110 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756484}
-
Pavel Yatsuk authored
Test fails to receive callback about url focus change. Screenshots indicate that url bar didn't get focused. I suspect that OmniboxTestUtils.toggleUrlBarFocus logic to tap in the middle of the view doesn't correctly focus urlbar in some cases. If that's the case then directly calling urlBar.requestFocus() would work better for this test. This CL adds check to see if urlbar got focused. BUG=812066 R=twellington@chromium.org Change-Id: I9b120fa6cb2cf68b95a34f1e08c4143bf6e5787a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136060 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756483}
-
