- 12 Aug, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597233486-9b99859a3e8f91576b2a111cc083e1a4b72a89f4.profdata to chrome-mac-master-1597255086-4c97f40f3099850ce4002243596e1c9e8589ecba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fc218658384d9edc07f652faf21f03feabeafb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353098Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797420}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4ca4974. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I281db5ed18dfbe4a1afafff4ec819432772b4d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353170Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797419}
-
Meilin Wang authored
Please see screenshot in the linked bug. Bug: b/161481195 Test: manually. Change-Id: Ie276b743b122d447cc658dfff6e72476122aef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336493 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797418}
-
Brian Malcolm authored
This is intended to replace the NativePrinters policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. NOPRESUBMIT=true BUG=chromium:1113362 Change-Id: I3d0616d9f414fa391be24d71780513df86e2a5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340363 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797417}
-
Kyle Horimoto authored
This class will implement the core functionality for Phone Hub. Currently, it simply instantiates an instance of FeatureStatusProviderImpl. Additionally, we provide a static Get() function to be called by //ash in ash::Shell::OnFirstSessionStarted() to get access to Phone Hub without taking a dependency on //chrome (which is not allowed). Bug: 1106937 Change-Id: I980237970349dc3b0ec47b0d144a59680c1c14bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350024 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797416}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/75a11031..9e3426eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I990d5ee5366bfa63ee7fcd321142cb608b38fbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352756Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797415}
-
Daniel McArdle authored
This is a speculative fix for https://crbug.com/1114334. Logs attached to crash reports indicate that the KeyChainAliasCallback is being invoked twice. Specifically, "No client certificate selected" appears twice in the log, and in one instance we see them appear within 1ms of each other. It's possible that Chrome's maybeShowCertSelection is accidentally invoking the callback one of those times, or that Android's KeyChain framework is double-invoking the callback. The docs do not specify how many times the callback may be invoked. This CL also switches logging to org.chromium.base.Log and limits the TAG to 20 characters, as required by presubmits. Bug: 1114334 Change-Id: I3e5e1f318f579b0b7a4521f058ba1f0a7224c487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344624 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#797414}
-
Xianzhu Wang authored
This is to cover the future cases of backdrop effects without needing a new enum value. Also add the value into histograms/enums.xml Bug: 1115564 Change-Id: I1d190d78186a55f93aa208af3a7f6c3015e9b09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352552Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797413}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I31fa2fa16ecb83f82c193e052142b63cc3dec752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351381Reviewed-by:
-
Chris Palmer authored
Fall back to reading from urandom only when that fails. Bug: 995996 Change-Id: I0a357dc39c6b2081eda749e770168e592eaa458b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353190Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797411}
-
Xida Chen authored
This CL removes code that is related to an expired flag: touch-events. No behavior change is expected. Bug: 1110731 Change-Id: I5e94c60415941edc92330d01054e752b0f111009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352765 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#797410}
-
Gang Wu authored
managed by menu item should be setVibility(View.VISIBLE) and setEnabled(false) when shows up. App menu should be kept open after disabled item has been clicked. Previously click on the item will close the app menu. This CL also fixes TalkBack announcing "disabled" for the item. Bug: 997053 Change-Id: I4442bd889c30b850c7287869054a3beff2455b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351419Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797409}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09afd88dfed8..dfa133b7b48c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaf0f7565830362fdc1c9012a689e25f32ca713a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352760Reviewed-by:
-
Chris Sharp authored
Include the min and max values already specified in the policy descriptions and in the code handling the policies. The limits for the PolicyRefreshRate policy are specified in components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc. The limits for the MaxInvalidationFetchDelay policy are specified in chrome/browser/policy/cloud/cloud_policy_invalidator.cc. BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, they just were missing from the schema Change-Id: Ia1b3904dd1f377d5bc1ee7c2742f3eaeb3f34969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349211 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#797407}
-
Marijn Kruisselbrink authored
This gets rid of the redundant ConfirmDirectoryReadAccess method, and instead just requests read access on the corresponding permission grant instead. In the future this will make it easier to support a single prompt for getting access to a writable directory, instead of the current two separate prompts. To do this, also adds an extra flag to the NFSPermissionGrant::RequestPermission method to indicate if this particular permission requests requires user activation. Bug: 1115632 Change-Id: Ie3980867d162e16723569a0fd36f27323d2700ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341214Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#797406}
-
Yuke Liao authored
In order to promote unit_tests, extensions_unittests and views_unittests to be sheriffed to prevent regressions. Bug: 1111979 Change-Id: Ib326e7eb0d3b54fc58119fd702d8702d48d46973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353152Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#797405}
-
Corentin Wallez authored
Following the PSA for API deprecations, the following are removed: - GPUTextureDescriptor.arrayLayerCount - GPUTextureCopyView.arrayLayer - GPUBuffer.setSubData Also updates a couple uses of the deprecated WGPUBufferCopyView members. Bug: dawn:22 Change-Id: If826f85a42cb9c713bb958ef29a512b8583e3f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351970Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#797404}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008120800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/yzqZBKPmH-7JzPqoGRyX5xzi_i8ljeOuLly8tsBta8YC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I62e12077672a19e4242d54477912e10d8ead1a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352365Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797403}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b60e067b4374..d253278f9865 2020-08-12 johnkslang@users.noreply.github.com Merge pull request #2370 from alan-baker/update-tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ynovikov@google.com Change-Id: I12df79c5d3c83a30910728fdbeb7eabc5853e1fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353129Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fc2bd2179672..2b36c8eb3e1c 2020-08-12 patrick.brosset@microsoft.com Remove the previewed class when pressing Escape in the .cls pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114726 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I701c748e0343ad1517e004c701f647478e106af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353094Reviewed-by:
-
Tommy Martino authored
Change-Id: I93a77f3be4ff44dd95f5ee7e8e176f44ae312758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353109Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797400}
-
James Long authored
Instead of displaying below the "general details" section, the class and package-specific node details have now been moved up and placed in the same list layout as the general details, making the panel more uniform. Icons have also been added beside all links, the same as the favicon for the page, to indicate that the links take you to a different graph. Bug: 1102546 Change-Id: Ib05b35b7108685dad3cb5f0a87841302fa061e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349983 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#797399}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f7f46a7432a9..00fcb720bc39 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC szager@google.com,smcgruer@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: szager@google.com,smcgruer@google.com Change-Id: Idd24a57863d844e753e44264b3136a974befbd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351378Reviewed-by:
-
Sonny Sasaka authored
The battery client should be initialized only when the show-bluetooth-device-battery flag is enabled. Bug: b:160905767 Change-Id: Iaa8532554085d902740766767ed65177265e557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341824 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#797397}
-
Alex Keng authored
This CL changes the return value of TSFBridge::Initialize from void to HRESULT and refactors the logics in TSFTextStore::TSFTextStore out to TSFTextStore::Initialize. The HRESULTs of various COM calls during TSF initialization are propagated so the caller can handle errors, if any, accordingly. Note at the moment upstream doesn't have any use case for the HRESULT, but downstream will use the value for WebView2 initialization, ex. handling errors due to creating CLSID_TF_CategoryMgr instance in a thread initialized with COM_MTA (while all TSF functions expect STA) Change-Id: I227000a594f203eecc37838ff877d3dcd077df2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340543 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#797396}
-
John Williams authored
Change-Id: I9edc1a14022d1393fc6fa61afafddcdb944edfa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348412Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797395}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09afd88dfed8..dfa133b7b48c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If86b511849d143ff9950245f2f2bcda630dd9ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351122Reviewed-by:
-
dizg authored
Bug: 1115056 Change-Id: I46e9750b9755e2ee62b3e3974b0ff6663d00de41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346354 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#797393}
-
Chris Hamilton authored
This migrates our code to use the recently added blink token types rather than our own equivalent types. Change-Id: I02fa92bef1c4906595ae7d526909e41ad93b3294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341221 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#797392}
-
Aya ElAttar authored
- This CL is based on dpapapd@ comments on crrev.com/c/2098906 - Moved ChromeURLDisabledUI to a separate folder under webui/chromeos directory. Change-Id: I17a3ab761b91a05af00d6c6db5e9d857d7ba488b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349708Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797391}
-
Ilya Nikolaevskiy authored
Bug: chromium:1112391 Change-Id: Ic02acc66b236d6f376e8593c490066c61c7eff0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351830 Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797390}
-
Chris Harrelson authored
When this flag is on, we will use GeometryMapper for overlap testing and squashing sparsity tests. This code will be rolled out via a Finch experiment in order to estimate its impact on performance. Bug: 1115577 Change-Id: I42d29d1e25d8d4df9ea1410af3203342c3242040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343675 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797389}
-
Swapnil authored
When the browser is shutdown, we start destroying the objects. In ExtensionInstallEventLogManger, we used to destroy |logger_| after the |extension_log_upload_| pointer. This could cause to a crash because we try add a LOGOUT event before the shutdown. And while adding the LOGOUT event, ExtensionInstallEventLogManager::Add method is invoked which posts a task to invoke InstallEventLogManagerBase::LogUpload::OnLogChange. Thus we should destroy the |extension_log_upload_| pointer after destroying the |logger_| pointer so that we add the LOGOUT event and prevent the crash. Similarly, this should be fixed for ARC++ reporting. Bug: 1114191 Change-Id: I6e88f5747b6a5b7a36e1dcee3083204833c9aeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346306Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Removes the special casing that was recently added to the GPU context loss pixel tests, as we have confirmed that the tests otherwise pass if not for the expected crash check. Bug: 1061298 Change-Id: I00ec5ec7034a68025b505a28f69c852ad304de7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353049 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#797387}
-
Bo Liu authored
RenderProcessHost::Shutdown does not go through fast shutdown, but does go through RenderProcessHostImpl::ProcessDied. This ends up being recorded as out of memory kill on Android. Add RenderProcessHost::ShutdownRequested, and plumb it to where ProcessedCrashCounts is recorded. Then record a count of how much this would affect the OOM metric if it's taken into account. Bug: 1115517 Change-Id: I43ac22e4dfcc2ff0c23423355817420b2a5aa5be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351170Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797386}
-
Becca Hughes authored
Change-Id: I63b64b85cd4c9b42bef2a3f1518d79d573e9131f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352514Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797385}
-
Becca Hughes authored
BUG=1053599 Change-Id: I9dbe1a011579fb3e7f8cf9b99a85b97bda5bb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341935 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#797384}
-
Peter Kasting authored
No intended behavior change. Not a complete list, just changing a few places I was already touching. Bug: none Change-Id: I53b652722671366803a5e6b76fec7b1c41c3cc86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345509 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797383}
-
James Hawkins authored
Networking components have a lot of dependencies that need to be in place for testing, so use internet-config-dialog as the host instead of OS Settings. Note that ideally this would not be required for testing, but with Polymer2 going away soon, it's not worth building more infra to support this case. R=khorimoto@chromium.org Bug: none Test: none Change-Id: I06ca337eb0c18e362d91d8ddee81ffe2707dd0b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352551Reviewed-by:
-
Xinghui Lu authored
Bug: 1097310 Change-Id: Iac117bddb711cbd493c05e8a86a40ca8d00f0130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353090Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797381}
-
