GitLab

In rare cases on OS X with in-process-gpu and zero-copy disabled,
rendering deadlocks can be triggered when a brokered attachment
arrives before the channel reader registers itself as an observer
of the attachment broker.

This patch simply replays unhandled attachment for new observers,
giving them a chance at handling attachments received before they
registered. This is safe since attachments already have unique ids.

BUG=584201
R=erikchen@chromium.org

Review URL: https://codereview.chromium.org/1810503002

Cr-Commit-Position: refs/heads/master@{#381691}

Remove some dead const variables flagged as such by clang (instead
of deactivating the compiler warning as the change was simple).

TBR=rohitrao@chromium.org
BUG=594519

Review URL: https://codereview.chromium.org/1797253002

Cr-Commit-Position: refs/heads/master@{#381690}

https://chromium.googlesource.com/chromium/src/+/73a59b847

BUG=595491
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/1807783004 .

Cr-Commit-Position: refs/heads/master@{#381689}

Ideally we want to remove the fallback ticking of webview entirely, but
in the interim we should move it to the compositor thread in order to
avoid the sync IPC for the software draw as well as the shared memory
allocation.

BUG=431166

Review URL: https://codereview.chromium.org/1782093002

Cr-Commit-Position: refs/heads/master@{#381688}

Add third_party/class-dump/BUILD.gn to build class-dump as a host tool as
part of the iOS build.

Create a template "class_dump" (in third_party/class-dump/class-dump.gni)
to simplify the execution of the class-dump tool on given framework. This
required converting testing/iossim/redirect-stdout.sh to a python script
as gn can only invokes python script.

TBR=rohitrao@chromium.org
BUG=594519

Review URL: https://codereview.chromium.org/1806523002

Cr-Commit-Position: refs/heads/master@{#381687}

Add a new config //build/config/compiler:enable_arc that adds the
required flag to enable ARC (automatic reference counting).

BUG=594519

Review URL: https://codereview.chromium.org/1806513002

Cr-Commit-Position: refs/heads/master@{#381686}

This didn't work because isStartOfParagraph(endOfInsertedContent) was true and
<br> wasn't added.

This CL moves HTMLTextFormControlElement handling code earlier, and makes it
cover this case.

BUG=380471

Review URL: https://codereview.chromium.org/1809033002

Cr-Commit-Position: refs/heads/master@{#381685}

In SDK, it is WebKit.framework/Versions/A/Headers/WebKit.h.
Use the same case, so that it would work on case sensitive filesystem.

Review URL: https://codereview.chromium.org/1801363004

Cr-Commit-Position: refs/heads/master@{#381684}

Previously, we incorrectly split CSS composite faces into multiple faces
for shaping, one for each comma-separated entry of unicode-range:. This
breaks shaping of ligatures and other features when the characters that
ought to be shaped combined were in different unicode-range entries. It
is also inefficient for subsetted web fonts that use unicode-range:
extensively, for example Google Fonts and Adobe TypeKit.

The fix is to transfer the UnicodeRangeSet information from CSSFontFace
to HarfBuzzFace and only restrict the glyph lookup function to the whole
unicode-range information, instead of restricting it to a single entry
and shaping multiple times with the same face. This should have a slight
performance benefit as well.

BUG=583450
TEST=fast/css/font-face-unicode-range-ligatures.html
R=eae, behdad

Review URL: https://codereview.chromium.org/1806653002

Cr-Commit-Position: refs/heads/master@{#381683}

This ensure that the files required by ui_base_unittests and
gfx_unittests application will be copied into the application
bundles on iOS.

BUG=297668

Review URL: https://codereview.chromium.org/1806033002

Cr-Commit-Position: refs/heads/master@{#381682}

WebRTC 12013:12025

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/addc0e6..4ac195e

Libjingle 12009:12020

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/a63b848..75c1fc7

TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/1809023002

Cr-Commit-Position: refs/heads/master@{#381681}

ListHashSet::add() and similar used to return an AddResult value
containing a pointer to ListHashSetNode, instead of an actual value
specified by the user. This is unintuitive, and the users are forced to
append "->m_value" to obtain a pointer to the object they've really
added.

This patch fixes this issue, and giving what the users usually expect.

Interestingly, no production code (outside of tests) made use of
storedValue. LinkedHashSet did not have this issue.

BUG=582349

Review URL: https://codereview.chromium.org/1813693002

Cr-Commit-Position: refs/heads/master@{#381680}

BUG=496258

Review URL: https://codereview.chromium.org/1807663002

Cr-Commit-Position: refs/heads/master@{#381679}

BUG=webrtc:5426

Review URL: https://codereview.chromium.org/1809623002

Cr-Commit-Position: refs/heads/master@{#381678}

LayoutTests/editing/selection/
 move-by-character-001.html
 move-by-character-002.html
 move-by-character-003.html
 move-by-character-004.html
 move-by-character-005.html
 move-by-character-6.html
 move-by-character-brute-force.html
 move-by-character-crash-test-textarea.html

This CL also moves them to editing/selection/modify_move

BUG=

Review URL: https://codereview.chromium.org/1809963002

Cr-Commit-Position: refs/heads/master@{#381677}

This patch includes U+FE50-FE6F Small Form Variants[1] in
isCJKIdeographOrSymbol(). These code points are compatibility variants
for the CNS (Chinese National Standards) 11643 character set.

[1] http://www.unicode.org/charts/PDF/UFE50.pdf

BUG=587325

Review URL: https://codereview.chromium.org/1805673004

Cr-Commit-Position: refs/heads/master@{#381676}

ContentViewCore holds a window pointer that is used during
destruction of native AwContents to remove observers. However the
current CleanupReference based finalization scheme does not enforce
an ordering on the destruction of native WindowAndroid and AwContents
instances. Satisfaction of the constraint that AwContents is destroyed
before WindowAndroid is therefore dependent on the CleanupReference
implementation, and possibly the implementation of the JVM as well.

Making the AwContents DestroyRunnable strongly reference the
associated WindowAndroidWrapper enforces the correct ordering.

BUG=595336

Review URL: https://codereview.chromium.org/1809643002

Cr-Commit-Position: refs/heads/master@{#381675}

Remove the following channels:
 - BackForward
 - Editing
 - Events
 - Frames
 - FTP
 - History
 - IconDatabase
 - Loading
 - PlatformLeaks
 - PopupBlocking
 - Progress
 - SpellingAndGrammar
 - LiveConnect
 - Threading
 - Compositing
 - Gamepad
 - ScriptedAnimationController

They are unused.

Review URL: https://codereview.chromium.org/1811883002

Cr-Commit-Position: refs/heads/master@{#381674}

Use w3c testharness in
LayoutTests/editing/selection/
 extend-by-character-001.html
 extend-by-character-002.html
 extend-by-character-003.html
 extend-by-character-004.html
 extend-by-character-005.html
 extend-by-word-001.html

BUG=

Review URL: https://codereview.chromium.org/1798413003

Cr-Commit-Position: refs/heads/master@{#381673}

BUG=274045

Review URL: https://codereview.chromium.org/1789593002

Cr-Commit-Position: refs/heads/master@{#381672}

When there is an IME extension listening on input.ime.onKeyEvent, the key event will be passed to the extension before the OS handling it, and  ProcessKeyEventDone() will be called after the extension calls input.ime.keyEventHandled.

When users texting fast, the callback method of ProcessKeyEventDone() may be excused in different orders. The current implementation has bugs as the variables in system such as |composition_changed_| and |result_text_| will be changed when input.ime.keyEventHandled trys to run the callback.

This bug only occurs on Linux as there are two keydown/keyup events generated when pressing/releasing the key and only one event is passed to the extension.

This CL fixes this bug by adding helper function ProcessKeyEventByEngineDone() in InputMethodAuraLinux to recover the passed environment.

BUG=517773
TEST=None

Review URL: https://codereview.chromium.org/1801363005

Cr-Commit-Position: refs/heads/master@{#381671}

The compilation was broken due to crrev.com/381594

BUG=none
TBR=paulirish, pfeldman

Review URL: https://codereview.chromium.org/1814743002

Cr-Commit-Position: refs/heads/master@{#381670}

textarea-paste-newline.html used dumpAsText() without js-test.js.
This CL has no behaivor changes.
This is a preparation of crbug.com/380471.

BUG=380471

Review URL: https://codereview.chromium.org/1807123002

Cr-Commit-Position: refs/heads/master@{#381669}

Rewrite white-space property for contenteditable=plaintext-only elements as:
    normal   -> pre-wrap
    nowrap   -> pre
    pre-line -> pre-wrap
because whitespace collapsing doesn't make sense in plain-text editing.
The new behavior matches to Microsoft Edge for TEXTAREA.

BUG=595491

Review URL: https://codereview.chromium.org/1813663002

Cr-Commit-Position: refs/heads/master@{#381668}

Cr-Commit-Position: refs/heads/master@{#381667}

There's no pointers to what GN is or how to set it up from this document
despite there being references to using it. This change adds the
GN Quick Start Guide to the Advanced Features section.

Review URL: https://codereview.chromium.org/1806213002

Cr-Commit-Position: refs/heads/master@{#381666}

BUG=none
R=horo

Review URL: https://codereview.chromium.org/1810453002

Cr-Commit-Position: refs/heads/master@{#381665}

BUG=589698

Review URL: https://codereview.chromium.org/1800823002

Cr-Commit-Position: refs/heads/master@{#381664}

It was a dumpAsText() test without js-test.js.
This CL has no behavior changes.

Review URL: https://codereview.chromium.org/1813583002

Cr-Commit-Position: refs/heads/master@{#381663}

The Material Design history flag (#enable-md-history) uses the old-style
UI with only an enable/disable button. It should have a drop-down with
"Default", "Enable", "Disable" like all new feature flags.

BUG=586340

Review URL: https://codereview.chromium.org/1766273002

Cr-Commit-Position: refs/heads/master@{#381662}

It is useless with new Animation system.

BUG=575041

Review URL: https://codereview.chromium.org/1810853002

Cr-Commit-Position: refs/heads/master@{#381661}

BUG=

Review URL: https://codereview.chromium.org/1810713002

Cr-Commit-Position: refs/heads/master@{#381660}

R=isherman@chromium.org
BUG=none
TEST=`git grep md-downloads`

Review URL: https://codereview.chromium.org/1805273002

Cr-Commit-Position: refs/heads/master@{#381659}

Also use the platform-specific color in CommonThemePaintMenuItemBackground

This should fix a regression introduced by ff6ab32f

BUG=570698

Review URL: https://codereview.chromium.org/1797053002

Cr-Commit-Position: refs/heads/master@{#381658}

Previous isTreatedAsStackingContext is confusing because besides
positioned elements we also treats some other elements as "pseudo
stacking contexts" (see ObjectPainter::paintPseudoStackingContext()
==> renamed to ObjectPainter::paintAllPhasesAtomically()).

The actual difference between elements "isTreatedAsStackingContext" and
other pseudo stacking contexts is that the former are treated as
"z-index:0" so are stacked in the containing stacking context.

Then isTreatedAsOrStackingContext() is to check if the element should
be stacked, so rename it to isStacked().

Added a chapter in Source/core/paint/README.md to explain how we understand
and use the concepts.

Also avoid "pseudo stacking context". Rename
ObjectPainter::paintPseudoStackingContext() to
ObjectPainter::paintAllPhasesAtomically().

Review URL: https://codereview.chromium.org/1798263002

Cr-Commit-Position: refs/heads/master@{#381657}

Grab the current time in various formats so we can compare how long it's
been since the last ack.

Also use QueryUnbiasedInterruptTime to determine whether the computer
has been suspended recently.

BUG=588342

Review URL: https://codereview.chromium.org/1804303002

Cr-Commit-Position: refs/heads/master@{#381656}

BUG=496258

Review URL: https://codereview.chromium.org/1809863002

Cr-Commit-Position: refs/heads/master@{#381655}

BUG=none

Review URL: https://codereview.chromium.org/1808943002

Cr-Commit-Position: refs/heads/master@{#381654}

Cr-Commit-Position: refs/heads/master@{#381653}

This is needed to allow building with the N preview SDK.

BUG=595525,595522

Review URL: https://codereview.chromium.org/1808073002

Cr-Commit-Position: refs/heads/master@{#381652}