- 02 Mar, 2020 40 commits
-
-
Jinsuk Kim authored
Extends the experiments to M85 so the flag options will be visible. Change-Id: I4643b2dcc0167af9a6e9ad2d0a85ec7ae1d027f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081715 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#746148}
-
Thomas Guilbert authored
Despite hand coded test values, the difference between base::TimeTicks::Now() and the Document's origin time can result in times aligned with a 5 microseconds clock. This is a test failure, because we don't know whether or not the time values were successfully clamped. This CL uses the reference monotonic time instead of base::TimeTicks::Now() when initializing the test values, which guarantees deterministic results. Bug: 1057319 Change-Id: I26ee485545a75ba25bc2e9187e78f032fce767e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083737Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#746147}
-
shrekshao authored
Tested on Pixel 3 XL (with HDR support) (validating) and Nexus 5X (without HDR support)(validating/passthrough) with up-to-date WebGL ASTC test. Not tested with passthrough angle on Pixel 3 XL due to the build config and cmd line settings for passthrough angle not work properly locally (reported to Geoff). But given that angle exposes the extension with the same name as OpenGL it should be fine. Bug: 1049880 Change-Id: Iadc1a78591068927bbed9523131924187f53fe3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080823 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746146}
-
Wenyu Fu authored
Use criteria helper to wait desire state of UI to reduce flakiness. Bug: 1056985 Change-Id: I8883722a62120cc4228e2fd5d7c3abc8b3ca071d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080470 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746145}
-
Sergey Ulanov authored
ApplicationControllerReceiver protocol is being replaced ApplicationContext. This CL updates CastRunner to use ApplicationContext instead of ApplicationControllerReceiver. Bug: 1028409 Change-Id: I7679ba3238754e994bf9fcc2bec1a30ddcd75389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079808 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746144}
-
Brandon Wylie authored
Bug: 1015174 Change-Id: I356619e74745a31ebd0aef46f64977a025dd099b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078978 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#746143}
-
Raymond Toy authored
In DeferredTaskHandler::BreakConnections, we want to remove finished handlers and break the connection. when a finished handler is removed from active_source_handlers_, it might be deleted, but we were still using that to create the connection. Instead, break the connection first and then remove it. Manually ran test from the bug and it passes with this change. Without this, it failed right away. Bug: 1057593 Change-Id: I3c9346a6842f412100d608876adb268befb80470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083436 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#746142}
-
Gang Wu authored
This reverts commit d9deeea6. Reason for revert: compile error on ios-device build https://ci.chromium.org/p/chromium/builders/ci/ios-device/150149 Original change's description: > Update Crashpad to 11b8eb10d4ad6ed50ee43d3bb50d13967d638dfa > > 9ed829054711 Bring up skeleton crashpad_client_ios > 22701bb0e448 fuchsia: Use zx_system_get_version_string > f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test > 0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump > d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad > 8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file > 11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING() > macro > > Change-Id: I5f0ba09aae2fcd1a8b91543f91a94ffe093f16b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083654 > Commit-Queue: Mark Mentovai <mark@chromium.org> > Reviewed-by: Joshua Peraza <jperaza@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746133} TBR=thakis@chromium.org,jperaza@chromium.org,mark@chromium.org Change-Id: I48cc6cb41ab563964f50fa02cf3a7570c820a059 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083933Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746141}
-
Mike Reed authored
Bug: skia:9984 Change-Id: I119ce10adcf14000d2f706f7c947f3c3f1da68a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083599Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#746140}
-
Tricia Crichton authored
Prior to complete removal planned for m84, the LaunchApp command will be rejected. As a temporary workaround, a new capability is added to give access to LaunchApp when requested by users. Bug: chromedriver:1778 Change-Id: I93f9aab5fca4593032b5876ddf2fbb52e50c7335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080782Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#746139}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4044.25-1582542147-benchmark-82.0.4072.0-r1 to 82-4044.31-1583145468-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibeba5967bda1115a7d3dc80e2aaabbdc64f53340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746138}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I1496ecb101aff65a24a4471eebe8dcb09ca3e6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083343Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746137}
-
Piotr Bialecki authored
Part 2/2. Previous work: https://crrev.com/c/2067538 Changes: - XRInputSourceDescription now carries additional boolean signifying whether an input source is primary or auxiliary. Additionally, added comment explaining current situation around input source ID reuse. - ArCoreGl now propagates the input source information for non-primary input sources as well. - XRInputSource ignores auxiliary input sources for the purposes of WebXR events. - XRSession ignores auxiliary input sources when determining whether onbeforexrevent will be raised. - Debugging: debug-sources.js now keeps track of input sources by assigning a number to each of them. The order of input sources in the session's input source array is not guaranteed to be stable. Fixed: 1048329 Change-Id: Ie260151cc34e5b937d0c3e16c4be3e5fa8c44783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072596 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746136}
-
Ian Clelland authored
Byte sequences, previously delimited by asterisks, have changed in Structured Headers draft 15 to use ':' as the delimiter. This CL updates the implementation to be in line with the latest draft, while keeping backwards compatiblity with draft 9 for existing uses. Bug: 1048755 Change-Id: I1e8684a016085573ab6815bb078c8f7f3a41870e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073537 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#746135}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.15-1582543985-benchmark-82.0.4072.0-r1 to 82-4044.31-1583147204-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I5c6a1aa96c5a46a63e2fb8fc305401708de73829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083914Reviewed-by:
-
Mark Mentovai authored
9ed829054711 Bring up skeleton crashpad_client_ios 22701bb0e448 fuchsia: Use zx_system_get_version_string f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test 0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad 8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file 11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING() macro Change-Id: I5f0ba09aae2fcd1a8b91543f91a94ffe093f16b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083654 Commit-Queue: Mark Mentovai <mark@chromium.org> Reviewed-by:Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746133}
-
Luciano Pacheco authored
Initial re-style for file grid, updates the size, spaces and some colors in the file grid. Some styles are shared between file list and file grid and also previous look'n'feel and the new one, so CSS selectors are hard to overwrite for new look'n'feel in the file grid. Add":not(files-ng)" to the icon selector to simplify the issue and add "#list-container list" when the rule should apply only to file list. Add a new test: add file-ng flag showGridViewDownloads Test: browser_tests --gtest_filter="*showGridViewDownloads*" Bug: 992822 Change-Id: Ia761775207377a3aa94c5fe1762702cc2afbda62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072685 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746132}
-
Xing Liu authored
Disable flaky ConfirmManagedSyncDataDialogIntegrationTest# testDialogIsDismissedWhenRecreated. TBR=bsazonov@chromium.org Bug: 1054855 Change-Id: If4303f12d5aec847b7a2d23392dd7c895e767d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081521Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746131}
-
Moe Ahmadi authored
The PZPS header information is expected in the following format in the Chrome suggest response. Every suggestion with a header has a header group id in its respective "google:suggestdetail" dictionary which maps to a header text inside "google:headertexts>a". ... "google:headertexts":{ "a":{ "40009":"Recommended for you" } }, "google:suggestdetail":[ ... { "zl":40009 }, { "zl":40009 } ], ... This CL parses that information and adds the respective header as a |header| field on the first ACMatch in every group of adjacent matches with the same header, unless: 1) Matches with the same header are not adjacent to one another, i.e., are interleaved by matches with different headers or matches without one. 2) Matches without a header come after the ones with headers. Note that the headers do not determine classification or ranking of the matches. They are expected to be valid after the AutocompleteResult is finalized. These error conditions, however, are in place to safeguard the integrity of the displayed headers. Bug: 1052519 Change-Id: Ibbd3a812690605cd13763e41f109197ef75c1727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079303Reviewed-by:Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746130}
-
chromium-autoroll authored
Roll airmont AFDO profile from 82-4044.25-1582540590-benchmark-82.0.4072.0-r1 to 82-4044.31-1583148634-benchmark-82.0.4072.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I68aad14edb2a7b81af241a78c3232471acdb6eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083854Reviewed-by:
-
Brandon Wylie authored
When new tab pages are reparented, the view isn't loaded completely. New tab pages have their own logic to restore scroll position, which is the only outstanding state that would change between theme change. Bug: 1052246,1055228 Change-Id: I5c7b42f6daecc30a6499bcdf4bc6ded97795afab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067385 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746128}
-
Patrick Noland authored
In this design, the OptionalBrowsingModeButtonController queries individual providers and shows the provider with the highest precedence. Changes of note: - ExperimentalButton has been renamed to OptionalButton. -"enableExperimentalButton" is now "updateOptionalButton" and does not assume that it's starting from a disabled state. We no longer update the drawable in a separate code path. - IdentityDiscController now lives in its own package/directory. - Neither ShareButtonController nor IdentityDiscController need to care about the OverviewModeState - Optional button IPH is triggered by the OptionalBrowsingModeButtonController Bug: 865801 Change-Id: I254d42311bd20104b96c001508767f1f7fe3a4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065308 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Mia Glaese <glamia@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746127}
-
Xianzhu Wang authored
http/tests/input/discard-events-to-unstable-iframe.html http/tests/misc/synthetic-gesture-initiated-in-cross-origin-frame.html http/tests/misc/destroy-middle-click-locked-target-crash.html None of them seems recent regression. TBR=wangxianzhu@chromium.org NOTRY=true Bug: 980969,1057822,1057087 Change-Id: I39863216af0d0b8f24f9b35da0e9f2453d51f52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083931 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746126}
-
yilkal authored
This CL corrects a bug which occurs in the following situation: 1. Chrome and its web apps are active for X(example 1 hour). 2. Chrome is still active when time limit is changed to anywhere in 0 > new_limit < X(above). 3. Observe that other web apps are paused where chrome is not. Bug: 1057724 Change-Id: I1984057fff376e07bf738aaa31e6cc7eb49b5908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083630 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#746125}
-
Kevin McNee authored
promise_rejects_dom and promise_rejects_js are strict about which constructor is being used for the exception. In portals WPTs, we frequently open a new window to run the test as we can't destroy the context the test harness is running in. We now specify which window is producing the expected errors. Bug: 1057783 Change-Id: Ia3b4b55a0a12f0df96fc4bed45cd7c82a97ed5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083826Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#746124}
-
Ben Joyce authored
Bug: 1052460 Change-Id: Ib6d918fd3ab24344ff6b2e30f342801673dd4e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080817Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#746123}
-
Xinghui Lu authored
To make policy_engine build on iOS, replace browser_context with pref_service and is_off_the_record. Bug: 1050859,1028755 Change-Id: I343b1b9f83dc1e69cdb5304d0b64f062120e844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071159 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#746122}
-
Wan-Teh Chang authored
Put MATCHER(ContainsDecoderErrorLog, "") in the unnamed namespace. aom_video_decoder_unittest.cc, dav1d_video_decoder_unittest.cc, and gav1_video_decoder_unittest.cc all have a MATCHER class with this name. Putting them in the unnamed namespace avoids name conflicts. Strangely, the linker did not warn about duplicate symbols. Include <memory> and <utility> in aom_video_decoder_unittest.cc and gav1_video_decoder_unittest.cc. Use the correct base::Bind variants (Repeating or Once) for the OutputCB and DecodeCB callbacks. $ gn args out/Default # In the editor, add the following lines: # enable_libgav1_decoder = true # enable_libaom_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests Tested: Change-Id: I535ba5847717b736074bf7a29ffae1e897fd0acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081243 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
-
David Tseng authored
Some web trees, in particular: rootWebArea iframe ***rootWebArea iframe rootWebArea *** will set its tree->data().focus_id but not either its focus->GetStringAttribute( ax::mojom::StringAttribute::kChildTreeId) nor its tree->data().focused_tree_id The code assumed this more strict interpretation of the data, which appears to not work in this case. The topmost tree directly points to the innermost frame, skipping the frame in-between. Fixed: 1038739 Test: manually on the snippet in the bug. Change-Id: I5174cfcfabeb3bb4606d8636ab0f867d1310e52e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080783Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746120}
-
Michael Chang authored
Bug: 1042224 Change-Id: I165b2ab1d625ceac23c31efd92b5e2db82d722a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079262 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746119}
-
Rakesh Soma authored
to support TOS acceptance feature in previous versions of chrome as well. Bug: 1045536 Change-Id: I7ba5fd35549acf10d5335960bb77c61a7470d484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082111 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Yusuf Sengul <yusufsn@google.com> Auto-Submit: Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746118}
-
Ian Kilpatrick authored
We were inconsistent with how we named the variables, however most of them were pural, e.g. "MinMaxSizes sizes;" This changes: - MinMaxSize -> MinMaxSizes - MinMaxSizeInput -> MinMaxSizesInput - ComputeMinMaxSize -> ComputeMinMaxSizes This should have no behaviour changes. Change-Id: Ib0c352197dd6d5317b908b4037109ec1b459099c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080895Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746117}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 35a1546b. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nsatragno@chromium.org: external/wpt/webauthn NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I87e113530a9b1106b00170ecafe976535872f063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083691Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746116}
-
Dale Curtis authored
a22cc239 moved this section out of UpdateNativeAudioHardwareInfo(), but forgot to bring the lock along. R=guidou Bug: 1043040 Change-Id: I5b17a2cf0ad55d61c0811db1dae7045af4a91370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083814 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746115}
-
Tommy Li authored
This CL enables OmniboxPreserveDefaultMatchAgainstAsyncUpdate by default. This will roll out with M82. Bug: 1021217, 398135 Change-Id: I83b3b542c6cc2d246480388d8f98d9f4ac00535a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082426Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#746114}
-
Scott Violet authored
ComposedBrowserControlsVisibilityDelegate (by way of ObservableSupplierImpl) may post a task to notify the observer (the Tab in this case). If the Tab is destroyed before the task runs, then when the task runs we get a crash as the Tab has been destroyed (specifically mNativeTab is 0, which means the jni call DCHECKs). I would like a test for this, but it proved slightly tricky. BUG=1057657 TEST=none Change-Id: I85534c464fe11121fb9f65710fc3fb69b48b0d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083813Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746113}
-
Andrew Xu authored
It is a regression issue caused by my recent CL: https://crrev.com/c/2052593. A test case is added for this scenario. Bug: 1057710 Change-Id: Iccdffd7f0eab7d4216a0ae9bc675797f52dc0f10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080954Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746112}
-
Robin Lewis authored
Bug: 1039781 Change-Id: Ie89490e0087a752cc746453184cba0f62cb16fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083345 Commit-Queue: Robin Lewis <wrlewis@google.com> Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746111}
-
Gregory Guterman authored
This reverts commit 5c614415. Reason for revert: The CL is missing an important piece of validation code. 'generate_buildboy_json.py --check' needs to validate the new bucket files, which it does not in this CL. Original change's description: > infra: Generate source side spec by bucket > > Doesn't include internal builders. > > Bug: 1028719 > Change-Id: Iec40cb84086ed23cd7d5ca60c317296460466497 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033847 > Commit-Queue: Gregory Guterman <guterman@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745574} TBR=agable@chromium.org,martiniss@chromium.org,guterman@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028719 Change-Id: I9f0beb4efc49f532eb8a25137aafc6ad35c36354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083621Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gregory Guterman <guterman@google.com> Cr-Commit-Position: refs/heads/master@{#746110}
-
Shimi Zhang authored
AutoCloseableRouter implements close() method from java.io.Closeable, however close() will be called only when used with try-with-resources statement. Normally this class won't be in a try-with-resources statement unfortunately, so one needs to call close() explicitly. Bug: None Test: No logic change, only comments. Change-Id: I9c0b36372b8b51f0d3610fb82799db42a1fb910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081012Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#746109}
-
