- 15 Jul, 2020 40 commits
-
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: I9bb8090747407e77408a9fa1556ccba3633cbd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298783 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788750}
-
Kristi Park authored
Multiple flakes on Webkit Linux Leak (e.g. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/16692) TBR=hiroshige@chromium.org Bug: 1068175 Change-Id: Iee830b5b4c604ff4cf0527643447f389d3674a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300231Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788749}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=rdevlin.cronin@chromium.org Change-Id: Ic1fa9cea86ab7c6106af4db2837d773aaf8dac6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298859 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0b63703..e7945d6e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id36999313702de5f83d56987884af85326c2c5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300007Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788747}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1de497cc50ab..0a8f44c514ce 2020-07-15 bclayton@google.com Regres: Collate and add new documentation for Regres If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I92e566619f9a7e5d14deb678350a73e7109bff4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788746}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bda66062b2e..1a82e68482aa 2020-07-15 treehugger-gerrit@google.com Merge "Use version script for heapprofd client API." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia0c02d196546ad0dcdfda94e76362e6e10b94592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300524Reviewed-by:
-
Peter Wen authored
Add benchmarks to measure improvements to turbine header generation and java compilation. A change to turbine.py will re-build all headers that chrome_public_apk depends on. Similarly for compile_java.py and building all .javac.jar files. Example: $ tools/android/build_speed/benchmark.py extra_incremental Summary gn args: target_os="android" use_goma=true android_fast_local_dev=true gn gen: 6.6s turbine_headers: 43.3s avg (43.2s, 43.5s) compile_java: 60.2s avg (59.9s, 60.5s) Bug: 1092528 Change-Id: I815ea2020b054c0fc0552afb5837dc1aa670e2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300404 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788744}
-
Francois Doray authored
This method was only used by the obsolete agent interference recorder. The "enqueue order at which we became unblocked" is still tracked internally, because it is used to compute the value of the "was_blocked_or_low_priority" argument passed to TaskObserver::WillProcessTask(). Bug: 1019856, 984057 Change-Id: Iaf7d742c7ab978eee4e105c53b28c6170642698a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297661 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788743}
-
Bin Wu authored
Change-Id: Ib6254975ed3313b1debd3e147abeec11ddfa4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292788Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#788742}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I09561300dff61ba4d7a0688ae6653865aa1a363b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299522Reviewed-by:
-
Christopher Cameron authored
TBR=mcasas Bug: 1105566 Change-Id: Ie07c3f3c2197faf77aefa5fd35090020fda204fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300085Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788740}
-
ckitagawa authored
This CL adds separate unit tests suits for - ScaleController - ScrollController - Viewport BitmapState is tightly coupled to the mediator so that continues to be covered by the mediator test. This CL also removes redundant mediator tests and cleans up the BitmapState @VisibleForTesting annotation. Many tests need to remain in the mediator to ensure that scroll/scale interact correctly with bitmap updates. Bug: 1099722 Change-Id: Ie38ece7d7e8bbbb05fa4356475f44ae537858139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295223 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788739}
-
Dana Fried authored
Code now tries to align the badge font with the center of the primary menu item text (which actually aligns the "cap-height boxes" rather than the whole font because of how fonts are rendered. Values have been adjusted to meet redlines; see: https://docs.google.com/presentation/d/1iERU69_-_PpQba5MAvSdxCX_wZrqMpCZOjHCSbFyZWY/edit#slide=id.g8abf29f0df_2_60 but also to look best on both Windows 10 and Linux with standard font-rendering options. We may have to make some additional small tweaks for Mac. This patch also consolidates code and moves more general computations into text_utils at the request of some of the gfx/fonts owners. Bug: 1098731 Change-Id: I50fafa7291aad3131e16428f537bc0ed0266dae9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285511Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788738}
-
rbpotter authored
Bug: 1000989 Change-Id: I56a24453859b60133d8d0366a51968de53c62c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299000Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788737}
-
John Delaney authored
Adds an enabled expirement for the Heavy Ads Intervention. Change-Id: Icf8f645fb171f2d97568915bae595e23910dc5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300262Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788736}
-
Dana Fried authored
These are important for hover card and tablet tabstrip performance monitoring. Bug: 1105000 Change-Id: Icc65936d1407a044afb58aaef12d8a002283ccc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298710Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#788735}
-
Ben Pastene authored
This is a reland of 8f372d5f Reason for reland: - All hand-rolled DEPS-consuming apps have been updated. - No changes in this CL between original & reland. Original change's description: > Split the cros_boards gclient var into two for fetching QEMU images. > > This will help with the TODO at: > https://source.chromium.org/chromium/chromium/src/+/master:build/config/chromeos/rules.gni;drc=ded9eb5153bb13b3f8821a6fa6fac6b3f0f590fd;l=22 > > It will also remove the need for hard-coding the names of all these > QEMU-compatible boards. > > Bug: 937821 > Change-Id: Iab180fc012bd694b4908ba0654da93d42e2274fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265498 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#786005} Bug: 937821, 1103538 Change-Id: I6124b41f5032d9daffd4b9747ec3a974b19c6db4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299469Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#788734}
-
Katie D authored
This matches UX spec for these reader mode strings. AX-Relnotes: n/a Bug: 1041918 Change-Id: I12c1e54a684c42b655581851a15fc45c4850a9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292695 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#788733}
-
Andrew Grieve authored
Bug: 1041930 Change-Id: Id4419b20a9f586bb4e00a751f7e10a36ac3f1a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297729Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788732}
-
Torne (Richard Coles) authored
Check final_android_sdk instead of public_android_sdk when deciding how to set the APK versionCode. This is a no-op for upstream as they are always the same, but for downstream builds means that we will only add the +50 offset when we're building against a preview SDK, instead of also adding it when we're building with a final-but-not-yet-upstreamed SDK. Bug: 1025990 Change-Id: Ife01462fa3f214760e88f498e33fca2c3d1c5c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300265Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
-
Mike Wittman authored
The build id flag was enabled in non-official builds in https://crrev.com/776312. The tests depending on it can now be enabled in that configuration. Bug: 870919 Change-Id: I37e7bc2fbfad4b6df2126071652c4c5982e84e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296263 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#788730}
-
Andrew Grieve authored
Bug: 1102997 Change-Id: I66520edcde45c937d162d6fdf5e566cd0f21a949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292782 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788729}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=xdai@chromium.org Change-Id: I404ebeab57af22c4e7ad6521b4f3811bd56883df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298819 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#788728}
-
ssid authored
Register histogram obvserver in startup tracing, so we do not miss the early histograms. Change-Id: I028cc11fe9d29b936c159f1d60f6305d6cdf6597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298326Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#788727}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: Id6619facec9d05362ad17336602b5764fda46647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297036 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#788726}
-
Justin Miron authored
This is a reland of 3f8e5c2d. This change was reverted as it depended on main frame intersection measurement which broke renderer frame intersection observation (crbug/1084786). The culprit CL has been fixed and has been reimplemented independent of render frame intersection observation in: https://chromium-review.googlesource.com/c/chromium/src/+/2206924. Original change's description: > Ad Density UKMs recorded in AdsPageLoad. > > This change adds ads page load metrics observer processing of > FrameIntersectionUpdates for ad frames. Each frame, including the > main frame, stores its main frame intersection in FrameData. The new > AdsArea class handles calculating the combined area of all ad frames. > Density is measured over the lifecycle of a page and the maximum denisties > are recorded. > > The two new UKMs are: MaxAdDensityByArea, MaxAdDensityByHeight. These > will be used to evaluate/motivate future interventions on page ad > density according to the Better Ads Standard. Height is needed > explicitly to match the definition of the standard. > > BUG=993453 > > Change-Id: I054a2017f56843762d39f44870848c622fc38a43 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137771 > Commit-Queue: Justin Miron <justinmiron@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#768347} Bug: 993453 Change-Id: I1562846669b53b2d0a0eba9392e98e63b5e66a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292894Reviewed-by:
John Delaney <johnidel@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#788725}
-
Elly Fong-Jones authored
This change avoids touching CastDialogView::GetWindowTitle, which has some actual logic for computing the title. Bug: 1075649 Change-Id: I678b72391023ae35bd9a4d9fcc4f0d99ce82d822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300267 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788724}
-
Peter Kasting authored
Toggling view visibility is simpler, safer, and more performant than deleting and recreating views. Additionally, this will enable more refactoring in the future to further simplify visibility setting, layout, etc. Bug: none Change-Id: I9cb961d3117bfc9fc6f7b867aab8f266ad565dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295993Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#788723}
-
Tina Wang authored
A browser policy connector is used to check if the browser has any pref that managed by policy. Bug: 1105206 Change-Id: I1067124b42bcfb39f88ec6a10333eaaec5da44fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295997Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#788722}
-
Becca Hughes authored
This is a reland of c670ba45 Original change's description: > Reland "Turn on Media History by default" > > This is a reland of ccf0e2f9 > > Fixes TSAN issue in the constructor of sql::Database > by moving it to the main thread. > > Original change's description: > > Turn on Media History by default > > > > BUG=1024351 > > > > Change-Id: Id01595e63f5f776a226087741ef602ba30b80328 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295224 > > Auto-Submit: Becca Hughes <beccahughes@chromium.org> > > Commit-Queue: Tommy Steimel <steimel@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#787954} > > Bug: 1024351 > Change-Id: I19be665637f5c28261f7197547ddc5fe6671127e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296884 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788312} Bug: 1024351 Change-Id: Ie371d56df987c19a10017050ead02922a530f2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300224Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#788721}
-
Annie Sullivan authored
Bug: 1104365 Change-Id: I20491cecfaf80abe4194f24005938c623911c7f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298179 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788720}
-
Arthur Eubanks authored
It is implicitly on, but does not work when LIBCXX_ENABLE_SHARED and LIBCXX_ENABLE_STATIC are both turned off. See https://reviews.llvm.org/D82702. Bug: 1105597 Change-Id: Iaac9dba2a98fb8d097558ec9960ddd1bc55fda83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299468Reviewed-by:
-
Stephen McGruer authored
Bug: 1092520 Change-Id: Ifd801925303ffbf2694a9ba4a1f96a4e08cf058e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299520Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#788718}
-
Wei Li authored
Two small changes in the login bubble dialog example: 1) only show the labels after submit as showing them on the initial screen might confuse users; 2) change the input position to be closer to the label. Screenshots are in https://docs.google.com/document/d/1PZPJIipxBT0QfEHqeZtlfGq7e0z2Wo0v8x5CNVzEOmM/edit# Bug: none Change-Id: I879b682b7be5c5ffea31beabce911c83e91eaff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296626Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#788717}
-
Leonard Grey authored
New number via consultation with PM and UX. Bug: 1098397 Change-Id: I9ddb3582974b199c8d820fc76026a064a21a4edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300320Reviewed-by:
-
Steven Bennetts authored
This is part of a larger effort to refactor callbacks in chromeos/network. The Get and Set Properties methods require small state machines which do not do well with separate success / error callbacks. This CL changes the API to use a single callback more sutible for a cleaner OnceCallback model. Bug: 1007660 Change-Id: I6b94f469147daa0dbfffe4fdef67d31e1af0f323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293258 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#788715}
-
John Abd-El-Malek authored
Bug: 1102743 Change-Id: I76c928fa620908482f1bf07c00fd429132f93ff0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296822 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Dominic Farolino authored
R=sclittle@chromium.org Bug: N/A Change-Id: I3ea94a937ecc957389217a24bd4cc961a6d11c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300500Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#788713}
-
Tommy Steimel authored
This CL adds the necessary deps to chrome/browser/share to pass `gn check`. chrome/browser/share depends on the ProfileManager in chrome/browser, so we allow circular dependencies. Bug: 1105857 Change-Id: Ic2aec390319e7e16d7d47d06bb1299555b3d6194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300220Reviewed-by:
-
Adlai Holler authored
This is part of a larger effort to have users specify the GrDirectContext when creating new derived images. See skbug.com/10466 for details. Change-Id: Ia3d78f0a7bf54798450e9f9a3c3a86bcdd1caf9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295982 Commit-Queue: Adlai Holler <adlai@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#788711}
-
