- 26 Jun, 2020 40 commits
-
-
Meredith Lane authored
CreativeOriginStatusWithThrottlingNestedUnthrottled failing flakily on Win7 builder, so disabling that test. TBR=cammie@chromium.org, johnidel@chromium.org Bug: 1099545 Change-Id: I888c05963914c4c507c161f9bb9867e4cd49e3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269399Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#782837}
-
Yutaka Hirano authored
Adding a UKM similar to Extensions.WebRequest.KeepaliveRequestState. Proposal: https://docs.google.com/document/d/1XYsa2W1zjWIvrpuAq7IA1wEGZIvbJLoiPF6rMob01Tg/edit Bug: 1098251 Change-Id: I6bccb85935646bb9ed1879ec19fb409323807124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262402 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782836}
-
Karandeep Bhatia authored
Add more tests for navigation to javascript urls in isolated worlds. The tests show that the isolated world CSP is not enforced for them. This will be fixed in a follow up. This doesn't introduce any behavior change. BUG=896041 Change-Id: I77510f4931608b2d0990ac5e6b60555d75959e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262117Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782835}
-
Yoshifumi Inoue authored
Rather than changing |PositionForEndOfLine()| to work with overflowed layout, this patch changes |AdjustSoftLineWrap()| to check whether specified position in |NGOffsetMapping| or not. When the position isn't in |NGOffsetMapping|, |AdjustSoftLineWrap()| returns specified position without adjustment, for keeping source code simple. Here is steps to |PositionForEndOfLine()| to return wrong position: 1. Layout places <select> at |LayoutUnit::Max()| and sets line width to |LayoutUnit::Max()|. 2. |NGInlineCursor::PositionForEndOfLine()| calls |PositionForPointInlineBox()| with |LayoutUnit::Max()| for <select>. 3. |LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel()| is called and returns null. 4. |LayoutBlock::PositionForPoint()| returns end of |Text| node position by traversing layout tree. Bug: 1098795 Change-Id: I5e86732fe15e9980da46ad3e32db4ef0b7170b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265974 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#782834}
-
Gavin Williams authored
For CrOS, this will show a printer icon with a status badge next to the currently selected destination only if it is a local printer. Screenshot: http://screen/xOt5q6RBGHO Bug: 1059607 Change-Id: I6afeed18ea5eb4ed9482f6358b59347ffd63d426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230761 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#782833}
-
Brian Sheedy authored
Re-enables GPU pixel test inexact matching, which was erroneously disabled when refactoring some code. This requires making the shared Skia Gold code accept an optional list of strings for extra arguments. Also drive-by fixes the OWNERS file for the shared code, as it was incorrectly using the @google.com account instead of the @chromium.org one. Bug: 1099423 Change-Id: Ie4005d3bc0c633b36f4a1328772a43d26c673707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268224 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782832}
-
Benjamin Smith authored
R=tmrts@chromium.org, ulan@chromium.org Label click is a critical user journey for Gmail. Perform a label click and go to next page of results. Bug: 1044682 Change-Id: I43b95f720d494451b94c225fc7cc11c7c4b3c0ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036550 Commit-Queue: Benjamin Smith <codesmith@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782831}
-
Steven Bingler authored
In preparation for future changes, modify EnterpriseInfo to return the results of a "ownership" request using a callback to the waiting function. This change allows for multiple queued callback to wait on a single async request. These changes make it simpler to add additional consumers of the class. The result of the computation is then cached for future use. The lifetime of this cache is the lifetime of the application. Bug: 1085168 Change-Id: I59c9d6f295d75492ddab762dc307fa67ecf21760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252739Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#782830}
-
Hiroki Nakagawa authored
Bug: 1073296 Change-Id: I7f445bd642458a722c72b5763542ea29ab134c08 Tbr: shimazu@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269400Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#782829}
-
Leonid Baraz authored
Making that will guarantee, that queue is destructed on the appropriate queue only and in order with other asynchronous operations (after them all). When the device is shutting down, it won't allow any new asyn operations to start. This should resolve crbug/1098359. Bug: 1098359 Change-Id: I12fd860778bc8dd7efb1f51f6d878c2cd1dd3256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268382Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#782828}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/fdc66e03064d..f318b72e2035 2020-06-26 jophba@chromium.org Move test_main for test binaries to executable() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4481b18adb0e6c8a570ae7e6cb786c206d45393b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269059Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782827}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Icba1fd57c71ce85b0318719d4265de96ff5406dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269777Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782826}
-
Kyle Horimoto authored
(1) Show "Instant Tethering" as an alt tag for connected devices setup when the flag is on. (2) Correct string: "setup" => "set up". (3) Correct messages string so that it does not have "settings" in the name. This was previously inconsistent with other search tags. Bug: 1096805 Change-Id: I8dd664dffaf55fbbddac3885fe56556ba5ea2615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268590Reviewed-by:Regan Hsu <hsuregan@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782825}
-
Charlene Yan authored
Bug: 1018320 Change-Id: I14885665ecb5d83362e264a015eff4ed6fcfedfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267928Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782824}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0d5f47eb1f8c..c84119493b9c 2020-06-25 zzyiwei@google.com GPU Memory: add proto for perfetto producer in gpuservice If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157142645 Tbr: perfetto-bugs@google.com Test: Test: take a perfetto trace with the producer Change-Id: I02ffd0eeb4b3bec8a89a3ef8ea9c75e2d14fd0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269058Reviewed-by:
-
Dale Curtis authored
During playback startup before getTimestamp() has valid information, we may end up with a negative result for delay. Bug: 801435 Change-Id: I9fedb094de0091d8abec6d608cbdf5fdf165dc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268233 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#782822}
-
Zufeng Wang authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/xWPW8iOCFFb9BXbsulgdmAJ8knCb8NlzyKzfh1Tst2AC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006240800_RC00.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Ieb0893c0edbe619f1c13f7604841f815f742d14e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266233Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Zufeng Wang <zufeng@google.com> Cr-Commit-Position: refs/heads/master@{#782821}
-
Matthias Körber authored
Change-Id: I8c08365e0a4135ccd72750adfd1297a97134c769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268917Reviewed-by:
-
Jesse McKenna authored
When restarting Chrome after an update we sometimes observe a large number of hard page faults for chrome.dll. This suggests that the prefetching of chrome.dll has failed, and this can significantly impact startup time, especially for users with spinning disks. This change updates PreReadFile so that if errors are hit while initializing the mapped file or calling PrefetchVirtualMemory then PreReadFileSlow is called, just like in the case where PrefetchVirtualMemory is not available. An UMA histogram, Windows.ChromeDllPrefetchResult, is emitted after any attempt to prefetch chrome.dll. This reports the outcome, including whether the PreReadFileSlow fallback was used. This also cleans up the code to avoid an extra use of decltype, and an unneeded dereference of the function pointer. Bug: 1096609 Change-Id: I570220ebb7ed148dfdd48ec8948f9480594dbd2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248065 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782819}
-
Mitsuru Oshima authored
Change-Id: I804b607bd597dfe918a85178b60a33d7d61f1687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265720Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#782818}
-
Meredith Lane authored
This reverts commit 19e537d0. Reason for revert: Suspected cause for CreativeOriginAdsPageLoadMetricsObserverBrowserTest.CreativeOriginStatusWithThrottlingUnknown deterministically failing. on Win7, first failure: https://ci.chromium.org/p/chromium/builders/ci/Win7%20%2832%29%20Tests/61594 Original change's description: > Disable AdTagging when the Ads content setting is set to allow > > What: Do not run the SF filter in DryRun mode on pages where the > content setting is set to allow. > > How: Delete the ongoing activation throttle for the navigation when > we receive an explicit disabled activation state. > > Currently we ignore disabled activation states when we receive them, > as normally the SF filter is running in DryRun mode anyway. > > > Change-Id: Ibc5202ec5f68bd284987cdd4d5dfa0e8de0708a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218371 > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Commit-Queue: John Delaney <johnidel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782722} TBR=jkarlin@chromium.org,csharrison@chromium.org,johnidel@chromium.org Change-Id: I3f150050d45b258b664178c501254c8fc42315a4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269397Reviewed-by:
-
Jimmy Gong authored
- The bug occurs if there is a '.' in the file name of a print job. - It is valid to have a '.' in a file; however, we were incorrectly assuming that all files that have '.' and did not a standard file extension could not be Google files e.g. Google Docs. - For example, '.test - Google Docs' would result in the generic file icon rather than the Google Doc's icon. - The fix is to also check if the file is a Google file in the case where the file icon was initially determined to be the generic icon. - Add browser test for this fix. Bug: 1053704 Test: browser_tests Change-Id: I6708fbea936f5a9623f465329874d5e69dcb4bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266432 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782816}
-
Daniel Cheng authored
Change-Id: Id9c015b40c46b2b6d12bfd6b7d5d6cb869e91137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266376Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782815}
-
Chris Harrelson authored
Text fragment anchors are very expensive to compute; otherwise page load performance may suffer significantly. Before this CL, text fragments could be invoked an arbitrary number of times up to the time when the document was loaded - whenever a lifecycle-based or forced update happened. This slowed down page load, as well as all layout-inducing DOM APIs. A previous CL (*) regressed performance on top of this problem, because it invoked the text fragment regardless of whether layout was dirty. Before that CL, the expensive part of text fragment invocation only happened if layout was dirty. Layout could be dirty many times before the document is loaded, but many fewer times than the number of lifecycles or forced layouts. The main consequence of this CL is that text fragment invocation will not happen at all until the document is parsed, and then once again once it is loaded (which includes waiting for certain subresources to load, in particular images). It appears that the spec allows (*) user agents to define the timing of fragment scrolling and highlighting. The test TextFragmentAnchorTest.TargetStaysInView exercises this new code code quite well, and still passes with this CL. I couldn't make it pass until every part of the new CL was in place. (*) https://chromium-review.googlesource.com/c/chromium/src/+/1981806 (**) https://html.spec.whatwg.org/multipage/browsing-the-web.html#try-to-scroll-to-the-fragment Bug: 1094452 Change-Id: Iee19989061128ff158b72ed99cabd0dec8f449e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267137Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782814}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bf1816170b1f..8e144aa33faa 2020-06-25 bsheedy@chromium.org Remove WebRTC usage of //third_party/pymock If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094489 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic7838179eab9cae3285aba862a8b42afc321edaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268502Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/84289884f156..c55849a7826f 2020-06-25 cjamcl@chromium.org [Lighthouse] Roll Lighthouse 6.1.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic8dbddf8f8a1234c7b19f4531de4e3b4602e704b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269098Reviewed-by:
-
Meredith Lane authored
This reverts commit b14d5263. Reason for revert: DCHECK(!overview_mode_) causing crashes on multiple steps for linux-chromeos-dbg build, starting from https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg Original change's description: > Shelf should not update state when entering overview mode. > > Bug: 1033219 > Change-Id: Iaf760307c32a67e3ef5da7308235a3c297c2d0af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242832 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Yulun Wu <yulunwu@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: Yulun Wu <yulunwu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782657} TBR=xiyuan@chromium.org,tbarzic@chromium.org,yulunwu@chromium.org Change-Id: I393e96bcd6ba88cb01b2be2d088ed3495effbc02 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268959Reviewed-by:
-
Pete Williamson authored
For feedback on the Discover feed (on the NTP), we want to drop all the PSD other than the ones directly relevant for the feed. The feedback will be processed by the discover team instead of the chrome team, and we want to make sure PII is not leaked to teams outside chrome to strongly comply with privacy. The approach we took was to make FeedbackCollector a base class. For feedback going to chrome we use a derived class called ChromeFeedbackCollector. For feedback going to the AGSA team, we use a derived class called FeedFeedbackCollector, which only includes PSD specific to the Chrome feed. A new unit test for the FeedFeedbackCollector has been added. We also removed the FeedContext parameter from the FeedbackCollector, since it is only used now by the FeedFeedbackCollector. Bug: 1091058 Change-Id: Ia088b20aaf2ef4a50c2ce163cacd159f7a0c28e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241455 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#782810}
-
Daniel Hosseinian authored
PrintCompositeClient is a WebContentsObserver, meaning it can observe when renderers crash or are deleted for any other reason. Allow PrintCompositeClient to track the renderer that spawned each print compositor process, and delete those processes when the associated renderer is deleted. Consequently, print compositor processes will not hang when a renderer crashes or when a user navigates to a new page in the middle of a long compositor job. Bug: 1048899 Change-Id: I5a7466aaeb0e8238c6fccddd1692bdb02aecfa9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236199Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#782809}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I65cb05bf485d9ede8f9bcbb2b6e6d305acbd77bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268311Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d781655d0f3..6ee18c2d01f6 2020-06-25 syoussefi@chromium.org Vulkan: Remove debug symbols from internal shaders 2020-06-25 jonahr@google.com CGL: Add basic multithreading support 2020-06-25 jonahr@google.com Add basic multithreading support to GLX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1087084 Tbr: cwallez@google.com Change-Id: I2d889ea211a85ce2016fe14a0c0dc0c7e57e7a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268501Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593108049-54cd7c484f00124b00c3e227cbddebfe7f650a96.profdata to chrome-mac-master-1593129542-eae571d99fb364561b81bf0410208d0db84ed4e4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieccf5eaf60f0ae8fd848cf1ea066b99c2515401e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269060Reviewed-by:
-
Eric Roman authored
Change-Id: I935dafb8a08ac65871798ba9a74dc2943f672d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268887 Auto-Submit: Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#782805}
-
Nico Weber authored
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/431d6e57284a..6c656df63da5 $ git log 431d6e572..6c656df63 --date=short --no-merges --format='%ad %ae %s' 2020-06-25 thakis mac: Only call system aligned_alloc() with the 11.0+ SDK. 2020-06-25 thakis Only use system aligned_alloc on mac/ios if the SDK has them. 2020-06-25 thakis Fix argument order for aligned_alloc on mac. 2020-06-25 thakis Make vulkan_memory_allocator build with the MacOSX11.0 SDK. Created with: roll-dep src/third_party/vulkan_memory_allocator TBR=jmadill Bug: chromium:1098741 Change-Id: I0553a043471e4a45603b9e1fd7fbd9302382e902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268639Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782804}
-
Stefan Zager authored
Bug: 1092673 Change-Id: I088d993addb97e76dd35c6166f5b179008bf50a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268880Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#782803}
-
Nidhi Jaju authored
This CL replaces the use of IsolatedPrerenderServiceWorkerObserver:: IsServiceWorkerRegisteredForOrigin() by directly calling ServiceWorker Context::HasRegistrationForOrigin() in IsolatedPrerenderTabHelper:: CheckEligibilityOfURL. This can be done because this method is called on the UI thread. By using HasRegistrationForOrigin(), we are able to use the already existing |registered_origins_|, as it is not necessary to retrieve all service registrations just to confirm if a service worker is registered for a particular origin. Furthermore, the IsolatedPrerenderServiceWorkerObserver class is also removed as it is not needed anymore. The motivation of this change is to eliminate unnecessary memory allocations and data conversions GetAllOriginsInfo() performs (see [1] for details). When the browser has many service worker registrations for different origins, these allocations/conversions have considerable performance impact. [1] https://docs.google.com/document/d/1iaQGQzovFVL3LxDiyIvVgEUFWMhzrXpdf_6TmuwIICA Bug: 807440 Change-Id: I6081df48fd6b02850ca8276923134ee7c821b92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259677Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#782802}
-
James Cook authored
Add the skeleton for a mojo API for open/save file dialogs, roughly following the existing SelectFileDialog C++ interface. Add SelectFileDialogLacros, which lives in lacros-chrome and binds to a remote SelectFile interface in ash-chrome. The class lives in //ui/shell_dialogs to be close to other per-platform select dialog wrappers, as well as to demonstrate how a lacros mojo API can be called from a component outside src/chrome. Add a stub SelectFileImpl in ash-chrome. For now this just returns a single file immediately. Follow-up CLs will actually open a dialog, using the existing file manager-backed dialog used by ash. 1-page design doc at go/lacros-file-picker Bug: 1090587 Test: manual, hit Ctrl-O and /etc/lsb-release is loaded in a tab Change-Id: I9ebd9ff25f8aa32deac5eabb85f40a37e4b72856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261405 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#782801}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e9a7aeca54da..0cf906bce58a 2020-06-25 fancl@chromium.org auto-triage: Separate alert groups by domain If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097767 Tbr: oysteine@google.com Change-Id: I91c92ffcceb9d0febcbf281384b6a602fd3ad6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268739Reviewed-by:
-
Owen Min authored
This reverts commit 350e9c41. Reason for revert: This CL is not related to AutotestPrivateApiTest.AutotestPrivate failure. The test was flaky before the original CL landed. Original change's description: > Revert "Fix issue that webstore private APIs return array improperly" > > This reverts commit 0403341d. > > Reason for revert: AutotestPrivateApiTest.AutotestPrivate is failing > > https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19325 > > Apologies to developer if reverted in error. > > Original change's description: > > Fix issue that webstore private APIs return array improperly > > > > webstorePrivate.getExtensionStatus and requestExtension should return > > extension status as a string but not an array of string. > > > > Bug: 1099334 > > Change-Id: Ib56e466cc1d967e3a322494076ad7640a6868aac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267719 > > Commit-Queue: Owen Min <zmin@chromium.org> > > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#782607} > > TBR=zmin@chromium.org,karandeepb@chromium.org > > Change-Id: Ibe7b886da11ee5864d3b8a73b8ed7d98f53327d6 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1099334 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268839 > Reviewed-by: Chris Mumford <cmumford@google.com> > Commit-Queue: Chris Mumford <cmumford@google.com> > Cr-Commit-Position: refs/heads/master@{#782740} TBR=cmumford@google.com,zmin@chromium.org,karandeepb@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1099334 Change-Id: I60e43ed8b5d5450e7143683c2ff1516c5d93f8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268542Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
The upcoming MSE-in-Workers experimental implementation will also have SourceBuffer and SourceBufferList exposed on DedicatedWorker. This change adds that conditional exposure (though it's all currently gated on MediaSourceInWorkers RuntimeEnabled feature, which is experimental-only and disallows MediaSource construction success at the moment). As the implementation is refined later, similar may need to occur for {Audio,Video}Track{,List} and their relevant SourceBuffer supplement IDLs, and possibly also TrackDefault{,List}. BUG=878133 Change-Id: I67a460515e3d3e53631a45a2e687505ff981bf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268937 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#782798}
-
