- 09 Aug, 2018 40 commits
-
-
Andrii Shyshkalov authored
NOTREECHECKS=True No-Presubmit: True No-Try: True Bug: 872722 Change-Id: I78a357132559302f59848a712363d02cb2f0e91a Reviewed-on: https://chromium-review.googlesource.com/1169949 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581889}
-
Andrii Shyshkalov authored
TBR=pkasting Bug: 872722 Change-Id: Iffb249c1d61d468ac8f301b4808049e03ab52127 Reviewed-on: https://chromium-review.googlesource.com/1169912Reviewed-by:
-
Francois Doray authored
Before this CL, recomputing occlusion too many times before occlusion states became stable caused a call to DumpWithoutCrashing(). Now that we didn't get any crash reports in the last 6 months, this CL replaces the DumpWithoutCrashing() with a simple DCHECK. Bug: 813076 Change-Id: I2ec8c5fa89a1646367035c3585df091a9a4f76cc Reviewed-on: https://chromium-review.googlesource.com/1168024Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#581887}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b04cdc9bc5e1..bca7d20ad76a git log b04cdc9bc5e1..bca7d20ad76a --date=short --no-merges --format='%ad %ae %s' 2018-08-09 nastasoiuf@google.com Integration 2018-08-09 wangge@google.com Add Test Cases for `utils.py`. 2018-08-09 wangge@google.com Add Logic to Use Monochrome After Milestone 52. Created with: gclient setdep -r src/third_party/catapult@bca7d20ad76a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390,chromium:863390 TBR=sullivan@chromium.org Change-Id: I7ebb2f0dbfb94c7af0c997dbd5826e7bd03ea455 Reviewed-on: https://chromium-review.googlesource.com/1169108Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581886}
-
Vasilii Sukhanov authored
Dismiss the generation prompt when > 5 characters typed. Bug: 869890,859472 Change-Id: Ib842b92857a79e92e411e7247ad0cc4a322dd364 Reviewed-on: https://chromium-review.googlesource.com/1167507Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581885}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 84f87556. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22574 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB mtrofin@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=kereliuk No-Export: true Change-Id: I8da40e9d8be7e1a738a8f2f1ffbe16f65f1d3f29 Reviewed-on: https://chromium-review.googlesource.com/1169123 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#581884}
-
Mirko Bonadei authored
The code that was causing the problem has been removed from absl. Removed from: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/8f96be6ca60d967bd4b37f93d0a03bcff4145200 --- 5aba0b15eaf6c5beff0e91670a7cdf5ad1151886 by Derek Mauro <dmauro@google.com>: Use std::chrono to get the current time on both Apple and Windows platforms, eliminating the unnecessarily complicated logic on Apple platforms. PiperOrigin-RevId: 206979219 --- Bug: webrtc:9557 Change-Id: Idb2858b39b2ef8ed7e69d4d740faef9d369e8747 Reviewed-on: https://chromium-review.googlesource.com/1165348 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581883}
-
Ross McIlroy authored
ready_state_ could be kErrorOccured as well as kReadyStreaming. Update the logic to check for this and add a new NotStreamingReason to log it. BUG=chromium:865098,chromium:871276 Change-Id: I7f4e17c843b74632d4cf167664f26fdb92f30a8c Reviewed-on: https://chromium-review.googlesource.com/1164943 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#581882}
-
Andrew Grieve authored
This will match up pak symbols when they have moved between grdp files. Change-Id: I55ae383498c66a11c675cb1b0eb4866da4cae721 Reviewed-on: https://chromium-review.googlesource.com/1168456Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581881}
-
chrome://sync-internalsMikel Astiz authored
The regression was introduced in https://chromium-review.googlesource.com/1160229 which overlooked the fact that the UI makes assumptions about when it's notified about the results (i.e. no synchronous reply expected). There are cleaner alternatives to the proposed fix, but it seems most conservative to go back to the previous implementation by partially reverting the offending patch. Bug: None Change-Id: I81d82d27234666d407708b1ccd366e493784e9c5 Reviewed-on: https://chromium-review.googlesource.com/1169045 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#581880}
-
Luke Halliwell authored
As a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1133975 Realized when plumbing this through in chromecast's render client that we need the RenderFrame. Bug: 862698 Change-Id: I1764dcd25dacac7a406d8b179d7abb5af2d14dad Reviewed-on: https://chromium-review.googlesource.com/1151761Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#581879}
-
Mohamed Amir Yosef authored
The server identifies bookmark commit requests by the absence of a client_defined_unique_tag. Bookmarks should be handled differently when generating server ids. This CL makes sure the client_defined_unique_tag is only populated for non-bookmark data types. Bug: 516866 Change-Id: I0c3b1f314c638878fd8780663484aec780215e99 Reviewed-on: https://chromium-review.googlesource.com/1169052 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581878}
-
Peter Wen authored
Bug: None Change-Id: I1e24a3a076ca89dcde0712620f8194fed7702183 Reviewed-on: https://chromium-review.googlesource.com/1167109Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581877}
-
Greg Kraynov authored
We're moving away from using MessageLoop in Blink, hence, we want to make SequenceManager support any missing pieces and provide a good level of abstraction on top of a thread. Specifically, this CL will unblock removing MessageLoop references from content::RenderThreadImpl. Bug: 828835 Change-Id: I5a785a26f35839eea3705ecb5abc61672c497457 Reviewed-on: https://chromium-review.googlesource.com/1167516Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581876}
-
David Tseng authored
This reverts commit ad618241. Reason for revert: <INSERT REASONING HERE> Chromeos-dbg bots are now green (for chromevox); this change was unlikely to be at fault. Original change's description: > Revert "Only alert accessibility when a notification's text changes" > > This reverts commit feb758c3. > > Reason for revert: <INSERT REASONING HERE> > SpokenFeedbackTests failing on chromeos dbg > Original change's description: > > Only alert accessibility when a notification's text changes > > > > Bug: 867426 > > Change-Id: I7f220566f3e7a2b4ce7ef639d012f4323b762208 > > Reviewed-on: https://chromium-review.googlesource.com/1166231 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Commit-Queue: David Tseng <dtseng@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581474} > > TBR=stevenjb@chromium.org,dtseng@chromium.org > > Change-Id: I8b23c03e08642caa7b05d2ce88e6f330dd056c37 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 867426 > Reviewed-on: https://chromium-review.googlesource.com/1167603 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581607} TBR=stevenjb@chromium.org,dtseng@chromium.org Change-Id: I0b1270e0ebdbfbca89baefe9a9f676062862479e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867426 Reviewed-on: https://chromium-review.googlesource.com/1168329Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581875}
-
jdoerrie authored
This change simplifies FidoBleConnection by passing the obtained BluetoothAdapter from FidoBleDiscovery through the FidoBleDevice to the FidoBleConnection. This removes the need to query for the adapter within FidoBleConnection and simplifies the implementation. Bug: 763303 Change-Id: I83e0c5e715246db4c3ac0dc0427797c8d783853c Reviewed-on: https://chromium-review.googlesource.com/1167056 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581874}
-
Jérôme Lebel authored
This CL enables unified consent given when the user signs in to Chrome. This CL also disabled and enables unified consent given when the user toggles the corresponding switch on and off in the Sync and other services settings screen. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5384052f4abe117e7816733e45dc4091afe55708 Reviewed-on: https://chromium-review.googlesource.com/1165151Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581873}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f43cb96e..4fe3de13 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4ab8f99b744760d60f58e2d1205d5453efba0f9 Reviewed-on: https://chromium-review.googlesource.com/1168985Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581872}
-
Jérôme Lebel authored
Adds a call from -[MainController scheduleLowPriorityStartupTasks] to the BrowserViewController, to present the ConsentBumpCoordinater if needed. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If27ff2e61659489da6e61a48b9d1e252ad43f9e8 Reviewed-on: https://chromium-review.googlesource.com/1163506 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#581871}
-
vitaliii authored
virtual/mouseevent_fractional/fast/events/autoscroll-over-scrollbar.html fails. virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-nested-divs.html timeouts. virtual/mouseevent_fractional/fast/events/recorded-keydown-event.html timeouts. TBR=sahel@chromium.org NOTRY=true Bug: 872705,851090 Change-Id: I03aa2e1cac464c8a880bfd570fec2531bb26c2c8 Reviewed-on: https://chromium-review.googlesource.com/1169055Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581870}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b2db53998dc4..5f0ce99c04eb git log b2db53998dc4..5f0ce99c04eb --date=short --no-merges --format='%ad %ae %s' 2018-08-09 buildbot@webrtc.org Roll chromium_revision 474eca05..46dc99a5 (581204:581557) 2018-08-09 nisse@webrtc.org Revert "Refactor RtpVideoStreamReceiver without RtpReceiver." Created with: gclient setdep -r src/third_party/webrtc@5f0ce99c04eb The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I03c16d7d120279a4ef44dfe86d97aaf7e63a80c4 Reviewed-on: https://chromium-review.googlesource.com/1168415Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581869}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/8f612ebb15..bea85b5273 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/8f612ebb15..bea85b5273 Bug: None Change-Id: I34abe94b1abce30aa15cd0a38376b655e992ca48 Reviewed-on: https://chromium-review.googlesource.com/1165343Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#581868}
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace and conflict. This happens for functions in: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc The functions are very similar but not identical. Therefore, the functions in components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc are renamed to be something more file specific. Bug: 869381 Change-Id: I8b26857cfa9fd80b42d9ff79de4b49753c824b54 Reviewed-on: https://chromium-review.googlesource.com/1169018Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files gets merged and functions with the same name may end up in the same namespace and conflict. This happens for the function TruncateUTF8. This commit solves the issue by moving the function to a shared util file. Bug: 869381 Change-Id: Ia9f754138fb18aa9af575f7cd2f92bca4e8ea0c2 Reviewed-on: https://chromium-review.googlesource.com/1168497Reviewed-by:
-
Michael Lippautz authored
Previously we checked whether a backing could be freed during incremental marking using the provided Traits and kWeakHandlingFlag. It turns out that WeakMember may also be part of otherwise strongly treated in-place constructed objects, e.g., std::pair<WeakMember<T>,U>. Completely turn off promptly freeing for HashTable backings during incremental marking. Bug: chromium:870306, chromium:757440 Change-Id: I94aacad0dbba707a4e0fb8c8119591fd413f9314 Reviewed-on: https://chromium-review.googlesource.com/1165353 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using jumbo, files gets merged and the compiler gets a larger scope. AddressField is defined in both autofill::AddressField and ::i18n::addressinput::AddressField and the reference is ambiguous. That is the reason the namespace autofill:: needs to be specified even though the call is made within that namespace. Bug: 869381 Change-Id: I3ac8813403e04b37b7936397e617aab436214056 Reviewed-on: https://chromium-review.googlesource.com/1169012Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8fa35d11d312..b04cdc9bc5e1 git log 8fa35d11d312..b04cdc9bc5e1 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 wangge@google.com Fix Minor Path Issue. 2018-08-08 achuith@chromium.org Disable testSmokeIsBrowserRunningReturnFalse on chromeos. Created with: gclient setdep -r src/third_party/catapult@b04cdc9bc5e1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390 TBR=sullivan@chromium.org Change-Id: I1275ee52b09f04b678a1e7460a766d501df143af Reviewed-on: https://chromium-review.googlesource.com/1168926Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f765805983d1..60627d6eafd0 git log f765805983d1..60627d6eafd0 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 thestig@chromium.org Change CPDF_Font::GetNextChar()'s in-out parameter to pass by pointer. 2018-08-09 thestig@chromium.org Revert "Rework of CPDF_Parser::GetLastObjNum." Created with: gclient setdep -r src/third_party/pdfium@60627d6eafd0 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I444c631e6a75fba79aa1f5f916966062272514cc Reviewed-on: https://chromium-review.googlesource.com/1168925Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581862}
-
Rune Lillesveen authored
This method was used for style sharing which was removed for issue 721517. Removed unit tests for ScopedStyleResolver which only tested this API. Bug: 721517 Change-Id: Idebecd6b6b66bbf6a229bcf35669e6c4c5bda055 Reviewed-on: https://chromium-review.googlesource.com/1169015Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581861}
-
Peter E Conn authored
Bug: 871266 Change-Id: Ie6e0075b343b6035ab29d8e23d5d2fe065a7f62e Reviewed-on: https://chromium-review.googlesource.com/1165549Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#581860}
-
Ned Nguyen authored
Bug:827156 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic2fbf6e01d967fb64d5b0de03d8d5fa860243628 TBR=jbudorick@chromium.org NOTRY=true # flake Change-Id: Ic2fbf6e01d967fb64d5b0de03d8d5fa860243628 Reviewed-on: https://chromium-review.googlesource.com/1168661 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581859}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cc03e427. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22573 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/css-text/overflow-wrap mtrofin@chromium.org: external/wpt/wasm rego@igalia.com: external/wpt/css/css-grid rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request worker-dev@chromium.org: external/wpt/workers external/wpt/worklets NOAUTOREVERT=true TBR=kereliuk No-Export: true Change-Id: I33dd7b8c510c2676d1635335e33ebfa607eca47c Reviewed-on: https://chromium-review.googlesource.com/1168738 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
I *think* this was added for "associated URL loaders" in https://crrev.com/fe95d9b23ae824, which was reversed, so I'm thinking DelegatingURLLoader isn't needed. At least, the tests seem to pass. We were holding on to the delegating loader on the browser side for lifetime in URLLoaderAssets, but it looks like the renderer holds on to its loader anyway while the nav preload is ongoing in ServiceWorkerContextClient::NavigationPreloadRequest, so it looks correct to rely on the renderer to do it. This was inspired by the linked bug, but not expected to solve it. Bug: 866335 Change-Id: I3b87887e72613e089b99b9d4a91cc76ebc0d620d Reviewed-on: https://chromium-review.googlesource.com/1168943 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Laís Minchillo authored
Static WebView methods are implemented using the class WebViewFactoryProvider.Statics, in this CL we implement the corresponding class for the WebView support library. Bug: 851995 Change-Id: I2f9ed164d3b468acf77feaff4b0f192724ff511e Reviewed-on: https://chromium-review.googlesource.com/1148384 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#581856}
-
Marc Treib authored
It records, when configuring the data types, whether we're configuring the full Sync feature or only the Sync transport layer. Bug: 856179 Change-Id: I8b1453c30dcbb96c7d1028d0c5de467b5fdb2197 Reviewed-on: https://chromium-review.googlesource.com/1167061Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#581855}
-
Jean-denis Muys authored
The unittest still requires knowledge of SigninManager, as the IdentityManager testing facilities being used require passing in the SigninManager. Affects media_router_contextual_menu_unittest.cc Bug: 797897 Change-Id: I94d3fd68cff3143e461dc9ece3ae860d28d1f3ae Reviewed-on: https://chromium-review.googlesource.com/1139061 Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#581854}
-
vitaliii authored
fast/events/middleClickAutoscroll-nested-divs.html TBR=sahel@chromium.org NOTRY=true Bug: 851090 Change-Id: Iead1902129d55753ed00ebf4c3d4d7ee1e6fbc71 Reviewed-on: https://chromium-review.googlesource.com/1169048Reviewed-by:
-
Matt Falkenhagen authored
I neglected to flush one of the interfaces in r581387. Bug: 862294 Change-Id: Ifaa93c99b160916f34520fa6f840976e0847ae97 Reviewed-on: https://chromium-review.googlesource.com/1168956 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Greg Kraynov authored
SetNextDelayedDoWork() now disregarded in most cases because DoWork() can schedule delayed wake-ups. ScheduleWork() now directly delegates to MessagePump because it's cheaper than testing that we're inside of DoWork(). Bug: 828835 Change-Id: I8417607d73f695099b37bc1066ccdd317b6e190a Reviewed-on: https://chromium-review.googlesource.com/1167508Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581851}
-
Tetsui Ohkubo authored
This is a reland of 76c395e0 Reason for reland: slider initial position was broken. Original change's description: > Fix UnifiedVolumeView asan failure during closing. > > This CL fixes UnifiedVolumeView asan failure when > 1. the slider is in unified system tray main bubble > 2. volume key is pressed during bubble fade out animation > > This is because controllers are deleted before views are deleted. This > is intented because usually controllers are called only when a user > makes mouse event in the bubble. Slider is an exception because > it also notifies controller that value is changed by API although > it's ignored on controller side. Other possible fixes are: > > * Make controller ptr in the view WeakPtr. > * UnifiedSliderView implement Slider listener and not forward changes > caused by API. > > The CL is the least verbose fix. > > TEST=manual > BUG=871005 > > Change-Id: Ifb40b4107e1a04936bf6cd6e0649139498e15746 > Reviewed-on: https://chromium-review.googlesource.com/1164962 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581759} Bug: 871005 Change-Id: I24691cfe371e08251ed13c24b3a60db1e1b2cb9f Reviewed-on: https://chromium-review.googlesource.com/1168882 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581850}
-
