GitLab

This patch moves the routines for consuming <color> and <position> out
of CSSPropertyParser.cpp and into CSSPropertyParserHelpers. We expect
that we'll require these routines for various Houdini APIs.

BUG=499780

Review URL: https://codereview.chromium.org/1802673003

Cr-Commit-Position: refs/heads/master@{#381865}

Make parsing of <transform> more strict by checking
that something valid follows after a comma.

BUG=593321

Review URL: https://codereview.chromium.org/1811953002

Cr-Commit-Position: refs/heads/master@{#381864}

BUG=

Review URL: https://codereview.chromium.org/1811133002

Cr-Commit-Position: refs/heads/master@{#381863}

This feature will (hopefully) improve the performance of Syzyasan builds.

BUG=

Review URL: https://codereview.chromium.org/1671063002

Cr-Commit-Position: refs/heads/master@{#381862}

MojoAudioDecoder is the client side part of the decoder
that runs in the renderer process.

This CL connects it to the remote service and propagates
the media task runner to it.

BUG=542910

Review URL: https://codereview.chromium.org/1797393007

Cr-Commit-Position: refs/heads/master@{#381861}

The settings breadcrumb feature is being removed.
That location on the title bar will become the search
within settings.  This CL removes the breadcrumb
code.

BUG=589630

Review URL: https://codereview.chromium.org/1815523002

Cr-Commit-Position: refs/heads/master@{#381860}

We use fixed color format (kN32_SkColorType) to decode images. Since the default
preferred format is 16-bit color on low-end devices, we can reduce memory
footprint by storing decoded image in 16-bit color format when we use the
default settings for the preferred format. This CL makes
SoftwareImageDecodeController allocate memory based on the preferred format.

I ran memory.blink_memory_mobile 20 times. The results can be found at [1].
I removed SimulateMemoryPressureNotification() so that I can observe memory usage in
common patterns (still, memory pressure notifications would be sent if memory
usage is high). According to the results, we could reduce ~40% discardable
memory on average.

Note that Blink still uses fixed 32-bit color for decoding. This means that
skia/cc will convert decoded images when we store decoded image in 16-bit color.
We might want to make Blink's decoding format configurable in the future.

[1] https://drive.google.com/file/d/0B6NYyLPujP4TaWItc3lsZXR6TTg/view?usp=sharing

BUG=519146
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1808633002

Cr-Commit-Position: refs/heads/master@{#381859}

BUG=593910

Review URL: https://codereview.chromium.org/1809283002

Cr-Commit-Position: refs/heads/master@{#381858}

This contains the last fixes necessary for VS2015 compatibility.

TBR=siggi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1811943004

Cr-Commit-Position: refs/heads/master@{#381857}

Rather than keeping it around forever, we should kill it. Now that the user shell is acting as the login broker for apps run for that user, it's not necessary to keep login too. This simplifies the login app a bit.

BUG=

Review URL: https://codereview.chromium.org/1806203002

Cr-Commit-Position: refs/heads/master@{#381856}

BUG=589194
TEST=Put too many icons on shelf, move shelf to left, click chevron to
open overflow bubble.  Observe that bubble doesn't overlap shelf.

Review URL: https://codereview.chromium.org/1809963003

Cr-Commit-Position: refs/heads/master@{#381855}

This CL extends the ChromeAnimation class to notify
Animatable interfaces that a particular property
animation has finished.

BUG=

Review URL: https://codereview.chromium.org/1801363006

Cr-Commit-Position: refs/heads/master@{#381854}

Review URL: https://codereview.chromium.org/1807093002

Cr-Commit-Position: refs/heads/master@{#381853}

On OSX, NodeChannel::ShutDown() calls into
NodeController::GetMachPortRelay() which acquires |parent_lock_| and
deadlocks due to a recursuve lock acquisition.

BUG=582468

Review URL: https://codereview.chromium.org/1808233003

Cr-Commit-Position: refs/heads/master@{#381852}

This change better handles the non-user-triggered focus event that happens when the dialog loads. The behavior only appears on Mac and when the dialog initially is opened; however, it appears 100% of the time in these cases.

This adds an element with the sole purpose of triggering focus on that element when the dialog is open rather than any of the other header elements. This prevents messing with the tabindex (whether elements are focusable and in what priority) of the other elements. The tabindex of this element is then updated to be unfocusable so that the user cannot accidentally tab to the element.

BUG=594951

Review URL: https://codereview.chromium.org/1807803002

Cr-Commit-Position: refs/heads/master@{#381851}

A performance optimization. This avoids any heap allocations.

BUG=595584
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1806223002

Cr-Commit-Position: refs/heads/master@{#381850}

Avoid most window->shelf lookup calls; misc cleanup.
Remove some ChromeLauncherController auto-hide functions.
(inline pref lookup function call, context menu ops)

Add Shell::OnShelfAlignmentChanged to revise set pattern.
(support ShelfLayoutManager::SetAlignment, w/o Shell::SetShelfAlignment)

Prerequisite for https://codereview.chromium.org/1760743002

BUG=557406
TEST=No behavior changes or regressions.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1812013003

Cr-Commit-Position: refs/heads/master@{#381849}

BUG=547073

Review URL: https://codereview.chromium.org/1807703002

Cr-Commit-Position: refs/heads/master@{#381848}

I expect to add 2 more documents in the follow up:

- clusterfuzz-libfuzzer integration documentation (build bots, corpus, status links, reports)
- reference (fuzzer_test reference, fuzzer options, dictionaries, etc.)

BUG=539572

Review URL: https://codereview.chromium.org/1809843002

Cr-Commit-Position: refs/heads/master@{#381847}

BUG=357747

Review URL: https://codereview.chromium.org/1807893002

Cr-Commit-Position: refs/heads/master@{#381846}

Adds a browser proxy object and implements the setup flow. Tests in a
separate CL.

BUG=563721

Review URL: https://codereview.chromium.org/1806123002

Cr-Commit-Position: refs/heads/master@{#381845}

In r380416, we switched to one accessibility tree per frame, whether site
isolation is on or not. On Android we only want the main frame's
BrowserAccessibilityManager to be connected to the ContentViewCore, not
any child frames.

I modified RWHVAndroid::CreateBrowserAccessibilityManager in that change so
that it wouldn't associate child frames with ContentViewCore, but I got my
logic flipped (in a way that made tests pass, but didn't work in practice).

In fixing it here, I realized that it may not be safe to assume that the
main frame is the first one to create a BrowserAccessibilityManager.
A more robust fix is for RFHI to pass a flag indicating whether it wants
a BAM for the main frame or for another frame.

In the future we may want to use that flag on other platforms, too - like
on Mac really only the main frame's BAM should have the cocoa_view_, but
I'll do that in a follow-up.

BUG=595150
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review URL: https://codereview.chromium.org/1809793002

Cr-Commit-Position: refs/heads/master@{#381844}

The first time IOSurface 2D Canvas was enabled, there were no test failures over
several days. The second time it was enabled (along with a bug fix, and some new
tests), trace_test.IOSurface2DCanvas started flakily failing.

BUG=595754

Review URL: https://codereview.chromium.org/1813073002

Cr-Commit-Position: refs/heads/master@{#381843}

BUG=NONE
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/1811203002

Cr-Commit-Position: refs/heads/master@{#381842}

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus+ash.

BUG=578206

Review URL: https://codereview.chromium.org/1814533002

Cr-Commit-Position: refs/heads/master@{#381841}

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808

Review URL: https://codereview.chromium.org/1813063002

Cr-Commit-Position: refs/heads/master@{#381840}

I accidentally added a media dependency in my last CL:
https://codereview.chromium.org/1799713002/

This CL removes the dependency since we're trying to decouple
media from gpu.

BUG=586384

Review URL: https://codereview.chromium.org/1807263002

Cr-Commit-Position: refs/heads/master@{#381839}

Left upper corner of the rect may not always be the starting position
in the DOM hierarchy, and this assumption was causing crashes.

BUG=589082

Review URL: https://codereview.chromium.org/1806813004

Cr-Commit-Position: refs/heads/master@{#381838}

This change supplements the existing build-time heuristic (which
renders the bad-clock interstitial only when the system clock is outside
the range (build-2d,build+365d)) with a comparison of the system clock
to network time, fetched from |NetworkTimeTracker|.

Network time has priority: if the network time says the clock is
accurate, the bad-clock intersitial will not be used.

The |CLOCK_FUTURE| and |CLOCK_PAST| metrics are recorded only when the
interstitial is shown, however the decision was made.  The new
histograms |interstitial.ssl.clockstate.build_time| and
|interstitial.ssl.clockstate.network| provide data about the state of
the system clock whenever a |CERT_DATE_INVALID| error is encountered.
This should help us to assess the effects of the change.

Future work will focus on providing better network time in more cases.

BUG=589700

Review URL: https://codereview.chromium.org/1772143002

Cr-Commit-Position: refs/heads/master@{#381837}

This is in aid of reusing this code to obtain secure time.

BUG=589700

Review URL: https://codereview.chromium.org/1805263002

Cr-Commit-Position: refs/heads/master@{#381836}

The comment should mention that bumping the version also flushes the
theme cache. I had intended to add that with my recent change but it
slipped my mind. Having the mentioned explicitly would have helped me
when working on the theme regression that needed the version number bump.

BUG=595510

Review URL: https://codereview.chromium.org/1811803002

Cr-Commit-Position: refs/heads/master@{#381835}

Method evaluateOnCallFrame was moved to V8DebuggerAgentImpl.
While evaluatiom on call frame for command line API support, method based on V8WindowCustom binding is used instead existing scope_extension argument. In consequent callFrame was removed from CommandLineLineAPI constructor.
Introduced InjectScopeExtensionByName helper class.

BUG=595206
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1811853002

Cr-Commit-Position: refs/heads/master@{#381834}

This makes it possible for a client to prevent surface contents
from appearing in screenshots or from being visible on
non-secure outputs.

This also removes some oom checks from server.cc that should have
been removed by: https://codereview.chromium.org/1717773002

BUG=549781

Review URL: https://codereview.chromium.org/1802993003

Cr-Commit-Position: refs/heads/master@{#381833}

The resampler can partially consume audio samples (since when resampling,
one output sample can correspond to fractional input samples). By keeping
track of the partially-consumed samples, we can improve the accuracy of
the estimated rendering delay.

BUG=

Review URL: https://codereview.chromium.org/1809203003

Cr-Commit-Position: refs/heads/master@{#381832}

R=dpapad@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/1801293005

Cr-Commit-Position: refs/heads/master@{#381831}

The comment claims it only fails on 10.6, which we don't test anymore.

R=kbr@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/1813883003

Cr-Commit-Position: refs/heads/master@{#381830}

Previously, GN builds would not properly include the Chromium version
build and patch numbers in the Chrome-Proxy header sent to the Data
Reduction Proxy. This CL fixes this, and adds assertions and tests to
ensure that the build and patch numbers are always present.

BUG=595471

Review URL: https://codereview.chromium.org/1808333002

Cr-Commit-Position: refs/heads/master@{#381829}

Autofill wallet metadata notification identifier should be
"WALLET_METADATA" instead of "AUTOFILL_WALLET_METADATA" on the client
side to match the server side sync. The server uses the name of the
protobuf WalletMetadataSpecifics to derive the identifier. This affects
only wallet metadata update notifications.

BUG=593546

Review URL: https://codereview.chromium.org/1806853006

Cr-Commit-Position: refs/heads/master@{#381828}

ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts.

BUG=592422

Review URL: https://codereview.chromium.org/1800213002

Cr-Commit-Position: refs/heads/master@{#381827}

We can expose test_runner::WebTask as blink::WebTaskRunner::Task.
Doing this means that components/test_runner/web_task.h header
no longer needs to be included outside of components/test_runner.

BUG=595089

Review URL: https://codereview.chromium.org/1805753002

Cr-Commit-Position: refs/heads/master@{#381826}