GitLab

1. Automate the selection of the proper channel to enable the verifier.
   Now the code is enabled at runtime.

2. Switch to a hash_map to track handles.

3. Intercept CloseHandle to detect the code that is closing handles owned
   by ScopedHandles. The initial implementation only covers chrome.exe/dll,
   but the plan is to extend that in the future to all modules loaded in the
   process.

BUG=362176

See https://codereview.chromium.org/490043002/ for the initial review.

Review URL: https://codereview.chromium.org/510633002

Cr-Commit-Position: refs/heads/master@{#293365}

Original CL: https://codereview.chromium.org/512693003/

This was reverted because LocationBarBrowserTest.PageActionUITest is flaky on
Mac. Resubmit this, but with the flaky test disabled on mac.

BUG=408261
BUG=410866

Review URL: https://codereview.chromium.org/543783002

Cr-Commit-Position: refs/heads/master@{#293364}

BUG=387069
R=bauerb@chromium.org, jochen@chromium.org
TEST=build succeeds

Review URL: https://codereview.chromium.org/538753003

Cr-Commit-Position: refs/heads/master@{#293363}

BUG=410029,  273089

Review URL: https://codereview.chromium.org/529203002

Cr-Commit-Position: refs/heads/master@{#293362}

BUG=408728,410593

Review URL: https://codereview.chromium.org/532913003

Cr-Commit-Position: refs/heads/master@{#293361}

It also hooks up libpdf which chrome requires at startup.

Adds the enable_hidpi and use_athena build flags.

Adds a locales list.

This makes the chrome target actually runnable from a GN build.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/541153002

Cr-Commit-Position: refs/heads/master@{#293360}

This is separated from https://chromiumcodereview.appspot.com/535373002/
just for CQ safety.

The first one was reverted because it has silly typo on file names.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/541173002

Cr-Commit-Position: refs/heads/master@{#293359}

GLHelper has functionality for testing for appropriate GL readback
format support, caching this information where appropriate. This change
switches RendererGpuVideoAcceleratorFactories over to using that code
for supported format identification and glReadPixels in the desired
format. The code continues to do a software swizzle if necessary.

TEST=WebGL conformance tests
BUG=None

Review URL: https://codereview.chromium.org/456823002

Cr-Commit-Position: refs/heads/master@{#293358}

No fancy animations, this just adds basic functionality. In fullscreen mode,
the tabs are shifted over, and traffic light buttons are manually added in.

BUG=405564

Review URL: https://codereview.chromium.org/508313002

Cr-Commit-Position: refs/heads/master@{#293357}

BUG=352290

Review URL: https://codereview.chromium.org/522763002

Cr-Commit-Position: refs/heads/master@{#293356}

This reverts commit 5f5a7f3f.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/541923002

Cr-Commit-Position: refs/heads/master@{#293355}

Start checking the following names:
- Method names
- Method parameter names
- Local variables

BUG=318404
TRB=qinmin@chromium.org
R=boliu@chromium.org, qinmin@chromium.org, tedchoc@chromium.org

Review URL: https://codereview.chromium.org/543553002

Cr-Commit-Position: refs/heads/master@{#293354}

The compositor makes it possible to customize the message loop proxy
both on the main and impl threads. However BlockingTaskRunner just uses
base::MessageLoopProxy::current() directly and thus overrides this
choice. Using the correct message loop proxy is important because
clients of BlockingTaskRunner have an implicit dependency on the
ordering of tasks posted to BlockingTaskRunner vs. all other tasks
posted to the task runner for that same thread.

This patch fixes the problem by removing the thread-local
BlockingTaskRunner::current() instance in favor of an explicitly
constructed instance which is given a specific SingleThreadTaskRunner
to use. The resource provider is changed to pass a Proxy-owned
blocking task runner to the clients which need one.

BUG=391005
TEST=1. Apply https://codereview.chromium.org/363383002
     2. out/Debug/chrome --disable-impl-side-painting --ignore-gpu-blacklist tools/perf/page_sets/tough_scheduling_cases/raf_canvas.html

Review URL: https://codereview.chromium.org/485043003

Cr-Commit-Position: refs/heads/master@{#293353}

We don't need to do deep copies -- shallow copies will do. However, for
structs and such, we need to carefully work around the shared_definition
nonsense.

R=jamesr@chromium.org
BUG=406156

Review URL: https://codereview.chromium.org/535333002

Cr-Commit-Position: refs/heads/master@{#293352}

BUG=409875
NOTRY=true

Review URL: https://codereview.chromium.org/536553003

Cr-Commit-Position: refs/heads/master@{#293351}

This broke due to r285254 (http://crbug.com/391008), the fix is trivial.

BUG=408809

Review URL: https://codereview.chromium.org/540583002

Cr-Commit-Position: refs/heads/master@{#293350}

This is separated from https://chromiumcodereview.appspot.com/535373002/
just for CQ safety.

TBR=yoz@chromium.org
TEST=None
BUG=407777

Review URL: https://codereview.chromium.org/536323005

Cr-Commit-Position: refs/heads/master@{#293349}

BUG=378035

Review URL: https://codereview.chromium.org/537083002

Cr-Commit-Position: refs/heads/master@{#293348}

Rework the seccomp_bpf compiler internals to work in terms of a single
general masked-equality condition instead of the variety of limited
condition operators previously supported.  All of the peephole
optimizations previously applied continue to be supported so similar
instructions should be emitted, but the handling of upper/lower words
is more cleanly structured now.

The old sandbox->Cond() interface continues to be supported for now so
that the old seccomp_bpf_unittests continue to give us assurances that
the new code generator is still correct.  Meanwhile, we provide a new
lower-level sandbox->CondMaskedEqual() method that bpf_dsl can now use.

BUG=408845
R=jln@chromium.org

Review URL: https://codereview.chromium.org/530133003

Cr-Commit-Position: refs/heads/master@{#293347}

Review URL: https://codereview.chromium.org/538733002

Cr-Commit-Position: refs/heads/master@{#293346}

BUG=409926

Review URL: https://codereview.chromium.org/520093002

Cr-Commit-Position: refs/heads/master@{#293345}

BUG=405274
NOTRY=true

Review URL: https://codereview.chromium.org/538093002

Cr-Commit-Position: refs/heads/master@{#293344}

This removes the hacky fall-back-to-interpolated-time code when audio
ends before video. Considering we're still getting audio render
callbacks during this time, we can simply account for how much
silence we've written to compute the media time.

More importantly, this brings AudioRendererImpl's TimeSource
implementation in line with how WallClockTimeSource operates and gets
us one step closer to removing TimeDeltaInterpolator entirely.

BUG=370634
R=dalecurtis@chromium.org, xhwang@chromium.org

Review URL: https://codereview.chromium.org/518613002

Cr-Commit-Position: refs/heads/master@{#293343}

Context: see https://codereview.chromium.org/511653002/
BUG=

Review URL: https://codereview.chromium.org/540483004

Cr-Commit-Position: refs/heads/master@{#293342}

There were couple issues that were fixed:
1. If oninput listener fires before the guest is requested to "wait
for oninput", we would timeout. This is taken care of by a flag.
2. TextInputClient::SetCompositionText() call sends an IPC to the
renderer/, if the next JavaScript step runs before the IPC is sent
then that would fail the test. This is taken care of by sending
executing empty JavaScript code on the embedder.

BUG=387956
Test=Internal test only change, nothing visible.

Review URL: https://codereview.chromium.org/532883003

Cr-Commit-Position: refs/heads/master@{#293341}

Changes are needed for Chrome for Android using nano protobufs.

Full list of changes:

r339 Adding forwarding implementation of WakeLockManager in its original location (temporary workaround for Chromium)
r338 * Updating example code to use nano protos instead of lite protos * Addressing Android lint warnings
r337 Removing unused ticl.ProtoWrapper class and moving example code
r336 Android cache invalidation client release August 2014

Depends on https://codereview.chromium.org/532303003/

BUG=377891

Review URL: https://codereview.chromium.org/513293002

Cr-Commit-Position: refs/heads/master@{#293340}

This change will make it so that a fake UserGestureIndicator is not set for
every javascript execution request triggered by the browser. This was
interfering with how the virtual keyboard handles programmatic focus() calls on
load.

This is part 2 of 3, depends on blink change:
https://codereview.chromium.org/516753002

BUG=408426, 406336

Review URL: https://codereview.chromium.org/518583003

Cr-Commit-Position: refs/heads/master@{#293339}

Review URL: https://codereview.chromium.org/525513003

Cr-Commit-Position: refs/heads/master@{#293338}

BUG=None
R=achuith@chromium.org, zelidrag@chromium.org

Review URL: https://codereview.chromium.org/539733002

Cr-Commit-Position: refs/heads/master@{#293337}

In the new enhanced bookmark UI, Uncategorized items are bookmarks
under mobile and others node.

BUG=386785

Review URL: https://codereview.chromium.org/533363002

Cr-Commit-Position: refs/heads/master@{#293336}

R=blundell@chromium.org

Review URL: https://codereview.chromium.org/539023002

Cr-Commit-Position: refs/heads/master@{#293335}

Removed tailing \ character from the example usage to
make GCC to forget the multi-line comment warning.

BUG=410777
TEST=build with gcc

Review URL: https://codereview.chromium.org/534383003

Cr-Commit-Position: refs/heads/master@{#293334}

Looks like there's fewer bitmaps than cursor types. On CrOS X11 we
fallback to left pointer, so do the same here.

BUG=410870
TEST=manual on link_freon
NOTRY=true

Review URL: https://codereview.chromium.org/540103002

Cr-Commit-Position: refs/heads/master@{#293333}

BUG=409636

Review URL: https://codereview.chromium.org/532533002

Cr-Commit-Position: refs/heads/master@{#293332}

BUG=279351

Review URL: https://codereview.chromium.org/540613002

Cr-Commit-Position: refs/heads/master@{#293331}

BUG=

Review URL: https://codereview.chromium.org/537893002

Cr-Commit-Position: refs/heads/master@{#293330}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/545443002

Cr-Commit-Position: refs/heads/master@{#293329}

- Add null-checks
- Return an empty mime/thumbnailUrl instead of error if request is succeeded (media_manager.js)
- Make savedVolume_ consistent (media_controls.js)

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/537863002

Cr-Commit-Position: refs/heads/master@{#293328}

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/522543002

Cr-Commit-Position: refs/heads/master@{#293327}

Reland of https://codereview.chromium.org/477973002/

There was a memory leak.  EndEnumeration wasn't called on the iterator.

Fixed and tested with ASAN.

The leak was detected because SimpleCache doesn't clean up its enumerators on deletion, but it should.  See https://code.google.com/p/chromium/issues/detail?id=410276

BUG=392621

Review URL: https://codereview.chromium.org/528233003

Cr-Commit-Position: refs/heads/master@{#293326}