- 23 Sep, 2016 40 commits
-
-
cwallez authored
https://chromium.googlesource.com/angle/angle.git/+log/c287ea6..28a97ee BUG=chromium:648031,chromium:648135,648063,607283,645532,chromium:648074 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Merge branch 'master' of https://chromium.googlesource.com/chromium/src fuzzers: add a fuzzer for the ANGLE shader translator BUG=angleproject:1522 Review-Url: https://codereview.chromium.org/2364873003 Cr-Commit-Position: refs/heads/master@{#420732}
-
bnc authored
* Remove HttpNetworkSession::enabled_protocols_. * Spell out AlternateProtocol enum values in HttpNetworkSession::IsProtocolEnabled() and in HttpServerProperties::IsAlternateProtocolValid(). * Remove ALTERNATE_PROTOCOL_MAXIMUM_VALID_VERSION, ALTERNATE_PROTOCOL_MINIMUM_VALID_VERSION, enum AlternateProtocolSize. BUG=116575 Review-Url: https://codereview.chromium.org/2362233002 Cr-Commit-Position: refs/heads/master@{#420731}
-
ntfschr authored
If Webview is started in an application using defaultToDeviceProtectedStorage="true", it will first try to switch to a CE context. If it's unable to switch contexts, it throws an exception. BUG=645921 Review-Url: https://codereview.chromium.org/2339343002 Cr-Commit-Position: refs/heads/master@{#420730}
-
lazyboy authored
Specifically this CL moves files related to the following APIs/Natives: certificate_provider quick_unlock_private file_system_provider platform_keys_natives & enterprise.platformKeys and friends Locally, I also see linux (non-chromeos) binary size reducing by ~5.6k [1] BUG=376319 [1]: With patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61426832 Sep 22 17:43 out/Release/chrome Without patch: ls -al out/Release/chrome -rwxr-x--- 1 lazyboy eng 61432496 Sep 22 17:44 out/Release/chrome Review-Url: https://codereview.chromium.org/2367653002 Cr-Commit-Position: refs/heads/master@{#420729}
-
falken authored
Original patch author: horo@ at https://codereview.chromium.org/2248583003/ bug 608049 is a top crasher on stable channel. The cause is that render process hosts are not reliably destructing on shutdown because shared workers keep them alive. Shared worker bookkeeping is expected to return the worker ref counts to zero when documents close, but I suspect it often doesn't finish in time for shutdown since it requires posting tasks between the IO thread and UI thread. https://crrev.com/798a8b94726d3c439e6302998f31bc487f521ec8 tried to solve the bug by removing waiting for an IPC from the renderer process, but the thread hopping means shutdown is still racy. This patch forcibly sets the ref counts to 0 on the UI thread when the browser context is shutting down, similar to what we do for service workers. BUG=636377,608049 Review-Url: https://codereview.chromium.org/2342523002 Cr-Commit-Position: refs/heads/master@{#420728}
-
dpranke authored
Since the builders are being removed. R=dnj@chromium.org BUG=649579 Review-Url: https://codereview.chromium.org/2358133005 Cr-Commit-Position: refs/heads/master@{#420727}
-
ryansturm authored
This introduces an in memory blacklist for previews. This also introduces an interface for retrieiving prior sessions information from a store. The blacklist is keyed on fully qualified domain name and will blacklist domains based on user history of opt-outs on those domains. This does not yet implement adding preview navigations to the blacklist or using the blacklist to determine site navigation eligibility. Nor does this CL implement the backing store. BUG=639087 Review-Url: https://codereview.chromium.org/2335023002 Cr-Commit-Position: refs/heads/master@{#420726}
-
bnc authored
* Remove all unnecessary IsSpdyAlternative() checks. IsSpdyAlternative() implies origin_url_.SchemeIs(url::kHttpsScheme), see DCHECK in constructor. * Inline now const |spdy_certificate_error_|. * Inline and remove SwitchToSpdyMode(). This method was only used twice out of four potential places. Removal makes sense as the method is trivial, and there are no corresponding methods for |using_spdy_ = false|, |using_quic_ = true|, and |using_quic_ = false| assignments. * Use url_constants instead of string literals for schemes (http, https, ftp, and wss). There has already been two uses of such constants. * Remove unused |destination| local variable. * Fix some comments. * git cl lint: Remove unnecessary semicolon, add includes. BUG=475060 Review-Url: https://codereview.chromium.org/2359153003 Cr-Commit-Position: refs/heads/master@{#420725}
-
apacible authored
Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 Review-Url: https://codereview.chromium.org/2363033002 Cr-Commit-Position: refs/heads/master@{#420724}
-
maxbogue authored
BUG= Review-Url: https://codereview.chromium.org/2363853002 Cr-Commit-Position: refs/heads/master@{#420723}
-
rockot authored
ServiceManager is trying to use an out-of-process native runner in production, which is a big no-no. This adds some junk to help track that down. BUG=649673 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2369543002 Cr-Commit-Position: refs/heads/master@{#420722}
-
open.hyperion authored
Updated and refactored URLIndexPrivateData::HistoryItemsForTerms to handle searching the history for both the original search string as well as the string with a break inserted. The goal is to support mid-word autocomplete in the Omnibox. Currently, if the user types "funtimes", inserts the cursor between the "n" and the "t" and begins typing the word "good" the Ominbox will search for URL results that match "fungood times" only. We want to also search for "fungoodtimes". BUG=591979 TEST=0. Clear browser history. 1. Visit the following link: https://twitter.com/fungoodtimes 2. Open a new browser tab. 3.Type into the Omnibox "funtimes". Note the lack of the suggestion for the above URL. 4. Insert the cursor between the "n" and "t" in "funtime" and type "good". 5. The above URL should show in the autocomplete list. Review-Url: https://codereview.chromium.org/2364553004 Cr-Commit-Position: refs/heads/master@{#420721}
-
yiyix authored
Introduced a new layout for accessibility detailed view. Each row now contains a vectorized icon which is shown on left, a description which is shown in the middle and a check mark is shown on the right. The row on the bottom which contains "setting" option and "learn more" option is removed and it will be included in the title row in the future cls. This CL also updates the description of ChromeVox from "ChromeVox (Spoken feedback)" to "ChromeVox (spoken feedback)" TEST=tray_accessibility_browsertest BUG=632102 Review-Url: https://codereview.chromium.org/2343603003 Cr-Commit-Position: refs/heads/master@{#420720}
-
melandory authored
BUG=647248 Review-Url: https://codereview.chromium.org/2344663003 Cr-Commit-Position: refs/heads/master@{#420719}
-
tedchoc authored
This change, http://crrev.com/2297193003, introduced a chrome specific InvalidationClientService, but it did not properly update all the appropriate references. This pulls the registered service from the AndroidManifest.xml if applicable. Does it through this indirection as components/ is unaware of chrome/. BUG=647774 Review-Url: https://codereview.chromium.org/2352943002 Cr-Commit-Position: refs/heads/master@{#420718}
-
rockot authored
It needs to be a public dependency as it's exposed by chrome/browser/ui/browser.h and uses generated code. BUG=649766 R=thakis@chromium.org TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2368633002 Cr-Commit-Position: refs/heads/master@{#420717}
-
clm authored
Review-Url: https://codereview.chromium.org/2361413002 Cr-Commit-Position: refs/heads/master@{#420716}
-
paulmeyer authored
This patch implements new find-in-page functionality that allows for frames that are either newly added or navigated during a find session to be automatically searched so that matches in their new content are automatically highlighted and included in the results shown in the find bar. Also, there is a fix included in this patch to prevent the find-in-page bar from closing when a subframe navigates (the find session should only end if the main frame navigates). Design doc: https://docs.google.com/document/d/1r4F19FIKg4zPJCaSyJ9-T0sgFbxlCGKL3FjqQEAKegg/view BUG=2220,621660 Review-Url: https://codereview.chromium.org/2236403004 Cr-Commit-Position: refs/heads/master@{#420715}
-
agrieve authored
This will give us an easy toggle for testing out obfuscation. BUG=620323 Review-Url: https://codereview.chromium.org/2369573002 Cr-Commit-Position: refs/heads/master@{#420714}
-
zmin authored
BUG=642059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2351173004 Cr-Commit-Position: refs/heads/master@{#420713}
-
ekaramad authored
Currently, with the flag --use-cross-process-frames-for-guests switched on, MimeHandlerView still creates a BrowserPlugin while on the browser side we expect an OOPIF based implementation. This causes PDF viewer to crash. On the other hand, GuestViews will soon use OOPIF. Hence, temporarily, we need to make MimeHandlerView an exception and force it to use BrowserPlugin's codepath even when the switch above is turned on. BUG=563285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2165523004 Cr-Commit-Position: refs/heads/master@{#420712}
-
dmazzoni authored
It was using different time calls for the start time and current time. BUG=589632 Review-Url: https://codereview.chromium.org/2367693003 Cr-Commit-Position: refs/heads/master@{#420711}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/cc0937273030..aa840647fc7f $ git log cc0937273..aa840647f --date=short --no-merges --format='%ad %ae %s' 2016-09-23 bsalomon Don't compute path keys for volatile paths in GrShape. 2016-09-23 csmartdalton Add Pixel C knobs to skpbench 2016-09-23 jvanverth Some Vulkan memory fixes and cleanup 2016-09-23 reed change SkXfermodeImageFilter to carry no impl information BUG=649562 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=borenet@google.com Review-Url: https://codereview.chromium.org/2367933002 Cr-Commit-Position: refs/heads/master@{#420710}
-
eroman authored
parse an entire Certificate. (Part of a series of changes for simplifying the parsing tests to be in terms of just certificates for consistent entry point and expectations) BUG=634443 Review-Url: https://codereview.chromium.org/2361233002 Cr-Commit-Position: refs/heads/master@{#420709}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/446c7dc4627650a1011b835c3e452ed2114f81df Add result_details as a log of nest step. (hzl@google.com) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=605572 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2364183002 Cr-Commit-Position: refs/heads/master@{#420708}
-
alexclarke authored
The TimeDomain now only knows about the first wake up per queue and the system tries to only have one pending delayed DoWork posted on the base runloop. Because of this any cancelled delayed tasks get removed by TaskQueueImpl::WakeUpForDelayedWork before a wakeup is requested. TimeDomain has been changed to take advantage of this new limitation and several redundant methods have now been removed. The bug which caused the revert of V1 has been fixed, specifically ThrottlingHelper::PumpThrottledTasks doesn't get broken by the new assumptions since we're no longer using ClearExpiredWakeups. BUG=638542, 605718 Review-Url: https://codereview.chromium.org/2359493002 Cr-Commit-Position: refs/heads/master@{#420707}
-
kbr authored
BUG=639145, 649250 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel NOTRY=true Review-Url: https://codereview.chromium.org/2360353002 Cr-Commit-Position: refs/heads/master@{#420706}
-
brettw authored
This disables header checking for split static libraries. In addition to the internal issues discussed in the added comment to split_static_library.gni, there is a circular include cycle between //chrome/browser and //chrome/browser/ui. Both of these are split static libraries, so enabling check for this configuration would additionally require listing all of the split ui targets in the allow_circular_includes_from annotation in the browser target. Since this is only for official builds, we still get header checking on the normal builds so there should be no missing coverage for header checking. R=dpranke@chromium.org Review-Url: https://codereview.chromium.org/2363083003 Cr-Commit-Position: refs/heads/master@{#420705}
-
dcheng authored
This hook automatically installs and maintains a merge tool config for the clang-format merge driver, which can help automatically resolve conflicts that arise from clang-format reformatting patches. Note that this change does not have any impact other than tweaking the git config of the main project). The custom merge driver will later be activated by updating .gitattributes with lines like: *.cpp merge=clang-format *.h merge=clang-format BUG=574611 Review-Url: https://codereview.chromium.org/2359933005 Cr-Commit-Position: refs/heads/master@{#420704}
-
jbudorick authored
BUG=649693 Review-Url: https://codereview.chromium.org/2364083002 Cr-Commit-Position: refs/heads/master@{#420703}
-
tedchoc authored
Custom tab context menus worked previously because CustomTabActivity was in charge of creating the initial tab, and all subsequent tabs reuse the delegate of the parent tab. When restoring, the TabModelSelectorImpl via TabPersistentStore was creating the tabs and using the default logic in ChromeTabCreator. This change moves ChromeTabCreator creation to the activities themselves, which allows CCTs to overwrite the default tab delegate construction. This also moves the svelte tab saving logic to the selector, which is consistent with all other tab saving behavior (and allows the activity to be unaware of that dependency and enables creation w/ fewer params). BUG=649139 Review-Url: https://codereview.chromium.org/2359923005 Cr-Commit-Position: refs/heads/master@{#420702}
-
tommycli authored
Since the browsertest modifies the feature flags after browser startup, it can lead to inconsistent and unexpected behavior. This CL preserves the existing features flags. BUG=649783 Review-Url: https://codereview.chromium.org/2362383002 Cr-Commit-Position: refs/heads/master@{#420701}
-
dewittj authored
This check is implementation-dependent (and unused outside the model). As such it belongs only inside the offline page model. BUG=622763 Review-Url: https://codereview.chromium.org/2345133002 Cr-Commit-Position: refs/heads/master@{#420700}
-
jbudorick authored
BUG=634052 Review-Url: https://codereview.chromium.org/2366763003 Cr-Commit-Position: refs/heads/master@{#420699}
-
skym authored
pattern, and fixed lint violations. BUG=647875 Review-Url: https://codereview.chromium.org/2365763002 Cr-Commit-Position: refs/heads/master@{#420698}
-
John Abd-El-Malek authored
BUG=504347 R=scottmg@chromium.org Review URL: https://codereview.chromium.org/2368563003 . Cr-Commit-Position: refs/heads/master@{#420697}
-
kbr authored
BUG=none NOTRY=true Review-Url: https://codereview.chromium.org/2367493003 Cr-Commit-Position: refs/heads/master@{#420696}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8358e322..12bdd904 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2360343005 Cr-Commit-Position: refs/heads/master@{#420695}
-
robliao authored
BUG=637095 Review-Url: https://codereview.chromium.org/2360053002 Cr-Commit-Position: refs/heads/master@{#420694}
-
ellyjones authored
When the tab switches between allowed and blocked, cookie info from the previous tab should no longer be shown. BUG=649006 Review-Url: https://codereview.chromium.org/2361123002 Cr-Commit-Position: refs/heads/master@{#420693}
-