GitLab

Explaining why we look up a Profile for accessibility events even
though we don't use it.

Bug: none
Change-Id: I7edf8958612c87569900faa06c1d7e3d7a63caac
Reviewed-on: https://chromium-review.googlesource.com/1119027Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571205}

Its callers are AudioNodeInput::Enable and AudioHandler::MakeConnection,
which already assume that they own the graph.

Bug: 856641
Change-Id: I04b8c910a335129e6c522f968fb2b913805cdc18
Reviewed-on: https://chromium-review.googlesource.com/1118757Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571204}

The dependency on content/public/browser is causing linker errors for
some builds. Switching this to a forward declaration solves the problem.

Bug: 110846462
Test: Builds correctly for targets the previously had missing symbols
Change-Id: Icd83e5f149f463d70bfcc730ba6fe416654d2d38
Reviewed-on: https://chromium-review.googlesource.com/1115774Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#571203}

Bug: 827376
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I16781ef2ad241f28da0eef3126d9b6a66840f828
Reviewed-on: https://chromium-review.googlesource.com/1105568
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571202}

As per dgozman@ TODO.

Bug: 789577
Change-Id: Ia2fd373ea8b1578af35c15d86aa5d4b853dbf765
Reviewed-on: https://chromium-review.googlesource.com/1117688Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571201}

This patch implements StartNotify such that it can take a cccd_value and
notify the application on what type of notification is requested by a
remote device.

In addition, we read optional device_path also in Start/StopNotifiy().

A relevant patch is crrev.com/c/1114351

Bug: b:78593133
CQ-DEPEND: CL:1114351
Test: Pass Android CtsVerifier test on server sending indication/notification
Change-Id: I51812ab29292fe5af9958b9b0c2314f4b801b9c2
Reviewed-on: https://chromium-review.googlesource.com/1114310
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571200}

Apparently, the ComputedStyle on a child may change during
LayoutBlock::ComputeBlockPreferredLogicalWidths. We used to keep a
reference to the ComputedStyle on the stack before [1]. Re-introducing
scoped_refptr here.

The reduced test exposed a DCHECK problem tracked by 389648. Instead of
adding an almost identical new test, with another TestExpections line,
we add writing-mode to the existing test which would expose the ASAN
issue as well.

[1] https://crrev.com/0aca50f1552c882bc72ed5c419085fa975847a9c

Bug: 853538, 389648
Change-Id: I5cb09c8cd9a7ae6d0621758f4690fce2abbb8096
Reviewed-on: https://chromium-review.googlesource.com/1117697
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571199}

Merge internal change: 202416832

Change-Id: Id6d5e9d5cd8bf2c43bca133ef2fa830b1faea3de
Reviewed-on: https://chromium-review.googlesource.com/1117930Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571198}

webaudio: Use AudioHandler::BreakConnectionWithLock in BaseAudioContext::PerformCleanupOnMainThread.

PerformCleanupOnMainThread acquires the lock on the associated context, so
acquiring it recursively is unnecessary.

Bug: 856641
Change-Id: I603a0f1ca070076dcfb841bdeddd2876e28ec0d8
Reviewed-on: https://chromium-review.googlesource.com/1118606Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571197}

When building using Jumbo unnamed namespaces gets merged
and variables with the same name conflict. This happens
for the variables kTitleIconSize in
views/ime/ime_window_frame_view.cc,
views/relaunch_notification/relaunch_recommended_bubble_view.cc
and views/relaunch_notification/relaunch_required_dialog_view.cc.

This commit solves the issue by moving the variables from
the namespace to the class. It also moves other variables
in the same namespace, to keep the files locally consistent.

Bug: 773275
Change-Id: I0ec9b735f6f6c579bebe61ab6a1a8cfcac876f56
Reviewed-on: https://chromium-review.googlesource.com/1107619
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571196}

Inset media contols by the safe area to avoid overlapping
the display cutout.

BUG=857252

Change-Id: I38c25a07f880cd93caf6c89662e541f52096e638
Reviewed-on: https://chromium-review.googlesource.com/1117835Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571195}

Created new flag, --diff-with, which will diff two .size files and display their
relative sizes instead of the absolute sizes in a single .size file.

Preview at:
https://notwoods.github.io/chrome-supersize-reports/monochrome-diff-2018-06-27/

Reports can be compiled by running:
```
tools/binary_size/supersize html_report after.size --diff-with before.size --tree-view-ui --report-dir diff-report
xdg-open diff-report/index.html
```

Bug: 847599
Change-Id: I860ce6cd70c7261d3053d6a259f0208d74f0b35e
Reviewed-on: https://chromium-review.googlesource.com/1117758
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571194}

This reverts commit 4ffc8d34.

Reason for revert: Consistently failed the bot https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Audio%20Linux

Original change's description:
> Layout table roles should provide name from contents when used recursively.
> 
> Recent table refactoring means we expose more layout tables. This is
> generally a good thing.
> 
> It broke some accessibility in Hangouts, where there was a layout table
> inside of an ARIA button and the accessible text of the button came from
> inside the layout table. Previously the layout table was just exposed as
> generic elements, and layout table roles should behave the same way with
> regards to how text is exposed to ancestors.
> 
> Bug: 856277
> Change-Id: I9b30931b306fda09a5408df4dc3b3dd1c54e619e
> Reviewed-on: https://chromium-review.googlesource.com/1117628
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571139}

TBR=dmazzoni@chromium.org,aleventhal@chromium.org

Change-Id: I496fb5987f7155064193ae475d45a00c7dbbb3b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 856277
Reviewed-on: https://chromium-review.googlesource.com/1118945Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571193}

The old code marked these clicks as LINK which causes unintended
consequences because they are treated as normal webpage link clicks.
This change marks them as AUTO_BOOKMARK like other forms of UI
generated navigations.

Bug: 856788
Change-Id: Id1634e7c4f6a2286bd518db28f8b0d77c899e259
Reviewed-on: https://chromium-review.googlesource.com/1117870Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@google.com>
Cr-Commit-Position: refs/heads/master@{#571192}

The primary goal was to make ThrottledTimeDomain directly
inherit TimeDomain since RealTimeDomain gets moved to //base
and will be made internal. Since we can't use TaskQueueManagerImpl
outside of scheduler/base it was required to make the TimeDomain
deal with it, that caused API changes, and finally it makes sense
to update doc comments when API changes. It could be nice to break
this down into a smaller CLs, but most changes here are pretty
dependant on each other.

Bug: 857101
Change-Id: I5cd3352f714bf1b0f6e89255c5bc31cc540336c4
Reviewed-on: https://chromium-review.googlesource.com/1107977
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571191}

This CL updates the sizing-medium and sizing-large CSS class rules to
reduce the sizes. This update makes sizing-large mostly useless, but to
avoid making this change too complex for merging into M68, we are
updating the CSS rules in the simplest way and have added a followup
cleanup task to remove the sizing-large CSS class and other redundant
CSS rules.

Bug: 857145
Change-Id: Ifd80ff7137221f4ca86d0c27f7c4042ec569ef06
Reviewed-on: https://chromium-review.googlesource.com/1117315
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571190}

BUG=

Change-Id: I79be463e073aff1c6def72032fd362dd3b83f66d
Reviewed-on: https://chromium-review.googlesource.com/1118763Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571189}

https://android.googlesource.com/platform/external/perfetto.git/+log/bd16a937023d..01b356851646


git log bd16a937023d..01b356851646 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 michaschwab@google.com Begin mithril frontend


Created with:
  gclient setdep -r src/third_party/perfetto@01b356851646

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ibb9d8331e359c86e24150d124b7910ff8d0e5ef2
Reviewed-on: https://chromium-review.googlesource.com/1118566
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571188}

This was accidently removed in e6ae00bf ("[Ozone/Magma] Ozone Magma
Platform").

Bug: none
Test: compile
TBR: camurcu@google.com
Change-Id: Ic3920d638d9e1495d48626e0f994a11f4f148237
Reviewed-on: https://chromium-review.googlesource.com/1118745Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571187}

Noticed unnecessary api usage of factory's GetInstance function. Factory
is a singleton, so no real optimization, but make calls more
transparent.

Test: behavior unchanged and passes chromeos_unittests
Change-Id: I38bf5d1b7f498d975ad348bd3c8aa02c8b38166a
Reviewed-on: https://chromium-review.googlesource.com/1117270Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571186}

This seems to not have been caught by CQ.
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1110221
TBR=haraken@chromium.org

Bug: 856643
Change-Id: Ib17dcaeb656f114527f3d31f16dc2bb9971b6f95
Reviewed-on: https://chromium-review.googlesource.com/1118556Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571185}

TBR=atwilson

Bug: 844950
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I92e5e1f9f28489ec265c89a11c932af47a8a48b7
Reviewed-on: https://chromium-review.googlesource.com/1113029
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571184}

We already don't save "Never translate <website>". We want the same behavior for
"Never translate <language>" in order to be consistent. Additionally, the
"Always translate" button doesn't work in incognito mode.

1. Remove the "Always translate <language>" button in incognito mode, on desktop
   and Android.

2. Don't persist "Never translate <language>" if clicked in incognito mode, but
   still apply it to the current session.

Needs more work to update the iOS UI.

Bug: 793925
Change-Id: I53f9bbd8dbcf605ef0682bf993b2835ab0ba92aa
Reviewed-on: https://chromium-review.googlesource.com/1115204Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571183}

https://crrev.com/c/1110371 added some preferences from
PrivacyPreferences to SyncAndServicesPreferences. This CL removes these
preferences from PrivacyPreferences if UnifiedConsent feature is
enabled so they aren't shown in two different screens.

Bug: 814728
Change-Id: Ic1e573a13aebd2d8df056e1da6299d15f9a8bfdc
Reviewed-on: https://chromium-review.googlesource.com/1117074Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571182}

Bug: 775415
Change-Id: I69c7fcae44cd2d330c175da5ad588d861fd17e95
Reviewed-on: https://chromium-review.googlesource.com/1116793
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571181}

Now that the ThirdPartyConflictsManager can be destroyed at runtime,
it is no longer safe to pass an unretained reference to the ModuleListFilter
to a background task.

Also fixes setting the ThirdPartyConflictsManager's terminal state in
its destructor.

Change-Id: Idcc5f5aa6c69911d29c402c91372fce6bf376df5
Reviewed-on: https://chromium-review.googlesource.com/1112459
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571180}

1. Pagination buttons were enlarged from 4dip radius to 5dip radius
2. Pagination button stroke width was changed to 2dip from 1dip
3. Removed padding between buttons
4. Enlarged InkDrop radius.

Bug: 856678
Change-Id: Ie4754848373a635a045c7366462e6bcde0499194
Reviewed-on: https://chromium-review.googlesource.com/1114306
Commit-Queue: Daniel Zhang <oxyflush@google.com>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571179}

In homecher, suggestion chips will replace suggested apps.
1. Modify SuggestionChipView to alter between assistant style and app
   list style based on input parameter.
2. Add the SearchResultSuggestionChipView which contains a
   SuggestionChipView.
3. Add the SuggestionChipContainerView to contain a list of suggestion
chips.

Bug: 855282
Change-Id: I3ee78198aafa5c480f97ee3d3bf9a6aa70504e20
Reviewed-on: https://chromium-review.googlesource.com/1112436
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571178}

Bug: None
Test: None
Change-Id: Ib4e8dde9bee345b877064cbe00b21bc5827912ad
Reviewed-on: https://chromium-review.googlesource.com/1117755Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Matt Swartwout <mwswartwout@google.com>
Cr-Commit-Position: refs/heads/master@{#571177}

This change introduces a Priority parameter for
component_updater::OnDemandUpdater::OnDemandUpdate.

The change is mechanical for the existing implementation.

Bug: 857215

Change-Id: I736b2ece704a8dda8d8f2d5a0d6d6419ceb22402
Reviewed-on: https://chromium-review.googlesource.com/1111558Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571176}

TBR=kbr@chromium.org

Bug: 857527
Change-Id: I3b8cc86a3728dab2633f2dda0ebf1eb6090cdb35
Reviewed-on: https://chromium-review.googlesource.com/1118755Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571175}

Omnibox entity suggestions with two lines of text will layout
as before, but now if the second line description is absent,
the primary content text line will be vertically centered.

Bug: 856703
Change-Id: Ie672ccece28be79d18bf6f7f07f9937af434178d
Reviewed-on: https://chromium-review.googlesource.com/1115760
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571174}

Some detached requests fail because the network changes between
requests. Retry the request in this case, only once.

Bug: 851399
Change-Id: Ic77c28e5ac49fecaf634e4a225c8f443f75e2560
Reviewed-on: https://chromium-review.googlesource.com/1118262Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571173}

https://developer.android.com/reference/android/Manifest.permission.html#FOREGROUND_SERVICE

BUG=

Change-Id: Ie3e01cea3d810373d804c2a56d42d5f4f44607f9
Reviewed-on: https://chromium-review.googlesource.com/1117135Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571172}

Bug: 854598
Change-Id: I457e8940a4ad5ff4aa89cfae4415f0addd1e6a64
Reviewed-on: https://chromium-review.googlesource.com/1118621
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571171}

This reverts commit fed0e8ec.

Reason for revert: It broke most of the chrome_informational builders at BuildPackages stage. See crbug.com/857133 for details. 

Original change's description:
> Pull GN via CIPD package
> 
> This is a reland of
> https://chromium-review.googlesource.com/c/chromium/src/+/1112840.
> 
> 
> The gn binary will be downloaded into third_party/gn. This CL rolls
> buildtools forward to a revision where the gn binary is a stub that
> prints an error message and returns 1. This is to avoid depending
> on the old location, and helping users relying on gn auto regen.
> 
> Update mb.py to use the new location.
> 
> Update explicit location in ios/web_view/BUILD.gn for the new location.
> 
> Update explicit location in
> tools/traffic_annotation/auditor/traffic_annotation_auditor.cc for the new
> location.
> 
> Update explicit location in tools/licenses.py with for the new location.
> 
> Update explicit location in testing/libfuzzer/gen_fuzzer_owners.py.
> 
> Bug: 855791
> Bug: 856883
> Bug: 856884
> Bug: 856878
> Bug: 856899
> Bug: 857107
> Bug: 857110
> Change-Id: Iedaa29161e56cc90beafd802efca3a6c12859c58
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1117264
> Commit-Queue: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571031}

TBR=dpranke@chromium.org,scottmg@chromium.org

Change-Id: I28962c879b7bc24e809b29427122bb425e9450a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 855791, 856883, 856884, 856878, 856899, 857107, 857110
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118825Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571170}

It was reenabled in f73246ba.
No, it is still flaky.

BUG=845267
TBR=kbr@chromium.org

Change-Id: I4ad193b01738945c63dfa12585be7b9354408b49
Reviewed-on: https://chromium-review.googlesource.com/1118528Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571169}

This reverts commit fe55ead6.

Reason for revert: UX direction change.

Original change's description:
> Revert "Omnibox UI Refresh: Align Omnibox text to new Suggestion text"
> 
> This reverts commit 0830cdf0.
> 
> Reason for revert: UX direction change.
> 
> Original change's description:
> > Omnibox UI Refresh: Align Omnibox text to new Suggestion text
> > 
> > The goal of the CL is to re-align the Omnibox text to match the new
> > Refresh spec.
> > 
> > In the new Refresh spec, the text has a different indentation depending
> > on whether or not the popup is open, so this CL resets the insets
> > of the OmniboxViewViews whenever the popup opens or closes.
> > 
> > It also updates LocationBarView to no longer ignore the left-inset
> > value of the OmniboxViewViews. We used to also ignore the right-inset
> > value, but we stopped doing that recently [1].
> > 
> > After no longer ignoring the left-inset value, we update the
> > non-Refresh value to the correct value of 0 (to keep things looking
> > the same), and update the Refresh value to 2, which matches mocks.
> > 
> > We are updating the inset of the OmniboxViewViews textfield instead of
> > the bounds of the textfield because we want the whole area to remain a
> > clickable I-beam, even if we indent the text a bit.
> > 
> > [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc
> > 
> > Bug: 849779, 823535
> > Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4
> > Reviewed-on: https://chromium-review.googlesource.com/1096491
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> > Commit-Queue: Tommy Li <tommycli@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566834}
> 
> TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 849779, 823535
> Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90
> Reviewed-on: https://chromium-review.googlesource.com/1117218
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570847}

TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org

Change-Id: Ib5afb6cc4e892594e3cfdd0c775ae6ef1e4f862f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 849779, 823535
Reviewed-on: https://chromium-review.googlesource.com/1118785Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571168}

Bug: 855620

Change-Id: Id4da3e42581147261f706c15f3649a38fad52ff1
Reviewed-on: https://chromium-review.googlesource.com/1117031
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571167}

Move tough_compositor_cases.py into the rendering folder and refactor
classes to inherit from RenderingStory

Bug: 849392
Change-Id: I0a675d99f81a7588612e648e9ad5c3fef210e8d1
Reviewed-on: https://chromium-review.googlesource.com/1117574
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#571166}