GitLab

Also filled in some JavaDocs to satisfy the linter.

BUG=355072
TEST=AndroidWebviewTest

Review URL: https://codereview.chromium.org/230673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263041 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Suspect this broke RenderTextTest.ElidedText in http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds/27081.


Original issue's description:
> Fix creating platform font on Windows
> 
> fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to
> 1). ScriptShape fails to generate glyphs on Windows XP for some complex
> scripts (Hindi text for instance) if font is created with fdwCharSet=0.
> 
> Other paramaters are unchanged because they still expand to 0.
> 
> BUG=361994
> 
> TEST=On Windows XP, go to Control Panel and Regional and
> Language Options. Under Languages tab check Install files
> for Complex Script and right-to-left languages (including
> Thai) and Install files for East Asian languages. Click
> Details and install Hindi language. Launch Chromium. Go to
> advanced settings and go to Languages. Add Hindi language
> and click Display Chromium in this language button. Restart
> Chromium. Expected result: Hindi font glyphs should be
> properly generated for all UI elements (tabs, menus,
> notification panels).
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263001

TBR=asvitkine@chromium.org,msw@chromium.org,tmoniuszko@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=361994

Review URL: https://codereview.chromium.org/228703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355611

Review URL: https://codereview.chromium.org/230773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263037 0039d316-1c4b-4281-b951-d872f2087c98

ContentMainRunner is part of content module public classes, so it should be exported using CONTENT_EXPORT.

BUG=361976

Review URL: https://codereview.chromium.org/232203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263036 0039d316-1c4b-4281-b951-d872f2087c98

I've also updated the most straightforward changes to just remove
references to WebFrame altogether. Code that uses a mixture of both
throughout hasn't changed.

BUG=346764

Review URL: https://codereview.chromium.org/231793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263035 0039d316-1c4b-4281-b951-d872f2087c98

The comments provided in PPB_InputEvent and PPP_InputEvent incorrectly describe
how handled events are delivered to handlers in web pages.

When a plugin handles an event, the event is not "bubbled" to any default
handlers. However, any listeners in a web page run before the event reaches the
plugin, so the plugin can't prevent any listeners from getting the event.

An attempt to make the implementation match the specification broke existing
plugins, so the only reasonable approach is to make the comments match the
behavior.

BUG=324352
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/228653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263034 0039d316-1c4b-4281-b951-d872f2087c98

This fixes some build errors for the "chromeos=1 use_ozone=1" build. We
need to stub out IME support until we have an ozone implementation.

BUG=361341
TEST=chrome --ozone-platform=test

Review URL: https://codereview.chromium.org/232233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263033 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263032 0039d316-1c4b-4281-b951-d872f2087c98

Chrome OS currently tells Blink to use subpixel-positioned
text when running on images built with the highdpi USE flag.
Additionally use subpixel positioning when
--force-device-scale-factor is used to force high-DPI mode.

BUG=361598

Review URL: https://codereview.chromium.org/231583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263031 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ager@chromium.org
BUG=340752
TEST=waterfall

Review URL: https://codereview.chromium.org/226613009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361778

Review URL: https://codereview.chromium.org/227523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263029 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Improve computation of PrefHashCalculator::legacy_device_id_instance_. (https://codereview.chromium.org/231673002/)

Reason for revert:
PrefHashCalculatorTest.TestLegacyDeviceIdAlgorithm is failing in some configurations.

Original issue's description:
> Improve computation of PrefHashCalculator::legacy_device_id_instance_.
> 
> 1) Compute it at most once in the lifetime of the browser (rather than at most once per PrefHashCalculator).
> 
> 2) Explicitly AllowIO in the scope of this computation. This isn't ideal, but there is no other good way until we can get rid of this legacy artifact in a few milestones.
> 
> Note that I have to skip a presubmit error for (2): "Banned functions were used. New code should not use ScopedAllowIO." :(.
> 
> BUG=361687
> R=erikwright@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262995

TBR=erikwright@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361687

Review URL: https://codereview.chromium.org/228763007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158641
R=hclam@chromium.org

Review URL: https://codereview.chromium.org/231653008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263027 0039d316-1c4b-4281-b951-d872f2087c98

This lets us get drop many of our patches. It also adds NPN support for free.
On the downside, it introduces a handful of new bugs that need additional
patches.

BUG=115301

Review URL: https://codereview.chromium.org/210323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263026 0039d316-1c4b-4281-b951-d872f2087c98

Fixing caps lock problems under ChromeOS where the tray does not properly follow the real caps lock change

BUG=356393
TEST=visual with chromebooks internal keyboard, external keyboard and with linux

Review URL: https://codereview.chromium.org/231753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263025 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350904

Review URL: https://codereview.chromium.org/225393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263023 0039d316-1c4b-4281-b951-d872f2087c98

The ozone message-pump is no longer needed. So remove that, and use the default
message-pump based on libevent instead. Also, add a convenience method for
adding a watcher on a file-descriptor to the message-pump from the message-loop.

BUG=354062
R=rjkroege@chromium.org, sky@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/231643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263022 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug in the API webview.executeScript. After this fix, if the webview (who calls the executeScript API) is navigated to another source, the executeScript API won't be injected and executed in the new source.

BUG=239388

Review URL: https://codereview.chromium.org/226043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263020 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343725,343651

Review URL: https://codereview.chromium.org/229463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263018 0039d316-1c4b-4281-b951-d872f2087c98

This is not used in production yet, since Android kernels do not have seccomp
mode two support, yet.

BUG=308763, 166704

Review URL: https://codereview.chromium.org/180783019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263017 0039d316-1c4b-4281-b951-d872f2087c98

Introduce a new bookmarks component and update DEPS for chrome/browser
and chrome/chrome_browser.gypi.

Move names of bookmark preferences from chrome/common/pref_names.{cc,h}
to components/bookmarks/core/common/bookmark_pref_names.{cc,h} and add
an include in chrome/common/pref_names.h to limit modification to the
client files.

BUG=360613
TBR=sky

Review URL: https://codereview.chromium.org/228393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263016 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361412
TEST=unittest

Review URL: https://codereview.chromium.org/232133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263015 0039d316-1c4b-4281-b951-d872f2087c98

If a page requires touch scrolling, we currently report a failure if the browser
doesn't support touch. This means that no average numbers will be reported on the
dashboard.
Instead of failing, we could skip the page and show a warning message to make the
user aware of that.

BUG=355661

Review URL: https://codereview.chromium.org/230373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362138
TBR=sky@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/233313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263013 0039d316-1c4b-4281-b951-d872f2087c98

We'll test this on device to make decision, and
evisit options page after that.

BUG=361672
TEST=DisplayManager.UIScaleUpgradeToHighDPI

Review URL: https://codereview.chromium.org/230683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263012 0039d316-1c4b-4281-b951-d872f2087c98

When passwords for the current site are added, updated, or removed from
the password store, we should add, update, or remove them from the
bubble in order to keep things up to date.

This patch deals with the common case of removing passwords from the
settings page while the password bubble is instantiated on a separate
tab. A future patch will deal with adding or removing the site from the
blacklist.

BUG=330154
R=vabr@chromium.org,markusheintz@chromium.org

Review URL: https://codereview.chromium.org/228593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263011 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the iOS implementation of the ProfileOAuth2TokenService.

BUG=NONE

Review URL: https://codereview.chromium.org/226643012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263008 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263007 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171141:171269&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/227913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263006 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263004 0039d316-1c4b-4281-b951-d872f2087c98

A follow-up to https://codereview.chromium.org/216183008/

Password manager internals page serves as a debugging output from the process of observing submitted password forms and offering the user to save the password. The user will be able to grab the debugging info and pass it onto the Chrome developers to help investigate issues.

This CL introduces:
1) RendererSavePasswordProgressLogger, a specialization of the SavePasswordProgressLogger for the renderer part of the password management code.

2) Additional support in the PasswordManagementClient to use the Logger in the renderer code.

More context in the design doc: https://docs.google.com/document/d/1ArDhTo0w-8tOPiTwqM1gG6ZGqODo8UTpXlJjjnCNK4s/edit?usp=sharing

A follow-up CL will introduce actual logging calls.

TBR=inferno@chromium.org
BUG=347927

Review URL: https://codereview.chromium.org/228263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263002 0039d316-1c4b-4281-b951-d872f2087c98

fdwCharSet param changed from 0 to DEFAULT_CHARSET (which is defined to
1). ScriptShape fails to generate glyphs on Windows XP for some complex
scripts (Hindi text for instance) if font is created with fdwCharSet=0.

Other paramaters are unchanged because they still expand to 0.

BUG=361994

TEST=On Windows XP, go to Control Panel and Regional and
Language Options. Under Languages tab check Install files
for Complex Script and right-to-left languages (including
Thai) and Install files for East Asian languages. Click
Details and install Hindi language. Launch Chromium. Go to
advanced settings and go to Languages. Add Hindi language
and click Display Chromium in this language button. Restart
Chromium. Expected result: Hindi font glyphs should be
properly generated for all UI elements (tabs, menus,
notification panels).

Review URL: https://codereview.chromium.org/230793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263001 0039d316-1c4b-4281-b951-d872f2087c98

1) Compute it at most once in the lifetime of the browser (rather than at most once per PrefHashCalculator).

2) Explicitly AllowIO in the scope of this computation. This isn't ideal, but there is no other good way until we can get rid of this legacy artifact in a few milestones.

Note that I have to skip a presubmit error for (2): "Banned functions were used. New code should not use ScopedAllowIO." :(.

BUG=361687
R=erikwright@chromium.org

Review URL: https://codereview.chromium.org/231673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262995 0039d316-1c4b-4281-b951-d872f2087c98

Once gpu rasterization is disabled on a layer, it will stay disabled.

BUG=329722

Review URL: https://codereview.chromium.org/222903005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357050
TEST=none

Review URL: https://codereview.chromium.org/230503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262993 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262991 0039d316-1c4b-4281-b951-d872f2087c98

In both aura/views and mac, notifications are done through the message-center. So
the implementations of BalloonCollection are never used. So remove these. Only the
GTK version of the implementation remains.

BUG=354062, 361784
R=mukai@chromium.org, rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/231213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262988 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361585

Review URL: https://codereview.chromium.org/226183015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262987 0039d316-1c4b-4281-b951-d872f2087c98

 - The 'compare and swap' operations should enforce memory ordering even when
   the exchange does not occur.
 - The exclusive monitor does not need to be cleared by CLREX if a LDRX was
   not followed by a matching STREX.
 - Use LDAR and STLR where possible.
 - Use the 'I' and 'J' constraints to hint for constants valid for immediate
   values

Based on V8 changes at https://codereview.chromium.org/220793002

BUG=354405

Review URL: https://codereview.chromium.org/230963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262986 0039d316-1c4b-4281-b951-d872f2087c98

Fix an issue where keyboard events improperly reset the scroll status while
a touch scroll was active in InputHandlerProxy.

BUG=361160

Review URL: https://codereview.chromium.org/230663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262985 0039d316-1c4b-4281-b951-d872f2087c98