GitLab

R=csharp

Bug: 830892
Change-Id: I821588099796a86a685bd85fa29456fd5d8bc705
Reviewed-on: https://chromium-review.googlesource.com/1197102
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589235}

Workaround for an occasional crash we see in the autotest lab.
I'm just skipping the code so we can put MashLogin in the CQ.

Bug: 869385
Change-Id: I1267922036d3ab88276a2315dc9d3bb7d2ed2020
Reviewed-on: https://chromium-review.googlesource.com/1210683Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589234}

This reverts commit 8eed4853.

Reason for revert: Suspected of breaking the following test:
org.chromium.chrome.browser.browseractions.BrowserActionActivityTest.testOpenSingleTabInBackgroundWhenChromeAvailable

On the Android CFI bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI

Original change's description:
> Reland: Remove SeparateTaskCustomTabActivity for Android version > L.
> 
> Cause of revert:
> ===============
> A few MediaLauncherActivityTest don't run on the CQ. They were waiting
> on SeparateTaskCustomTabActivity to finish, but it is no more used.
> 
> Original description:
> =====================
> Remove SeparateTaskcustomTabActivity for Android version > L.
> 
> Make SeparateTaskcustomTabActivity to be used only for Android version
> pre L. The part used for Android version >= L is merged into
> CustomTabActivity.
> 
> This is a prerequisite for skipping the ChromeLauncherActivity and
> directly launch the CustomTabActivity.
> 
> TBR=tedchoc@chromium.org
> R=​lizeb@chromium.org
> 
> Bug: 681559
> Change-Id: I121241a2f43f62c346a24adb153649bec3b80af3
> Reviewed-on: https://chromium-review.googlesource.com/1201845
> Reviewed-by: Benoit L <lizeb@chromium.org>
> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588788}

TBR=lizeb@chromium.org,arthursonzogni@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 681559
Change-Id: I002cddd65d1fc326c5a212671d4f7d07355689a6
Reviewed-on: https://chromium-review.googlesource.com/1211242Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589233}

The stop button and the issue icon share the same space in sink item UI,
so when both are present (i.e. when a sink has both a route and an
issue) we must ensure that the stop button is shown, so that the user
can stop the route.

Bug: 879627
Change-Id: I73751190dec2cde98b9568e7ebb4b2cea8516dea
Reviewed-on: https://chromium-review.googlesource.com/1208818Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589232}

Will follow up on displaying proper message for managed account.

Bug: b:113579103
Change-Id: I279937f8f3d622e7fd7cf947b4f261b64cd320ff
Reviewed-on: https://chromium-review.googlesource.com/1198002Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589231}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b27d084b0112..21bcb9d8b9db


git log b27d084b0112..21bcb9d8b9db --date=short --no-merges --format='%ad %ae %s'
2018-09-06 corentin@wallez.net BUILD.gn: Make a better interface with dependents. (#1877)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@21bcb9d8b9db

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I465fc82d319a94b2494428efc1b057b258645b60
Reviewed-on: https://chromium-review.googlesource.com/1210442Reviewed-by: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589230}

Implementing the intant theme test in a non-flaky way. Instead of using
OnThemeChange event to determine whether the theme has applied on existing
tab/current tab/new tab, we directly check the css setting is equal to the
new theme or not.

Bug: 335297
Change-Id: Ic366e180281b23ccdffcbcd9e4b2144485591607
Reviewed-on: https://chromium-review.googlesource.com/1208939
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589229}

The current URL generated from a Calculator suggestion searches for
the result e.g. "4", not the calculation e.g. "2+2". This CL swaps
the terms (actually, it clears the original query) and, further, treats
the suggestions as distinct from non-calculator suggestions, so that
they don't dupe against other WYT suggestions.

Bug: 873666
Change-Id: I006f9754ee7e48d0a21a1f149c4ef76b3ca509fd
Reviewed-on: https://chromium-review.googlesource.com/1197342
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589228}

Bug: 877571
Change-Id: I981008a53c0a88aa98027f5fa56697ba410917ab
Reviewed-on: https://chromium-review.googlesource.com/1204511Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589227}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/upgrade_detector.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=grt@chromium.org

Bug: 874080
Change-Id: I902becb0feb9bf1e0464c2dd507b734fb5e16508
Reviewed-on: https://chromium-review.googlesource.com/1190932Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589226}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/chromeos.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=satorux@chromium.org

Bug: 874080
Change-Id: Ic87ecc4c25a20a2dea3053249c03dafded46db27
Reviewed-on: https://chromium-review.googlesource.com/1191236Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589225}

This CL moves all work that runs on the video decoder's thread into
D3D11VideoDecoder, and all GPU main thread work into Impl.

It does not actually move decoding to a different thread, nor does
it remove all of the threading assumptions from the code.  For
example, D3D11PictureBuffers still assume that they're created and
destroyed on the GPU main thread.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4ee52d84c77c57127d26803153c043959f7429ef
Reviewed-on: https://chromium-review.googlesource.com/1197165
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589224}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/printing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 874080
Change-Id: I23d9583ee267f5d88fb8c2e708fd7055d9f05951
Reviewed-on: https://chromium-review.googlesource.com/1191184Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589223}

Some video paths go through the V4L2 decoder, so need to whitelist it to
work with the early sandbox.

Bug: b/113126106
Test: Compiled
Change-Id: Iae5f144efa2b2017d8a6c0e55dfc4128bbd65ce4
Reviewed-on: https://chromium-review.googlesource.com/1199708Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589222}

This gives users a way to reach apps when the overflow is beyond filled
on tablet mode. Also fix a bug with the shelf layout manager handling
events on the overflow.

Test: manual
Bug: 808237
Change-Id: Ia3d4a14c8c1a15f7c991a201bdad94d6657f4e6d
Reviewed-on: https://chromium-review.googlesource.com/1208826Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589221}

This CL uses ScopedBlockingCall to mark blocking calls in /components/printing.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 874080
Change-Id: If905506e78f47d3a2524a4d574184def19f3ce54
Reviewed-on: https://chromium-review.googlesource.com/1191786Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589220}

This implements initial values for SVGAnimatedNumber properties (which
includes SVGAnimatedNumberOptionalNumber since it is a reverse proxy to
the former.)

Bug: 225807
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Icb62d7383cacf7df122fc56af0977015b5adf9b7
Reviewed-on: https://chromium-review.googlesource.com/1209705
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589219}

This reverts commit 6d6b6173.

Reason for revert: Suspected of breaking the Mac builder:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Builder/89748

This code doesn't seem obviously related to the webui failure there, but there are no other webui CLs in the blame list.

Original change's description:
> Add the ability for AndroidSmsAppHelperDelegate to launch the PWA.
> 
> Also actually use this ability when the "Set Up" button in multidevice
> settings is clicked.
> 
> R=​khorimoto@chromium.org
> 
> Bug: 870093
> Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586
> Reviewed-on: https://chromium-review.googlesource.com/1185498
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589196}

TBR=khorimoto@chromium.org,tommycli@chromium.org,jlklein@chromium.org

Change-Id: I855abd7c530600362082c83ee155aaa3d713415f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 870093
Reviewed-on: https://chromium-review.googlesource.com/1211382Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589218}

This implements initial values for SVGAnimatedEnumeration properties.

Bug: 225807, 523685
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I857dd5d6a52b2e3c4e866c2b589be3373449fc24
Reviewed-on: https://chromium-review.googlesource.com/1209683Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#589217}

This is needed to support a server provided blacklist (via Cacao) for
HTTPS Server Previews. Details are specified in
  https://docs.google.com/document/d/13Pj85rq3aUfVxxMe4Dad9uqz54n0GgD8iPqUowdsD-c/edit?usp=sharing

Bug: 864640
Change-Id: Ie9b4a56dd0edc97df48f2d6e066ad2a0b1104458
Reviewed-on: https://chromium-review.googlesource.com/1207574
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589216}

This reverts commit d9183af5.

Reason for revert: suspected of causing https://bugs.chromium.org/p/chromium/issues/detail?id=881420

Original change's description:
> [Autofill] Populate ChromeUserContext in Payments requests
> 
> This change adds |chrome_user_context| and |full_sync_enabled| values to
> Unmask, GetDetails, Upload, and MigrateCards requests, as long as either
> of the appropriate flags are enabled.
> 
> Bug: 840703
> Change-Id: Ieb3baf980b68add43a3111c0902a03b574b1adcf
> Reviewed-on: https://chromium-review.googlesource.com/1208434
> Commit-Queue: Jared Saul <jsaul@google.com>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589060}

TBR=sebsg@chromium.org,jsaul@google.com,dlkumar@google.com

Change-Id: Id88b0a194dad400be5ba95a36f11d8ebb5ccd1ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 840703
Reviewed-on: https://chromium-review.googlesource.com/1211282Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589215}

Preparation for adding a postscript and full font name unique matching
function to WebSandboxSupport, in which a similar return type is needed,
but the use case is not fallback.

BUG=880832

Change-Id: Ibb66f3fe0007c517d74f56ba10096141b702676e
Reviewed-on: https://chromium-review.googlesource.com/1209842Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589214}

Add the mojo interface to start an OffscreenTab mirroring with the
mirroring service.

Bug: 734672
Change-Id: I3b9edbdccffdfb06b0a325170ed6108be81a6975
Reviewed-on: https://chromium-review.googlesource.com/1195821Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589213}

This CL makes sure that tests for cross-origin fetches from content
scripts cover both 1) programmatic content scripts (i.e. ones triggered
by chrome.tabs.executeScript) and 2) declarative content scripts (i.e.
ones listed under "content_scripts" entry in an extension manifest).

The extra test coverage is desirable to ensure that the future work to
provide a separate URLLoaderFactory for content scripts gives correct
results both for programmatic and declarative content scripts.  For
example - providing the URLLoaderFactory in ExtensionMsg_ExecuteCode
would be wrong because it would not cover declarative content scripts.

Bug: 846346
Change-Id: Ibe3f32fd69d502e0a0874fde7636629e5b6693fa
Reviewed-on: https://chromium-review.googlesource.com/1208816Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589212}

In-memory download service (for incognito) returns a blob instead of a
file path when the download is complete. This CL passes the value down
to the (in memory) DatabaseTasks that expect a valid blob handle.

Bug: 863939
Change-Id: I7840c6d6e10ddf883cd44d6eb316a6cc7cbbee47
Reviewed-on: https://chromium-review.googlesource.com/1208171Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589211}

This change feeds offline status information to the Feed component so that
it can properly display the offline badges on articles that are downloaded.
The call to actually open Feed articles with custom load params is not
done in this change, but the cache FeedOfflineHost holds is preparing for
this eventual use case.

Bug: 866125
Change-Id: Ie28cfe0913d9d93f197d5aba1bff181369d3bf39
Reviewed-on: https://chromium-review.googlesource.com/1197268
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589210}

Its possible for users to enter clamshell but still need the VK by
plugging in an external mouse. This cl check whether the internal
keyboard is disabled to determine showing or hiding VK instead of just
tablet mode or not.

TabletModeController is getting a lot of friend test class, so also
introduce TabletModeControllerTestApi.

Test: ash_unittests
Bug: 878795
Change-Id: I0b6e07ef6833e00dd1b6d5358ad7aca4e63a12e5
Reviewed-on: https://chromium-review.googlesource.com/1198486
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589209}

This CL is not a straight revert of
https://chromium.googlesource.com/chromium/src/+/76a593e26e0e5e1d962bbcc95562490e56901787

but it essentially recovers that functionality.
The revert is needed due to a bug in Chrome bookmark
manager.

Bug: 878392
Change-Id: Ifa5867691ffe88ed557fb548a5de572ec5236580
Reviewed-on: https://chromium-review.googlesource.com/1210124
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589208}

Bug: 872404
Change-Id: I6b169bf470d9af2ef3c7fca9ef59081615ece5cf
Reviewed-on: https://chromium-review.googlesource.com/1208692Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#589207}

Per the mocks, move the throbber and the info icon to the left of the view.
Also factor out constants and throbber creating code into a helper file.
Screencap: https://drive.google.com/open?id=1UF1uamxoR0oG-3aEHwdJkoHU_7pJW_CB

Bug: 879630
Change-Id: I42ee54d063df0f9af74cad10a4a21a9a8f78a869
Reviewed-on: https://chromium-review.googlesource.com/1199945
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589206}

The auth_type parameter is always a const char[]. This saves allocating
a string copy of it.

Bug: none
Change-Id: I53c57252c9006b8dd0cf155a04132aad0975ed70
Reviewed-on: https://chromium-review.googlesource.com/1208144Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589205}

Currently a crash can occur if CustomTabsConnections starts the browser
synchronously while an async browser startup is in progress.

Bug: 881019
Change-Id: I2d1b764c8212a05b85f59c5edfa92ac28a4171f9
Reviewed-on: https://chromium-review.googlesource.com/1210623Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589204}

After adding "use_jumbo_build=true" args in GN, jumbo build can be
enabled.

Bug: 869381
Change-Id: Ia95bfd39e2f8f5b7ab1df879d12433341245d046
Reviewed-on: https://chromium-review.googlesource.com/1204372
Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589203}

Crash happens inside documentInteractionController:willBeginSendingToApplication:
delegate callback on removing observer from _downloadTask. It is
possible to stop coordinator before willBeginSendingToApplication: gets
called, in which case DownloadManagerCoordinator will crash. This CL
adds null check before calling UnopenedDownloadsTracker::Remove to
prevent the craash.

Bug: 880919
Change-Id: Ib73d6663b2a100b4f3c075f4c8643eaacc3b45a5
Reviewed-on: https://chromium-review.googlesource.com/1208963Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589202}

Some dialog boxes, like the accelerator confirmation dialog that appears
when you press Search+Control+M, focus the dialog and then immediately
after focus one of the buttons. This was causing ChromeVox to suppress
information about the context of the dialog.

Fix this by using PostTask to defer all events from Views. This doesn't
even add any delay, it just pushes the event firing to after the current
call stack so that transient changes get suppressed.

Manually confirmed that the experience with this particular dialog is
improved, other dialogs and views seem to continue to work fine.

Bug: 729449
Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373
Reviewed-on: https://chromium-review.googlesource.com/1176207
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589201}

R=dpranke

Bug: 879147
Change-Id: Ic975848737614812a94460f6c3ef7653d3d1329a
Reviewed-on: https://chromium-review.googlesource.com/1210682
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589200}

This CL improves accessibility based on feedback of issue 870627 and
mocks from issue 838387:
1. The keyboard accessory is announced when made visible (string [1]).
Before this CL, android:clickable=true was used to prevent clicks
from propagating to the content area behind it. This caused Talkback
to read "double-tap to activate". This is gone now, by setting the
appropriate listeners when initializing the layout.

2. The key icon's name changed to "Show passwords" (string [4]). Once
triggered, it changes to "Show keyboard" (string [2]) in accordance to
what it does.

3. An opened password sheet is immediately announced with string [3]:
"Showing saved passwords and password options".

4. The title ("Saved passwords for XYZ") doesn't read "Double-tap to
activate" anymore.

5. Disabled entries (e.g. password entries when email fields are
focused) are now read back with the proper "Disabled" suffix.


Uploaded pictures for the new hashes (because there is no way to
download them anywhere):
[1] IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION:
https://photos.app.goo.gl/kiYYx8tzyjfPB7oA7

[2] IDS_KEYBOARD_ACCESSORY_SHEET_HIDE:
https://photos.app.goo.gl/RxuGqCZp6QtmNLUJ9

[3] IDS_PASSWORD_ACCESSORY_SHEET_OPENED:
https://photos.app.goo.gl/NBpw2HavFSiZ5NSq8

[4] IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE:
https://photos.app.goo.gl/fMprsLC8Y8giAdxF7

Bug: 870627, 838387
Change-Id: Iebccefa8d5ede702b8bdc2dc92f055064981fa80
Reviewed-on: https://chromium-review.googlesource.com/1209405Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589199}

- The StreamFailBeforeReadIsExecutedOnNetworkThread is flaky on Fuchsia.

Bug: 880474
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester
Change-Id: I36c11741d674fec99286f25bd8503bb77903e950
Reviewed-on: https://chromium-review.googlesource.com/1210364Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589198}

Make sure the USS implementation also clears data on signout, just like
the directory-based implementation does. This also enables an
integration test to test this in the butter scenario.

Also making a small fix: Updating the storage in PDM in
OnSyncInitialized, because if sync is disabled, we won't get the
OnStateChanged call.

Bug: 880735
Change-Id: I6aa49b8c459a48cb92a1e3d7283f05eed8e6eb5c
Reviewed-on: https://chromium-review.googlesource.com/1206490
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589197}

Also actually use this ability when the "Set Up" button in multidevice
settings is clicked.

R=khorimoto@chromium.org

Bug: 870093
Change-Id: I3dd5bcd9c8e3946e1ae42a5db69f2bb7ed3ea586
Reviewed-on: https://chromium-review.googlesource.com/1185498
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589196}