- 28 Mar, 2019 40 commits
-
-
Jonas Olsson authored
Bug: 941413 Change-Id: I9987a8ce31151310104bb7b37a884cdcfeb81671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520833Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jonas Olsson <jonasolsson@chromium.org> Cr-Commit-Position: refs/heads/master@{#645239}
-
Ivan Sandrk authored
Bug: 578342 Change-Id: I54b346798ff8e295938430058fc92b694c3dedc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541159 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Miyoung Shin authored
- long -> int32_t/uint32_t/uint64_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930251 Change-Id: I32a2c4c077bcf42b77830bbd1cbf596b231b4782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541619 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#645237}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4788c03a0392..d5a7a435d526 git log 4788c03a0392..d5a7a435d526 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 yyanagisawa@chromium.org cros_build_lib: supports long input file names. Created with: gclient setdep -r src/third_party/chromite@d5a7a435d526 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4e213c111f25f93e9e149d08a6cf158f5985f99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645236}
-
Hayato Ito authored
No behavior change. This CL just adds various assertions for flat tree node data's possible values so that we can detect dirty status. Bug: 906494 Change-Id: Ia2a420956828ac73b08a4d563e03a83c7835f15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535725 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#645235}
-
Ramin Halavati authored
ProfileChooserView generates several menus and draws them. Drawing is done using different code paths causing difficulty in maintenance of similar output. This CL separates content generation code and menu formatting to make a unified code path for drawing all menus and prepare the class for separation of Incognito menu (which is used on all desktop platform) from Profile menu which is not used on Chrome OS. Bug: 934689 Change-Id: I657c127e38e439eff26247284e0911fcc94be2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499457Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#645234}
-
Eliot Courtney authored
Also, mark status bar tooltip bubbles as ignored for PIP collision detection using this mechanism. Bug: b/127838266 Test: unit test Change-Id: I02d4fb093199eef97f29dc1283105f12b36cbe1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530275 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#645233}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/57e05b8be2d9..94f195b18776 git log 57e05b8be2d9..94f195b18776 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 swiftshader.regress@gmail.com Regres: Update test lists @ 179c9324 Created with: gclient setdep -r src/third_party/swiftshader@94f195b18776 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ife4764ddddb52bb4e6b07eb871dadef41260d541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542965Reviewed-by:
-
Javier Ernesto Flores Robles authored
The request to the Google server for favicons now uses the size in pixels as the API requires. Bookmarks now request the icons in points an the logic to get the pixel size is consolidated in favicon_loader. Previously it was requesting in pixels, so the image retrieved had the right size, but the call subsequent call to FaviconForUrl would multiply again the size and scale . Change-Id: I59c0deacd173f9433d14a8ff3446ac7bed857d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535885 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645231}
-
Mario Sanchez Prada authored
Make sure that we don't re-use the callbacks from TestCompletionCallback, so that we're prepared for when they become non-repeating callbacks (i.e. base::CompletionOnceCallback), instead of base::CompletionCallback. This CL was uploaded by git cl split. TBR=tzik@chromium.org Bug: 807724 Change-Id: Id1ce48998eeda76b142fc0ec91de903a47411344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541113 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#645230}
-
David Jean authored
Added too many methods to delegate, and will work at chipping away at those next. I tried to pass in interfaceProvider to app url loader service but it introduced so many cyclic depedencies so I did a more complex delegate instead. Bug: 907527 Change-Id: I3bc38be90c353d3f7dee91778c099b074ff0a9d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529002 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#645229}
-
Mario Sanchez Prada authored
Make sure that we don't re-use the callbacks from TestCompletionCallback, so that we're prepared for when they become non-repeating callbacks (i.e. base::CompletionOnceCallback), instead of base::CompletionCallback. This CL was uploaded by git cl split. TBR=pwnall@chromium.org Bug: 807724 Change-Id: I430cf751ded3734a7ff7895e890da66b840ca823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541191 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Andrew Grieve authored
Based on stack: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.app.Activity.finish()' on a null object reference at org.chromium.chrome.browser.preferences.privacy.OtherFormsOfHistoryDialogFragment.onClick(OtherFormsOfHistoryDialogFragment.java:89) at org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest.lambda$testDialogAboutOtherFormsOfBrowsingHistory$3$ClearBrowsingDataPreferencesTest(ClearBrowsingDataPreferencesTest.java:311) Started failing on android-cfi here: https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Android%20CFI/builds/4869 Change-Id: If48a75067a0278a9468c2263938c122f37c19806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542489 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#645227}
-
Gauthier Ambard authored
This CL fixes the mojo tests with the new WebUI implementation. # The JS is using "var" for Mojo, which makes the presubmit fail. # However, the script isn't working without it. NOPRESUBMIT=true Bug: 739844 Change-Id: Ic7211942ee9ebcc5c2490a84b48237ed43418a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526181Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#645226}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5f4bcbb9467f..1ba2cb8589a8 git log 5f4bcbb9467f..1ba2cb8589a8 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 yunchao.he@intel.com Construct ComboInputStateDescriptor to simplify tests and examples Created with: gclient setdep -r src/third_party/dawn@1ba2cb8589a8 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I561ed7e92f72907ae4c65e7f14c26dc28a842755 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542877Reviewed-by:
-
Tomas Popela authored
The XDG_CURRENT_DESKTOP could contain multiple values in priority order separated by colon. Go through them in the loop and return on the first one that we recognize/support. The previous state was causing problems with Chrome on the GNOME Classic mode (used in Red Hat Enterprise Linux 7) where the users with multiple Google accounts set in Chrome couldn't switch between them - only one was shown in the account switcher in i.e. GMail. The reason for that was that the XDG_CURRENT_DESKTOP's value GNOME:GNOME-Classic was parsed as not as base::nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_GNOME. base: :nix::DesktopEnvironment::DESKTOP_ENVIRONMENT_OTHER and Change-Id: I122f24fd1cf5a0f932c3fccd5220152a9944609d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541077Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#645224}
-
Tobias Sargeant authored
On Android M+ we can use ConnectivityManager to fetch proxy information rather than relying on system properties or intent extras. In order to keep WebView applications that use reflection to trigger the proxy change broadcast working, we must continue to register the old ProxyReceiver object. To ensure that this is not triggered by real system broadcasts, we register it with an empty intent filter. Bug: 851995 Bug: 908085 Change-Id: Ibfa6c35693301868f8a63ea924649e4c2bc8a328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526268Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#645223}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: I480a537eb4a65bf9c6b1c3de9316a0fa111740c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542752Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#645222}
-
Christos Froussios authored
We are fully launching the migration of away from the native linux backends. Bug: 571003 Change-Id: I26d0cfe87bead16ed33f728b05f4c060331faae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536190 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#645221}
-
Eliot Courtney authored
Currently, it just goes on top of the PIP window. Bug: 942992 Test: unit test Change-Id: Ic88b5c3cdc6173277a017f6a2c4211a3d13338c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530223 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#645220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6822584e81a7..f2e35430ab78 Created with: gclient setdep -r src-internal@f2e35430ab78 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: I7a37fdf45878282d30e8e877bcf648652be7b0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543017Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645219}
-
Alan Cutter authored
This CL updates content browsertests to use the existing GetTestDataFilePath() instead of hard coding "content/test/data" many times. Bug: 946403 Change-Id: Ia90dbbdcd269cccd278de80bbf85ab3326fe1463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541546 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#645218}
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/editing, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This is the third CL to clean up Foo::Create() in renderer/core/editing. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Iff61466f39a40ef67803d09b7730e54eecb80776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541547Reviewed-by:
-
Kuo Jen Wei authored
TEST=Test take photo/recode video, see if the saved filename is correct. Change-Id: I30af029ef862bb5577c6c8e14ee5a2814d79dc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539628Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#645216}
-
Peter Kasting authored
This eliminates some uses of child_count(). Bug: 940135 Change-Id: I8720a5f2be0da68fb4c2b55e51cbebaa2cd95c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536739 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#645215}
-
Chris Blume authored
Currently, SharedImageBacking and its derived classes are not thread safe. This CL makes it thread safe by adding a flag to SharedImageBackingFactory::CreateSharedImage. There is also a consistent way to acquire the lock if needed or do nothing otherwise. Bug: 938594 Change-Id: I3fe2c2ecc627f327f26cedab029a1388bfabf913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504894 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#645214}
-
Sangseok Jang authored
Existing implementations do not work with widgets displayed in other processes(e.g, PWAs). StackAbove and StackAtTop are implemented through BridgedNativeWidget mojo interface Bug: NONE Change-Id: I61ee9391332d61081d59865ac61994671ebc0093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522492Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sangseok Jang <sangseok.jang@navercorp.com> Cr-Commit-Position: refs/heads/master@{#645213}
-
Leo Zhang authored
Set ime service flag enabled by default on TOT. Bug: 888885 Change-Id: I80254287be9e0d8b3fbaf24d090e2a1960e1f05c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542742Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#645212}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/705f480f4506..e810ad90799c git log 705f480f4506..e810ad90799c --date=short --no-merges --format='%ad %ae %s' 2019-03-28 syoussefi@chromium.org Vulkan: dump summary of commands in digraph 2019-03-28 syoussefi@chromium.org Vulkan: roll Vulkan repos to v1.1.102 2019-03-28 syoussefi@chromium.org Vulkan: remove dependency to inheritedQueries Created with: gclient setdep -r src/third_party/angle@e810ad90799c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I4e19af909b41da0162528449d54b09a899c73e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542982Reviewed-by:
-
Nico Weber authored
Bug: 464945 Change-Id: I7ed5179a01266ab43782b590dc48da8865b44f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542680 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#645210}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0b19d73c4b89..3240800a9487 git log 0b19d73c4b89..3240800a9487 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@3240800a9487 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: If91047b65b190f9c69f2ab8e6c4538ca9626b26c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542981Reviewed-by:
-
Peter Kasting authored
This avoids some uses of child_count(). Bug: 940135 Change-Id: I583b471a7750f0dccba5e2eb6bd4f61661c9a4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535293 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit fc93308f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 644811 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5MzMwOGY1Zjk0YmJhYzJlMDcyNGU2YmUzZDRmN2Q2OWRlNjQyNgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Linux/70364 Sample Failed Step: sandbox_linux_unittests Sample Flaky Test: ParameterRestrictions.ptrace_getregs_allowed Original change's description: > Disable ParameterRestrictions.ptrace* tests on Android < N. > > Bug: 934930 > Change-Id: I0c9bae607e06a921c4587fcfb50ebc574c830c7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540281 > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#644811} Change-Id: I9628666758500dba61d72b4cfa7e2890b9ff798a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542905 Cr-Commit-Position: refs/heads/master@{#645207}
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: Ifc7362c11b630b2d97a3eb10315204d678ceaa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541621Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a GetChromeTestDataDir() helper for browsertests to use instead of hard coding the chrome test data directory many times. This also removes redundant calls to tell the embedded_test_server() to serve the chrome test data directory. This gets set up in InProcessBrowserTest's constructor. Bug: 946403 Change-Id: I994d1c8e3b798f0e3a70e4c48a56da3f94cdb83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539366Reviewed-by:
-
Gyuyoung Kim authored
As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance using MakeGarbageCollected<Foo> in //third_party/blink/renderer/core/editing, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. This CL is the second to clean up Foo::Create() in renderer/core/editing. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibb38a1f6047c7cb9566f5b352f9fe7b4cf7223cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542747Reviewed-by:
-
Simon Que authored
R=tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 945731 Change-Id: I3a37b6b44b30ef2fee3ac86dd59fd620a8bf6150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541620Reviewed-by:
-
Dan Beam authored
Screenshots: https://drive.google.com/corp/drive/u/0/folders/1e3dizEeFQ_TvLfST7rCUzH_A58C75ky8 R=rbpotter@chromium.org BUG=926883 Change-Id: Ia79875072b2c261e348c96a4d4a3762935715639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542725Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#645202}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c881d8d4872a..6822584e81a7 Created with: gclient setdep -r src-internal@6822584e81a7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org Change-Id: Ic3ed75d84475b49e6663fa7f76d5ec5f03fc1afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542979Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#645201}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01a065884b7d..0b19d73c4b89 git log 01a065884b7d..0b19d73c4b89 --date=short --no-merges --format='%ad %ae %s' 2019-03-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 179c932426b3..57e05b8be2d9 (1 commits) Created with: gclient setdep -r src/third_party/skia@0b19d73c4b89 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I182580c3b7ea29a93177282121b548d14d38d1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542980Reviewed-by:
-
