- 18 Apr, 2018 40 commits
-
-
Noel Gordon authored
Fixed by crrev.com/551279 Tbr: yamaguchi-san Bug: 832799 Change-Id: I54f77904b9a1a76020701d641c46293d00d2e72a Reviewed-on: https://chromium-review.googlesource.com/1016781Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551646}
-
Noel Gordon authored
Move TestVolume helper code down, closer to where it's first used. Bug: 833834 Change-Id: Id2620b791e434941c28cbb308d23cd0350b3a9d2 Reviewed-on: https://chromium-review.googlesource.com/1013771 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
-
Thiemo Nagel authored
Log the degree of protection against cookie theft, split by 1st/3rd party. Includes a bit of TransportSecurityState refactoring (no functional change) to provide easy access to HSTS lifetime. Bug: 749059 Change-Id: Ib9ab7cff6a7fb4c65e84d7085e70ef13d5c00ba9 Reviewed-on: https://chromium-review.googlesource.com/978142Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551644}
-
Noel Gordon authored
This reverts commit 978a6eb4. Cause identified and fixed in http://crrev.com/551279 Tbr: fukino-san Bug: 831211 Original change's description: > Disable flaky transfer tests which have Drive targets in FileManagerBrowserTest. > > TBR=fukino@chromium.org > > Bug: 831211 > Change-Id: I173d35915b89bcd346d473d41f01db718808574c > Reviewed-on: https://chromium-review.googlesource.com/1010829 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550384} TBR=fukino@chromium.org,kmarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831211 Change-Id: I18de18fd85f1be7a7a1a7a2f121a6877bd3e3af5 Reviewed-on: https://chromium-review.googlesource.com/1016720 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
This creates a mock ToastNotifier, which replaces the Windows Action Center and allows us to validate that the values sent over are as expected. BUG: 734095 Change-Id: Ibaee2fa161d9025c4b747a75943e5e20d3abffc8 Reviewed-on: https://chromium-review.googlesource.com/1003155 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551642}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 07da4764. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15753 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams TBR=robertma No-Export: true Change-Id: I8f29c44942b48ef08bb0eaf7bd0eb26eae26ce67 Reviewed-on: https://chromium-review.googlesource.com/1016048 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551641}
-
Andrew Grieve authored
Bug: 831953 Change-Id: I9e3c697d25a0754fad18a45f7a0a19c721e54e9c Reviewed-on: https://chromium-review.googlesource.com/1011667 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
-
Marc Treib authored
As of https://crrev.com/c/997654, Sync support for Supervised Users is gone, so GetSyncScopeToUse isn't required anymore. Bug: 829304 Change-Id: Ie912abfa75eb15b05b7f7b23067ea83550bfdecf Reviewed-on: https://chromium-review.googlesource.com/1016285Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551639}
-
Ramin Halavati authored
Order of tests in auditor tester are changed to provide more debug data. Bug: 690323 Change-Id: If17d5cb4a159b34b21a7b07b86ce181e165c9998 TBR: msramek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1016288Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#551638}
-
Sergey Poromov authored
This function was using username from PolicyData that could be obsolete after domain rename. Previous refactorings removed almost all users of the function. The only left one is GetManagedBookmarksDomain(). This usage could be changed to extracting the domain from profile email with a check if the profile is managed. BUG=831652 TEST=Run trybots Change-Id: Idba70400f2282e3e9f341a64af49ba1fcf1d4aa5 Reviewed-on: https://chromium-review.googlesource.com/1010283Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551637}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..c90d4d38c895 $ git log aa8b3982a..c90d4d38c --date=short --no-merges --format='%ad %ae %s' 2018-04-17 jmadill Fix problematic query in TOutputGLSLBase::visitDeclaration. 2018-04-17 jmadill Revert "Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation" 2018-04-17 jmadill Prerequisite code for simpler GlslangWrapper. 2018-04-13 lucferron Vulkan: Fix issue in GlslWrapper and maxVaryingVectors calculation 2018-04-17 lucferron Vulkan: clearRegionWithScissor did not determine the region correctly 2018-04-16 lfy GLES1: gl(Enable|Disable)ClientState 2018-04-17 jmadill Vulkan: Fix build after roll. 2018-04-17 jmadill Vulkan: Suppress ClearIssue test. 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 Created with: roll-dep src/third_party/angle BUG=chromium:833736 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I5d6efbb528d3b927f3f9cc75385be40138ae451c Reviewed-on: https://chromium-review.googlesource.com/1016171Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551636}
-
Olga Sharonova authored
Synchronously wait while AddRef() of the service context is called. (There is a thread hop through the service manager thread there). Bug: 831386 Change-Id: I848652f647a106c8f9a1dfcd847de56819aded41 Reviewed-on: https://chromium-review.googlesource.com/1010202 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551635}
-
Noel Gordon authored
Tbr: yamaguchi-san Bug: 832192,833752 Change-Id: I71207ce1d98d86c896a6fac91d29cf8e85fe4a43 Reviewed-on: https://chromium-review.googlesource.com/1016480Reviewed-by:
-
Artem Titov authored
Bug=none TBR=dpranke@chromium.org Change-Id: I1fca8665da905d5e87bd094452a13a5ce77c2ada Reviewed-on: https://chromium-review.googlesource.com/1016461 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#551633}
-
Andrew Grieve authored
Change-Id: Ibda212961fe444e5b329019d9912c78a97a8c310 Reviewed-on: https://chromium-review.googlesource.com/1013152Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#551632}
-
Sergey Poromov authored
PolicyData will now contain GAIA ID of the user. It's better to lookup user in |known_user| by gaia id if it's present. It could be that it will be broken if stable |username| field in policy will became not in sync with |known_user| database. BUG=831663 TEST=Run trybots Change-Id: I43532cac2f5e559b8b4f71858d3f070e0e715366 Reviewed-on: https://chromium-review.googlesource.com/1009910Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551631}
-
https://webrtc.googlesource.com/src.git/+log/4478d9b7733d..b02644f2b89d $ git log 4478d9b77..b02644f2b --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:812974,chromium:None,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd96d3e68659f9f0bc8017a17c00109c02edf4f0 Reviewed-on: https://chromium-review.googlesource.com/1016540Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551630}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f70a4135..97da922b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ic14c0c498161df0b00bdee2d3a549ca00caab12c Reviewed-on: https://chromium-review.googlesource.com/1015145Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551629}
-
Rune Lillesveen authored
This reverts commit bae2319e. Reason for revert: layout test started failing on trusty Linux The following test started failing (see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20%28dbg%29/11682): virtual/mouseevent_fractional/fast/events/touch/gesture/gesture-tap-mouse-events-between-frames.html Original change's description: > Use the real mouse position when synthesizing mouse events. > > Aura synthesizes a mouse event at certain times, including when the > window comes back from being minimized. Currently it uses the last known > mouse position, which works in most cases. However, the window doesn't > get mouse events when minimized, so the last known position isn't > updated. When the window comes back, if the user's mouse is not over the > window it can cause buttons to get stuck in the hovered state until the > user moves the mouse back into the window. > > To fix this, this patch uses the real mouse position. > > Bug: 828591 > Change-Id: I604d6ddf8f260fe32bd0e4a607f19f1793cf5c5e > Reviewed-on: https://chromium-review.googlesource.com/1006396 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551551} TBR=sky@chromium.org,bsep@chromium.org Change-Id: I1d4448e688447d63d812046c31084f3d04121978 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828591 Reviewed-on: https://chromium-review.googlesource.com/1016601Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#551628}
-
Jan Wilken Doerrie authored
This is a reland of 82d9545a Original change's description: > [base] Add missing methods to base::span > > This change implements constructors for base::span that allow the > construction from a pair of pointers, std::arrays and containers > supporting base::data and base::size, e.g. std::initializer_list. > In addition, this change adds operator(). > > Bug: 788913 > Change-Id: Ibc280eef1c7e47a5a27e92503dda3614ef5513a4 > Reviewed-on: https://chromium-review.googlesource.com/981139 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551313} TBR=dcheng@chromium.org Bug: 788913 Change-Id: I2e02879ddd2839ce0c26c8b18e565d555e08cc7b Reviewed-on: https://chromium-review.googlesource.com/1013468Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#551627}
-
Mark Cogan authored
Bug: 659649 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8813d293c71b1403f18368c60fa0a2435193cac4 Reviewed-on: https://chromium-review.googlesource.com/1016286 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551626}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/084709505993..84ba9179592f $ git log 084709505..84ba91795 --date=short --no-merges --format='%ad %ae %s' 2018-02-07 yhong cros_sdk: Add a non-interactive mode friendly flag `--working-dir`. 2018-04-17 yueherngl nami: add additional sign_type Created with: roll-dep src/third_party/chromite BUG=chromium:None,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6cd2a2612c1ab54ff8e1e8fe0c5dd9ea6d64a9fc Reviewed-on: https://chromium-review.googlesource.com/1016541 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551625}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I42c2e90e868728390129c4b537b005c28aba0a54 Reviewed-on: https://chromium-review.googlesource.com/1016322Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551624}
-
Takuto Ikuta authored
Current goma backend does not support cl.exe execution with /Brepro. Change-Id: Ie892880488e3ed22b9253bd8f3bc21306f9b0524 Reviewed-on: https://chromium-review.googlesource.com/1016446Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#551623}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 322e3b54. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15752 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: I845d6637ab248725f660724da03550de692808e7 Reviewed-on: https://chromium-review.googlesource.com/1016362 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
In the legacy Blink CORS, these information are stripped in DocumentThreadableLoader in MakeCrossOriginAccessRequest(). Current OOR-CORS implementation only has DCHECKS for them, but hasn't stripped. Bug: 803766 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If1a4657804215a8ce9a302acb658f9407348a79a Reviewed-on: https://chromium-review.googlesource.com/999672 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#551621}
-
Jinsuk Kim authored
The internal API in CVC fits conceptually in GestureListenerManagerImpl. There is no functional changes. Bug: 598880 Change-Id: I571745b33f9e8b64c94f32fd8ce5faa950aec422 Reviewed-on: https://chromium-review.googlesource.com/1014861 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551620}
-
Marc Treib authored
This will effectively turn off Sync for Supervised Users. Supervised Users have been deprecated, and it's not possible anymore for custodians to add or update any restrictions, which was to main reason for requiring Sync. Bug: 829304, 809030 Change-Id: I510cc9da1aa26147e890b94e17dcb147d5ca9034 Reviewed-on: https://chromium-review.googlesource.com/997654Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#551619}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6a93eff9ef52..084709505993 $ git log 6a93eff9e..084709505 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 ihf caroline-arcnext: mark CQ/PFQs bvt-arc important. 2018-04-17 dgarrett chromeos_config: Record builders moved to Legoland. 2018-04-17 dgarrett config_lib: UseBuildbucketScheduler. Created with: roll-dep src/third_party/chromite BUG=chromium:834078,chromium:None The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iba4ad91e214467453d3327f5cf4db291476cb558 Reviewed-on: https://chromium-review.googlesource.com/1015983Reviewed-by:
-
David 'Digit' Turner authored
symbol.py: - Remove _GetChromeOutputDirCandidates() because the function would normally always return a list with a single item, the result of constants.GetOutDirectory(). Even in the case where none of CHROMIUM_OUTPUT_DIRECTORY or BUILDTYPE are defined in the environment, it would have reported a list with *two* default directories (i.e. ["$OUT/Debug", "$OUT/Release"]), which is error prone since one cannot assume that their content corresponds to the same set of sources / DEPS, and hence may lead to incorrect symbolization. Besides, all high-level scripts that call into this one already set these environment variables through constants.SetBuildType() or constants.SetOutDirectory() - Make the SECONDARY_ABI_OUTPUT_PATH variable private with an underscore prefix, and improve the error message in SetSecondaryAbiOutputPath(). - Remove the "$OUT/lib" paths from the result of GetLibrarySearchPaths(), since GYP is not used anymore. Update the comment that explains the library locations. stack_core.py: - Make a few functions private using an underscore prefix. Also document the weird / error-prone behaviour of _FindSharedLibraryFromAPKs(). Unfortunately, it is not trivial to pass a list of APKs without introducing yet another global variable (a better solution is planned in the future). constants.py: - Remove 'build_type' parameter from GetOutDirectory() since its only user was removed (see above). Also slightly improve the exception message when the method is called without CHROMIUM_OUTPUT_DIR or BUILDTYPE being defined. - Remove obsolete SetBuildDirectory() function, since there are no callers for it, and its usage is slightly confusing with that of SetOutputDirectory() (!) - Log a warning when SetBuildType() is called when CHROMIUM_OUTPUT_DIR is already defined, because the value will completely be ignored by GetOutDirectory(). - Remove GetBuildType() (no callers). - Remove GetAdbPath(), code search reveals there are no callers anymore for it :-) Tested manually by running a few scripts, like build/android/tombstones.py BUG=NONE R=agrieve@chromium.org,jbudorick@chromium.org,pasko@chromium.org Change-Id: Icb38da2a6d5511aca4cb217abd6ac25f1cb313df Reviewed-on: https://chromium-review.googlesource.com/1007280 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#551617}
-
Olivier Robin authored
- If multiple events are received on the same runloop, autofill will only react to the last one. Only send this one to avoid useless computation. - Also avoid to send events on unfocus events, as autofill UI should only apply to the field that has focus (and is the keyboard responder). Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idc316480a4c03550766d549104609fb5b052c38d Reviewed-on: https://chromium-review.googlesource.com/998154Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551616}
-
Christopher Lam authored
This CL fixes an issue where the right-click of a bookmark item wouldn't show a new command menu when a command menu was already open. This was caused by the mousedown on the original menu not closing the menu. When cr-action-menu changed to no longer be a type extension, the event was no longer fired by the dropdown itself, and rather a child. This CL changes the event expectation so that the menu will close correctly. Bug: 825119 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1cd5494c7208b21d55f817303389bb845794458e Reviewed-on: https://chromium-review.googlesource.com/1013769 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551615}
-
stkhapugin@chromium.org authored
Hooks the location bar to the fullscreen animations, and adds animations to scale the location bar contents and to fade out the share button. Bug: 829397 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I05b0d4bee4ecc430d74a54a54d23c3708d3bfcbd Reviewed-on: https://chromium-review.googlesource.com/1012080 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#551614}
-
tanvir.rizvi authored
PositionWithAffinity uses default affinity as second parameter. This CL introduces 1) PositionWithAffinity(Position) and 2) Makes default affinity as a required field. Bug: 831952 Change-Id: Ie13f8ca3b612587d953628c56402bb9108fea1b5 Reviewed-on: https://chromium-review.googlesource.com/1014862 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551613}
-
https://skia.googlesource.com/skia.git/+log/a05e199cd962..2f54f2c31572 $ git log a05e199cd..2f54f2c31 --date=short --no-merges --format='%ad %ae %s' 2018-04-18 angle-skia-autoroll Roll third_party/externals/angle2/ aed1b56aa..c90d4d38c (2 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ide71b27f0602579c29ec3349b600d66a2ed17723 Reviewed-on: https://chromium-review.googlesource.com/1015205 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551612}
-
David 'Digit' Turner authored
This hardens the zip parsing code in the crazy linker library to avoid integer type and overflow problems. - Defines packed struct types for various ZIP records, and helper functions to read their fields more easily. - Provides a MemoryRangeReader convenience class to ensure parsing the file data doesn't try to read values out of bounds, and check offsets / ranges properly. FYI, another CL adds unit-tests to the zip parser, but the code was split since it required other non-trivial changes to other classes. See https://chromium-review.googlesource.com/c/chromium/src/+/911408 BUG=543292 R=palmer@chromium.org,rsesek@chromium.org,agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org Change-Id: Ic378c83396eb124b9ef8c605f21c5fa5dcc8139a Reviewed-on: https://chromium-review.googlesource.com/910852 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
This reverts commit 96b9e995. Reason for revert: introduces memory leak on youtube.com test First failling here: https://ci.chromium.org/buildbot/chromium.linux/Leak%20Detection%20Linux/4115 Original change's description: > [Spellcheck] Enable cold mode idle time spellchecker in M68 > > As previously planned, we will enable cold mode checker as bug fix to > the current spellchecker, and will monitor its performance. > > Bug: 824030, 716642 > Change-Id: Ie37a08fb6d5562d2f2ff2c2ac84e8033b6ffb776 > Reviewed-on: https://chromium-review.googlesource.com/1015790 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551558} TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org Change-Id: I03087aad24d41208a56aa1904eb55c719e771578 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 824030, 716642 Reviewed-on: https://chromium-review.googlesource.com/1015363Reviewed-by:
-
Ramin Halavati authored
Traffic annotation auditor's tester on FYI bot is updated to return more gracefull output if auditor cannot produce any result. Bug: 690323 Change-Id: If39c0cf092010c43d4c8a5b26a786172ba3cf937 TBR: msramek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1015901Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bde5be65..f70a4135 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ie74203b7ebe4b3793a93bf51a5721dcd63aded81 Reviewed-on: https://chromium-review.googlesource.com/1015144Reviewed-by:
-
Takashi Toyoshima authored
There are two ToRtcOptinlal functions in the same jumbo build group, and it breaks jumbo builders. Bug: 834162 Change-Id: Id37adc6bef5ce4d0e38b8e564f3998d27084a53d Tbr: sergeyu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1016217Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#551607}
-
