GitLab

BUG=163902,163904,163922,163924
TBR=glider
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11416318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170744 0039d316-1c4b-4281-b951-d872f2087c98

Create different implementations for desktop Chrome / CrOS, and change
initialization to keep the CrOS version in BrowserPolicyConnector
instead of the Profile.

BUG=chromium:108928
TEST=compiles and passes tests, cloud policy works as before.
TBR=phajdan.jr@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/11415094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170742 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170741 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/11418289/
Review URL: https://codereview.chromium.org/11412301

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170740 0039d316-1c4b-4281-b951-d872f2087c98

Android's time_t is 32-bit by default, but the platform provides
a <time64.h> providing for time64_t and associated functions.

Use time64_t in base/time_posix.cc to implement base::Time::Exploded
conversion routines. This avoids un-necessary clamping of the year
to the 1901-2038 range when calling base::Time::Explode() or
base::Time::FromExploded().

BUG=162007
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11308176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163210

Review URL: https://codereview.chromium.org/11428091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170737 0039d316-1c4b-4281-b951-d872f2087c98

The FindThirdPartyDirs function no longer filters out empty/missing
directories as of r170273; update webview_licenses to do this. Also,
actually print the name of the directory causing a license error to make
debugging failures easier.

BUG=

Review URL: https://codereview.chromium.org/11421199

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170736 0039d316-1c4b-4281-b951-d872f2087c98

R=torne@chromium.org
BUG=163896
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/11280278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170733 0039d316-1c4b-4281-b951-d872f2087c98

Change summary:
- Add 'const' to ShellDelegate::IsUserLoggedIn()
- Use TrayImageItem::UpdateAfterLoginStatusChange delegate instead of ShellObserver::OnLoginStateChanged()
- Add a pref: kShouldAlwaysShowAccessibilityMenu
- Add a checkbox to chrome://settings

BUG=158287
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/11280236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170732 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=162375

Review URL: https://codereview.chromium.org/11414292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170730 0039d316-1c4b-4281-b951-d872f2087c98

Add a tool to look for unused suppressions.

BUG=112065

Review URL: https://chromiumcodereview.appspot.com/11421163

TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/11415256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170727 0039d316-1c4b-4281-b951-d872f2087c98

Widen some suppression, add general Histogram suppression (hope the other ones
will be unused then); exclude some tests.

BUG=163880
TBR=glider
NOTRY=true
Review URL: https://codereview.chromium.org/11419286

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161748


Review URL: https://chromiumcodereview.appspot.com/11421166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170725 0039d316-1c4b-4281-b951-d872f2087c98

Part 1: https://chromiumcodereview.appspot.com/11362183/

The second part of this change implements the "true" path,
i.e. the user provides us with a new AwContents to host
the popup window. This arrives asynchronously.

While we are waiting for the reply from the user, we defer
loading of the popup contents using a resource throttle.

When we receive the callback we replace the ContentViewCore that
is contained in the new AwContents with one that wraps the WebContents
for the popup. This triggers an update to the AwIoThreadClient for
that AwContents, which resumes the deferred load for the popup.

Android only change and android bots green
NOTRY=TRUE

Review URL: https://chromiumcodereview.appspot.com/11348075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170721 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170720 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170718 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=163855

Review URL: https://codereview.chromium.org/11348346

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170717 0039d316-1c4b-4281-b951-d872f2087c98

Two reasons to do this:
- We should prevent LocalFileSystemService's RemoteChangeProcessor
  methods from being called for origins that may not have been
  initialized in the local side yet. (If we run the initialization
  simultaneously it's not straightforward to disallow this)
- It's not easy to undo the RegisterOrigin if local-side's
  initialization fails.

BUG=none
TEST=manual

Review URL: https://codereview.chromium.org/11316270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170716 0039d316-1c4b-4281-b951-d872f2087c98

Sharable constants and methods are moved to common/cloud_print so they can be shared by all cloud print related features.  Classes/constants/methods in service/cloud_print are moved into namespace cloud_print. Tests are added. 

BUG=163603

Review URL: https://chromiumcodereview.appspot.com/11360151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159981


Review URL: https://chromiumcodereview.appspot.com/11299270

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170714 0039d316-1c4b-4281-b951-d872f2087c98

This adds default implementations to the Cocoa and Gtk shell windows. The views shell window is currently the only class that implements these in a non-default way; the Cocoa and Gtk will get their own implementations in a follow-up patch.

This is needed to have the app window setBounds() and getBounds() APIs operate
on content bounds rather than window frame bounds.

R=ben@chromium.org,rsesek@chromium.org,estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/11369237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170713 0039d316-1c4b-4281-b951-d872f2087c98

R=kinaba@chromium.org
BUG=160904


Review URL: https://chromiumcodereview.appspot.com/11418127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170712 0039d316-1c4b-4281-b951-d872f2087c98

from Routing IDs, instead of using ChildThread::ResolveRoute. This avoids a
potentially unsafe downcast from IPC::Listener* to RenderViewImpl*, if the given
routing_id does not correspond to a RenderView.

BUG=163008


Review URL: https://chromiumcodereview.appspot.com/11316209

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170708 0039d316-1c4b-4281-b951-d872f2087c98

An upload of a large file requires multiple requests of ResumeUploadOperation
which should be tested.

BUG=162348
TEST=none

Review URL: https://codereview.chromium.org/11308315

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163204
TEST=manual


Review URL: https://chromiumcodereview.appspot.com/11418256

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170705 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szager@chromium.org
BUG=163855

Review URL: https://codereview.chromium.org/11419282

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170704 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170703 0039d316-1c4b-4281-b951-d872f2087c98

Switch backing repository for android from chromium.googlesource.com to git.chromium.org to avoid Over Quota error.

TBR=szager@chromium.org
BUG=163855

Review URL: https://codereview.chromium.org/11416313

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170702 0039d316-1c4b-4281-b951-d872f2087c98

Needs to revert this because its WebKit patch was unrolled.
(See r136319, unreviewed, rolling out r136236).
> Update the Speech Api to support array(s) of result items
> instead of a single item at a time.
> 
> BUG=143124
> TEST=Covered by content_unittests
> 
> Review URL: https://chromiumcodereview.appspot.com/11421103

TBR=tommi@chromium.org
Review URL: https://codereview.chromium.org/11416310

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170701 0039d316-1c4b-4281-b951-d872f2087c98

> Disable threaded compositing when texture sharing is blacklisted
> 
> When texture_sharing is blacklisted, we can't do readbacks from the
> browser process and thus hit the render process to do readbacks for
> the thumbnailer or the extensions getVisibleTab() API. This path is
> a bit buggy in threaded compositing mode, so disable the thread.
> 
> BUG=158747
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11361077

TBR=jamesr@chromium.org
BUG=163046
Review URL: https://codereview.chromium.org/11280272

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170700 0039d316-1c4b-4281-b951-d872f2087c98

> Make sure Java Bridge cleans up all stub object it creates.
> 
> I have been trying to see why the JavaBridgeChannelHost, which is reference counted, sticks around forever.
> 
> Here is what I found:
> 
> When talk back is enabled. Each JavaBridgeChannelHost typically have 5 references to it. 3 of them should be cleaned up by this patch. (see comments in the .cc file)
> 
> BUG=157699
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/11359143

TBR=acleung@google.com
Review URL: https://codereview.chromium.org/11412297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170699 0039d316-1c4b-4281-b951-d872f2087c98

It looks like the call to GetMagnifierType() on accessibility_util:124 is
introducing some crashes.

chrome!chromeos::accessibility::GetMagnifierType()
[accessibility_util.cc : 283 + 0xb

> Add Chrome OS accessibility histograms.
> 
> BUG=99504
> TBR=joi
> 
> Review URL: https://chromiumcodereview.appspot.com/11414232

TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/11348342

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170698 0039d316-1c4b-4281-b951-d872f2087c98

I have been trying to see why the JavaBridgeChannelHost, which is reference counted, sticks around forever.

Here is what I found:

When talk back is enabled. Each JavaBridgeChannelHost typically have 5 references to it. 3 of them should be cleaned up by this patch. (see comments in the .cc file)

BUG=157699


Review URL: https://chromiumcodereview.appspot.com/11359143

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170694 0039d316-1c4b-4281-b951-d872f2087c98

"drive_file_path" was unused...

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/11412295

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170693 0039d316-1c4b-4281-b951-d872f2087c98

This is just a stub for now so I can iterate on it with follow up changes to
implement the real stuff.

views_examples_exe will be built directly on top of AURA API.

BUG=141187
TEST=out/Debug/views_examples_exe
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11421176

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170692 0039d316-1c4b-4281-b951-d872f2087c98

This is a combination of https://codereview.chromium.org/11308302/ and https://codereview.chromium.org/11434064/, with some fixes to tests.

BUG=153137
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/11411308

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160903
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/11417150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170688 0039d316-1c4b-4281-b951-d872f2087c98

Use SpdySessionDependencies in HttpNetworkTransaction and
HttpProxyClientSocketPool tests, instead of hand-rolled alternatives.BUG=


Review URL: https://chromiumcodereview.appspot.com/11348333

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133088
TBR=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/11434074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170686 0039d316-1c4b-4281-b951-d872f2087c98