GitLab

TODO: I think my plan for masked cards is to rank them just below the worst ranked unmasked card, but not above any local card that's been used at least 5 times. That way they'll start near the top, but eventually filter down to the bottom (unless you unlock them), while staying above cards you've used zero times.

For wallet addresses, perhaps stick them just below the worst ranked "complete" local address. A "complete" address is defined by addressinput::HasAllRequiredFields.

BUG=342426

Review URL: https://codereview.chromium.org/947693002

Cr-Commit-Position: refs/heads/master@{#318165}

This will allow us to use ChromeNativeAppWindowViews as a base
for ChromeNativeAppWindowViewsMac.

BUG=459877

Review URL: https://codereview.chromium.org/947343003

Cr-Commit-Position: refs/heads/master@{#318164}

This brings the context menu options closer to what is in the App
Launcher, and hides the webstore link in cases where it shouldn't be
shown to the user. This change is ignored on Mac.

BUG=449095

Review URL: https://codereview.chromium.org/899173002

Cr-Commit-Position: refs/heads/master@{#318163}

Currently type WiMAX fails ONC validation so any property
changes from Settings are ignored.

This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests.

BUG=460829

Review URL: https://codereview.chromium.org/949783003

Cr-Commit-Position: refs/heads/master@{#318162}

Review URL: https://codereview.chromium.org/959863004

Cr-Commit-Position: refs/heads/master@{#318161}

Testing shows that this change is correct, but there was no evidence supporting the other change. Will manually run the x64 dbg test try bot for this change.

TBR=thakis@chromium.org,jvoung@chromium.org
BUG=458690,460563

Review URL: https://codereview.chromium.org/942003008

Cr-Commit-Position: refs/heads/master@{#318160}

BUG=none

Review URL: https://codereview.chromium.org/953163002

Cr-Commit-Position: refs/heads/master@{#318159}

See https://codereview.chromium.org/958693004

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/955183002

Cr-Commit-Position: refs/heads/master@{#318158}

Host:port can be resolved from service name.
Still old method is useful when client already know them.

BUG=461504

Review URL: https://codereview.chromium.org/948283005

Cr-Commit-Position: refs/heads/master@{#318157}

Cast will use NetworkChangeNotifierLinux. This commit also fixes a
some logging messages and tear down in ConnectivityChecker.

R=gunsch@chromium.org
BUG=391064

Review URL: https://codereview.chromium.org/960693002

Cr-Commit-Position: refs/heads/master@{#318156}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/bacacfe..1175397

TBR=arv@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/957863002

Cr-Commit-Position: refs/heads/master@{#318155}

In order to prepare for future changes where additional metrics
will be added to the TBM module, I have also preemptively added a
filter function which filters out values relating to gpu_times.

R=nednguyen@chromium.org
BUG=455292, 453131

Review URL: https://codereview.chromium.org/959983002

Cr-Commit-Position: refs/heads/master@{#318154}

BUG=266140

Review URL: https://codereview.chromium.org/880083004

Cr-Commit-Position: refs/heads/master@{#318153}

With the brand new Compositing display items, we no longer need these
transparency methods. This patch depends on a blink-side patch:
https://codereview.chromium.org/953143003.

Review URL: https://codereview.chromium.org/956813002

Cr-Commit-Position: refs/heads/master@{#318152}

This CL mainly converts from using positional parameters to a single
struct, but there are various other changes as well.

The functions corresponding to different HTTP methods have been
eliminated, and the "doMethod" function has been renamed "start".
Saving one parameter at each call site seemed like a poor tradeoff for
having four functions that differ only in the HTTP method they use.

The core logic of creating an XHR and arranging for the onDone
function to be called has been factored out into a separate function,
startInternal_.

The "parameters" argument has been replaced by separate urlParams and
content arguments.  This eliminates the need to heuristically decide
what to do with the parmameters based on the HTTP method, and it
allows URL parameters and body content to be included in the same
call, a case which occurs in practice in host_controller.js.

There are now three parameters for sepecifying different types of body
content: textContent, formContent, and jsonContent.  They have
different data types, and the formContent and jsonContent parameters
implicitly set the Content-type header to the correct value.

A new parameter, oauthToken, is a convenience for adding a
correctly-formatted Authorization header.  This formatting was
previously duplicated at five seperate call sites.

The string "OAuth" in Authorization headers has been replaced with
"Bearer". The OAuth 2 spec supports the use of "Bearer" but not
"OAuth".

There are no longer any instances where headers are specified
explicitly, but the ability to do so still exists in the API.

Finally, headers and urlParameters with the value null are accepted
but not included in the HTTP request.  This simplifies the logic of
the doRegisterHost function in host_controller.js.

BUG=

Review URL: https://codereview.chromium.org/945033002

Cr-Commit-Position: refs/heads/master@{#318151}

Drivers may establish minimum sizes for the modesetting buffers. Since
cursor buffers are treated differently by the DRM API, they do not
require to be registered. Registering them on drivers with tight lower
bounds will fail since cursor buffers tend to be small.

BUG=none

Review URL: https://codereview.chromium.org/959953002

Cr-Commit-Position: refs/heads/master@{#318150}

Also adds more fields to environment to narrow the scope of
benchmark and user story set discovery. This should avoid problems
with adding Python files to unrelated directories, and hides PageTests
from external Telemetry benchmark runners like run_gpu_tests.py and
chrome_proxy's run_benchmark.

R=dtu,nednguyen,sullivan,kbr@chromium.org,bolian
BUG=460181
TEST=tools/perf/run_benchmark; content/test/gpu/run_gpu_tests.py; tools/chrome_proxy/run_benchmark  # All return a full and correct test list.

Review URL: https://codereview.chromium.org/942663002

Cr-Commit-Position: refs/heads/master@{#318149}

BUG=460741

Review URL: https://codereview.chromium.org/954053004

Cr-Commit-Position: refs/heads/master@{#318148}

As we're planning to intercept the _heap_init and _heap_term function to control which heap gets used by the crt we need to make sure that libcmt doesn't get patched.

R=chrisha@chromium.org
BUG=

Review URL: https://codereview.chromium.org/952183003

Cr-Commit-Position: refs/heads/master@{#318147}

Both args are not neccecary as state, so they don't need to be in the
constructor.

BUG=461504

Review URL: https://codereview.chromium.org/948413006

Cr-Commit-Position: refs/heads/master@{#318146}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/b180ee9..09bdb2a

BUG=none

Review URL: https://codereview.chromium.org/952293002

Cr-Commit-Position: refs/heads/master@{#318145}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63d0024..37a6107

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/956903004

Cr-Commit-Position: refs/heads/master@{#318144}

Automated definition used enum types instead of strings, and it looks like we
need to include the two functions which take "any" arguments.

BUG=461039

Review URL: https://codereview.chromium.org/956063002

Cr-Commit-Position: refs/heads/master@{#318143}

This simplifies the way in which a DRP TestContext is created, in that
optional parameters are specified with explicit methods on the Builder.

BUG=461914

Review URL: https://codereview.chromium.org/959913002

Cr-Commit-Position: refs/heads/master@{#318142}

Avoid optimization of using glTexImage2D over glTexSubImage2D when there
are EGLImages attached to the texture, as glTexImage2D will orphan the
EGLImage. Orphaning and reattachment is probably more expensive than the
win of using glTexImage2D over glTexSubImage2D.

BUG=460344

Review URL: https://codereview.chromium.org/954053002

Cr-Commit-Position: refs/heads/master@{#318141}

If we don't do this, then we have a race condition between unloading
this extension, and trying to use it because we have manually
navigated to it.

BUG=460431

Review URL: https://codereview.chromium.org/961443003

Cr-Commit-Position: refs/heads/master@{#318140}

BUG=461537

Review URL: https://codereview.chromium.org/955443004

Cr-Commit-Position: refs/heads/master@{#318139}

The render surface calculation wasn't taking into account animated
filters.  These are animations which will eventually set a filter, but
the filters on the layer are empty at render surface calculation time.

This is just a missed case in render surface calculation, as it used
to be handled naturally on the compositor thread after the filter got
added.

R=vollick@chromium.org
BUG=461180

Review URL: https://codereview.chromium.org/957703004

Cr-Commit-Position: refs/heads/master@{#318138}

driver along with unit tests.

In this change, the test driver can now call GAIA and retrieve an access and
refresh token given an authorization code.  It can then store the refresh token
locally and retrieve it on subsequent tool runs.

BUG=

Review URL: https://codereview.chromium.org/880273006

Cr-Commit-Position: refs/heads/master@{#318137}

On Android, CastService::Start is never called (!). This is because
Android uses a Java-based UI message loop after
BrowserMainRunner::Initialize is completed, and BrowserMainRunner:Run is
never called (nor should it be).

See ChromeBrowserMainParts for similar handling of the Android case.

R=lcwu@chromium.org,byungchul@chromium.org
BUG=internal b/18934906

Review URL: https://codereview.chromium.org/953283002

Cr-Commit-Position: refs/heads/master@{#318136}

This moves software fallback decisions to GpuProcessTransportFactory
from the ui::Compositor, where it was already making decisions like
"can I fallback to software compositing on this OS". Now it will not
return an OutputSurface to ui::Compositor until it has successfully
bound/initialized one.

R=jbauman, piman@chromium.org
BUG=461396

Review URL: https://codereview.chromium.org/953803005

Cr-Commit-Position: refs/heads/master@{#318135}

BUG=

Review URL: https://codereview.chromium.org/937593002

Cr-Commit-Position: refs/heads/master@{#318134}

BUG=436834
TEST=In guest mode (across browsers), Bookmarks doesn't show in the
wrench menu.

Review URL: https://codereview.chromium.org/953723003

Cr-Commit-Position: refs/heads/master@{#318133}

Boolean binding is strange and in this case, we didn't actually want question marks in the bindings for the paper-checkbox's attributes. This makes everything work properly.

R=michaelpg
BUG=

Review URL: https://codereview.chromium.org/948283004

Cr-Commit-Position: refs/heads/master@{#318132}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9b9eaa4..bacacfe

TBR=arv@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/960643002

Cr-Commit-Position: refs/heads/master@{#318131}

With the change, https://codereview.chromium.org/875583002, it is
possible to start a remote connection in fullscreen mode, we simply
need to notify the DesktopConnectedView that we are in fullscreen upon connecting.

BUG=461609

Review URL: https://codereview.chromium.org/958693002

Cr-Commit-Position: refs/heads/master@{#318130}

* Adding myself to these OWNERS files as an owner-in-training
* Removing gbillock as he no longer works on the project

BUG=

Review URL: https://codereview.chromium.org/956093002

Cr-Commit-Position: refs/heads/master@{#318129}

Since Mac does not support transparency, having a window with no title bar is inconvenient because it can't be dragged aside to access other windows. This CL adds a standard window frame on Mac.

BUG=b/19370387

Review URL: https://codereview.chromium.org/952823003

Cr-Commit-Position: refs/heads/master@{#318128}

This patch adds an SkRect for bounds to compositing_display_item and
uses it for setting the canvas layer bounds. With this patch and the
associated blink-side patch [1] we pass the following additional
layout tests:
LayoutTests/svg/zoom/page/zoom-mask-with-percentages.svg
LayoutTests/svg/transforms/text-with-mask-with-svg-transform.svg
LayoutTests/svg/custom/absolute-sized-content-with-resources.xhtml
LayoutTests/svg/custom/mask-excessive-malloc.svg
LayoutTests/svg/batik/masking/maskRegions.svg

[1] https://codereview.chromium.org/960483002

Review URL: https://codereview.chromium.org/952123002

Cr-Commit-Position: refs/heads/master@{#318127}

If OffscreenPreRaster is enabled, the viewport rect for tile priority
and the tile memory limit calculation will be based on the size of the
webview, instead of the size of visible area of the webview.

Design doc here
https://docs.google.com/document/d/1xOMjvbEIS3dMzpWXWrsl7qV8QOgGEIZL1QxgnfOXmq4/

BUG=460638

Review URL: https://codereview.chromium.org/944053004

Cr-Commit-Position: refs/heads/master@{#318126}