- 06 Aug, 2018 40 commits
-
-
Han Leon authored
This CL removes one usage of content::ServiceWorkerResponse by using blink.mojom.FetchAPIResponse directly. BUG= Change-Id: I8f52aa854107e17134622254a8f438853cb35a44 Reviewed-on: https://chromium-review.googlesource.com/1163535 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#580842}
-
Mathieu Perreault authored
Will contain Payments account information, initially customer ID. Bug: 870936 Test: none Change-Id: I0b7310b4ed66f3f50af627f93bef8fb75d32bea0 Reviewed-on: https://chromium-review.googlesource.com/1162947 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580841}
-
Gauthier Ambard authored
This CL adds a delegate for the ConsentBumpCoordinator, notifying it when the coordinator is finished, with the option chosed by the user. Bug: 866506 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia192a4e34da1daab1b969c86d91ea14e1738fcaf Reviewed-on: https://chromium-review.googlesource.com/1162161 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580840}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d2f6e76cbc6b..fe60316384dc git log d2f6e76cbc6b..fe60316384dc --date=short --no-merges --format='%ad %ae %s' 2018-08-06 cbruni@chromium.org Fix propertyMode in ic_stats_entry Created with: gclient setdep -r src/third_party/catapult@fe60316384dc The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:864898 TBR=sullivan@chromium.org Change-Id: Ibdfbb20f4952f1dd7e2ebbc599993edc4e4c0181 Reviewed-on: https://chromium-review.googlesource.com/1163108Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580839}
-
Yutaka Hirano authored
It's not used in chromium, and we need to remove it because we are moving CORS logic to the network service. Bug: 800669 Change-Id: I78d4b9ed641d3dca54ad80954872082e2450d2ef Reviewed-on: https://chromium-review.googlesource.com/1157364 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580838}
-
Jan Wilken Dörrie authored
This reverts commit dfa8728a. Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by a CL this one depended on. Original change's description: > Revert "Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors"" > > This reverts commit ffac89b5. > > Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 > > Original change's description: > > Reland "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > > > This reverts commit d01b7c9e. > > > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > > > Original change's description: > > > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > > > > > This reverts commit f61df6f9. > > > > > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. > > > > > > Sample builds: > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 > > > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 > > > > > > failures: > > > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 > > > BluetoothTestWinrt.GetPrimaryServices/1 > > > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 > > > BluetoothTestWinrt.GetPrimaryServicesByUUID/1 > > > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 > > > BluetoothTestWinrt.GetGattServices_and_GetGattService/1 > > > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 > > > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 > > > > > > Original change's description: > > > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > > > > > > > This change implements reading and writing of Remote Gatt Descriptors > > > > for WinRT. Furthermore, it enables corresponding tests. > > > > > > > > Bug: 821766 > > > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > > > > Reviewed-on: https://chromium-review.googlesource.com/1156703 > > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#579838} > > > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 821766 > > > Reviewed-on: https://chromium-review.googlesource.com/1159961 > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#580062} > > > > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766 > > Reviewed-on: https://chromium-review.googlesource.com/1160902 > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580201} > > TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: I0b4eac30dd4f35b8fb275bed74d69f7b7b1b0f38 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766,870208 > Reviewed-on: https://chromium-review.googlesource.com/1161681 > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580440} TBR=kinuko@chromium.org,reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821766, 870208 Change-Id: Icaf844c0c0aa72ab38db3e834df3100088339f1b Reviewed-on: https://chromium-review.googlesource.com/1163384Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580837}
-
Gemene Narcis authored
Just before a form is going to be added to LoginDatabase a more check have to be made for blacklisted sites. If the site is already blacklisted by user then the new form will not be added. Also, a histogram is added to know how many duplicates are in the LoginDatabase at every startup. This histogram has the role to inform us when the code that do the de-duplication can be deleted. Bug: 862930 Change-Id: Id256b6dc1c4995636c7281392bd1cb34af4ab5bc Reviewed-on: https://chromium-review.googlesource.com/1151636 Commit-Queue: Narcis Gemene <gemene@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580836}
-
Eric Willigers authored
visibility:collapse on rows shipped in M62 https://www.chromestatus.com/features/5684392546533376 https://chromium-review.googlesource.com/614461 BUG=174167 Change-Id: I23e0d27c55e13586e8934625c703727323d5709f Reviewed-on: https://chromium-review.googlesource.com/1163223 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#580835}
-
Mohamed Amir Yosef authored
uss migrator code is responsible for copying data from directory and delivering to the USS framework. It was not ready to migrate bookmarks because many fields that are relevant only for bookmarks were not migrated. (such as parent_id) This CL fixes that. Bug: 516866 Change-Id: I8613ababd595a5de5f74e2c47a59b3d0141159d5 Reviewed-on: https://chromium-review.googlesource.com/1162226Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#580834}
-
Mohamed Amir Yosef authored
This CL removes an unused |model| parameter from BookmarkChangeProcessor: :SetBookmarkFavicon() Change-Id: I0aa20f60d03caf1fbb45b3b9e2bc263e2a8d2f5f Reviewed-on: https://chromium-review.googlesource.com/1162339 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580833}
-
Mihai Sardarescu authored
It is impossible for the sync service to ensure that USER_EVENTS model type disabled when HISTORY_DELETE_DIRECTIVESis disabled. Howver, "Activity and interactions" must be disabled when HISTORY_DELETE_DIRECTIVES is disabled. This CL changes the personalized version of UrlKeyedDataCollectionConsentHelper to be enabled only when sync is active for both HISTORY_DELETE_DIRECTIVES and USER_EVENTS data types. Bug: 865537 Change-Id: Iaad834761ad4d7ddf56feec73f1f567b240c2b7f Reviewed-on: https://chromium-review.googlesource.com/1162235Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580832}
-
Takashi Toyoshima authored
ResourceLoadScheduler.{Traffic|Decoded}Bytes.{Main|Sub}frame(Not)?Throttled were introduced to measure loading traffic and data amount per throttling state and frame types. After the first introduction, ResourceLoadScheduler.{Traffic|Decoded}Bytes.KBPerFrameStatus were also introduced as metrics that can replace them, and are easy to be compared. This patch removes measuring code for the older metrics, and marks histogram items as obsolete. Bug: 854016, 854019 Change-Id: I5eb469c9699060c0018437097d9cfc4940c4c19a Reviewed-on: https://chromium-review.googlesource.com/1157952Reviewed-by:Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580831}
-
Jérôme Lebel authored
When the switch is toggled, the preference is updated, but the cell should not be reloaded (to let the animation finish). The UI is reloaded only when a value update notification is received without user action. When the user consent is removed, all sections are expanded and all cells inside are enabled to be modified. https://drive.google.com/open?id=1hvi5LyGjBDODkRQymvC5sbUjSN9tafFz Bug: 827072, 849838 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5bc39e1ee80d8844e56900a7a22e8201a3e2d411 Reviewed-on: https://chromium-review.googlesource.com/1144934 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#580830}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 75dbb726. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22543 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I06f0025af5fc5fcfc9e93f7178af478c7cffd98b Reviewed-on: https://chromium-review.googlesource.com/1163294 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#580829}
-
Jan Wilken Dörrie authored
This reverts commit b050a38a. Reason for revert: https://crrev.com/c/1161883 fixes the device_unittests breakage triggered by this CL. Original change's description: > Revert "Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors"" > > This reverts commit be2632ac. > > Reason for revert: Broke device_unittests on Win10 Tests x64 (dbg) crbug.com/870208 > > Original change's description: > > Reland "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > > > This reverts commit 67ca5a07. > > > > Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. > > > > Original change's description: > > > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > > > > > This reverts commit 20f64257. > > > > > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) > > > > > > Original change's description: > > > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > > > > > > > This change implements obtainining Remote Gatt Descriptors for WinRT by > > > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > > > > appropriate tests are enabled. > > > > > > > > Bug: 821766 > > > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > > > > Reviewed-on: https://chromium-review.googlesource.com/1156392 > > > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#579830} > > > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > > > > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 821766, 870208 > > > Reviewed-on: https://chromium-review.googlesource.com/1159943 > > > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > > > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#580106} > > > > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org > > > > Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 821766, 870208 > > Reviewed-on: https://chromium-review.googlesource.com/1160901 > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580200} > > TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org > > Change-Id: I9bd3f94b1be3b58b7975e1e57dff09cd7a9c2910 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766, 870208 > Reviewed-on: https://chromium-review.googlesource.com/1161682 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580442} TBR=reillyg@chromium.org,ksakamoto@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 821766, 870208 Change-Id: I29824289cbd23722a5e0397f07f40b62769549d4 Reviewed-on: https://chromium-review.googlesource.com/1163382Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580828}
-
Oscar Johansson authored
Without jumbo, chrome/renderer takes around 7 CPU minutes, which is around 1.2 % of the total build time. This commit will enable jumbo support for this target, reducing build time when using jumbo. Bug: 870617 Change-Id: I4b35b6fc69e30c61dc1f24082bbaa338ad96b4ef Reviewed-on: https://chromium-review.googlesource.com/1161804Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580827}
-
Mikel Astiz authored
This addresses a TODO about naming inaccuracy: this method, just like any other in ModelTypeChangeProcessor, gets exercised on the model thread. So there is no actual thread safety requirements. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7adc0d0df8975d1a64e2101ee2ca4cc7a63f5a82 Reviewed-on: https://chromium-review.googlesource.com/1160859Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580826}
-
Matt Falkenhagen authored
This test has flaky timeouts on Fuchsia bots. Bug: 862294 Change-Id: I19e164ecbac86347b9756e55c92e7a59da05dddd Reviewed-on: https://chromium-review.googlesource.com/1163046Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#580825}
-
Tetsui Ohkubo authored
According to UX spec, notifications scroll behind SystemTray part of UnifiedSystemTray. Technically it is hard to implement this naively, because ARC++ notifications use NativeViewHost which ignores views layer hierarchy. In this CL, we just paint the background of SystemTray corners with the same color as notification's. It looks natural to users while avoiding complexity other hacks to fix the issue would add. TEST=manual BUG=863494 Change-Id: I65147a0b8fd9bb2400f79b6bb6cbfea4fb13db33 Reviewed-on: https://chromium-review.googlesource.com/1161710Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#580824}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I83202210a016a62b421c4cf0d864614d2b2e6e45 Reviewed-on: https://chromium-review.googlesource.com/1163297Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580823}
-
Adam Rice authored
Update WritableStream to standard version https://github.com/whatwg/streams/commit/51227372cc84846bdcf68312724c4cac6a4b9e58 Remove failing test expectations. Changes: The timing of access of strategy parameters has been changed to match the standard. This mostly only affects the tests that are looking for it. Algorithms are cleared out once they will no longer be called, enabling garbage collection. Bug: 866388 Change-Id: I948a858c101960bd19c826f9d8764575d5360c66 Reviewed-on: https://chromium-review.googlesource.com/1146622Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580822}
-
Oscar Johansson authored
When building using jumbo, files gets merged and constants with the same name may end up in the same namespace and conflict. This happens for: chrome/renderer/chrome_content_renderer_client.cc chrome/renderer/extensions/extension_hooks_delegate.cc chrome/renderer/extensions/tabs_hooks_delegate.cc This commit solves the issue by renaming the constants to something more file specific. Bug: 870617 Change-Id: I3ded3625b3851724362d496191c5bd25dda081f6 Reviewed-on: https://chromium-review.googlesource.com/1161803Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#580821}
-
Adam Rice authored
I removed these histograms in March 2017 in https://codereview.chromium.org/2764683002 but I forgot to mark them as obsolete in histograms.xml. Mark them as obsolete. BUG=700568 Change-Id: I76e83d25ea45488ae8631c6402171dda3e61f987 Reviewed-on: https://chromium-review.googlesource.com/1161719Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580820}
-
Marina Ciocea authored
This reverts commit eab3705f. Reason for revert: regression reported in https://crbug.com/870171 Original change's description: > Delay audio service launch on the browser startup. > > (see the bug) From the traces the service/process creation gets posted to the > IO thread during startup. > It may be delaying startup for some other services needed for the first paint, or it may be > just eating up CPU when the load is already quite high. We'll experiment with delaying > the service launch. > > Bug: 867461 > Change-Id: I048e33d049e665d8e9489046c5813918d8077524 > Reviewed-on: https://chromium-review.googlesource.com/1153248 > Commit-Queue: Olga Sharonova <olka@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579460} TBR=gab@chromium.org,olka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 867461 Change-Id: If0751dd76f8e880d0fc8454c6707778de5ce6685 Reviewed-on: https://chromium-review.googlesource.com/1162183Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#580819}
-
Marc Treib authored
ProfileSyncService::Initialize used to early-out if DISABLE_REASON_PLATFORM_OVERRIDE or DISABLE_REASON_ENTERPRISE_POLICY were present. However: - In practice, platform_sync_allowed_provider_ isn't set at this point, so DISABLE_REASON_PLATFORM_OVERRIDE will never occur. Even if it did, calling StopImpl(KEEP_DATA) at this point (before |engine_| exists) does nothing. - Both disable reasons can disappear during Chrome's lifetime, in which case ProfileSyncService is left in a half-initialized state. In particular, it won't be listening for auth events. This CL removes handling for DISABLE_REASON_PLATFORM_OVERRIDE, and does not early-out anymore for DISABLE_REASON_ENTERPRISE_POLICY. Bug: 870683 Change-Id: I354629deaa42a782e10658190c84e967fee593a3 Reviewed-on: https://chromium-review.googlesource.com/1162236Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580818}
-
David Staessens authored
Currently the jpeg decoder always assumes the VAAPI will support decoding to the I420 format. As this might not be the case for all VAAPI implementations this change adds a method to the VAAPI wrapper to check whether a specific format is supported. Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8ad54a27b9e1d560f5590ae778e43f8d75bba8e9 Reviewed-on: https://chromium-review.googlesource.com/1102277 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#580817}
-
Kunihiko Sakamoto authored
Mark virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen* as Failure on Android TBR=mcnee@chromium.org No-Try: true Bug: 871139 Change-Id: If29b18d3297e306364b87f0c2582bab476c35c68 Reviewed-on: https://chromium-review.googlesource.com/1163408Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580816}
-
Darren Shen authored
Currently, when we disable the keyboard, we directly reset the state back to UNKNOWN without logging or validation. This means that in the UMA metrics for state transitions, the transitions going into a state does not add up to the transitions going out of a state. This patch explicitly changes the state back to INITIAL when the keyboard is disabled. When the keyboard is about to be disabled, the only valid states are INITIAL, LOADING and HIDDEN. We don't change if the current state is INITIAL to avoid self-transitions. Bug: 775354 Change-Id: Idab146e017d179a9086808481f3ed65b6f0dfbcf Reviewed-on: https://chromium-review.googlesource.com/1163346Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#580815}
-
Kouhei Ueno authored
Bug: 868592 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5cff4653a62c357e8eb9d5a82a11b8018653b712 Reviewed-on: https://chromium-review.googlesource.com/1163235Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#580814}
-
Hayato Ito authored
https://bugs.webkit.org/show_bug.cgi?id=82702 was already closed. We can remove this old FIXME. TBR=rakina Change-Id: Ib04660f4cb4be99c68a71d935de4d8bf429716ce Reviewed-on: https://chromium-review.googlesource.com/1163343Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580813}
-
Hayato Ito authored
Change-Id: Icd3665e37131c31c584a97355b3f74d76b0f34ff Reviewed-on: https://chromium-review.googlesource.com/1162084Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580812}
-
Chih-Yu Huang authored
When VDA enqueue flush input buffer to the Tegra driver before enqueuing any normal input buffer, Tegra driver will stuck. Now for the devices which do not support V4L2 decoder command, if we call Flush() before decoding any buffer, we skip sending an empty buffer to the driver and notify flush is done. BUG=chromium:845627 TEST=pass video_decode_accelerator_unittest on nyan-big and peach-pit Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I34a5ec76d95fac8f5bedd3ead08202b1a4e41dcd Reviewed-on: https://chromium-review.googlesource.com/1127559 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#580811}
-
Hayato Ito authored
Change-Id: I8cfd1db4b3b48b69c478a0bc5a60402e035272eb Reviewed-on: https://chromium-review.googlesource.com/1162085Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580810}
-
Ramin Halavati authored
Preferences related to Arc are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I45d5f5bb40841c386d39709d9da80ca431b2a2e1 Reviewed-on: https://chromium-review.googlesource.com/1158069Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#580809}
-
Yuki Yamada authored
Removed V8WorkerOrWorkletEventListener::HandleEvent() in order to remove blink::V8WorkerOrWorkletEventListener. The difference between V8AbstractEventListener::HandleEvent() and V8WorkerOrWorkletEventListener::HandleEvent() was checking if script controller is available or not. This should be done in not only V8WorkerOrWorkletEventListener but also other event listeners, so this CL added this operation by checking ScriptState::ContextIsValid(). Bug: 869778 Change-Id: I3168f9990d2c6d076061b4d7d8f9ab85619f71d5 Reviewed-on: https://chromium-review.googlesource.com/1160069Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#580808}
-
Hayato Ito authored
These comments don't make sense at this point. No behavior change. Just removing comments. TBR=rakina Change-Id: I39b0097f45775551ef1614cd4b4efdfce9f41146 Reviewed-on: https://chromium-review.googlesource.com/1163341Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#580807}
-
Kunihiko Sakamoto authored
This reverts commit 94558b66. Reason for revert: Findit thinks this made the following tests flaky: TabRestoreTest.RestoreWindowBounds (crbug.com/870945) BrowserNavigatorTest.Disposition_NewPopupFromAppPopup (crbug.com/871010) Original change's description: > [NTP] Adds an experiment for M69 NTP features. > > Only the first experiment entry gets covered by perf waterfall, so adding > this item ensures better test coverage. Also, the existing experiment, > NewTabPageAllBirthday_Enabled, could not be re-used since > go/revising-finch-configs recommends creating a new experiment when > changing size or behavior of existing groups. > > Bug: 831910 > Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5 > Reviewed-on: https://chromium-review.googlesource.com/1160925 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580314} TBR=holte@chromium.org,ramyan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831910,870945,871010 Change-Id: Ifb86fbc322d939eba40f84b1ee32a21d76361f86 Reviewed-on: https://chromium-review.googlesource.com/1163361Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580806}
-
Takashi Toyoshima authored
Bug: none Change-Id: Ia12fd5e686b2642a37ac30a372d0a54394310e47 Reviewed-on: https://chromium-review.googlesource.com/1157962Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#580805}
-
Dominic Farolino authored
There is no observable result of this change. Before this CL, ModuleScriptFetchRequest stored a blink::Referrer and a blink::ScriptFetchOptions. This effectively stored two blink::ReferrerPolicy members under ModuleScriptFetchRequest. We also generated ModuleScriptFetchRequest's Referrer in two different places in ModuleTreeLinker. Finally ModuleScriptFetchRequest's Referrer member was used in ModuleScriptLoader::FetchInternal to set ResourceRequest's referrer header. After this CL, we store only a referrer string in ModuleScriptFetchRequest, as the spec indicates, and do not generate a blink::Referrer in ModuleTreeLinker. Then in ModuleScriptLoader::FetchInternal, we generate and set ResourceRequest's final referrer. This also leaves a TODO, to stop storing ResourceRequest's referrer as a header value. R=kinuko@chromium.org, kouhei@chromium.org, nhiroki@chromium.org, yhirano@chromium.org Bug: 863769 Change-Id: Id22467f5c93e59b33ca01571addeceb1a505a1af Reviewed-on: https://chromium-review.googlesource.com/1157237 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#580804}
-
Yoichi Osato authored
Since "rendered position" is ambiguous, this patch renames it to simply the function name implemented in the file. Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I98d310b092edc0983ec03012f32c81f60224d2e0 Reviewed-on: https://chromium-review.googlesource.com/1160070Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#580803}
-