- 11 Nov, 2020 40 commits
-
-
Emily Stark authored
This CL adds a new Safety Tips feature flag which enables lookalike Safety Tips, specifically for the purpose of measuring how Simplified Domain Display behaves. This is necessary because multiple Finch experiments can't enable the same feature at the same time, and it's possible that we'll be running separate Safety Tips and Simplified Domain Display experiments at the same time. Ordinarily this would run the risk of muddying our data between the experiments, but since Safety Tips are only encountered very rarely, and we specifically filter out users who see multiple Safety Tipped sites in our experiment metrics (as they are outliers), we don't anticipate this to be a problem. Bug: 1146471 Change-Id: I033476e8e1cb3fb4afc2c7a1f8669ea28b2c7b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530253Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#826136}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81e9301838fc..6835e1ab1918 2020-11-11 chinglinyu@google.com Merge "traced: fix permissin check of /run/perfetto as default socket basedir" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ida4c6d855dd982d73cd1f9269884ee213635e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531246Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826135}
-
chrome://devicesrbpotter authored
The page has been behind a flag that is disabled by default since M86. By the M88 Stable release, cloud print will be turned down, so this page for adding new cloud printers will no longer be needed. Bug: 1112576 Change-Id: Ibc12a7180c268f5c91153d5c44ae615779b0f88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516245 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826134}
-
Clark DuVall authored
Bug: 949535 Change-Id: Iec2190a535baa03e581757977310e067cde3c953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527734Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#826133}
-
Chris Lu authored
Bug: 1138603 Change-Id: Ie4a57e74d125ea064368e74f2e49f7c2548bfc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527007 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#826132}
-
Adrienne Walker authored
This fixes issues from: https://chromium-review.googlesource.com/c/chromium/src/+/2446889 Bug: 1131151 Change-Id: I2d78538c1b6cd4e6cd2b1070e11fb1e024168dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530904 Auto-Submit: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#826131}
-
Josh Nohle authored
Record the furthest each discovery session progresses before ending. A discovery session starts when the share-target discovery UI appears and ends on failure, cancellation, or when a transfer completes. We also track the results of the individual steps in the discovery flow: starting discovery, finding share targets, and beginning a transfer to the share target. Bug: 1105579 Change-Id: I52e34b0a09c54a37f7d76aa1480cbce18e905d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524980 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#826130}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8da8bcdf92fb..81e9301838fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic4e30824f934a07eb1430903432cf8857725eb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530213Reviewed-by:
-
Jeevan Shikaram authored
This CL checks to see if the the payment method is supported and if there is an APK that will be able to handle the request. Bug: 1137688 Change-Id: I93508af961fade71a584b54a76b13c610f8e3a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528809 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#826128}
-
Charlie Hu authored
Previously parse of 'Permissions-Policy' HTTP header still reports parsing error with 'Error with Feature Policy: '. This CL lets parse of 'Permissions-Policy' HTTP header use a separate logger that has prefix 'Error with Permissions Policy: '. Note: Previously merge of feature policy and permissions policy was implicit, i.e. done by concatenating the two together and relying on the parsing rule that first occurrence of feature wins. This CL makes the merge explicit in |FeaturePolicyParser::ParseHeader|. Change-Id: I25f877899aa709705fb96b6a6cfe003dedd217d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514961Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#826127}
-
Yoichi Osato authored
It is flaky: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel?limit=100 TBR=rbpotter@chromium.org BUG=1147205 Change-Id: Ic17a9f40d98f18a597d7ec353d78ff3ebe5afdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530957Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#826126}
-
Jesse Schettler authored
Replace the string for the helper text with the newest string and update the styling to match the spec. Bug: 1059779 Change-Id: I7b2ba855f0a34107b5c62ca1cb9f7f659c2e96fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530216Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#826125}
-
Christopher Lam authored
This CL centralizes the definition of the above variables into grit_defines.gni to reduce boilerplate across the codebase. TBR=thakis@chromium.org,boliu@chromium.org,oksamyt@chromium.org,gambard@chromium.org,khorimoto@chromium.org Bug: None Change-Id: I76aba8bcdc0a6d1613de1a8c961f85e95baecbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489102Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
- Adds response to click event when no network found link is clicked in esim and psim internet subpage groups. Bug: 1093185 Change-Id: Ib37f7806c19b8cf62517909d64f0570b190d615d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515362 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#826123}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: Icdf421e7d07aa3756f81d412f71f8f66eb4a9064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531296Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826122}
-
Rakina Zata Amni authored
Currently MimeHandlerView sandbox errors (trying to load in a sandboxed iframe) triggers a new navigation within a renderer, not notifying the browser until it finished committing in the renderer. We want to remove cases where the renderer starts navigations and not notify the browser until the navigation committed. See doc for more context: https://docs.google.com/document/d/1UjdxiDJ3sgVDbp0CZpsSntdwAYNMSfc2qajX4nzXfLY/edit?usp=sharing This CL moves the sandbox error navigation to be triggered from the browser side instead by checking the sandbox flags before committing. Bug: 1133115 Change-Id: I3c56574e36ac5115eb51df126ae19adc678a404b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449669 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#826121}
-
Joshua Peraza authored
Bug: 1050178 Change-Id: If99330fbef9978211dae0aacd038f4c5cefb83e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825326Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#826120}
-
Nidhi Jaju authored
In this CL, the typedef for ReadableStreamReader is added to the Readable Stream WebIDL file based on the Streams API Standard[1]. In order to avoid confusion, the ReadableStreamReader class is also renamed to ReadableStreamGenericReader. This also makes more sense as the base class for the Default and BYOB Readers. Furthermore, the return value of getReader() is also changed to use the ReadableStreamReader typedef. Due to how the bindings code works, this meant that the return type of getReader in the C++ implementation also had to be changed to void and pass the ReadableStreamReader as a parameter, which is set as the returned reader. Lastly, a new function called GetDefaultReaderForTesting() is added to support calls to getReader() and read() in the various test files without having to change the return type everywhere. [1] https://streams.spec.whatwg.org/#typedefdef-readablestreamreader Bug: 1093862 Change-Id: Icbb34470f52ddcef53e9b1fa34f3dd8f27c48198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524628 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#826119}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1fe2b80dc782..7006e15df59d 2020-11-11 fmalita@chromium.org [svg] Allow clients to pass a custom SkFontMgr 2020-11-11 brianosman@google.com Make runtime effect error tests simpler / more explicit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I24246faa0927a852186a916a67c1b77f5b4247f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531244Reviewed-by:
-
Joel Hockey authored
Change-Id: I9a84bfe3d5b0261353c19fb0120cc84dbf999aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531074 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#826117}
-
Ian Kilpatrick authored
Due to a HTML specification change, the default UA stylesheet for modal dialog elements has changed: https://github.com/whatwg/html/pull/5936/files https://chromium.googlesource.com/chromium/src/+/be7281e188f22856bf9084d9f5c74a0f48eee1da Specifically for this bug - position:fixed and position:absolute have slightly different behviour when printing. This switches the internal <dialog> element back to position:absolute. Bug: 1147394 Change-Id: I8a41ef869cd6a17db0c79ba42ca3d5a5eb247d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531215Reviewed-by:
-
Jeremie Boulic authored
This reverts commit 17c5fc75. Reason for revert: Due to a mistake when rebasing, 2 CLs were submitted at the same time. Relanding those 2 CLs properly. Original change's description: > Audio player: Convert dependencies in //ui/file_manager/image_loader/ > > In //ui/file_manager/image_loader: > - load_image_request.js > - image_loader_client.js > - image_loader_client_unittest.js > > Bug: 1133186 > Change-Id: If1fa276446e2ae5a8763ca1a9bb728cb0c7ce2b4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529649 > Commit-Queue: Jeremie Boulic <jboulic@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826095} TBR=lucmult@chromium.org,jboulic@chromium.org Change-Id: I11e659413196563811d843635a829d0b1a642b2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133186 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531438Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#826115}
-
Sammie Quon authored
Only for tablet mode. Like other capture mode entries, not available for login/lock/oobe. Bug: 948120 Test: manual Change-Id: I37ece1da0a48268507907fed4a713d2c4fb882fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530980 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#826114}
-
Aleks Totic authored
LayoutTableSectionInterface::PrimaryCellAt was no longer used, and was removed. Bug: 958381 Change-Id: I53ca91c87db0025d077c969e75d1c66a53aa6e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528829 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#826113}
-
Dana Fried authored
CTRL+RIGHT with keyboard focus on a tab will now always move the current tab right, and CTRL+LEFT will move it left. Likewise, CTRL+SHIFT+RIGHT will always move the current tab to the right end of the tabstrip, and CTRL+SHIFT+LEFT will move to the left end. Prelude to fixing the attached bug. Bug: 1110426 Change-Id: Ib29d539db982b9b970ea192ca9edb13b18ca7d0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528179Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#826112}
-
Moe Ahmadi authored
- takes 4px off the top padding of the tile and gives it to the bottom padding. - takes 4px off the top margin of the title pill and gives it to the top/bottom padding of the title pill. before: screenshot/4aAFKmpkL76Qjam after: screenshot/8MXKqLJgqyFSxz7 Fixed: 1147217 Change-Id: I59fcfa419c725b5c2f7ddbfefda6d233595494e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530202 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826111}
-
Tommy Li authored
In 2015, we ran an experiment called KeywordRequiresPrefixMatch = false, where we experimented with a query "wikipedia.org" being able to trigger the "en.wikipedia.org" keyword mode search engine. This experiment has been dormant since then. The TemplateURLService has a reasonably extensive amount of infrastructure to support the non-prefix matches to domain name, and this CL removes that. We are removing this to simplify the code and unblock a larger issue where we are trying to solve Sync conflicts and duplicate search engine proliferation, e.g. "amazon.com" => "amazon.com_" duplicates. Bug: 1022775 Change-Id: I9cc92f06c2fe955ddc655bdef23955ab33418faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523726 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#826110}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b4f4226d153e..cf49cb8206ba 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Owners-Override is +1 2020-11-11 ehmaldonado@google.com [presubmit][owners] Skip owners check when Bot-Review is +1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093627 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ia73086dd8f57646d67b704f31d921597d821440f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530225Reviewed-by:
-
Yi Zhang authored
//chrome/browser/devtools/ This CL is the 2nd part of converting base::Bind to Once/Repeating in //chrome/browser/devtools/ Bug: 1007635 Change-Id: I1c9db10b9e93ac5f57e6da8c3714367e5da33709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525900Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#826108}
-
Peter Boström authored
Replaces GridLayout with BoxLayout. This will allow dynamically adding and removing fields. Between-child spacing and dialog margins are dynamically updated using kMarginsKey as fields are added. This is tested by resolving a TODO to use OnFieldAdded() repeatedly in AddInitialFields(), which also paves the way for dynamically adding fields. Bug: 1106422 Change-Id: I7111978cbb55546802e61709833ca6cfbe38a0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518777Reviewed-by:
Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#826107}
-
Takuto Ikuta authored
use_debug_fission=false doesn't split debug info. Change-Id: Ib8def944dfcea1345f41284e9d125c082071848c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526826Reviewed-by:
Minoru Chikamune <chikamune@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#826106}
-
Bartek Nowierski authored
Until now, the functionality of requesting pages that are committed and PageInaccessible existed only on Windows. |AllocPages(..., PageInaccessible, ..., true)| led to |VirtualAlloc(..., MEM_RESERVE|MEM_COMMIT, PAGE_NOACCESS)| which would allocate memory charges without really backing virtual address space with physical pages. https://docs.microsoft.com/en-us/windows/win32/api/memoryapi/nf-memoryapi-virtualalloc This is inconsistent with |base::SetSystemPagesAccess| where |PageInaccessible| always leads to |VirtualFree(..., MEM_DECOMMIT)| Outside of unit tests, |AllocPages(..., PageInaccessible, ..., true)| was used only in a couple places in code, likely accidentally. Change-Id: I657787b4785e889984c5895518e9abbc26b50a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522934Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#826105}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/434681c2378b..c80cb7a957ea 2020-11-11 johnchen@chromium.org [Telemetry] Update doc about running on Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: I8add9eedb7400bed89c5f2a09b6fb8b90286c872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531234Reviewed-by:
-
David Black authored
Moving forward, the logic of when the holding space tray is visible will be updated such that we need to handle the case where the tray is shown but no previews are available. Bug: 1142572 Change-Id: Ifae93a7506f3b8a6ce26d3210b9804b2ebf33d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531061Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#826103}
-
Hajime Hoshi authored
It is fine to ignore the presence of WebGL usage when putting a page to BFcache. Memory consumption is the only concern, but the memory eviction (context lost) should work in the same way as regular background pages. Bug: 1146922 Change-Id: I06e041aab8aaf235a6f6115a31f5bf325d8bfae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525469Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#826102}
-
Zhenyao Mo authored
for DirectCompositionForceFullDamage This is because if we check finch first, then a user is assigned to a finch group, say, Enabled, but they could end up not getting this optimization if their device doesn't support BGRA overlays. If we check cap first, we make sure every user in the finch groups have BGRA overlays. (I just learned this yesterday.) BUG=1117185 TEST=bots R=sunnyps@chromium.org Change-Id: I366518548f28bac3c744f50ef94f95f553809cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530177 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#826101}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit crbug.com/1147680. Reason for revert: <INSERT REASONING HERE> Original change's description: > LaCrOS: Replace defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) > > The change is mostly mechanical replacing defined(OS_CHROMEOS) with > BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash > with some special cases (For those cases please refer to > http://go/lacros-macros). > > The patch is made in preparation to switching lacros build from > target_os=linux to target_os=chromeos. This will prevent lacros from > changing behaviour after the switch. > > Bug: 1052397 > Change-Id: I95c93df05b77c03b3686d7bd9430dfde74229761 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461547 > Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Albert J. Wong <ajwong@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825716} TBR=ajwong@chromium.org,wez@chromium.org,thakis@chromium.org,hidehiko@chromium.org,ythjkt@chromium.org Change-Id: I73ddc678f970b05f1805fc728f6ceb6169cc2c71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052397, 1147680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530958Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#826100}
-
Yuichiro Hanada authored
It's used only by arc::ArcSessionManager. Change-Id: I2bc0844ed29c12571f21cd8bc67e3ac81e3bd62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531153Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#826099}
-
David Roger authored
Bug: 1076880, 1147433 Change-Id: I3cb974e6ebde1cd0c37a9e462092dd5d6f4ef313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523185 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#826098}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dbcdc10..82f6a0e5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie278b7b1edfa19de7a20f0929694c2cddab1b773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531173Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#826097}
-
