- 15 Oct, 2019 40 commits
-
-
Ken Rockot authored
This removes the generalized GetMany API from LevelDBDatabaseImpl, which was only used by session storage to fetch specific metadata fields. The database logic has been migrated fully into SessionStorageContextMojo. Bug: 1000959 Change-Id: Ie972684a5ccedfc879997540ea2b3d4ac6698dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859587Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#706180}
-
James Hollyer authored
We are eliminating base::Bind in favor of base::BindOnce and base::BindRepeating in order to be more explicit. Bug: 1007811 Change-Id: I755a3b27dcfba2313a8c8f6c23b53a41525886d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863749Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706179}
-
Christopher Grant authored
BUG: None Change-Id: Ie3724fdc25171b5b5ce0fc1190498dbcaf2238fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863355Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#706178}
-
Hazem Ashmawy authored
Build boundary interfaces as a jar using java-library plugin instead of "com.android.library" plugin. This makes it simpler and easier to embed the compiled jar in webkit AAR file without any dirty workarounds like unzipping the AAR or accessing intermediates build files. Removing AndroidManifest.xml file since it's no longer needed by android library plugin. Bug: https://issuetracker.google.com/issues/142394338 Bug: https://issuetracker.google.com/issues/140178227 Test: manually cherry-pick change to //external and run gradlew :webkit:assembleRelease and gradlew :webview-support-interfaces:assembleRelease Change-Id: I1df2f04bb737c1f376d7d1a70c6c5d0664e2f39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859990Reviewed-by:
Aurimas Liutikas <aurimas@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#706177}
-
Thomas Tellier authored
see https://bugs.chromium.org/p/chromium/issues/detail?id=994492#c12 Bug: 994492 Change-Id: Icd4c1fa6ed5225092a5ca29eba2da07107e3876d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823876Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#706176}
-
Daniel McArdle authored
Reduces complexity from O(n^2) to O(n). Prior to this commit, we were performing an O(n) vector::erase for each empty child, say O(n) of them. Now, we do an amortized constant vector::push_back for each child to keep, along with O(n) constant-time vector::swap operations. Bug: 1014388 Change-Id: I4e614463c5ac207dd036876a54e65cca8ce0ed25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863154 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706175}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: Ic2b8ff888960bfe23a4a1193db9002bb486e9393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847395Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706174}
-
Rakib M. Hasan authored
This CL will remove the property decorator from a couple of fields in the TestFailure class, add named parameters to the DriverOutput constructor in test_failures_unittest.py and changed parameter names for baseline output back to expected_driver_output. Bug: chromium:1014196 Change-Id: I54353c2a6c19588b116a9f2ad86dc17df89f0f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863572 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#706173}
-
Thomas Tellier authored
Bug: 1002107 Change-Id: I51f7cb640b9e7438b407cbdcfa9afaf4e57c4d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862453Reviewed-by:
-
Zhongyi Shi authored
Change-Id: I6533f0abcdaf5667d3f7e0d2fb047dd1042e8163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861279 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706171}
-
Rahul Arakeri authored
The test fails because it tries to dereference a raw pointer which points to layer that was destroyed. The fix is to set the pointer to null and add checks in scrollbar_controller.cc Bug: 1002828, 987115 Change-Id: I46efc7e35ee62bb36020a42aafbd75998728017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854534 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706170}
-
meacer authored
This CL adds summaries and explanations for safety tips to the security tab of devtools. It assigns the precedence of warnings as SafeBrowsing > Safety Tips > Connection status. Bug: 1013374 Change-Id: I62524947a8c4588af78a430e0565e0969b8dc3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856680 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#706169}
-
Gary Kacmarcik authored
The new binaries don't work yet, so we need the installer to continue using the old binaries until we are ready to switch over. Change-Id: I776dcf8fcfe87cf12ac47ad1f48add85c58a178a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863732 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#706168}
-
Vladislav Kaznacheev authored
Bug: none Test: none Change-Id: Iee2fc67f7e9c25c3a8f745b0c316acdaf16b28ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859680 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#706167}
-
Owen Min authored
The pref is registered with profile prefs. Also change the enterprise_reporting::RegisterPrefs to enterprise_reporting::RegisterLocalStatePrefs. Bug: 1006899 Change-Id: I8334229e585f088f0a5da8bd8d0545c5c9078ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854467Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706166}
-
Mike Wiitala authored
Histogram to show distribution of Chrome OS users across wireless regulatory domains. Bug: chromium:950225 Test: Tested manually on DUT. Change-Id: I09718c854d435e2cffe5f8f2f2f79d56c48f3eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758401 Commit-Queue: Mike Wiitala <mwiitala@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#706165}
-
Adrian Taylor authored
Change-Id: I4e1c979b9980c458b7f0de5eee4beae93d1888a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848112 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706164}
-
Caroline Rising authored
Update an extension's position when it moves past the midway point between extensions. Bug: 1008538 Change-Id: I302bc0f4b50bb37999ce5c164a171ccd2eeeee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863509Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#706163}
-
Peter Kasting authored
I couldn't actually get this to trigger in practice; on trunk the button seems to snap between widths. That also seems like reasonable behavior and results in noticeably simpler code. Finally, when converting the result view to use layout managers, I couldn't find a way to produce an animation-based behavior anyway. Bug: none Change-Id: I4d2750b675de4bda8758eac2f530ee8b1467dd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854533 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706162}
-
Parastoo Geranmayeh authored
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest ::NestedSurfaceHitTestTest is flaky. TBR=kenrb@chromium.org Bug: 1014602 Change-Id: If7c69bcf4a50c8e7b2646ec8826ea0115018cca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862663 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706161}
-
Samuel Huang authored
Previously, class DevUiModuleProvider consists of static functions {ModuleInstalled(), InstallModule(), LoadModule} that are called directly. Unfortunately, these cannot be mocked for testing. This CL makes DevUiModuleProvider a singleton class that's accessed via GetInstance(). SetTestInstance() is added to allow a test to override DevUiModuleProvider functions, and inject a test instance that replaces the original singleton obtained from GetInstance(). Bug: 927131 TBR: yfriedman@chromium.org Change-Id: Ifee6899ebf67be17ad2ed15103b9c7b6d8e322a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863553Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706160}
-
Maksim Moskvitin authored
IMPLICIT_PASSPHRASE treated as a passphrase type, which requires user-provided passphrase for decryption. We support it because we still have some users with very old Nigori's. This CL doesn't introduce support for keystore migration, setting up or changing implicit passphrase. Bug: 922900 Change-Id: I3cb6e0119f141ab1bd4fce2cc1db7c70f2d2cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860415 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706159}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ccba5fc7b22..0fba1fdff325 git log 4ccba5fc7b22..0fba1fdff325 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org repo_util: use utf-8 output 2019-10-15 vapier@chromium.org paygen: import test modules from autotest Created with: gclient setdep -r src/third_party/chromite@0fba1fdff325 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0ce972d6ad9555a1bd088c4d62550315e5b23f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706158}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74cefac7. With Chromium commits locally applied on WPT: d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I4ca1df0c61151ee7b83864569dd3d340c0cf1945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863431Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706157}
-
Rob Schonberger authored
This can be tested and enabled in conjunction with other features and experiments for users in the future. Default behavior is completely unchanged, and unit test thoroughly tests new behavior. Bug: 1009290 Change-Id: I57076270b2272831376c9b5ee787d9eecfa8d28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861914Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706156}
-
Sammie Quon authored
It's possible to get to this state by scrolling a bit, then rotating a couple times. Not entirely reproducible (depends on num windows and how much scrolling and display size), but added a test case which repros 100% without this fix. Test: Added test Bug: 1013224 Change-Id: I15a4bcdcda83ccac4346727342108b0c295fd151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853130 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#706155}
-
Lei Zhang authored
Make it more obvious "rm -rf" is happening. Bug: 1009837 Change-Id: I3b39b4ecc7625ad38c93fac34be7fa233520fb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861502Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706154}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6841d25d45ac..af0aa0977370 git log 6841d25d45ac..af0aa0977370 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 88a7a882..1c1107d4 (705863:705985) 2019-10-15 danilchap@webrtc.org Replace RtpPacketizerH264::Fragment struct with rtc::ArrayView 2019-10-15 orphis@webrtc.org Update the header extensions capabilities with mid, rid and rrid 2019-10-15 srte@webrtc.org Cleanup: Propagating BitrateAllocationUpdate to RtpVideoSender Created with: gclient setdep -r src/third_party/webrtc@af0aa0977370 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1007894 Change-Id: Icb019d008ff5d03679698e4ff2a5a2a525d2af71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863113Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65c6e8ed..f18342d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6991932167a6330e6c53133351f78cccbc511c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863433Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706152}
-
Patti authored
Add a new flag HelpApp (--enable-features=HelpApp) for the new Chrome OS help app, disabled by default. If this flag is turned on, the old help app (called the Genius app) will not be shown in the launcher. BUG=1012578 Change-Id: I093bb905b856aeb9c8a4c629cd5909d53162ac90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855538Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706151}
-
Oystein Eftevaag authored
These were previously disabled for webview, but are flaky for non-webview android as well. TBR=crouleau@chromium.org NOTRY=true Bug: 1013618 Change-Id: Ia08c92b4563e93c63859c8d3ffc0001d3af1eebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863126Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706150}
-
Michael Ludwig authored
This does not actually change the current logic of what DrawQuads are drawn directly by skia_renderer or gl_renderer. It just makes it possible at the direct_renderer level for subclasses to have more flexibility in how they bypass RenderPasses. Bug: 1013735 Change-Id: I4a82155b57ce58a40ca68ccc2b05875e84d625e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860103Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#706149}
-
Vladislav Kaznacheev authored
When an app is being dragged from app list to shelf, a new shelf item is created and made hidden by setting its size to (0,0). It is supposed to stay at this size until the drag is complete. However, if a drag started very soon after some other shelf manipulation (e.g. drag leaving the shelf and re-entering quickly), it is possible for AnimateToIdealBounds to be called asynchronously. The hidden item's bounds will be animated to full size, resulting in a visible icon. This CL makes AnimateToIdealBounds ignore shelf items with (0,0) size. Bug: 985631 Test: manual Change-Id: Ieb23beb6ecf635ae60613f5f6217219f7963999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862507 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
-
Matt Reynolds authored
In an earlier CL, new metrics were added for navigator.getGamepads when called from a cross-origin subframe or an insecure context (WebFeature::kGetGamepadsFromCrossOriginSubFrame and WebFeature::kGetGamepadsFromInsecureContext). This CL enables UKM for the general case of calling navigator.getGamepads from any context (WebFeature::kGetGamepads). BUG=1014608 Change-Id: I276cc1fd23525e4e7ddeb1f3b7f5ea1f48fc387b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863354Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#706147}
-
Doug Arnett authored
For the preview types: LitePageServerPreviews, DeferAllScript, ResourceLoadingHints, and NoScript, this adds a 2nd Feature for each one that will be used to control whether the preview is enabled when a new EligibleForUserConsistentStudy Feature is enabled. This is meant to be used to allow a user-consistent experiment for a preview to be run without conflict with other preview experiments (notably CoinFlip ones) that are controlled by the Previews.gcl config. For example, when EligibleForUserConsistentStudy is enabled (targeting the that for the Default group of the Previews field trial), whether to allow LitePageServerPreviews on whether a new base::Feature's "LightPageServerPreviewsUserConsistentStudy" is enabled and then further whether the parameter "user_consistent_preview_enabled" is enabled or not. See also: https://docs.google.com/document/d/1Fj7KX_wKDIm3gwxaDMj_jhFDOJXzMJ6kYXWG-lDvLLw/edit?usp=sharing Bug: 1007523 Change-Id: Ia8c014566b2c0bda8d1488a482cf521f4dc7e362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823755Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#706146}
-
Kai Ninomiya authored
This reverts commit 9d6a01ba. Reason for revert: Breaking GPU tests on GPU FYI waterfall and on ANGLE's CQ. Bug: 1014659 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=fdoray@chromium.org,rkaplow@chromium.org Change-Id: I509cbe39c2d4f91859f5e8614d7d8f8d819d3a7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862858Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706145}
-
Oystein Eftevaag authored
TBR=croleau@chromium.org NOTRY=true Bug: 1014655 Change-Id: Ibf5e367a218502b2d46f8d4dac838355344c6f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862853 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
-
David Tseng authored
Bug: b:141606892 Change-Id: Ia67acf9d6218f5da33649561da4fed8a60298081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845234 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706143}
-
Istiaque Ahmed authored
Update ExtensionsClient to use that constant. Also, fix tests using channel overrides to use the more specific channel: canary instead of trunk. This is done by providing an override channel class called ScopedExtensionAPIEnabledInServiceWorkersChannel. Bug: None Change-Id: I890a738c66522d4541e24c61761b82aa1bff1ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841932Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
Fetch shared library file data from the implementation package to construct the correct asset path when using a Trichrome APK. Change-Id: Id7bd259e5be182d6b13828235636d41b812ffdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829867 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706141}
-
