GitLab

TBR=tony,yuzo
Review URL: http://codereview.chromium.org/6263013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72565 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562).

BUG=68682
TEST=compiles
TBR=thomasvl

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98

with the result of that corruption.

1. Now we mark any open entry as dirty, even if we are
supposed to delete the entry right away because if we
crash before that, we may end up clearing the dirty
flag of a dirty entry.

2. When we look for a parent of a given entry we now
double check that the entry is the one that we want (and
not just another entry with the same key).

3. If we have a loop on the hash collision list (result of
failing to do 1 and 2 above), we figure that out.

4. Now every time we open an entry from an LRU list we end
up using the same code path (with the proper handling of
dirty entries).

BUG=69135
TEST=net_unittests

Review URL: http://codereview.chromium.org/6292011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72563 0039d316-1c4b-4281-b951-d872f2087c98

- Move code included from blah_unittest.h (where blah_unittest.cc has actual
  unittests) into their own files, often completely out-of-lining the
  definitions.
- Remove anonymous namespaces from headers.
- Reorder method declarations.
- Make other unit test link against net_test_support instead of reaching in and
  including .h files in their targets directly.

BUG=68682
TEST=compiles

Review URL: http://codereview.chromium.org/6264013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98

In the past, the sync integration tests used to require a password file
stored on every test device in order to do a gaia sign in using
production gaia servers. This caused the tests to be brittle.

As of today, the sync integration tests no longer rely on a password
file, with gaia sign in being stubbed out locally.

This patch reconfigures the tests on autotest, so that it no longer
looks for a local password file.

In addition, the tests run much faster now, and therefore, we reduce the
max timeout to a more reasonable 2 minutes (in the extreme case).

BUG=chromium-os:11294, chromium-os:9262
TEST=sync_integration_tests

Review URL: http://codereview.chromium.org/6387004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72561 0039d316-1c4b-4281-b951-d872f2087c98

For M10, we don't want folks to turn on NaCl persistently because its API
surface hasn't been vetted as thoroughly as we would like.

Review URL: http://codereview.chromium.org/6299017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72560 0039d316-1c4b-4281-b951-d872f2087c98

Fix uses of bare 'string' to be 'std::string'.

BUG=55816
TEST=None

Review URL: http://codereview.chromium.org/6304021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72559 0039d316-1c4b-4281-b951-d872f2087c98

When plugins are not properly written they don't supply any
identificatrion info through their api which used to kill the plugin
loading code.

BUG=70775
TEST=test_shell_tests-PluginListTest.BadPluginDescription

Review URL: http://codereview.chromium.org/6324014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72557 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68672
TEST=manual; ask me for details.
Review URL: http://codereview.chromium.org/6368018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72556 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=70810
Review URL: http://codereview.chromium.org/6260020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72555 0039d316-1c4b-4281-b951-d872f2087c98

TBE=lzhang
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72554 0039d316-1c4b-4281-b951-d872f2087c98

it to use delay-loading.

TBR=nsylvain
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72553 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=70829

Review URL: http://codereview.chromium.org/6250028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=58853
TEST=none

Review URL: http://codereview.chromium.org/6395002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72550 0039d316-1c4b-4281-b951-d872f2087c98

contains something.

BUG=64997
TEST=none

Review URL: http://codereview.chromium.org/6264011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72549 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70782
TBR=ahendrickson

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72548 0039d316-1c4b-4281-b951-d872f2087c98

- focus search field by default.
- don't show search results page until user starts typing.
- focus search field on forward slash if not focused on a control.

BUG=69154,69722
TEST=Verify focusing behavior per above.
Review URL: http://codereview.chromium.org/6360016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72547 0039d316-1c4b-4281-b951-d872f2087c98

Position new windows correctly if a dock icon is shown but not
highlighted.
BUG=70409
TEST=Drag a tab to the edge of the screen so that a dock
appears. Release the tab outside the dock area. Check that the tab
(not the windows top-left corner) is under the cursor.

Review URL: http://codereview.chromium.org/6356010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72546 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6368017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70826
TBR=sergeyu

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72544 0039d316-1c4b-4281-b951-d872f2087c98

Capturer should be owned by ScreenRecoder. This patch also addes test to test
reconnection of ChromotingHost.

BUG=69969
TEST=ChromotingHostTest.*

Review URL: http://codereview.chromium.org/6266010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72543 0039d316-1c4b-4281-b951-d872f2087c98

As a preparation for print preview workflow, refactored PrintPage() function.

Created the following functions:
1. RenderPage(): Renders the page for printing. Handles Alpha blend transparency.
2. CopyMetafileDataToSharedMem(): Copy the metafile data to shared memory.

BUG=none
TEST=printing works after code changes.

Review URL: http://codereview.chromium.org/6321017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72542 0039d316-1c4b-4281-b951-d872f2087c98

* Add proper dialog classes for some CrOS overlays.
* Add proper dialog classes for a few overlays that were left behind last time.

BUG=70882
TEST=none

Review URL: http://codereview.chromium.org/6260019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72541 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/6283013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72540 0039d316-1c4b-4281-b951-d872f2087c98

I add full-screen/presentation mode detection for all 3 platforms. I also
add screensaver detection for MacOSX and Linux since it is missing in these
2 platforms.

BUG=25061
TEST=Manual test

Review URL: http://codereview.chromium.org/6359008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72539 0039d316-1c4b-4281-b951-d872f2087c98

In order for the shared memory to work, they must all use the same file name
which is keyed by the pid of the browser process. Previously the mac code path
was using the pid for each process so there was no sharing happening. Now mac
uses the same code path as win which properly uses the parent pid for all procs.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6364006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72538 0039d316-1c4b-4281-b951-d872f2087c98

doesn't poison rest of the browser tests.

BUG=20809
TEST=All DownloadTest.* browser tests pass except for 20809 specific one (windows)

Review URL: http://codereview.chromium.org/6283010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72537 0039d316-1c4b-4281-b951-d872f2087c98

  * Refactor the first-read logic for the in-mem server.
    Split out functions from the initial connection setup on first read.
  * Fixed the SPDY-only (non-NPN negotiated) case.
  * Hardened the server against invalid protocol attacks; would happily
    crash when an invalid-looking frame arrived.

BUG=none
TEST=self

Review URL: http://codereview.chromium.org/6262014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64779
TEST=None.

Review URL: http://codereview.chromium.org/6294015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72535 0039d316-1c4b-4281-b951-d872f2087c98

TEST=nacl_sandbox_test
BUG=64973
Review URL: http://codereview.chromium.org/6379004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=builds everywhere

Review URL: http://codereview.chromium.org/6388004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72533 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70810
TEST=see bug
Review URL: http://codereview.chromium.org/6350014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72532 0039d316-1c4b-4281-b951-d872f2087c98

the button).

BUG=chromium-os:11195
TEST=none

Review URL: http://codereview.chromium.org/6389003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72531 0039d316-1c4b-4281-b951-d872f2087c98

the html view has a different GdkWindow from the frame_container_, hence the border does not get drawn in the extreme corners in OnRoudnedWindowExpose.

BUG=70489
TEST=manual

Review URL: http://codereview.chromium.org/6384010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64211
TEST=none
Review URL: http://codereview.chromium.org/6338016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6335012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72527 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66114
TEST=Manual layout verification of Under the Hood panel.
Review URL: http://codereview.chromium.org/6342020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72526 0039d316-1c4b-4281-b951-d872f2087c98

BUG=70782
TBR=ahendrickson

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72525 0039d316-1c4b-4281-b951-d872f2087c98

When swapping render widget hosts the previous host instance is destroyed after the new host instance is created. This causes an issue because the ViewProp destructor used for saving the host's HWND for accessibility clears the new host's ViewProp since the key (the parent tab contents view host) is identical. Updating the code to explicitly clear the accessibility ViewProp inside Hide() and set it inside Show().

BUG=70657
TEST=Manual. Inspect32.

Review URL: http://codereview.chromium.org/6271019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72524 0039d316-1c4b-4281-b951-d872f2087c98

Propagate correct data to the Toolbar servers

BUG=67219
TEST=unit-tested
Review URL: http://codereview.chromium.org/6332012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72523 0039d316-1c4b-4281-b951-d872f2087c98