- 18 Aug, 2020 40 commits
-
-
Dirk Pranke authored
This adds an optional --isolated=outdir=PATH flag to the test executable API; this gives the test runners a stable path to the output directory from a swarming task, so that we can key other files off of it without needing to pass them all explicitly via the command line. This also adds the arg to the isolated_script wrapper, so that we those types of tests can handle the flag (by ignoring it for now). We may need to work through the other cases (like gtest tests) individually, which will be done in subsequent CLs. Bug: 816629 Change-Id: Ibff6a47544bf94af5d7693a8446dfb669351cc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358604 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799378}
-
Christian Biesinger authored
This exposed a bug where we don't correctly compute the cross size in a column flexbox with aspect-ratio. R=ikilpatrick@chromium.org Bug: 1045668,1117279 Change-Id: Ic823ed349e2caf061834e116d5958832745cd63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358827 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799377}
-
Peter Kotwicz authored
This CL renames IDS_SHOW to IDS_SHOW_CONTENT in components/component_strings.grd so that it no longer conflicts with components/browser_ui/strings/android/browser_ui_strings.grd I renamed the string as opposed to deleting the copy because the two strings are used for different purposes. IDS_SHOW in //components/component_strings.grd is used to toggle hiding and showing content IDS_SHOW in components/browser_ui/strings/android/browser_ui_strings.grd is used as text in button in a dialog. BUG=1093825 Change-Id: If77186cd7c52c3cdb0002b05d9c91628421a5ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358770 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#799376}
-
Jonah Ryan-Davis authored
We should enable webgl testing on these bots: Optional CQ - Intel and AMD ANGLE CQ - Intel and AMD FYI - Intel, AMD, NVIDIA and ASAN Bug: angleproject:4846 Change-Id: I6368808a15afcd4588676892cb8bf47c0da6b085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302930 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799375}
-
David Black authored
Previously, a notification for a firing timer in v2 would have a "CANCEL" button. This is being relabeled to "STOP". Previously, a notification for a firing timer in v2 would only popup to the user if it hadn't already been marked as read. It would be marked as read if the user interacted with it. Now, we will cause the notification to be "renotified" to the user when the timer is firing. Bug: b:165306385, b:165306366 Change-Id: Ieaace3594fc5294abbd76a892f4df35d85c618ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363449 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799374}
-
Becca Hughes authored
Makes sure we don't load non-JS module code as modules and also updates the NTP so it can embed chrome-untrusted://kaleidoscope. Change-Id: I8027daec3a31bdc42d22fb40c1d733b7f3dd6cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360475 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#799373}
-
Ahmed Mehfooz authored
Bug: 1106012 Change-Id: I58d4ec83d6367dd62d94c326f48118e81b1ddc94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355830Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799372}
-
Kushagra Sinha authored
Extend expiry of: - OAuth2Login.PreMergeVerification - OAuth2Login.PostMergeVerification histograms till M88. Bug: 1089119 Change-Id: Ied8791647017ce19cba738ea57c269a97a756d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362787Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#799371}
-
John Delaney authored
What: Defer creation/opening of the sql database until there is a storage operation which needs it. Why: We unconditionally create the database for every storage partition whether the API is being used which is unnecessary. This has the added benefit of not forcing the database to be initialized in every browsertest once the feature is enabled by default. How: Use the presence of the database file as a signal for creation. If the file path doesn't exist, we can defer creation until an impression is stored. No other operations need to create the database as it is empty and would be a no-op regardless. If the database path does exist, we defer opening the database until any operation is called, as there may be conversions that need to be sent or impression to convert etc. Change-Id: I25446805a991f04fcbf9aa237195950d055558aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360471 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#799370}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I1fdbb29361cc3d76d4b61a841ad107e906fb7a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5012a13f63ac..c24096ed3b5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1085419,chromium:1111893,chromium:912681 Tbr: tommycli@google.com,csharp@google.com Change-Id: I0fbaa31b1b0ba48c74a725b0231c381410233a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799368}
-
Robert Ma authored
Also re-organize the structure of the doc to make it a bit more logical. Bug: 1094512 Change-Id: I230de88902da3d4162af5f10332f7262a8465fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363303 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799367}
-
Sinan Sahin authored
Relands crrev.com/c/2246834 apart from the field trial testing entry and adds the command-line flag to more tests in test_suites.pyl. Benchmarks in tools/perf/benchmarks are run on offline devices, and this causes the offline indicator to show, affecting the stories being run. Showing the offline indicator isn't realistic when the test is simulating navigating webpages that would normally require the device to be online. Also, showing the offline indicator might cause flakiness in the results or dilute real regressions. We've investigated the reported regressions and confirmed that they're WAI when the indicator is showing. This CL adds a command-line switch to prevent the offline indicator from showing and adds the switch to related benchmarks. Bug: 1091491 Change-Id: I60a573a527b041ef986a7cddaf5d4705629fc8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358509 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799366}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I31fea9098e29e0c0bc700a4ab646c402e55bf003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357621Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799365}
-
Peter Boström authored
This prevents dialogs from being instantly accepted on Mac if holding VKEY_RETURN as the dialog pops up. Specifically it addresses a security issue where people can be tricked into holding enter while the site pops up a folder-selector dialog. The attack worked as following. The attacker tricks the victim into holding VKEY_RETURN. While the key is being held, the attacker triggers folder upload, which the OS auto-accepts by holding VKEY_RETURN. Before this change, FolderUploadConfirmationView would trigger on Mac with this VKEY_RETURN. With this change, the victim at least has to re-press VKEY_RETURN, which they are presumably at least more likely to notice. This also adds initialization of the EF_IS_REPEAT flag on Mac from [NSEvent isARepeat]. Hopefully that doesn't have wider negative consequences where ui::Event and NSEvent disagrees on the definition of a repeat event. Bug: 1097724 Change-Id: I3bb0589867cbfa059a2406e73ef43e66b5326fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357520Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#799364}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c2650ad..df143e8b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I573a2c4de279a1db4890d6bd9050a7cec8f2804b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363189Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799363}
-
Alex Gough authored
Following https://phabricator.services.mozilla.com/D54699 we do not need to supply the handle for the shared memory IPC mechanism to the child until the IPC server has been initialized. Bug: 1092010 Change-Id: Id82f88513b77db159adf96dbac577ed80de1d37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337394 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799362}
-
Ankit Kumar 🌪️ authored
Migrate all instances of pp::Point to gfx::Point/gfx::Vector2d at PDFEngine interface. The internals still have pp::Point dependency but the interface is now independent of pp::Point. The internal dependency will be migrated in a subsequent CL. Bug: 1101101 Change-Id: Ib8a729314ec6101183281235d35afc697a243b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326512Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799361} -
Wei Lee authored
Since we are about to migrate CCA to SWA, we should avoid using chrome.* API so that we can have it work on SWA as well. Therefore, replacing chrome.system.display API by our own mojo API. Bug: 1114967, 980846 Test: Launch CCA without showing error messages Change-Id: I89aaf3f2700adfade8dd8eae32554ac095bb0ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354109Reviewed-by:
Shik Chen <shik@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Kuo Jen Wei <inker@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799360}
-
Yuke Liao authored
This CL moves interactive_ui_tests out of experimental state so that it's sherrifed to prevent regressions. Bug: 1111979 Change-Id: Icb1f00acb09939b01b2946256bcf334611fba3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363024Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799359}
-
Olesia Marukhno authored
Bug: 1117550 Change-Id: I7ac6b9323174fa91f33471b7aa9202d2cec0de21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362792Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799358}
-
Dominic Mazzoni authored
Enabling Switch Access can only be done from a user profile. However, once it's enabled, it needs to be possible for a switch access user to reboot or sign out and still control their device. So, every time a switch access pref is changed in a signed-in user profile, sync that same pref value to the signin profile. That way the next time the user is on the signin screen, switch access continues to work with their same settings. If someone else wants to use the machine and doesn't want switch access enabled, they can turn it off in the quick settings. Bug: 1108808 Change-Id: I136abcddc59f76d7b6ba9c55e2b4cb0607c4ab36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361662 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#799357}
-
Sky Malice authored
TBR: timvolodine@chromium.org Bug: 1117683 Change-Id: Ibb9538fc0530dd48effa973af8628565af639b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363486Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799356}
-
Shakti Sahu authored
This CL is a precursor to moving ThinWebView to components. Only dependency on chrome layer was TabHelpers which was moved to a ThinWebViewInitializer interface. Bug: 1116770 Change-Id: I24fdd93e35ae24d9bede953e32c68b0fd7024ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358993 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#799355}
-
Lukasz Anforowicz authored
After r797542 (which removed SiteInstanceImpl::GetRequestInitiatorSiteLock) we always use an exact origin (never an approximate site) as |request_initiator_site_lock|. Because of that, this CL renames ..._site_lock to ..._origin_lock. Bug: 918967 Tbr: mmenke@chromium.org (//chrome/renderer/net) Tbr: dbertoni@chromium.org (//extensions/browser) Tbr: chromium-metrics-reviews@google.com (histograms.xml) Change-Id: Ifbe801eafccd641d11cb14ecef83ab097d01eb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274251Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#799354}
-
Eric Orth authored
Bug: 1093361 Change-Id: Ic580fd7351b0d397a65b8ff882eee58156e287d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342389Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#799353}
-
Caleb Raitto authored
Bug: 973801 Change-Id: Ibe6dcee62b3fcbae9ad6dddcb200cf1df81bd077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350360Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#799352}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1fdcaafe. With Chromium commits locally applied on WPT: 1e2e0f67 "Revert "webrtc: add wpt test that setCodecPreferences changes the sdp"" fc224cf2 "Origin isolation: rename the getter (but leave an alias)" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/x-frame-options NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Ieb3516ec564f13f2672622d8416f9678e1dd86b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363588Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799351}
-
Abigail Klein authored
Ensure that the disconnect handler which calls the caption host is bound to the same thread. This fixes a data race bug found by Clusterfuzz. Bug: 1055150, 1116338 Change-Id: Idfaab83da0b918181bb1296c5e753a06bad388cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359405Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#799350}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a5a97b4858fb..59a3c3be94f0 2020-08-18 fmalita@chromium.org SFML [1] backed for SkAudioPlayer/Linux 2020-08-18 brianosman@google.com Tweak viewer's shader panel 2020-08-18 johnstiles@google.com Add support for more basic types in SkSLCPPCodeGenerator. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: Ia68d518ad570adc4513f752b140ab86ac0a1b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363180 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Christian Biesinger authored
Some tests are already passing in legacy; remove expectation lines for them. R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I99284a4794e2f547f38ba4fb366a25506a926b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360501 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Renjie Tang authored
In QUIC with TLS, when 0-RTT keys are available and the session doesn't require confirmation, run crypto callback to notify QuicStreamFactory that the session can be activated. Bug: 1117331 Change-Id: I9863bf2cc03250393f67af2420313dfbf585ffad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363629Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799347}
-
James Cook authored
Also move it into namespace crosapi. This is more consistent with our current naming conventions. Bug: none Test: compiles Change-Id: I1859bb7f3afde20aca7cf9dd516d06fd62118883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362732Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#799346}
-
Xiaodan Zhu authored
Bug: 1010200 Change-Id: Ie3d552b6108c491e12510fb32f544a0d0f938453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353548Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#799345}
-
David Maunder authored
Previously operations were run concurrently which may lead to incorrect results. For example, a delete may follow a save on the queue, but the delete may finish executing first which makes it ineffectual. Bug: 1116506 Change-Id: Ia6136f8fbc9775c89fd1427aa736cdd6d972c662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356830Reviewed-by:
-
Yuke Liao authored
This CL runs interactive_ui_tests on linux-lacros-rel to prevent regressions. Bug: 1116180 Change-Id: I037ef2132bd6cb2cbd741c08c53fd13b5814746d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363367Reviewed-by:
-
mark a. foltz authored
This fixes a potential UAF in PresentationConnectionCallbacks::OnSuccess. Bug: 1116706 Change-Id: I25fc55edf968f41bfedecbeb2054a5eae56d0de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361025Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799342}
-
ssid authored
Change-Id: Id7450cd05f2e9263e4573a89290519a5649c4f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361538 Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#799341}
-
Mike Wasserman authored
Add origin_trial_feature_name to runtime_enabled_features.json5 entry. Pass execution contexts for RuntimeEnabledFeatures checks. Remove superfluous Screen DCHECKS: - Screen IDL properties are RuntimeEnabled - |display_| is only set non-null by runtime-enabled getScreens API - The context for the DCHECK is not plumbed to Screen by that API Add Screen interface implementation TODOs to use a dictionary instead. Skip property tests for proposed window.screen properties: - Filed crbug.com/1117660 for unexpected test breakage - TODO(crbug.com/1116528) comments explain this will be moot Add basic API entrypoint test. Related tests already exist in: third_party/blink/web_tests/external/wpt/screen_enumeration/ third_party/blink/web_tests/external/wpt/fullscreen/api/element-request-fullscreen-options.tentative.html third_party/blink/web_tests/webexposed/global-interface-listing* Bug: 897300 Change-Id: I3083f8f53736027358ef2146cec60186adb8eeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357632 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799340}
-
Tommy Li authored
This reverts commit 1b2b4828. Reason for revert: I think this is causing ongoing flakiness: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel?limit=200 OobeInteractiveUITest.SimpleEndToEnd https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyRgsSBUZsYWtlIjtjaHJvbWl1bUBicm93c2VyX3Rlc3RzQE9vYmVJbnRlcmFjdGl2ZVVJVGVzdC5TaW1wbGVFbmRUb0VuZAw Original change's description: > Reland "Oobe: enable child specific signin feature" > > This is a reland of e771c29c > > Original change's description: > > Oobe: enable child specific signin feature > > > > Bug: 1101318 > > Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824 > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Commit-Queue: Yunke Zhou <yunkez@google.com> > > Cr-Commit-Position: refs/heads/master@{#798671} > > Bug: 1101318 > Change-Id: I73f8f871c4063b0b8f3718eeb974881728071ff5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360061 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Commit-Queue: Yunke Zhou <yunkez@google.com> > Cr-Commit-Position: refs/heads/master@{#799026} TBR=xiyuan@chromium.org,antrim@chromium.org,alemate@chromium.org,rsorokin@chromium.org,yunkez@google.com Change-Id: I54a2c5fac3fd9257c24d840da37a8718209fb373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363650Reviewed-by:
-
