GitLab

https://skia.googlesource.com/skia.git/+log/81454dfaa92a..c950e05bafcd

2020-06-18 mtklein@google.com clean up old idea about nullptr/sRGB
2020-06-18 adlai@google.com Consolidate GrDrawingManager <-> GrRenderTask lifecycle
2020-06-18 egdaniel@google.com Revert "Don't release vk memory allocator until context is deleted."
2020-06-18 mtklein@google.com runtime shader children on skvm backend
2020-06-18 egdaniel@google.com Don't release vk memory allocator until context is deleted.
2020-06-18 nigeltao@google.com Reland "Allow building with Wuffs v0.3, not just v0.2"
2020-06-18 bsalomon@google.com Merge ShaderMode and FilterLogic enums in GrTextureEffect
2020-06-18 johnstiles@google.com Fix stack-buffer overrun in appendVAList.
2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98d0f30c4393 to fa3d64bf72d6 (41 revisions)
2020-06-18 rmistry@google.com Change URL in skia_css3gradients_desktop.py
2020-06-18 bsalomon@google.com Make Clip test FP use texture effect child
2020-06-18 bsalomon@google.com Use child effects for LUTs in perline noise effects
2020-06-18 bsalomon@google.com Update generated file
2020-06-18 bsalomon@google.com GrRRectBlurEffect uses child for nine patch
2020-06-18 dmazzoni@chromium.org Get rid of deprecated API to add children to PDF tag nodes.
2020-06-18 egdaniel@google.com Fix perspective fragcoord value in d3d.
2020-06-18 brianosman@google.com Support sample() in ByteCodeGenerator (but not the interpreter)
2020-06-18 bsalomon@google.com Use child effect for integral in GrRectBlurEffect
2020-06-18 djsollen@google.com Manually update ANGLE DEPS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC djsollen@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1078330,chromium:1081806,chromium:1085996,chromium:1091259,chromium:1092743,chromium:1094634,chromium:607777
Tbr: djsollen@google.com
Test: Test: Test: Build/CQTest: Test: angle_end2end_testsTest: Test: angle_end2end_tests.exe --gtest_filter=ImageRespecificationTest*Test: Test: dEQP-GLES31.functional.image_load_store.*.format_reinterpret.*
Change-Id: I5aecf7ec290346781fa50d5ddd3817088aa62326
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252523Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779985}

https://android.googlesource.com/platform/external/perfetto.git/+log/9c7a8fbc5977..28c801fc37b8

2020-06-18 treehugger-gerrit@google.com Merge "Add an optional fake system tracing backend"
2020-06-18 chiur@google.com Merge "Move Specification to InternedData"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib781c457d05d63d74e7e1ba266912770c6e4e3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252521Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779984}

Bug: 1094350
Change-Id: Id0f2d6318e5f34d9278a766d5f5cde736b16abd9
AX-Relnotes: n/a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243259
Commit-Queue: Alexander Surkov <asurkov@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779983}

The ordering between the destruction of each WorkerTaskProvider and
the ProfileManager/g_browser_process instance is not guaranteed.
This means that it's necessary to check if the ProfileManager still
exists before unregistering from it, which preclude us from using
ScopedObserver.

This is a common pattern for other ProfileManager observers
instances.

Bug: 1094235
Change-Id: I35369d8938c95dcc6ef5204ea15b5f4dfa4d000e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248073
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779982}

Since this value is false on most platforms, only set the flag when true
to reduce the stored UMA log size
see https://chromium-review.googlesource.com/c/chromium/src/+/2245893
for changes to the OmniboxEvent.

BUG=1090911

Change-Id: I766fc8d0f07eb4ff237b137b51806373005267f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250558Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779981}

ScopedFeatureLists are supposed to be initialized in text fixture
constructors to avoid data races.

Bug: 1095832
Change-Id: Ifd4a290cd4cf49421df99c5c0338e0fa8633d2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250084
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779980}

Change-Id: I95c2de6a9924eabaf149cb982a3e3e756a022f2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238381
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779979}

In Child lock screen, set time to 24 hour clock format if the
child user turn on "Use 24-hour clock" in preference.

Bug: 945186
Change-Id: I760387e8e58041f23529c24641362eec5de6a9b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225864
Commit-Queue: Xiqi Ruan <xiqiruan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779978}

This reverts commit 03df4919.

Reason for reland: Found a way not to regress cc memory.

This time we keep partial layout invalidation on LayoutText and
LayoutInline only. In this way we still need to relayout everything
else (blocks and etc) but at least we can reuse the old shape result,
which should be still better than before.

Original change's description:
> Revert "Enable full testing of CSSReducedFontLoadingLayoutInvalidations"
>
> This reverts commit 5aba5002.
>
> Reason for revert: Causing crbug.com/1092431
>
> Let's stop messing up the perf bots while debugging.
>
> Original change's description:
> > Enable full testing of CSSReducedFontLoadingLayoutInvalidations
> >
> > This is preparation for enabling finch experiments of the feature on M85
> >
> > Note: though M85 hasn't reached Beta, we'd like to have it covered by
> > test bots first to catch any breakage. We'd also like it to be tested
> > by perf bots, since this "feature" is a performance optimization.
> >
> > Bug: 441925
> > Change-Id: I3ef98ffcfa960381efd034cd1cd63e55fbda4b01
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231269
> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#775847}
>
> TBR=asvitkine@chromium.org,chrishtr@chromium.org,xiaochengh@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 441925, 1092431
> Change-Id: Ife4aa822dda70d88249306b63e30d3d39df7a560
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242383
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#778044}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 441925, 1092431
Change-Id: Ib0986810a9c516f33a900dc91b91e2689f586f14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245373
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779977}

R=harringtond@chromium.org

Bug: 1060399
Change-Id: Iff4a8b59a3f7ac1ec79a8adb9d16877a3fbbcbae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252460Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Arthur Wang <wuwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779976}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I67be0e52108c7bbd69ab3fba06160c54c820a11c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252838Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779975}

This CL makes sure an OverConstrainedError is returned in getUserMedia
if constraints require PTZ and system does not support PTZ.

Bug: 934063
Change-Id: Ia17167bce8eac0d45f4c97d30edbebb032fa55d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247820Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#779974}

Move Print Preview specific PDF resources to a separate grd file from
other resources for Print Preview.

This is in preparation for adding an assert in unpack_pak.py to prevent
unpacking any files in a pak file that are not under the root
directory.

Change-Id: I8145621439e5814383a33e837c6503d0f040eb4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251100Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779973}

Bug: 1095770
Change-Id: I467bb9c72885ea3c3bbe8576a7b4e22817bc7be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252690Reviewed-by: benjamin joyce <bjoyce@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779972}

This reverts commit 73bff5e4.

Reason for revert: Missing compile targets for Mac Builder 

Original change's description:
> Reland "Promote Mac10.15 Tests to main waterfall"
> 
> This is a reland of f297bdfa
> 
> Mac Builder's mb_config was updated to use that of Mac Builder Next's
> so that nacl is disabled.
> 
> build761-m9 and build769-m9 now has their xcode paths properly configured
> 
> Original change's description:
> > Promote Mac10.15 Tests to main waterfall
> >
> > Remove Mac Builder Next, switch OS of Mac Builder to 10.15
> >
> > This CL copies what was done for Mac10.14:
> > https://chromium-review.googlesource.com/c/chromium/src/+/2036769
> >
> > Bug: 1066873
> > Change-Id: If227273be17c14547b16db1a68ff69f84fcc59eb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242162
> > Commit-Queue: Stephanie Kim <kimstephanie@google.com>
> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#779041}
> 
> Bug: 1066873
> Change-Id: I26810565b9d00eab37ac67708845f8fb311c8e77
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250825
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Commit-Queue: Stephanie Kim <kimstephanie@google.com>
> Cr-Commit-Position: refs/heads/master@{#779924}

TBR=gbeaty@chromium.org,kimstephanie@google.com

Change-Id: If8936ab72aa50bf8af5dda8cfba527737a1dcfe6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252845Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#779971}

Also roll the feature flags

https://quiche.googlesource.com/quiche.git/+log/c0dc4ceb325c..46d05bc682ff

$ git log c0dc4ceb3..46d05bc68 --date=short --no-merges --format='%ad %ae %s'
2020-06-17 dschinazi Do not send max ack delay when it has the default value
2020-06-17 dschinazi Deprecate quic_negotiate_ack_delay_time
2020-06-17 quiche-dev Demotes a WARNING log to VLOG(1).
2020-06-17 dschinazi Introduce QuicDisableVersion and QuicVersionIsEnabled
2020-06-17 zhongyi Add a method in QuicConnection to be called when the client successfully migrate itself after probing.
2020-06-17 haoyuewang Internal QUICHE change

Created with:
  roll-dep src/net/third_party/quiche/src

R=dschinazi@chromium.org

Change-Id: I638b47628092863e8bdbb6573eb08368dd4a7267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251307Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779970}

Manual reland:
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2029609
Revert: https://chromium-review.googlesource.com/c/chromium/src/+/2109970
Reset for revert: flaky DCHECK in AssertExpectedConcurrency
Fix: Avoid calling AssertExpectedConcurrency from ShouldYield.
https://chromium-review.googlesource.com/c/chromium/src/+/2112235

Original Description:
Note: This CL enables feature BlinkHeapConcurrentMarking to get
the desired behavior. However, we should land enabling
BlinkHeapConcurrentMarking on its own first.

active_markers + GlobalPoolSize() is used to determine
the desired number of workers.

NotifyConcurrencyIncrease() is called periodically from
ConcurrentMarkingStep() if GlobalPoolSize() > 0,
to make sure enough workers are scheduled.

Bug: 1046343
Change-Id: I4c36044686128b23fc25f45b99334c219a08cffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214908Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779969}

This CL does the following:
1- Adds 'cr-view-manager' to the profile picker.
2- Starts the implementation of the main profile picker screen.
3- Adds the 'Add Space' icon, which will be the entry point for the
profile creation flow.

Bug: 1063856
Change-Id: I626b3ecbc22129e0ad1478c2258812286efe5588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249781
Commit-Queue: Monica Basta <msalama@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779968}

Bug: 1007874
Change-Id: I501a90c677b05c87053a42920ed7eabdd9491752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230627
Commit-Queue: Danila Kuzmin <dkuzmin@google.com>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779967}

This method has a single user - it also essentially a pure function.
Fold it.

Bug: 634143
Change-Id: I2c0f9cdc615dcd19f8b1a58ea43cd61066bf9cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252078
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779966}

Add img width to settings/content style to properly scale banner

Bug: 1096441
Change-Id: Ia364223860c88f3aab1dbd273037fb6bba49a274
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252001Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779965}

This CL introduces the handling of showing in-session notifications
when update is required as per the policy but the device is
connected to a metered network or has reached end-of-life(EOL).

In case of metered network -
The notification is to be shown when the policy is received and on the
last day of the deadline. Clicking on the notification button starts
update process over metered connection.
For end-of-life devices -
The notification is to be shown when the policy is received, one week
before deadline and on the last day of the deadline. Clicking on the
notification button opens the enterprise/management info page which
would contain details about the end-of-life of the device.

This detail on the settings page will be implemented in subsequent CL.
New browser and unit tests are also included to verify this behavior.

Bug: 1048607
Change-Id: I4c09a00a50ff1673db1b15e4f05a4a29e825f043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245612
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779964}

The addition of a handleBar below the omnibox in the toolbar is
useful to indicate the user that the expanded tabstrip can be shown by
pulling the toolbar downwards.

Bug: 1094335
Change-Id: I03c7d8b95c81d11a90afbdf1bac9f3f6eeb9841a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249763
Commit-Queue: Roberto Moura <mouraroberto@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Roberto Moura <mouraroberto@google.com>
Cr-Commit-Position: refs/heads/master@{#779963}

Bug: 832274, 913173, 956736, 1042205
Change-Id: I2adeec04a28ad4c595ec63af181acf25c40b9ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250639Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779962}

No significant build speed changes.

Commits:
  https://github.com/google/turbine/compare/95f6fb6f1e962e8b6ec672905b0b04233f002dc2...1c98ea68543162a33c89c3629ed29c2c46391b7b

Ran:
  tools/android/build_speed/benchmark.py all_incremental && \
  git checkout update_turbine && \
  tools/android/build_speed/benchmark.py all_incremental

Results:
  Summary
  gn args: target_os="android" use_goma=true android_fast_local_dev=true
  gn gen: 6.5s
  chrome_java_nosig: 36.6s avg (36.5s, 36.7s)
  chrome_java_sig: 38.8s avg (38.9s, 38.8s)
  chrome_java_res: 23.1s avg (23.2s, 22.9s)
  base_java_nosig: 41.1s avg (41.1s, 41.0s)
  base_java_sig: 90.9s avg (90.8s, 91.0s)
  Switched to branch 'update_turbine'
  Summary
  gn args: target_os="android" use_goma=true android_fast_local_dev=true
  gn gen: 6.4s
  chrome_java_nosig: 36.5s avg (37.0s, 36.0s)
  chrome_java_sig: 37.8s avg (38.2s, 37.5s)
  chrome_java_res: 22.7s avg (22.9s, 22.4s)
  base_java_nosig: 41.3s avg (41.5s, 41.1s)
  base_java_sig: 91.2s avg (91.1s, 91.3s)

Bug: 1082904
Change-Id: I11d5efe60979a5e5a669366443914dc77da807e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248581
Auto-Submit: Peter Wen <wnwen@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779961}

Ensures OnSampleCompleted(...) is called even if stack unwinding
is failing.

It is common on windows that Unwinding fails when the LdrLock is
taken. This leads to missing trace events in slow-reports. Also,
the LdrLock sampling profiler is not called and the state of the
loader lock is not reported correctly.

Bug: 1093912
Change-Id: Ice050be1df20c3465be54e56de8c0cecd9134ea0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250789Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779960}

-Wl,-undefined,dynamic_lookup is deprecated on iOS Simulator, which
prevents us from linking libc++abi into the main executable and
exporting symbols for shared libraries to use. Instead, disallow
export_libcxxabi_from_executables on iOS, since it is effectively
unsupported.

BUG=1095852

Change-Id: I35204f9ccf668941f9e058aa05ab3caa9eaf376b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250218Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779959}

Roll Chrome Win64 PGO profile from chrome-win64-master-1592474334-e0477f022b6eb5a61c43375c0dcd8da0fde9e8a1.profdata to chrome-win64-master-1592495797-d903a1fb107ff5cf8693e66337654c7b30cfb050.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: I654f6ce73b481b14f5e00257bc7fb0910c599c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252519Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#779958}

BUG=1096196

Change-Id: I92bbcc8659b250500f711ff33ab210a370f42ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251203
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779957}

Change-Id: Icdf51cb147ca87f22e72d62422d2713d06c3e38d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248741
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779956}

The checks that are necessary to determine if a TabElement moved towards
the start or the end of the tab strip are the same for TabGroupElements,
so this CL prepares the animation for TabGroupElement by moving these
checks to the animation functions.

Bug: 1082344
Change-Id: I9bd9322948c40c61e9324d74c6c0dfba41ea9551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250950
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779955}

This CL is a refactor with no intended behavior change.

Change-Id: I0673487c7bc3a7f4f895c03cff16ef982c8e8cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252621
Auto-Submit: Erik Chen <erikchen@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779954}

We currently don't attach this tab helper on Android until portal
activation, but this can be attached as soon as the portal's web
contents are created and is, in fact, required for autofill to work
correctly after activation.

Bug: 1083277,894428
Change-Id: Iee35a2433c68fc54d7e4307255cbb7a32ad05683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242173
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779953}

Creating a ScopedObserver<TabStripModel, TabStripModelObserver> is
disallowed since TabStripModelObserver already implements the same
functionality. This was enforced using template specialization with an
empty class body, which gives a very unclear compile error.

Explicitly deleting the constructor gives an error message that can be
traced back to this specialization.

Change-Id: Iee001e45b4014a08c88d4c0bd962ebc3273a5aa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243716
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779952}

This reverts commit 65e3049c.

Reason for revert: The root cause was found server-side; this workaround is no longer needed.

Original change's description:
> [DeviceSync v2] Force enrollment after SyncMetadata 404 errors
> 
> This is a mitigation put in place to handle 404 errors returned by the
> CryptAuth server during SyncMetadata requests. A 404 error is returned
> when the server cannot find an enrolled device with the same Instance
> ID.
> 
> Theoretically, this should never occur assuming that 1) we never run a
> v2 DeviceSync until the device has successfully enrolled using v2
> Enrollment and 2) the Instance ID does not rotate. Without this
> mitigation, the user will unsuccessfully try to sync until the next
> enrollment, which could be up to 30 days.
> 
> This fix will be removed when the root cause is uncovered.
> 
> Bug: 1092113, b/155642672
> Change-Id: Ibc766ad21d83d1ace26c5e8c6c45f3eed835da74
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234126
> Reviewed-by: James Vecore <vecore@google.com>
> Commit-Queue: Josh Nohle <nohle@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776330}

TBR=nohle@chromium.org,vecore@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1092113, b/155642672
Change-Id: I94ac09ca75aba101a800176c644beec4f9ace710
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252622Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779951}

Up until now, it has been complex to accessing an Activity UI Surface
when you have a WebContents. This dependency acquisition has been a pain
point, in particular for the modularization effort.

This CL therefore creates a new UnownedUserData[Host] framework that
allows any UI surface to make itself available through a host that does
not own them. This allows the UI framework to still safely maintain the
ownership model it needs, without being worried about resurrection.

The UnownedUserDataHost stores the UnownedUserData objects using a
WeakRef, allowing the objects to be garbage collected.

The initial use-case for this is to allow objects to attach themselves
to WindowAndroid, since that is available through WebContents.

For usage patterns for this, see the class documentation for
UnownedUserDataHost and UnownedUserDataKey.

Guarantees provided by the framework:
- The UnownedUserDataKey is generically typed to a particular type of
  UnownedUserData.
- One UnownedUserDataKey can be used for multiple UnownedUserData
  instances.
- One UnownedUserDataKey can be attached to multiple UnownedUserDataHost
  instances.
- One UnownedUserDataKey can be attached to a particular
  UnownedUserDataHost only once.
  - This ensures a pair of UnownedUserDataHost and UnownedUserDataKey
    can only refer to a single UnownedUserData.
- When an UnownedUserData object is detached from a particular host
  it is informed of this, except if it has been garbage collected.
- When an UnownedUserData object is replaced with a different
  UnownedUserData using the same UnownedUserDataKey, the former is
  detached.

Bug: 1091584

Change-Id: I4ed5f7f9f86dc28426f85646017e964bf0b1d4e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189190
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779950}

- Updates relevant chromeos BUILD.gn files
- Add imports and exports to os_route, os_settings_route and
  os_settings.js
- Update bluetooth test files.

Bug: 1045266
Change-Id: I81e52893befe36b4757283428b7844b2de8fe514
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220218
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779949}

If the block-start edge of a float was above the fragmentainer boundary,
and its margin-block-start would take us past the boundary, we'd fail to
detect the need for a break. The bug was that MovePastBreakpoint()
expects a border edge block-start offset, but we were passing the margin
edge from the float code.

We also need to introduce an additional check before deferring to
MovePastBreakpoint(), because in our implementation, float margins are
unbreakable and also don't collapse with the fragmentainer boundaries
(which MovePastBreakpoint() assumes that we can).

Bug: 829028
Change-Id: If7336055df4e90b7cbf313e843d697f5e4c796a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250063Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779948}

This change removes innerHTML usage from chrome://interstitials in
order to be compatible with Trusted Types.

Bug: 41905
Change-Id: I52416bfcf487ef0aba21ccf76e58ae957f479acd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245937Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#779947}

Bug: 1096515
Change-Id: I753e4d934b6c92d24f7b4276fc5fa9b716b45ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252418
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779946}