GitLab

I believe there is no good reason to allow nullptr observer,
and the bug seems to be hitting this. This is to catch such bug early.

BUG=471649

Review URL: https://codereview.chromium.org/1059383003

Cr-Commit-Position: refs/heads/master@{#324299}

BUG=

Review URL: https://codereview.chromium.org/1060943002

Cr-Commit-Position: refs/heads/master@{#324298}

Instead of logging an error.

Split out from https://codereview.chromium.org/1052133002
TBR=jdduke@chromium.org,michaelbai@chromium.org

BUG=457406

Review URL: https://codereview.chromium.org/1068363002

Cr-Commit-Position: refs/heads/master@{#324297}

R=inferno@chromium.org
BUG=450268

Review URL: https://codereview.chromium.org/1076453003

Cr-Commit-Position: refs/heads/master@{#324296}

BUG=475172
TBR=orenb@chromium.org

Review URL: https://codereview.chromium.org/1064413004

Cr-Commit-Position: refs/heads/master@{#324295}

BUG=475106

Review URL: https://codereview.chromium.org/1065353002

Cr-Commit-Position: refs/heads/master@{#324294}

To disable battery updates, we disable updates from usb only. But N6 devices can also charge from ac (which they do).
This CL disables battery updates from ac as well.

BUG=474701

Review URL: https://codereview.chromium.org/1066253003

Cr-Commit-Position: refs/heads/master@{#324293}

The old session cache assumed session IDs were unique and called into BoringSSL
internals in the tests. Instead separate it into:

- The session cache proper which just implements the keyed map of SSL_SESSIONs
  with expiration checks and size limits. This can be unit tested without
  using OpenSSL internals.

- SSLClientSocketOpenSSL which hooks into SSL_CTX and SSL as appropriate and
  looks up or caches sessions.

Add additional tests in SSLClientSocket tests to ensure test coverage for the
latter.

Note: this removes the session removal logic via SSL_CTX_set_sess_remove_cb.
It was never called anyway (see https://crbug.com/466352). With that removed,
the SSL_SESSION* pointer-keyed map is unnecessary and the cache can just be
a base::MRUCache (which is what the original was based on anyway).

BUG=454044

Review URL: https://codereview.chromium.org/994263002

Cr-Commit-Position: refs/heads/master@{#324292}

Revert of Get gn_all/gyp_remaining working for Windows. (patchset #2 id:20001 of https://codereview.chromium.org/1064333002/)

Reason for revert:
Seems to have broken the Win x64 debug builder:

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)/builds/7600

Original issue's description:
> Get gn_all/gyp_remaining working for Windows.
>
> This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.
>
> A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.
>
> R=brettw@chromium.org
> BUG=354261
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c
> Cr-Commit-Position: refs/heads/master@{#324285}

TBR=brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=354261

Review URL: https://codereview.chromium.org/1071603005

Cr-Commit-Position: refs/heads/master@{#324291}

This patch changes the way the tiling set eviction iterators work. It mostly
restructures how each phase is processed in order to allow easier changes
in the future.

High level summary of changes:
- Create helper iterators that can process individual phases
- Preprocess the order in which tilings are processed
- Define explicit enums for combinations of phases, instead of an enum + flags

R=enne, danakj

Review URL: https://codereview.chromium.org/1038793002

Cr-Commit-Position: refs/heads/master@{#324290}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/40acdae..ef4962f

BUG=none

Review URL: https://codereview.chromium.org/1067373003

Cr-Commit-Position: refs/heads/master@{#324289}

The browser will drop GestureFlingCancel events when it believes the
renderer has no active fling animations. However, this filtering would
report the event as "consumed", inadverently triggering tap suppression
logic for the subsequent tap.

Instead, report "no consumer exists" for the filtered GestureFlingCancel
events, avoiding spurious tap suppression.

BUG=474882

Review URL: https://codereview.chromium.org/1074553002

Cr-Commit-Position: refs/heads/master@{#324288}

The availability warning for enums isn't really that helpful, since if an enum
is added somewhere, the availability warning will be on wherever it is used.

BUG=474980

Review URL: https://codereview.chromium.org/1070873002

Cr-Commit-Position: refs/heads/master@{#324287}

BUG=424436,467287

Committed: https://crrev.com/475949d9430b6a759ce759f2133dd3a1577d0d0b
Cr-Commit-Position: refs/heads/master@{#324089}

Committed: https://crrev.com/8caa594c291b6dd3e35d60a886ef33b36ae78e97
Cr-Commit-Position: refs/heads/master@{#324164}

Review URL: https://codereview.chromium.org/1068603002

Cr-Commit-Position: refs/heads/master@{#324286}

This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.

A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.

R=brettw@chromium.org
BUG=354261
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1064333002

Cr-Commit-Position: refs/heads/master@{#324285}

The start and end callback logs were from a long time ago when those were
new and not as stable. Get rid of them now.

BUG=none

Review URL: https://codereview.chromium.org/1062203002

Cr-Commit-Position: refs/heads/master@{#324284}

iOS builds now default to 64-bit (codereview.chromium.org/1021513002). Bump
default device to iPhone 5s, which supports 64-bit binaries.

BUG=None
TEST=iossim works without passing any device flags.

Review URL: https://codereview.chromium.org/1070753004

Cr-Commit-Position: refs/heads/master@{#324283}

This CL implements remoting.MessageBox, a helper class for
showing a modal dialog using remoting.setMode() and updates
the corresponding call sites to use it.

This enables us to show the Me2Me finish dialog from within
remoting.Me2MeActivity instead of the global event handlers. In
this way, we can move the reconnect after finish logic from
remoting.SessionConnector into remoting.Me2MeActivity in a future
CL.

BUG=474840
NOTRY=true
TESTS=All Remoting Webapp Unittests passes and all Chromoting integration test passes
https://chromium-swarm.appspot.com/user/task/26b396ab62998910

Review URL: https://codereview.chromium.org/1066283002

Cr-Commit-Position: refs/heads/master@{#324282}

GpuMemoryBuffer::Format::R_8 should be used to represent textures with
only one channel, the associated image should have GL_R8/GL_R8_EXT
as internal format.

With this CL the only implementation of GpuMemoryBuffer that supports
R_8 is GLImageMemory, it expects a 4 bytes row alignment (4 is the
default value for GL_PACK_ALIGNMENT).

BUG=

Review URL: https://codereview.chromium.org/1051503003

Cr-Commit-Position: refs/heads/master@{#324281}

BUG=none

Review URL: https://codereview.chromium.org/1062363002

Cr-Commit-Position: refs/heads/master@{#324280}

BUG=474674

Review URL: https://codereview.chromium.org/1072583002

Cr-Commit-Position: refs/heads/master@{#324279}

It's possible that DelegatedRendererLayerImpl decides to not append
a quad if it's not valid. In that case it could crash trying to
validate the non-existant quad.

R=piman@chromium.org
BUG=475099

Review URL: https://codereview.chromium.org/1072563002

Cr-Commit-Position: refs/heads/master@{#324278}

Update to final v1.4.0 release
https://codereview.chromium.org/1067873002

Remove webview conditional
https://codereview.chromium.org/1069353002

R=tomfinegan@chromium.org

Review URL: https://codereview.chromium.org/1068113002

Cr-Commit-Position: refs/heads/master@{#324277}

Currently the instantiation of ChildTraceMessageFilter in
child_thread_impl.cc is guarded by a check on
CommandLine.HasSwitch(kSingleProcess)
The rationale is that in single-process mode we don't want to have any
message filter as the browser-side tracing will cover all the threads.
However, the aforementioned check is not complete, as it does not
covers the case of tests using the InProcessUtilityThreadHelper [1].
In those tests, the kSingleProcess flag is not present, but the
renderer is in-process anyways.
Replacing the the HasSwitch check in with IsInBrowserProcess(),
which covers also the latter case.

[1] for instance extensions/browser/sandboxed_unpacker_unittest.cc

BUG=474973

Review URL: https://codereview.chromium.org/1069253003

Cr-Commit-Position: refs/heads/master@{#324276}

Right now, Gesture Navigation has two very distinct phases: the initial
one, where the web contents window receives events and is moved, and the
follow up navigation, where the page still hasn't loaded and the user
scrolls on the overlay. The meat of this patch is to unify as much of
the logic as possible without sacrificing features. A new class is
introduced, OverscrollWindowAnimation, and the responsibility of the
existing OverscrollNavigationOverlay is steered into performing the
actual navigation.

TEST=Overscroll*
BUG=467692,464532,420121

Review URL: https://codereview.chromium.org/895543005

Cr-Commit-Position: refs/heads/master@{#324275}

Fixes issues related to compiling chrome in component mode on Windows. This just does chrome, there are likely other issues for test targets. Getting Chrome to work will also require an ANGLE roll.

I converted two static_library -> source_set. These aren't necessary but I noticed the extra .libs were being created and these don't need real static libraries as far as I can tell.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1069533002

Cr-Commit-Position: refs/heads/master@{#324274}

Legacy Skia flag.

BUG=475022
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1071463004

Cr-Commit-Position: refs/heads/master@{#324273}

No intended behavior change.

BUG=none

Review URL: https://codereview.chromium.org/1071513003

Cr-Commit-Position: refs/heads/master@{#324272}

If a mouse event has been created from the same native event with the
same time stamp, it shouldn't be marked as repeated.

R=sadrul@chromium.org
BUG=474282
TEST=events_unittests --gtest_filter=EventTest.*

Review URL: https://codereview.chromium.org/1068463003

Cr-Commit-Position: refs/heads/master@{#324271}

Test the experiment Chrome-Proxy directive by verifying that
a specific test URL only triggers a bypass when the command
line flag "--data-reduction-proxy-experiment=test" is set.

BUG=452292

Review URL: https://codereview.chromium.org/1044573002

Cr-Commit-Position: refs/heads/master@{#324270}

per Hwi and Alex.

BUG=none

Review URL: https://codereview.chromium.org/1069583002

Cr-Commit-Position: refs/heads/master@{#324269}

BUG=475072
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/1066363003

Cr-Commit-Position: refs/heads/master@{#324268}

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1055173003

Cr-Commit-Position: refs/heads/master@{#324267}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e0eac24..80027f9

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1075473002

Cr-Commit-Position: refs/heads/master@{#324266}

In ES6, these properties of the intrinsic %FunctionPrototype% are poisoned during
CreateIntrinsics() / AddRestrictedFunctionProperties(). It's unnecessary to poison them
again, and testing whether they are a function or not causes tests to fail.

BUG=v8:3982
R=arv@chromium.org

Review URL: https://codereview.chromium.org/1067223002

Cr-Commit-Position: refs/heads/master@{#324265}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/05e4aba..b7133be

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1069343004

Cr-Commit-Position: refs/heads/master@{#324264}

We broke repeating the same key twice in a row in r324081. Cancelling
repeat must update the repeated key, so that we can tell that we need
to start a new repeat for that key in UpdateKeyRepeat if it's pressed
again.

TEST=Repeat the same key twice in a row on link
BUG=473446

Review URL: https://codereview.chromium.org/1074503002

Cr-Commit-Position: refs/heads/master@{#324263}

When logging errors (Log.e), if the last argument is an exception,
its trace will be logged, like what happens with android.util.Log.

If the exception is used as argument for the format string, its
toString will be used in the message, then the trace will also be
printed, provided that it's the last argument.

BUG=474599

Review URL: https://codereview.chromium.org/1069373002

Cr-Commit-Position: refs/heads/master@{#324262}

CertNetFetcher is a class for issuing and cancelling network fetches, that will be used by CertVerifier. It fetches http:// AIA and CRL URLs.

This initial implementation has some remaining TODOs around:
  - Add POST parameters
  - Add cache bypass controls
  - Add maximum requests thresholds
  - Add more tests for cancellation/de-duplication

BUG=455366
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/908863004

Cr-Commit-Position: refs/heads/master@{#324261}

endRecording() is deprecated.

Review URL: https://codereview.chromium.org/1066273002

Cr-Commit-Position: refs/heads/master@{#324260}