- 18 Jul, 2019 40 commits
-
-
Ken Rockot authored
This interface is no longer used. Bug: 977637 Change-Id: I69f7fe7aac89c2da60fdb3cf8844712de90e9455 Tbr: nasko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707815 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#678744}
-
Ben Pastene authored
Looks good on the fyi bot: (ignore the conformance test failures) https://luci-milo.appspot.com/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests Bug: 938502 Change-Id: Ifa886afb5c44134d14170fd5967e1ab7d9c89916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708753 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678743}
-
Mugdha Lakhani authored
Change-Id: Ib7dcecb3d5fa91c54ee2e73f9470b02f7511e3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708912 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#678742}
-
Xiaocheng Hu authored
CSSMathFunctionValue::ComputeLengthPx() should only be called on <length> that doesn not involve percentages. Besides, the recursive computation on CSSMathExpressionNode should be aware of the difference between lengths and numbers, and treat them differently. These are ensured in this patch. Bug: 979895 Change-Id: I7ca3c253f9ed12537f92bc4e6f497fc9272a04f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707395Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#678741}
-
Mugdha Lakhani authored
Add Periodic Background Sync Scheduling logic which does the following: 1. Schedule a background task to launch Chrome to process pending periodic Background Sync registrations. 2. Schedule a delayed task to process periodic Background Sync registrations. In follow-up Cls, I'll add logic to revive suspended registrations. =========== An assert was being hit in BackgroundTaskSchedulerUma::toUmaEnumValueFromTaskId() because we weren't handling the case of PERIODIC_BACKGROUND_SYNC_CHROME_WAKEUP_TASK_JOB_IDs. I've fixed this now and also run various additional trybots to try and capture tests that were failing before. In addition, Jonathan has verified that his local repro (which I sadly don't have) of the failing gpu tests are fixed with this patch. For the change since the last land, please compare Patchset 3 against 1. Bug: 925297, 984580, 984563 Change-Id: Ie5df1a0370797671217ffc4ed6884e10fb13789c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704754Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#678740}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/83cfe4fa24d9..c7dced5f68c6 git log 83cfe4fa24d9..c7dced5f68c6 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 bsalomon@google.com Revert "Remove simple GrGpu::createTexture helper" Created with: gclient setdep -r src/third_party/skia@c7dced5f68c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: I6942c31bd4f11810731a027f92d96c39d860ec5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708990Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678739}
-
Ben Pastene authored
Bug: 985390 Change-Id: I0247b8502df17b0a39dffe8c2547267080e40902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707819 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Min Chen authored
Bug: 972162 Change-Id: Ic1517794808a0276205c3d3f03072d3a14206712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707393 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#678737}
-
Victor Hugo Vianna Silva authored
No caller of CreateForMobile sets this field above 16px, which is the minimal value enforced by LargeIconService, so in fact all mobile UIs that download from the favicon server use this default value. Behavior is not changed for them. For desktop UIs, this CL decouples the minimum_size from desired_size, keeping the desired size of 16 DIP while decreasing the minimum size to 16px. We argue that this is beneficial for the UI because it improves availability of icons. If any desktop UI in the future needs to enforce the minimum size to display, it can do so when loading the icon from local cache. Bug: 982810 Change-Id: I1160316e93fd721cc977833aa9635d40971a2da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695366Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#678736}
-
Yue Ru Sun authored
Change-Id: I5a7d547d205fb4a659614699fc9913554aaa565e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708971Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Cr-Commit-Position: refs/heads/master@{#678735}
-
Xida Chen authored
This is a reland of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1707251 It was reverted because: 1. cc/test wasn't included in the DEPS 2. oop_pixeltest.cc has some specific rules All the failed cases can be seen here: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8907623652171456896/+/steps/checkdeps__with_patch_/0/stdout With this change, I ran buildtools/checkdeps/checkdeps.py and it succeed. Bug: None Change-Id: I61909d50d3c5b006c2c1cc5a862fe51d106ca75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708576Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678734}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rsesek@chromium.org Change-Id: Ia002715c01ed6fbd2e7973068a33f64a07cf7a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649548 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Arthur Wang authored
R=agable@google.com, iannucci@chromium.org, jbudorick@google.com, tikuta@chromium.org Bug: 981462 Change-Id: I8482c2b0363ef828dd8a4ed00b7128dd21692ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705027Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Arthur Wang <wuwang@google.com> Cr-Commit-Position: refs/heads/master@{#678732}
-
Maksym Onufriienko authored
Moved tab-grid matchers from chrome_test_util namespace and updated BUILD files. Bug: 922813 Change-Id: I451258e52171967a190b95674007599f8c9545ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702391Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#678731}
-
Aga Wronska authored
Achieving desired announcement for custom parent access code input was quite challenging. It required delaying switching focus to the next input field in order not to skip some vocalizations. Vocalization example: * 8, 1 of 6, Next number Bug: 974020 Test: ParentAccessViewTest + manually Change-Id: Iee11b26d47548208c3c6c26beb83a09f7fb59ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706523Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#678730}
-
Joe Mason authored
R=proberge@chromium.org Bug: 968228 Change-Id: I89467713d2ee14bd9aa801bb96ce197f9dfbacc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708834 Commit-Queue: Joe Mason <joenotcharles@google.com> Commit-Queue: proberge <proberge@chromium.org> Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#678729}
-
Yutaka Hirano authored
Fix tests and expectations for Error structured cloning Spec: https://github.com/whatwg/html/pull/4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: 970079 Change-Id: I5f3eb0c5f1a2aee11f1ec668bd9bfe1e0f6ace2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703530 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#678728}
-
Yutaka Hirano authored
Bug: 970079 Change-Id: Ib6bb73dbc7d921d29963c28c3bb0d48a62380227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702266 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#678727}
-
Eugene But authored
The issue is that the gesture needs to start offscreen, and EG cannot replicate that. Bug: 978877 Change-Id: I9bd86297404619c8542663bbd932e0516c1101bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681973 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#678726}
-
chrome://webapksckitagawa authored
If a WebAPK is installed using browser1 and chrome://webapks is opened in browser2, the storage won't be available in browser1 and a crash happens. It is difficult to automatically test this scenario and should have been caught by me when testing the feature. Bug: 985296 Change-Id: Ie5cd0f66a1b544ef0be90629592106b855876a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706588Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#678725}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/88466e32f3a2..41fbffc1eecd Created with: gclient setdep -r src-internal@41fbffc1eecd The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: Ieb47309a22a00c2ab84998cd9d9e59a115ef428a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708988Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678724}
-
Yuki Shiino authored
In order to be consistent to other filenames, renames idl_types.py to idl_type.py. Bug: 839389 Change-Id: I40bd60613d18d18c45f3d5705f869a00ec39b2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707150 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#678723}
-
Jacques Chen authored
-Add compress="true" flag for brotli compression in grd files -Reduces need for more refactoring when changing compression libraries in the future Bug: 826858 Change-Id: I154bd8bffb8af1282a43250a03eb73c34a1d58e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707863Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jacques Chen <jacqueschen@google.com> Cr-Commit-Position: refs/heads/master@{#678722}
-
Peng Huang authored
viz::SkiaOutpuSurfaceImpl::ctor() may fail for many reasones (creating GLSurface fails, GL error, etc). In this case, viz::SkiaOutpuSurfaceImpl::ctor() will crash. This CL changes behavior by adding a new method viz::SkiaOutpuSurfaceImp::Create() to allow returning a nullptr when some error happens. So OutputSurfaceProvider can handle the error, and then fallback to software compositing. Bug: 959708 Change-Id: I9eb459c89d9820b2184a3f02b650d59306a269b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704393Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#678721}
-
Yuki Shiino authored
IdlTypeFactory makes it possible to iterate over all the instances of IdlType. It enables us to collect all the union types for example. Bug: 839389 Change-Id: Ibc52f8227f9c985ed768b64452004fe716d4462d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708589Reviewed-by:
-
Nektarios Paisios authored
A blank line that is designated using a single node containing only white space should have its start at the beginning of that white space and its end right after the white space. If some white space is not on a blank line by itself but is used to separate lines, it should always be connected to the node that represents the previous line's text in the tree. In this case, a position at its start should be recognized to be equivalent to a position at the end of the previous line, and a position at its end should be recognized as being at the start of the next line. If a node containing only white space is connected to a text node that comes after it in the tree, it should be treated as being part of the next line. R=ethavar@microsoft.com, kschmi@microsoft.com Bug: 951777 Change-Id: Ic833775df8a606d458fd560f0e6d8b2717def42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704534Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#678719}
-
Nektarios Paisios authored
This is a reland of e77f2b4c AXImageAnnotator adds an automatically created label to unlabled images. During that process it marks affected images dirty by adding them to the vector of WebAXObjects that RenderAccessibilityImpl should later send updates for. However, in RenderAccessibilityImpl we were not checking if the layout tree for every dirty object is clean before sending an update for it. Original change's description: > Fixes the cause of the crash in the new accessibility selection code > > Before every call to an accessibility API on the renderer, we were not checking if the layout tree is clean, > but only if the LayoutView of the document object had a clean layout > which is not the same thing. > > Change-Id: If8852842aaf4da06bbb8e65ba495b18c46f82b6a > Bug: 982306 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601618 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676445} Bug: 982306 Change-Id: Ib12ce68f56f389749cd1c7fed27a789f9a0939e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706570 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Aaron Leventhal authored
Fixes crashes that occur when serializing views accessibility trees. Assuming that ignored nodes are invalid is problematic because it can cause the tree serializer logic skip processing of some nodes and subtrees, and lead to dangling pointers. This should fix not only the listed bug but other mysterious crashes with similar stacks. This was a regression from a change causing ignored nodes to be invalid, https://chromium-review.googlesource.com/c/chromium/src/+/1123654/ -- the project that required that change (go/mustash) has been cancelled and the code that used it was removed, which means that no dependencies on the original change will break. R=nektar,jamescook Bug: 981311 Change-Id: I8fbf3e0f28343f664a480593c65fb4b23748c67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707948Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678717}
-
Donn Denman authored
Implements RenderWidgetHostView.SetInsets for Android. This allows restriction of the Visual Viewport without changing the Layout Viewport. A need from the Autofill Assistant is driving this change. Also removes the deprecated WebContents#getBackgroundColor since it is available from RWHV now. BUG=968150, 974430 Change-Id: I0b9087f4aa41ae6c923468d440371541d1ea4a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659354Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#678716}
-
John Budorick authored
Bug: 731375 Change-Id: Iff8edb06b1585e078dced13ba9c6ca1e2ce28b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708756 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Jack Steinberg authored
Bug: 972945 Change-Id: I984556c1636aa55e65227d5f174331bf9aeece84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706453 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#678714}
-
Jinho Bang authored
According to the spec[1], addPath() should halt if one or more of the transform matrix's m11, m12, m21, m22, m41, or m42 are Infinity or NaN. [1] https://html.spec.whatwg.org/multipage/canvas.html#dom-path2d-addpath Bug: 984849, 985067 Change-Id: I748e8946da243093ac10f05401daf9acaa67ff83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708213Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#678713}
-
Robert Ogden authored
Bug: 977603 Change-Id: Id8ef770f5fea07093c3033a9e8ce1003aa4fd730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707131Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#678712}
-
Lan Wei authored
In LayerTreeHostImpl::ScrollEnd, we need to check whether the scroll happens on main thread or impl thread, and we only set scroll gesture end flag to be true when the scroll happens on impl thread, so that we only update hover once after the scroll finishes for both main thread and impl thread scrolling. Bug: 877132 Change-Id: Ib48a6a142d2af848de8c7942f2b50fc31a492623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688884Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#678711}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |NGInlineItem:: SetSegmentData(unsigned)| for improving code health. Note: |NGInlineItem::segment_data_| is populated by static member function |NGInlineItem::SetSegmentData(RunSegmenterRange&, Vector<NGInlineItem>*)|. Change-Id: If95927677eadf32264ef7838ea65ed252df8a7df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708294 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#678710}
-
Yoshifumi Inoue authored
This patch gets rid of unused parameter |force| from |LayoutText:: SetTextWithOffset()| for improving code health. Change-Id: Id947c5c8df1b2d13f0163e7ba08efe4417d2b825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708289 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Saman Sami authored
This CL reverts all the fuzziness added by https://crrev.com/c/1669260 and uses off-by-one comparator in LayerTreeHostLayerListPixelTest/ScaledMaskWithEffect. Bug: 985195 Change-Id: I60bd9f62dc808e0b218f0ab245aab1db209f045f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708035Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#678708}
-
Edvard Thörnros authored
There is an animation element called "discard element" which is not supported in Firefox and not really part of most peoples daily internet usage. Removing it would simplify the code about the SVG SMIL animations a lot and looks like a good idea seen from and engineering point of view. This use counter is to check if it's a good idea for the users as well. There are actually two different UseCounters added, one which checks for the existence of a "discard" element and one that checks for if they are actually triggered. So breakage should be between those two values. The only thing added in this commit is two UseCounter, nothing else should have changed. Bug: 984947 Change-Id: I779fd2c05c20ac6912d7d9adb1e1ea65ab900bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708928Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Commit-Queue: Edvard Thörnros <edvardt@opera.com> Auto-Submit: Edvard Thörnros <edvardt@opera.com> Cr-Commit-Position: refs/heads/master@{#678707}
-
Joe Mason authored
R=proberge@chromium.org Bug: 985377 Change-Id: Iaecda7fc6afecc5e9bdd49108ce23b12e792d617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708972 Auto-Submit: Joe Mason <joenotcharles@google.com> Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
-
Ken Rockot authored
This change covers a few useful improvements to ServiceProcessHost. First, there are no longer actual ServiceProcessHost object instances for users to retain. Instead, service process lifetime is tied strictly to the lifetime of the relevant service pipe. Either the service or the browser side can hang up to elicit service process teardown. Second, API surface has been added to allow callers to enumerate currently running service processes as well as observe service process lifecycle events globally. ServiceProcessHost tests are updated to cover the new usage, as well as to demonstrate recommended usage in conjunction with new Mojo Remote idle timeout behavior for managing service process lifetime. Finally, additional documentation and clarification has been added to ServiceProcessHost's header. This is part of the ongoing effort to simplify Chrome services: https://docs.google.com/document/d/1M0-K0gi1xXO0f_-YKSH2LFVh4RJY-xe9T9VaGFOSXb0/edit Bug: 977637 Change-Id: If789159df0fcebae5161323a2a323481005c9516 Tbr: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703095 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
