- 19 Dec, 2020 19 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/814edbd0a53f..992341827b73 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I381dabfc0473773b582a88c8d9d9b3eb0c608d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598727Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838509}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f841b934..7d77ba8c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia050847ec93ba6faa09f98cd71f3f1e50981af94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598284Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838508}
-
Xiaoqian Dai authored
It can be annoying to remember the capture region from previous sessions that happen long time ago. This CL adds a 8 minutes timeout to forget the capture region since the last time the user selected one. Note the timer starts on the last time the user selected a capture region from the previous session and will be used to compare with the current session start time to see if we need to clear the capture region. Bug: 1159117 Change-Id: Idc8c47f6272eb7b41e912a737b2c52fed7f1750a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594558 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#838507}
-
Ana SollanoKim authored
NG Out Of flow Layout part This change prepares the out of flow logic to incorporate a containing block rect that will be passed from AddOutOfFlowChildCandidate as the out of flow items' grid area. As a result, both AddOutOfFlowChild Candidate and OutOfFlowPositionedNode have a new, default, optional LogicalRect argument. ContainingBlockInfo was simplified to account for this addition and thus, NGOutOfFlowLayoutPart was refactored. Bug: 1045599 Change-Id: Ibab921ed449513d8f802e4467e845fcfb327c11f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593715 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838506}
-
Clark DuVall authored
The workaround causes perf regressions on the bots because it is compiling the dex in the background. This is expected, so ignore the workaround on local builds. This also pushes compiling the dex to after startup in a best effort task, to hopefully not compete with any crucial startup tasks and avoid wiping any compiled dex before loading the chrome split. Bug: 1160025, 1160029, 1159608 Change-Id: I704a3c3027ac13b7dc461a18bcc4e18f6e99c62d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597890 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#838505}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0cf9ac4bcdbf..ce7df0b9c3ac 2020-12-19 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98d03a5789aa24a0d7a906d66b080828e4b8080b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598817Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838504}
-
Gyuyoung Kim authored
This CL replaces all uses of the native TriggeringEventInfo enum class with a new Mojo TriggeringEventInfo enum in order to make blink public layer slim. Bug: 919392 Change-Id: I8c11814fa8f0ce4d4403af41a74b5da613943252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596657Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#838503}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baa0b2e054f3..814edbd0a53f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I931e8ae9e4efa927867f962a5dec38766cd9ba36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598673Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I844f2108cf55d9d2ef73ca8119cb0903cbb90a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598579Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838501}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I5f252a25aa5b1b6038a20ab0cf24829f2647dfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598173Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/653f6196ce65..011e0ad18679 2020-12-18 kbr@chromium.org Promote RGBA4444 and RGB565 to RGB[A]8 on macOS with AMD GPUs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Iec8b3aab33d20bb371d1c9530fe486813f13084b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598395Reviewed-by:
-
Christopher Cameron authored
Delete functions that ImageData doesn't use. Also rename |color_settings| to |image_data_settings| or |settings| to reflect the fact that this is not just for color settings. Remove many redundant ImageData:: prefixes. TBR=fserb, yiyix Bug: 1160105 Change-Id: I172ef3ba2ab3e3895df39eea56ac0aa0f8e8c2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598722Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#838498}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608313318-f751eb3e0afe10dd0ffdda8eb8463b2fff104dc2.profdata to chrome-mac-master-1608332413-1345826b7877110cf324b564359d2e5da1b35fc0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5ebef605f51edb0336d029a442564ac7886260ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598668Reviewed-by:
-
chrome://interventions-internalsdpapad authored
Bug: None Change-Id: Ib5410a1927a80967587111bb0fe89a2bb74709b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597376 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#838496}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608313318-0751b22489821c3640549132c59c2716d05bfe2a.profdata to chrome-linux-master-1608332413-e74bf19c468b4f240b918ee99bd718a9ec1e581b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4801ec7ec733e90334619453971d6c3d30ee59fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598667Reviewed-by:
-
David Tseng authored
TBR=dtseng@chromium.org Change-Id: I806e8031d315948107885d16f0b58f0430780c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598756Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#838494}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/769475d2d68a..baa0b2e054f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Iccd93d2e1cf3fea60f6137c029e5541cdbb31741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598717Reviewed-by:
-
Daniel Hosseinian authored
Since Presentation mode is read-only, ignore all input events to disable form editing and tabbing across PDF contents. When entering read-only mode: - Unselect any selected text. - Kill any form focus. - Remove all form highlights, so they don't appear interactable. Bug: 1157120 Change-Id: Idf0b5669b9d0f55ccd68198aa941fdeb1097910e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596857 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#838492}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3bf6de85082f..769475d2d68a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I59b8e9d28f13f2539ea233140070221c8ceac9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598391Reviewed-by:
-
- 18 Dec, 2020 21 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7bfdb1044916..b6a382975ae7 2020-12-18 michaelludwig@google.com Report aa bloat in triangulating path renderer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1159852 Tbr: tdenniston@google.com Change-Id: I1b7fd74015e609c370b06bdee13fb7ea10b462c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598482Reviewed-by:
-
Kai Ninomiya authored
First triage of almost everything except uninitialized_texture_is_zero tests. Also add new expectations for flakes found by Findit. # Test expectations updates only. TBR: cwallez@chromium.org Bug: None, 1084377 Change-Id: Ie83c2bbae6a626835337857723bf15ccb3398548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597885Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#838489}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39dd802f. With Chromium commits locally applied on WPT: 39dd802f "[LayoutNG] Multi-column containing blocks" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ia80701bf2d95446fc4daf0e4a3540cf4f41ca3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595343Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838488}
-
Benjamin Beaudry authored
Once upon a time, we created a WPT for OOFs in multi-columns - with a tiny harmless nit that swooped in at the last second. Since then, we created a bunch of similar tests by copying the initial test and duplicating the nit every time in every test. This CL cleans up that nit in every test I could find it. Bug: N/A Change-Id: I19a53bca22719f8f0193d02bf94d13700a1e823d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598541Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838487}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c47b951ecbcb..653f6196ce65 2020-12-18 jmadill@chromium.org Import Vulkan DEPS from the new vulkan-deps repo. 2020-12-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 1ca6504eb7bb to 1cc5b3357d2f (2 revisions) 2020-12-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 45e7154d to af73f1e9 (218 revisions) 2020-12-18 jie.a.chen@intel.com Unsuppress TextureCubeTest.CubeMapFBO on Intel/Win/Vulkan 2020-12-18 timvp@google.com Fix ValidateBufferStorageEXT() 2020-12-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0592a5f8 to 45e7154d (750 revisions) 2020-12-17 jonahr@google.com Revert "GLX: Expose EGL_ANGLE_window_fixed_size" 2020-12-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from a5be11bd8b3f to 6d5916d4a91e (1 revision) 2020-12-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from fa44979d90aa to 1ca6504eb7bb (1 revision) 2020-12-17 timvp@google.com Reland "Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9" 2020-12-16 m.maiya@samsung.com Vulkan: Unskip tests with passthrough GLSL function 2020-12-16 jmadill@chromium.org Roll third_party/spirv-cross/src/ f38cbeb81..be527632a (167 commits) 2020-12-16 jie.a.chen@intel.com Unsuppress GLSLTest.PointCoordConsistency on Intel/Win/GL 2020-12-16 cwallez@chromium.org Revert "Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9" 2020-12-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from c0bcfaf3bae9 to a5be11bd8b3f (2 revisions) 2020-12-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5a03bdd6 to 0592a5f8 (472 revisions) 2020-12-16 jmadill@chromium.org Update VVL directories in Android build. 2020-12-16 m.maiya@samsung.com Vulkan: Accumulate internal cache stats in renderer 2020-12-15 timvp@google.com Vulkan: Ignore glFlush to reduce vkQueueSubmits in Asphalt 9 2020-12-15 paulthomson@google.com Tests: update WhatsApp trace 2020-12-15 cclao@google.com Vulkan: Reduce driver uniform data to minimum if specConst is used 2020-12-15 m.maiya@samsung.com Add EXT_clip_cull_distance extension autogen code 2020-12-15 m.maiya@samsung.com Vulkan: Add support for internal cache hit and miss counts 2020-12-15 m.maiya@samsung.com Add EXT_shader_framebuffer_fetch_non_coherent entry points 2020-12-15 m.maiya@samsung.com Vulkan: Add the tests for EXT_clip_cull_distance 2020-12-15 timvp@google.com Vulkan: flushCommandsAndEndRenderPass during glFenceSync() 2020-12-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c16dc7107fd3 to fa44979d90aa (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132827 Tbr: cwallez@google.com Test: Test: BufferStorageTestES3.BufferStorageFlagsPersistentCoherentWriteTest: Test: Manual verification with angle_end2end_testsTest: Test: angle_perftests --gtest_filter="*whatsapp*" Change-Id: I582af4bbf9c5c96ccc722f06cbe0124ddeb7a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598491Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c656afad176..3bf6de85082f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ibd0dbda0ea6c9bcb0d5a9a164f79f1293a56b107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598387Reviewed-by:
-
Jonah Chin authored
GetSkImage() is being deprecated. Making it private as we work to remove the remaining callers. This will help prevent new callers being added. Bug: 1031051 Change-Id: I3350e1ebddc43151bfc9b2de9577267bf092bf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597696Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838484}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I925f493348ed581f901354aefb3e7469da361695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598617Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838483}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608281112-88d0ddf14300db9b794d74edf4ee423dfb88388a.profdata to chrome-win64-master-1608301770-06e287340f948f5f8b3c9d0d066bd6a8223fd57f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5eaa6d816192fc9be35ef8db9e2f52f889cf8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596041Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608292656-f4e77ce1df5bcf85a782ab8ba15317931c7bc284.profdata to chrome-linux-master-1608313318-0751b22489821c3640549132c59c2716d05bfe2a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I43192b2c1c31589afc4e1b4c0551118639c9a917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598489Reviewed-by:
-
John Budorick authored
Bug: chromium:1007101 Change-Id: Ic6ced991520288f18638ecf780a5ecf87781b6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596045Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#838480}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608292656-9703ac908a9d7874f8ebb142529aafb38fb7b3af.profdata to chrome-mac-master-1608313318-f751eb3e0afe10dd0ffdda8eb8463b2fff104dc2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I37297d444b23c80fcab9eb99c8c87bf6764cbced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598604Reviewed-by:
-
Jordan Oroshiba authored
Adding preferences programmatically enables future ephemeral support where certain values might be a different preference type. Screenshots: https://crbug.com/1157989#c2 Bug: 1157989 Change-Id: I43f0e9d693fe10da41f2d5be1b3e68c5422eb086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587615 Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#838478}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/d1469c60c1ab..9a644c7903ca 2020-12-17 dneto@google.com spirv-reader: Restrict use of ConstOffset 2020-12-17 dneto@google.com [inspector] test interference between sampled and multisampled resources 2020-12-17 dneto@google.com Roll third_party/spirv-tools/ 2c458414c..8f4b35c33 (26 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Icb97063456bb4c69ff1674560ee8ed5209ef4796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597928Reviewed-by:
-
Alison Maher authored
Currently, when a multi-column is a containing block for an OOF positioned element, the corresponding column is mistaken for the containing block, which causes various DCHECK failures. Columns are not allowed to be containing blocks, so this change ensures that we skip over columns when placing OOF positioned elements. Bug: 1158706 Change-Id: Id969b91a8f472d34b4767ffe891a3405770e8443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597769 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#838476}
-
Keren Zhu authored
ScreenCaptureNotificationUIViews overrides CanActivate() so that the widget is not activatable when it is hidden, and activable when visible. This was a hack to fix the a display bug on Windows that lacks an explanation on why it worked. See r256851. This hack is causing issue on Mac that the button on the notification widget will initially show in active style and change to inactive style after a mouse hover. Removing the hack solves the cosmetic issue on Mac. Manually tested on Windows and didn't observe any issue in hiding/restoring the widget as described in the comment and in r256851. Details on why the hack caused the cosmetic issue: 1. CanActivate() is false during widget initialization. This will make native widget inactive but visual style active. 2. CanActivate() becomes true after initialization. When a mouse hover triggers repaint of the button in the widget, widget->IsActive() returns false because the native widget is inactive. Thus on Mac, the button is rendered in inactive style. Bug: 1156580 Change-Id: Ic1e4d4bdbe3f29e6f65123880e5e9d373edb189b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596099Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4acfef066a15..9c656afad176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ica201cffa13dc7080560aa50158298266cb8a98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597904Reviewed-by:
-
Filip Gorski authored
TBR=bialpio@chromium.org Bug: 1158528 Change-Id: I5442f8e50a09b9ede1231aa7e2a56eaf24b3a0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590367 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#838473}
-
John Delaney authored
This reverts commit 53e3903f. Reason for revert: Introduced test flakiness due to uninitialized member. Original change's description: > [conversions] Route impressions alongside rel="noopener" anchor navs > > What: > Route impressions for the Conversion Measurement API to the browser > process for anchor tags with rel="noopener". > > Why: > We currently drop impressions for anchor clicks which have noopener > set because the impressions do not get forwarded to the browser process. > > Anchor click navigations with the rel="noopener" attribute use a > different navigation path than those without the attribute, in which > the window creation mojo also navigates the frame to the target url. > This navigation is not annotated with an impression. > > How: > Add an Impression member to CreateNewWindowParams which will get > forwarded as a LoadURLParam for the subsequent navigation of the > window. > > This change also fixes a bug in which initiator_frame_tokens are not > set for noopener navigations. > > As of https://chromium-review.googlesource.com/c/chromium/src/+/2327963, > the lack of an initiator frame tokens are used to to indicate whether > an opener was suppressed for a navigation. Because attaching the token > breaks this logic, we route a new |was_opener_suppressed| param through > the NavigationController:LoadUrlWithParams() flow to recover the > behavior. > > Bug: 1155577 > Change-Id: I84739a9f4ec0df9a867f91397f80b46eea1bcee6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575223 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838275} TBR=dcheng@chromium.org,creis@chromium.org,csharrison@chromium.org,johnidel@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iee257a09d1f198a4ec68c52004a23780cfb6c95c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1155577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598616Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#838472}
-
Olivier Yiptong authored
Implements the ability to select all fonts in the font chooser as a checkbox. Unselecting the checkbox will cause all selection to disappear. Bug: 1159246 Change-Id: Ia3ecda193457a70e8c5b3282362c4439945943ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594510 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I255f255093be35b0820fa857dd3f4b823ee2a3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598479Reviewed-by:
-
