- 04 Jan, 2021 20 commits
-
-
Maksim Sisov authored
This reverts commit a489cfcd. Reason for revert: broke resizing and ui events. see https://crbug.com/1162867 Original change's description: > [ozone/wayland] Ensure root_surface is committed last in a frame > > wl_surface.commits of a frame can happen asynchronously due to wl_buffer > import delay, frame callbacks, etc. This asynchrony can cause visual > glitches when the root_surface commits before its subsurfaces commit. > > This CL ensures that a root_surface commit always happens after other > commits in a frame. > > Change-Id: I7c83e122c4cdee42e6b8aca74875fa71b6c1ab5a > Bug: 1144179 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547395 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Maksim Sisov (GMT+2) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#834327} TBR=rjkroege@chromium.org,edcourtney@chromium.org,msisov@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144179, 1162867 Change-Id: I2cb8547d7953d30754360cc43f4461c1043da5d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609138Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#840011}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I071afada9af5e982cbb4540948d1b8a97eb7a3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609884Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840010}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609715606-7327fbc2bc097e67219881656c33656311fe2598.profdata to chrome-linux-master-1609735837-b861a4376807b513deb2e032934fede931b47328.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If3ced9360c8f6c9b22d0b12dfd1f79c7c89d522d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609561Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840009}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8898c4d02bbd..fc914f43cdee 2021-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2cbcb18e95e6 to bf02c31bec07 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I8297e8005d9b85a7c5649d0884355965138c70fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609556Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6c8373a67ac5ffc8754927c92728e9b7dc4f8b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609553Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609715606-bc828d1ea3eb384c44f7e57d92c4fa0a403f1238.profdata to chrome-mac-master-1609735837-c60ecdf4104916b2f41a942cd44f933904d57531.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6153e0f89d67ee68c4b8180d17d92d076a1c6964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609560Reviewed-by:
-
Nektarios Paisios authored
When Views is exposed as an AXTree, it will be part of the forest of accessibility trees that together with the webpage makes up Chrome's entire window contents. Our current code in AXPosition has been written with the assumption that it would operate only on a single webpage. This patch adds a minimalistic AXTree that resembles what will eventually become the Views AXTree in AXPosition's unit tests. This will catch current bugs as well as prevent any future ones that relate to the assumption that AXPosition is operating only on a single webpage. AX-Relnotes: n/a. Split out from patch that fixes CreatePositionAtStart/EndOfContent https://chromium-review.googlesource.com/c/chromium/src/+/2595454/ Bug: 1049261 R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Icb3371bf1d0dcefeae6078f7c4cfd4d8f6cb179f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597569 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#840005}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a5786bb3..5747d7b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I950ef89e2598f9caaa764c861b8b56987081195a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609586Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d6893e8186c6..9ea50c462e29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I4cd4181131301a45ac263a8354267b8dde1752a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840003}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/af35386f2e28..8898c4d02bbd 2021-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 9642fd0d to b627347a (150 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I74070e788b27173aa86ff08f3c0aa9c91005dda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609552Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55d424afd0f9..e34cda18e490 2021-01-04 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I26d90dca845d1cf00364b9b65ce209d6b3a1b00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609550Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5908b1710a0769a1e2e658a75869ab850af4c881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605969Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#840000}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c6d0bb346e3e..d6893e8186c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I260b624a1d144440d4cd3ecca4204ebb89c68a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607952Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I58be219a8272d45932c0578d9da33c930c938ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609786Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839998}
-
Findit authored
This reverts commit 0823dbae. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 839992 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDgyM2RiYWVhZDc0YjM0NmE3NWQ2NTNlNjVhYjkwYjAyNzc5ZDNhNgw Sample Failed Build: https://ci.chromium.org/b/8859069977390233904 Sample Failed Step: content_browsertests Sample Flaky Test: All/StartupTracingTest.TestEnableTracing/6 Original change's description: > [tracing] Align --trace-startup and --enable-tracing. > > Use StartupTracingController both for --trace-startup (primary use case: > browser startup perf profiling) and --enable-tracing (primary use case: > browser test tracing). > > Due to historical reasons both flags are kept, but now their behaviour > is mostly the same. If both are present, --trace-startup takes > precedence. > > Differences: > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > continues until the browser is closed. (--trace-startup-duration overrides > both). > - `trace-startup-file` always treats the path as absolute, while if > `enable-tracing-output` ends with /, it uses the provided value as the > directory and generates the base name based on the current runtime > metadata. > > R=skyostil@chromium.org,eseckler@chromium.org > BUG=1157954 > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839992} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1157954 Change-Id: I089e53e58934bb503f087b1c8e3ef42c6d3df694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609585 Cr-Commit-Position: refs/heads/master@{#839997}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609694975-fbd77d93879261357aa62420928f6a65fd51bfd9.profdata to chrome-mac-master-1609715606-bc828d1ea3eb384c44f7e57d92c4fa0a403f1238.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iefbbb0a4423c2998052a4b889af01c2cf0a8c9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609726Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/05b836e76668..c6d0bb346e3e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I1706cdfa0303a4f8abfa3c95ebb43c99aa03231b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607528Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609694975-5bfe426b2a512fa42c2e141e3aebcf6d12112447.profdata to chrome-linux-master-1609715606-7327fbc2bc097e67219881656c33656311fe2598.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia6bd0d84534e1ca8923ead366ae0d599f0164ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609725Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1609628089-87028f1185486b77cca1695847a5fdbe4cf1b66e.profdata to chrome-win64-master-1609706476-e037a7867e3a2b5c8db3719f2e44b526c6e4a4dd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I619d66d8d7003f897302ddb9cd4ecbf766dd1178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609545Reviewed-by:
-
Alexander Timin authored
Use StartupTracingController both for --trace-startup (primary use case: browser startup perf profiling) and --enable-tracing (primary use case: browser test tracing). Due to historical reasons both flags are kept, but now their behaviour is mostly the same. If both are present, --trace-startup takes precedence. Differences: - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` continues until the browser is closed. (--trace-startup-duration overrides both). - `trace-startup-file` always treats the path as absolute, while if `enable-tracing-output` ends with /, it uses the provided value as the directory and generates the base name based on the current runtime metadata. R=skyostil@chromium.org,eseckler@chromium.org BUG=1157954 Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839992}
-
- 03 Jan, 2021 20 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5f9959fcd80c..05b836e76668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I907f7981e695e6b1cf8843cad6300028beb38ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608013Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iace03150508f0106117bf8179e8d687ee99839fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608786Reviewed-by:
-
Nektarios Paisios authored
One of the consequences of exposing Views as an AXTree is that certain assumptions in AXPosition are no longer true. One of those assumptions is that if a null position has been returned from a method that moves from a non-null position to some other position, such as `CreatePositionAtEndOfAnchor`, then the beginning or the end of the whole content has been reached. This is no longer true when a tree of Views is connected to the main tree representing the currently visible webpage. It's also not true when AXPosition starts to be used more on Chrome OS, where the whole desktop is exposed using a forest of AXTrees. In this patch, the entirety of the AXPosition code was scanned for any assumptions that would prevent it from working when the webpage's main tree is connected to a Views tree. Also, care was taken to ensure that UI Automation text range provider methods work as before, for e example navigating by word, line, etc. shouldnot stop at iframe boundaries. AX-Relnotes: n/a. Split out from patch that fixes CreatePositionAtStart/EndOfContent https://chromium-review.googlesource.com/c/chromium/src/+/2595454/ Bug: 1049261 R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I1a25d9f715c50773b418d322c2f7c52eacbd6732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597568 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I6fc17ac4d12763dfb6a3efedd86b2b9db5ed48b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605475Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1609522837-84ab2211e919c3fad6f369e27b31fc95c8fee99d.profdata to chrome-win32-master-1609682762-08bdfdb365b220d658d85f431f0f1e50e1c1f495.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib4d14ea36bd707dea75779025b42e7fc27011c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609624Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609675068-aa3df7997bc18ea72d433edcf3777e935950af74.profdata to chrome-mac-master-1609694975-fbd77d93879261357aa62420928f6a65fd51bfd9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I9f47952457f3d3be15a9476525b35c3673fc9aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609667Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/008b75993c87..5f9959fcd80c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I78b7442fc459812185968083885b6f9ed5266426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606640Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609675068-61dd81530c960d91069553fc8c4b9654d0687146.profdata to chrome-linux-master-1609694975-5bfe426b2a512fa42c2e141e3aebcf6d12112447.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4f6d913c3923653042011501930abbe2772e338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609666Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c80871481b67..008b75993c87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I9e96b8dd99f5b52d602b8dbca7542fd2101bf7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608012Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Ib83e42e45be7c983367673aba0aff324694e881b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609584Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101030600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/k8Zmt6h1QZWI3CzVXTcRILEXRukRGv1FB1TqVSjiC7gC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I5ec1c981dadc79dc5fced433f59c4e2133355c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606638Reviewed-by:
-
Mike Reed authored
See https://skia-review.googlesource.com/c/skia/+/349402 Bug: skia:7650 Change-Id: Ief9093e21c244eee791c7d7cc00125203d2e5009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606475Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#839980}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03d6120d0953..c80871481b67 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Icc1ed229c7ccfed719646c58efcbfe11999db36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608654Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1609650707-fe804b7c2ff551d5b0e7f1f93154c1d475ba7c16.profdata to chrome-mac-master-1609675068-aa3df7997bc18ea72d433edcf3777e935950af74.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idf5115cce4afeeb05ab104e45200855d73a3a4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609481Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1609650707-99c061003c2d9ed060e75a4c45fdb65879cfe381.profdata to chrome-linux-master-1609675068-61dd81530c960d91069553fc8c4b9654d0687146.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0ff699c3b62b772dcd804b27b53e830647c6ff4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609480Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iee82cdcca357f1ff5eaca28128ef1ca5b01c3252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609473Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/324af5729e8e..55d424afd0f9 2021-01-03 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5526ff799b43f1e5ad80884a3622534b9cabdf15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609478Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d074acb5292b..03d6120d0953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ieae46300e392780683e32a9f8322a65fe9ff3f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606296Reviewed-by:
-
Alexander Timin authored
Make generateTracingFilePath take a basename as a parameter, to allow C++ to customise the file name while relying on Java to figure out the correct directory. If an empty string is passed, Java will generate an appropriate unique name. R=skyostil@chromium.org BUG=1157954 Change-Id: Ie94448ef1db1f57d0f15deba5fa54753285ea429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588331 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#839973}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ia32c3bd56490c5a8074f46a15895e8c55ac7f6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605472Reviewed-by:
-
