GitLab

This comment points to a bug that only applies to HistoryQuick.  It's not
appropriate to link to here.

BUG=


Review URL: https://chromiumcodereview.appspot.com/11734029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11787030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175464 0039d316-1c4b-4281-b951-d872f2087c98

Now that the new sourceDevice field introduced in WebGestureEvent is
used in WebKit, we can safely remove references to the old one (in
WebGestureEvent::data.flingStart) in Chromium, so that the old one can
be completely removed from WebKit.

BUG=164389


Review URL: https://chromiumcodereview.appspot.com/11740009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175463 0039d316-1c4b-4281-b951-d872f2087c98

Introduces a new class that represents an item's position within an
arbitrarily ordered list.  It's currently biased towards bookmarks, but
it could be made more generic if there was a need for it.

This class supports inserting before, after, or between other
UniquePosition items.  It never runs out of position values, though it
can use up unbounded space in the worst case.

In addition to the basics mentioned above, it also has support for other
functions that are particularly useful for bookmark sync.  The positions
are serializable and de-serializable, for storage and transimission.
They also support conversion to and from int64 values, allowing them to
operate with old-style positions.

The class is not currently used anywhere.  This commit includes only its
implementation and some tests.

BUG=145412


Review URL: https://chromiumcodereview.appspot.com/11569045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175462 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168257


Review URL: https://chromiumcodereview.appspot.com/11782015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175461 0039d316-1c4b-4281-b951-d872f2087c98

over a year ago, but it's our only test for some features of extension
messaging, and we've recently been changing that.

If ExtensionApiTest.Messaging starts failing, this will be why. However,
don't get it confused with PlatformAppApiTest.Messaging. Those failures
are unrelated.

BUG=96725

Review URL: https://codereview.chromium.org/11778010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175458 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise IBusUiController will be used after freed by ibus operation sent from engine.

BUG=168310
TEST=None


Review URL: https://chromiumcodereview.appspot.com/11777010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175454 0039d316-1c4b-4281-b951-d872f2087c98

Using std::vector caused crashes in cases where a Dispatch call resulted in a Dispatcher being added and that addition provoked reallocation of the vector's storage.  This resulted in a bad iterator dereference in the dispatch loop.

BUG=chrome-os-partner:15544
TEST=Monitor unplugging/power removal still works.  The crash case no longer crashes.

Review URL: https://chromiumcodereview.appspot.com/11593015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175452 0039d316-1c4b-4281-b951-d872f2087c98

As we define new behavior for panels in the launcher (e.g. right aligned icons), we want to treat v1 panels (TYPE_EXTENSION_PANEL) as apps, not panels.

BUG=168229


Review URL: https://chromiumcodereview.appspot.com/11741023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175449 0039d316-1c4b-4281-b951-d872f2087c98

Two techniques are introduced implementing RGB->YV12 conversion using fragment shaders. This functionality is added to AcceleratedSurfaceTransformer, and validated by new tests checking accuracy against a reference implementation.

The faster ("MRT") technique needs hardware support for multiple simultaneous render targets, and takes two passes, the second pass reading one-quarter as much data as the first pass. The slower "WithoutMRT" technique requires three passes and reads the full RGB input with each pass.

On two machines I tested (one NVIDIA, one Intel), the fast path was about twice the speed of the dumb path. On an NVIDIA Quadro 6000 using the fast path, at 1280x720 frame size, conversion ran at 2838 fps. Accuracy was within two bits of the software implementation, and usually within one bit.

BUG=161537
TEST=Included unit tests.

Review URL: https://codereview.chromium.org/11280318

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175446 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/11773005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175444 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175443 0039d316-1c4b-4281-b951-d872f2087c98

The only change applicable to chromium is a fix for a bug 
that causes corruption. The corruption manifests as a missing 
sst file that renders the database unopenable.

BUG=168649


Review URL: https://chromiumcodereview.appspot.com/11775018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175442 0039d316-1c4b-4281-b951-d872f2087c98

This is the first attempt at splitting the scripts into
meaningful packages and make dependencies explicit.

BUG=167331

Review URL: https://codereview.chromium.org/11649008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157495
TEST=src/tools/telemetry/run_tests --browser=system TabTest.testActivateTab


Review URL: https://chromiumcodereview.appspot.com/11663011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175440 0039d316-1c4b-4281-b951-d872f2087c98

Change comboboxes to dropdown menus, per the latest mocks. Allow users to switch between manual entry and pre-fill modes.

lots of TODOs, but this seems like a good stopping point.

BUG=157270,157273

Review URL: https://chromiumcodereview.appspot.com/11743036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175439 0039d316-1c4b-4281-b951-d872f2087c98

BUG=167457
TEST=no more crashes in the crash server


Review URL: https://chromiumcodereview.appspot.com/11788019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175438 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162417
TEST=Run Chromium (unofficial build) with --fake-variations-channel=stable and ensure that a stable experiment, such as "UMA-Dynamic-Binary-Uniformity-Trial" shows up in about:version (after restarting once).


Review URL: https://chromiumcodereview.appspot.com/11737025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136445


Review URL: https://chromiumcodereview.appspot.com/11805002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175436 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157692

Review URL: https://chromiumcodereview.appspot.com/11775007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175435 0039d316-1c4b-4281-b951-d872f2087c98

Related CL: crrev.com/173507 - that CL calls StatisticsProvider::Init()
in PreEarlyInitialization stage to obtain channel info early. However
it also has a side-effect to load machine statistics early. After this CL
we start to observe that sometimes the crossystem tool hangs.

Ideally the tool hang should be root caused but it is timing sensitive
and also extremely rare.

The current CL makes StatisticsProvider::StartLoadingMachineStatistics()
a separate and explicit call, so that the crossystem tool can be invoked
later at PostBrowserStart stage. Hopefully by restoring the timing we
can eliminate the tool hang.

BUG=167671
TEST=CQ, manually verified that machine statistics is still available
under chrome://settings in the "bios_info" section.

Review URL: https://codereview.chromium.org/11778025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175434 0039d316-1c4b-4281-b951-d872f2087c98

%ProgramData% is read-only for processes running at low integrity level. since the host is now running at low integrity level and logs are written to ETW, this CL quits using debug.log altogether. See http://code.google.com/p/sawbuck/wiki/HowToCaptureLogsOffline for an example how logs can be collected via ETW infrastructure. The Chromoting provider's guid is "{2db51ca1-4fd8-4b88-b5a2-fb8606b66b02}".

BUG=134694


Review URL: https://chromiumcodereview.appspot.com/11776029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175433 0039d316-1c4b-4281-b951-d872f2087c98

Other LevelDB consumers will still be aggregated under LevelDBEnv.

BUG=164755


Review URL: https://chromiumcodereview.appspot.com/11776009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175432 0039d316-1c4b-4281-b951-d872f2087c98

The previous implementation always returned zero since it checked the
bounds of the scroll layer instead of its child. Also add a unit test
for the metadata values.

BUG=161945


Review URL: https://chromiumcodereview.appspot.com/11779008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175431 0039d316-1c4b-4281-b951-d872f2087c98

Use the SkBitmap version of CalculateKMeanColorOfBitmap() to avoid a PNG
encode/decode round trip.

BUG=none
TEST=cpu says it looks OK on his Win8 machine


Review URL: https://chromiumcodereview.appspot.com/11571050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175430 0039d316-1c4b-4281-b951-d872f2087c98

BUG=155330


Review URL: https://chromiumcodereview.appspot.com/11778005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175429 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org
BUG=168561
TEST=PromoResourceServiceTest.NotificationPromoTest passes after Jan 7 2013 5:40:75 PST

Review URL: https://codereview.chromium.org/11801015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=157692

Review URL: https://codereview.chromium.org/11785007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168169
TEST=should all pass


Review URL: https://chromiumcodereview.appspot.com/11801014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175426 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175425 0039d316-1c4b-4281-b951-d872f2087c98

TBR=macpherson
TEST=
BUG=

Review URL: https://codereview.chromium.org/11776028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175424 0039d316-1c4b-4281-b951-d872f2087c98

reading from sockets.

In particular, prevent the parser from reading beyond all ReadData in
HttpPipelinedConnectionImplTest.ConnectionSuddenlyClosedAfterResponse,
and fix a test that was trying to reuse a connection when
an earlier stream failed on it.

BUG=166915
Review URL: https://codereview.chromium.org/11795003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141005
TEST=ui_unittests --gtest_filter='X11UtilTest.*' passed

Review URL: https://codereview.chromium.org/11725005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175421 0039d316-1c4b-4281-b951-d872f2087c98

Due to the way the math works out for calculating which tiles to use for a
given content rect, the content scale for a picture layer has to be the maximum
of all the tilings on a layer.

Currently, each layer only has one tiling, but this change also creates the
infrastructure for adding different tilings over time and clamping contents
scales to a minimum.

NOTRY=true
R=danakj@chromium.org
BUG=155209


Review URL: https://chromiumcodereview.appspot.com/11777008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175420 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Set the max frames pending from the thread proxy.
> 
> When a parent compositor is present (ie, ubercompositor), throttle to a single
> pending frame.
> 
> Tests:
> LayerTreeHostTestMaxPendingFrames.DelegatingRenderer
> LayerTreeHostTestMaxPendingFrames.GLRenderer
> 
> BUG=123444
> NOTRY=true
> 
> Review URL: https://chromiumcodereview.appspot.com/11747002

TBR=danakj@chromium.org
BUG=168691
Review URL: https://codereview.chromium.org/11784030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123444
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/11754003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175413 0039d316-1c4b-4281-b951-d872f2087c98

Calculate connection timing information in ConnectJobs,
add store it in ClientSocketHandles.

BUG=77446
Review URL: https://codereview.chromium.org/11428150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175412 0039d316-1c4b-4281-b951-d872f2087c98

Add/update and use NativeTheme dialog colors for Win/Aura.
Use Label[Button] and Bubble[Border|Background] in DialogFrameView.
Add DialogFrameView::content_margins_ similar to BubbleFrameView.

Increase widget example size, add DialogExample with title.
Tweak dialog example InitParams (nix frame, make transparent).
Make the buttons in the widget example focusable.
Make LabelButton::GetPreferredSize public.
Refactor BubbleFrameView::GetBoundsForClientView.

Roughly matches the specification at:
https://docs.google.com/a/google.com/file/d/0B6x6iYCtKinEVjFvOWNfRlJCLU0/edit
See the screenshot on the bug at:
https://code.google.com/p/chromium/issues/detail?id=166075#c5

TODO(followup): Investigate a minor LabelButton drag/hot issue.
TODO(followup): Add/use new close (x) button resources.
TODO(followup): Generalize BubbleBorder to a custom frame border?

BUG=166075
TEST=[Views examples] dialogs look closer to mocks with --enable-new-dialog-style (actual Chrome dialogs need more work).
R=sky@chromium.org

Review URL: https://codereview.chromium.org/11756005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175411 0039d316-1c4b-4281-b951-d872f2087c98

The previous approach to fix the omnibox was specific to it and that's why it didn't handle other widgets. To fix this, generalize looking for the widget by asking the FocusManager for the focused views::Textfield. I had to add a special case for devtools since the way it worked before is that it gets the synthesized keyboard shortcut and in the renderer it translates it to a clipboard operation.

BUG=164235
Review URL: https://codereview.chromium.org/11734015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175409 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175408 0039d316-1c4b-4281-b951-d872f2087c98