- 20 Sep, 2018 40 commits
-
-
Sammie Quon authored
Test: manual Bug: 880947 Change-Id: Id5005664eab5f6988fe8f8368c75a8755e833554 Reviewed-on: https://chromium-review.googlesource.com/1234359 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592675}
-
Istiaque Ahmed authored
When EventAckData sees an event dispatch in IncrementInflightEvent on UI [1] thread, it hops to IO thread to start the associated worker and then returns to UI[2] to *record* that the event needs an ack from the renderer process. Event ACKs arriving between UI[1] and UI[2] would incorrectly fail to find the associated data in the *record*. This results in bad message termination. Move the data to IO thread instead, where both IncrementInflightEvent and DecrementInflightEvent can access the unacked event data. Note that both IncrementInflightEvent/DecrementInflightEvent has to pass through IO thread anyway to access ServiceWorkerContext. The new inner class IOEventData inside EventAckData contains the map for unacked events. This also fixes and enables an existing test's flakiness: FilteredEventsAfterRestart. Bug: 844821 Change-Id: Ia9df6c896abbae62c9f395f62ef67cab8e1bfb74 Reviewed-on: https://chromium-review.googlesource.com/1228994 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f524571e7f35..75040d8b299c Created with: gclient setdep -r src-internal@75040d8b299c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaff23ca0b9832a640985db862646f949b7a17ec1 Reviewed-on: https://chromium-review.googlesource.com/1234751Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592673}
-
Luciano Pacheco authored
Fix is used on crrev.com/c/1188046 Change-Id: I9edeeac193584599230a9348e21e93ae4aec887c Reviewed-on: https://chromium-review.googlesource.com/1229738Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#592672}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5445ed7b039684fe1479a8f20eadd25a6dcaa805 Reviewed-on: https://chromium-review.googlesource.com/1235226Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#592671}
-
Renjie authored
Currently when CloseSessionOnError() is called, it always does SILENT_CLOSE when closing the connection. However, sometimes this method is called to abort an active session, which means a connection close packet should be sent. Thus we should refactor this method to take a behavior paramater so the caller can decide which connection close behavior is proper in its own situation. Change-Id: I2601f4ed6fbd48d9ce89dad6f7a1f6b6fc4eddbd Reviewed-on: https://chromium-review.googlesource.com/1227399Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592670}
-
Erik Luo authored
With keyboard navigation experiment enabled, - Switch viewport's focus proxy from `element` > `_contentElement` - Clicking a message will select it - Click-selection applies "blue" highlight, except when a user expands objects, groups, or traces - Move focus from log > prompt when user types on 'keydown' - Better distinguish events below prompt (geometry works with MouseEvents, but not FocusEvents) - Stick to bottom when prompt gains focus Bug: 865674 Change-Id: I473bcdf714408406b0ce7a49772589daf3cbe9cb Reviewed-on: https://chromium-review.googlesource.com/1171814Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#592669}
-
Dan Beam authored
R=dpapad@chromium.org BUG=884428 Change-Id: Icfe2e0993204434e2639b506bd581e0fd7ef296e Reviewed-on: https://chromium-review.googlesource.com/1227596Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (no longer on Chrome) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#592668}
-
Shakti Sahu authored
Bug: 885322 Change-Id: Id509eb2009958b2532a428abd8db5156a7c026ae Reviewed-on: https://chromium-review.googlesource.com/1232477 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592667}
-
Donna Wu authored
With separated pipes, there will be a race condition between GetDevices() method and OnDeviceAdded/Removed events. In this case, device list returned from GetDevices() may out of date if a event happened between the request sending out the client getting the device list. This CL made the client bindings associated for UsbDeviceManager interface and implemented it in device::usb::DeviceManagerImpl to eliminate the potential race condition. Bug: 699790 Change-Id: Iad019009fa831f6d2f3ccf9b5c7064f18c416cea Reviewed-on: https://chromium-review.googlesource.com/1223339Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#592666}
-
chaopeng authored
In http://crrev.com/592186 we landed a performance improvement based on querying the direct compositing reasons of the transform node. This change lets us use that bit for non-BlinkGenPropertyTrees code which fixes the perf regression. Bug: 875991 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie1eab209e49a9685877c90e61b8388dc548f1e73 Reviewed-on: https://chromium-review.googlesource.com/1231836 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592665}
-
Erik Luo authored
Bug: none Change-Id: I6e206b63e45e8b6e4510125195aa1169223d5d1e Reviewed-on: https://chromium-review.googlesource.com/1220550Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d39389f6ec2e..109aa6d0f673 git log d39389f6ec2e..109aa6d0f673 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 thestig@chromium.org Remove more unneeded STL #includes from headers. 2018-09-20 thestig@chromium.org Remove many unneeded STL #includes from headers. Created with: gclient setdep -r src/third_party/pdfium@109aa6d0f673 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I79cdf382a6e67cc2d5e449a80c6da07d090aa94a Reviewed-on: https://chromium-review.googlesource.com/1235324Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592663}
-
David Tseng authored
TBR=dmazzoni@chromium.org Change-Id: I65cf219b1e2e89fc6889f65daedbc81e2a616e14 Reviewed-on: https://chromium-review.googlesource.com/1235017Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592662}
-
Alan Cutter authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1218186 which was reverted in https://chromium-review.googlesource.com/1230435 due to the added test failing mac-cocoa-rel. This reland removes the test from non-Views mac builds as it's only applicable with Views enabled. This CL updates the title text color for Linux and Windows 7 hosted app windows to be more consistent with Windows 10, Chrome OS, Android and text colors used by Gmail and Inbox. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357634&signed_aid=ONM068fpCagoCFdrDrfYuw==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=357642&signed_aid=2gnT0P6z9_fNMEZAGLKLnw==&inline=1 See bug for more screenshots. Bug: 883177, 885164 Change-Id: Iaeae13799629d418dfa4c4285032bf1d7990c402 Reviewed-on: https://chromium-review.googlesource.com/1233074 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592661}
-
Lakshmi Kumar Dabbiru authored
This Cl adds behavior to delete the local cards once they are successfully migrated to server cards. Bug: 852904 Change-Id: Id424b8c3886dc8ec608108eab764da85f2c426f0 Reviewed-on: https://chromium-review.googlesource.com/1234997 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#592660}
-
Kunihiko Sakamoto authored
Design doc: https://docs.google.com/document/d/1kzQRLybaUk12UgG8YTyACwNZ7tpcXwdjzPXU3CV25J8/edit Bug: 863305 Change-Id: Ibdfbd06dc354894c2ef92db878828d171adaa75f Reviewed-on: https://chromium-review.googlesource.com/1226758Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592659}
-
Kenichi Ishibashi authored
Looks like we also call ServiceWorkerNavigationLoader::FallbackToNetwork() after |loader_callback_| is consumed. When the callback is already called, dump debug log so that we can get better idea of the cause. Bug: 887033,881826 Change-Id: I24b6966b8d8ce2ffbcf33280e292df3842969b57 Reviewed-on: https://chromium-review.googlesource.com/1235256Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592658}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91c7297741c9..f524571e7f35 Created with: gclient setdep -r src-internal@f524571e7f35 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie71f5f89c15f30937fe183e684294f97c0bcff1b Reviewed-on: https://chromium-review.googlesource.com/1235320Reviewed-by:
-
Sam McNally authored
Bug: 883230 Change-Id: I727a2fabd5c283af814839621aacb5cff05fb648 Reviewed-on: https://chromium-review.googlesource.com/1235255Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#592656}
-
Ryan Cui authored
We are seeing lots of flaky failures on the builder. They are being looked at, but until they are fixed remove the tests from the builder to reduce maintainence burden on the broader team. Bug: 885309 Change-Id: I421702ec6155a2bf1d117ab77a286870e3e7b443 Reviewed-on: https://chromium-review.googlesource.com/1234795Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592655}
-
Alexey Kozyatinskiy authored
We can add it later as soon as we figure out frontend use case. R=luoe@chromium.org Bug: v8:8200 Change-Id: I8becec8c4734464c63ce7e8ac68f96595f7fa362 Reviewed-on: https://chromium-review.googlesource.com/1235280Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#592654}
-
Caleb Rouleau authored
Bug: 886965 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I84c96f5d3399a20b83a98ec68f1157eac2d67685 Reviewed-on: https://chromium-review.googlesource.com/1235281 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592653}
-
Ryan Hansberry authored
Update the MultiDevice and Tether watchlists with up-to-date file paths and current team members. Create new SmartLock watchlist. Change-Id: Iba7fdcefea847f0f6bf426ad485a47a76df71fd0 Reviewed-on: https://chromium-review.googlesource.com/1235309 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#592652}
-
Nigel Tao authored
This uninstalls (on log in) those web apps that were previously automatically installed due to being listed in an external .json file, but are no longer listed. This does for default-installed web apps what https://chromium-review.googlesource.com/1195293 "policy: Uninstall apps that are no longer forced installed" does for policy-installed web apps. Bug: 855281 Change-Id: I4125e60f4a6b9c6033d78ca54d0005be45d06e82 Reviewed-on: https://chromium-review.googlesource.com/1198644Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Weilun Shi authored
Dynamically determine the first n tiles get loaded based on the window size. Bug: 876814 Change-Id: I7830faff7d090c8b33c7726ca3faa3439fe52dda Reviewed-on: https://chromium-review.googlesource.com/1232686 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#592650}
-
Xiaohan Wang authored
Integration test of playing encrypted AV1 using ClearKeyCdm requires more refactoring and will be landed in a later CL. TBR=jrummell@chromium.org Bug: 884898 Change-Id: I17e113a0d384e12a3e2590866a86c2f168b9ab9a Reviewed-on: https://chromium-review.googlesource.com/1229299Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592649}
-
David Black authored
When refactoring, I accidentally assumed main thread. Bug: b:113731926 Change-Id: Ie989980c9f4796fb413b310a2254baaf36730f95 Reviewed-on: https://chromium-review.googlesource.com/1235211 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592648}
-
Luciano Pacheco authored
Rendering this table in Gitiles requires a table header. I've checked rendering using "gitiles" link in: https://chromium-review.googlesource.com/c/chromium/src/+/1223347/9/docs/test_descriptions.md https://chromium.googlesource.com/chromium/src/+/refs/changes/47/1223347/5/docs/test_descriptions.md Add more information for WebUI tests. Bug: 880688 Change-Id: If19bada962b67899676ebd2e4d8fa19b9fcec381 Reviewed-on: https://chromium-review.googlesource.com/1223347Reviewed-by:
-
Stephen Martinis authored
This CL enforces swarming dimensions for the mac testers on chromium.mac using swarming_mixins. Bug: 880973 Change-Id: I3982de0c6704ceaa2f8e3ab5b9909c5c01319aa6 Reviewed-on: https://chromium-review.googlesource.com/1223027 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592646}
-
Min Qin authored
This CL makes OfflineItemModel inherit from DownloadUIModel Bug: 881499 Change-Id: I63270a79917bae87fdb4ae3531f9088f7900509e Reviewed-on: https://chromium-review.googlesource.com/1225888 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592645}
-
yusukes authored
The Arc.IntentHandler* metrics have been replaced with ChromeOS.Apps.IntentPicker* months ago. BUG=824598 TEST=try Change-Id: I4d86f17c4a1f5529e6bf063837b75a48564bc378 Reviewed-on: https://chromium-review.googlesource.com/1234860 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
-
Jordy Greenblatt authored
The existing menu item was a relic of an old design and was in the wrong place and had a different SVG from the 'Connected Devices' Settings UI page. Bug: 877166 Change-Id: Id71107ca97965965e213d12a94d1184424259fe6 Reviewed-on: https://chromium-review.googlesource.com/1235275Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#592643}
-
Chris Harrelson authored
This improves BGPT testing, and makes GraphicsLayer a bit smaller. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I97a09fd97085e6a157251348dfbadc175fa76a59 Reviewed-on: https://chromium-review.googlesource.com/1227680 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
David Staessens authored
The VAAPI JPEG decoder on some platforms won't convert the decoded images to the I420 format, but will return the decoded images in the JPEG's pixel format. This change adapts the VaapiJpegDecodeAcceleratorTest to work correctly when no conversion is done. Additional cleanup: * Made a few member functions const. TEST=ran JDA tests on eve and grunt Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I715c5e88b8fa3c3d4db7a69a4e195d2ef3f79d8a Reviewed-on: https://chromium-review.googlesource.com/1218486 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#592641}
-
Josh Nohle authored
Before the CryptAuthClient attempts to make an API call, it fetches an OAuth2 access token. However, currently the client does not wait for the access token to become available before proceeding. This can lead to empty access token strings and errors such as [ERROR:cryptauth_device_manager_impl.cc(666)] GetMyDevices API failed: [authentication error] and [WARNING:cryptauth_enroller_impl.cc(139)] SetupEnrollment API failed with error: [authentication error]. Here, we change PrimaryAccountAccessTokenFetcher's mode from |kImmediate| to |kWaitUntilAvailable|. From PrimaryAccountAccessTokenFetcher's header file: |kImmediate|: Makes one-shot immediate request. |kWaitUntilAvailable|: Waits for the primary account to be available before making the request. In particular, "available" is defined as the moment when (a) there is a primary account and (b) that account has a refresh token. Bug: 887136 Change-Id: I745e0bb3f3ef1bc3226e46147fcb699c101d12dd Tested: Manual Reviewed-on: https://chromium-review.googlesource.com/1235284Reviewed-by:
-
Carlos Knippschild authored
Bug: 852872 Change-Id: I15f0b52900531ee987001ff4897f6c175470dcd3 Reviewed-on: https://chromium-review.googlesource.com/1234318Reviewed-by:
-
Aseem Garg authored
These were missed in an earlier CL. R=adamk@chromium.org BUG=v8:8186 Change-Id: I75e506098f2e2d4d7b507ce4f8a8b9a6c8d84b9c Reviewed-on: https://chromium-review.googlesource.com/1235315Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592638}
-
Joel Einbinder authored
Keypress events have a different keycode, so the wrong events were being captured and sent to DevTools from extension panels. But keypress is deprecated and we don't need these events anywhere in DevTools. So we can just remove the event listener. Bug: 882422 Change-Id: I9d286f581aa77ff208463a2edbb4eea093fa98ee Reviewed-on: https://chromium-review.googlesource.com/1232853Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#592637}
-
Weidong Guo authored
Bug: 884765 Change-Id: Iab02be967ed5c39b03eab1eb82086e405a82bd17 Reviewed-on: https://chromium-review.googlesource.com/1235292 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
