- 15 Jan, 2021 40 commits
-
-
Joe DeBlasio authored
This CL removes OWNERS for lookalikes for //components/security_interstitials/OWNERS. As the purview of lookalike owners grows (e.g. crrev.com/c/2628137 ), we should probably manage this a little more closely. The existing list also included a bunch of folks who know a lot about security interstitials, but should really chat with us before they change lookalikes stuff. It also updates the component for chrome/browser/lookalikes, since we have something more specific now. Change-Id: I1ee4fd4fc6d551a458cad36563d1f1ce445ce2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630744 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843929}
-
Caitlin Fischer authored
The experiment has launched. Bug: 1126640 Change-Id: I0aa59d57fc6110337f0cdc183814ac779a0f231f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631430Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843928}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610647094-29bf0a5bdecd41fe52f35b6c0534103ef2302651.profdata to chrome-win32-master-1610657917-c5f7c43f5defa75543fc37f687b27a8203dbe683.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I74b8a56d14e75fe59bac21a407a107941f9c503b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843927}
-
Brandon Wylie authored
If the Assistant consent flow is launched through SearchActivity, BottomSheetController isn't available. When this happens, the consent is aborted and retried next time. Bug: 1166119 Change-Id: Id177cce7644d2a6819adc3a11bba427f4a6bef90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627967 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#843926}
-
Caitlin Fischer authored
The server-side config indicates that the study has ended. Bug: 1126640 Change-Id: I9c2a1cae37f7c1a01e729959e7d77d2de783b67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631429Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#843925}
-
Minoru Chikamune authored
Before this CL, WebViewPlugin uses per-thread CompositorTaskRunner. After this CL, WebViewPlugin will use per-ASG CompositorTaskRunner. Bug: 1105403 Change-Id: Ie5480f35818e3821799a20785f2bde5b4cb62d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626679 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843924}
-
Xinghui Lu authored
If the size of the allowlist is too small, the allowlist check will be skipped and Chrome will fall back to hash-based check. We'd like to know how often that happens. Metrics added: SafeBrowsing.RT.AllowlistSizeTooSmall Bug: 1164555 Change-Id: Ibd29ebfccab72eacdd0fb0b5a45f9a8ebc3eff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622335 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#843923}
-
Cattalyya Nuengsigkapian authored
- Support independent alt-tab mode selection for multi-profile. - Save alt-tab mode to active user prefs and restore after a re-login and a crash. Bug: 1157105 Test: Manual test, `ash_unittests --gtest_filter=MultiUserWindowCycleControllerTest.*` Change-Id: I59208f3f9726e776a10f0761c8aa431bf11b2080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616320Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Cr-Commit-Position: refs/heads/master@{#843922}
-
Xiaodan Zhu authored
This CL disables the tab navigation when there is a desk being dragged. Bug: 1154038 Change-Id: I744a28fc07c2a5005e940afb03741dbc22c88216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622952 Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I9950f22a076ed0b5df43010c878d18372d5a6c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629402Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#843920}
-
Hirokazu Honda authored
This reverts commit 276dd2ba. Reason for revert: The root cause of the synchronization is fixed. Removes this workaround. Original change's description: > media/gpu/test/VFValidator: Workaround the buffer synchronization problem on intel 3.18 > > There is a synchronization problem on the mapped buffer on intel > skylake devices. This is due to some missing 9165 patches in kernel > 3.18, and thus will be fixed if the kernel is upreved to 4.4 or > newer. This bug causes a decoded content validation failure in > video_decode_accelerator_tests. > This is a workaround to this bug; usleep() is added after the > buffer is mapped and before the frame validation if the kernel > version is 3.18 and the processor is Skylake. > > Bug: b:149808895 > Test: video_decode_accelerator_tests on sentry > Change-Id: Ib77ebe0b83834e4d91bc994cbe6912348862e021 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371724 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801614} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:149808895 Change-Id: Id0f1bdcc486effef2c6d3fd64275d71051020028 Test: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631645Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843919}
-
Ken Rockot authored
This migrates all geolocation-api js-test web tests to the newer testharness, in preparation for further migration to internal WPT. They will move to WPT for the sake of modernization, but also primarily so that they can be HTTP tests that load ES6 modules for modern Mojo JS bindings. Bug: 1004256 Change-Id: I4c20c09fb3e10c8a35a3121f2e6df881e126d19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628257Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#843918}
-
Richard Chui authored
CL #1 of 2 for chromevox announcements (second part is for tab navigation). Add the following announcements: -Entering capture mode -Exiting capture mode -Selecting the type (image/video) -Selecting the source (window/region/fullscreen) -Screenshot captured -Recording starting -Recording stopped Bug: 1140597 Test: manual Change-Id: I17c8d62de27507dfd4a9711201525fbd76b993cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598056 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#843917}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7231b2e72311..b2af2da3481c 2021-01-15 bsheedy@chromium.org [Devil] Fix ArCore system path on Q If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: oysteine@google.com Change-Id: If91c1ff43003c459faf80c4b54afd20556a6df73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631586Reviewed-by:
-
Minoru Chikamune authored
Before this CL, ScrollableArea uses per-thread CompositorTaskRunner. After this CL, ScrollableArea will use per-ASG CompositorTaskRunner. Bug: 1105403 Change-Id: Iee3a7a9894918f5276d1110e50778e6523d2396f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626818 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Taylor Bergquist authored
Adds a mechanism for customizing the overflow indicators to ScrollView to support this. Also note that the overflow indicator added here is just a starting point for iteration with UX, not a final design. Bug: 1116119 Change-Id: If6eae1e244f6bce65f10e10d964c2ae2af9ee86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611652 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#843914}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610647094-405a32bcf15e5a84949640f99f84a5b9f61e2f2e.profdata to chrome-linux-master-1610668478-7d09cc584bcf96e72cb1514828da986e69ab213c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifb708c0149949bc5adf4a12566fda3eb650ad3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631785Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610647094-3e6a9456ec2a4877d37636e99663c09557aba29f.profdata to chrome-mac-master-1610668478-7094d9e47d32a574227817d5f93a8aaa3dc9b368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia6540ce6ce0140b882460854ee99cae021153964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631210Reviewed-by:
-
David Black authored
Previously a ui::Layer was directly owned which doesn't handle the case of layer recreation which is handled by ui::LayerOwner. Bug: 1166959 Change-Id: I92efce13e7a8a48423547cf134214d6b23b5c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631298Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843911}
-
Matt Menard authored
This ensures when the print-server-scaling flag is disabled that print servers acts identically for >16 servers as it does for <=16 servers. This fixes a regression. Bug: b:168650771 Change-Id: I6ed183bdb87fdd2440dea7893884310ccf5e60cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626118 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#843910}
-
Ted Meyer authored
Bug: 1109397 Change-Id: I3dbc859a10632cf2448c4f6f3bd28db6b708e8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631468Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843909}
-
Alan Cutter authored
This CL makes the "capture_links": "new-client" web app manifest setting behave like the existing experimental tabbed web app link capturing. This behavior is hidden behind the WebAppEnableLinkCapturing flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=484716&signed_aid=tplWTvCmrc2w7LVRH_JXdA==&inline=1 Bug: 1163398 Change-Id: I34c525bb35b09f25b2dfca3237d8baec9d5a1010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626618 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843908}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iee1a5be31833c43b68e2516c0ee1872e0a567384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631351 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843907}
-
David Black authored
Per UX instructions, the only UI appearing on hover should be the pin. Bug: 1166920 Change-Id: Ibdda78b1a60e83ec62ac381b30212dc57854c82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631452Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4386.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia9a70820fe6d4d426a4c4702c0fc0ecaa994a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631908Reviewed-by:
-
Ahmed Fakhry authored
BUG=1157997 TEST=Manual Change-Id: I1079920b3d3530f6ba263f7d2b8b2a92fd39e59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631286Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5255c465bbba..aedd133cd85f 2021-01-14 amaiorano@google.com VulkanBenchmarks: fix memory leaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I87703384d27acc39eebbab56c252e6efc7ab136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629854Reviewed-by:
-
Xiaodan Zhu authored
This CL implements the unittest for reodering desks by drag & drop. This CL adds three helper functions: - LongTapOnDeskPreview - StartDragDeskPreview - DragDeskPreviewTo - DropDeskPreview The CL adds two unittests: DesksBentoTest.ReorderDesksByMouse and DesksBentoTest.ReorderDesksByGesture which test - Trigger drag & drop and reorder desks by mouse. - Trigger drag & drop and reprder desks by gesture. Change-Id: I295e393ef4fdcf94a242ba4ecb011bb8f44515d3 Bug: 1154038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609587Reviewed-by:
-
Nancy Wang authored
Add browser tests for AppLaunchHandler to verify the restoration process. BUG=1146900 Change-Id: Ibeaf262080a24c680718888ee081cc62c5b21a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619245 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843901}
-
Lei Shi authored
Previously, resume_() will read content from the current sentence start to the end of the current paragraph, regardless of user-selected boundaries. This CL enables STS to read content from the current position to the end of the user-selected content. We use NodeUtils.Position as the anchors for start and end positions. This CL also refactors getNextNodesInParagraphFromNodeGroup, which is broken into getPositionFromNodeGroup and getNextNodesInParagraphFromPosition. Bug: 1166440 Change-Id: Iaad1b4d6c23f2508478f6547a6b0b95019518672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627335 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843900}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4386.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idd1eb98c614f5f14862ea7fb1ca3ca1d1925c81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631907Reviewed-by:
-
Michael Thiessen authored
Implements LaunchCauseMetrics for launch types that don't involve intents - Recents, Back, and Power button. It's not possible to distinguish between Back and Recents in all cases. However, when the Activity is killed in the background, and then restored from Recents, Android adds a flag to the intent we can look at. Also, when Chrome does not receive a UserLeaveHint when going to the background, we can be sure that the Back button will not return the user to that Chrome Activity. We can detect resume by power button by looking at whether the screen is off when Chrome is paused. (If Chrome happens to be killed while the screen is off, the launcher is shown on screen on) These changes range from extremely difficult to impossible to integration test as you would need control of multiple apps for some, and the ability to manipulate the Recents screen in others. I've opted for unit testing here, and have manually tested every situation I could think of in both CTA and CCT. Bug: 1163961 Change-Id: I86a00dcf7333a22da724a1b26be2c5bcf5236cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625909 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843898}
-
Esmael El-Moslimany authored
The callout can be included in the initial OGB response. Whether or not a callout is included can depend on the number of impressions. By using the cached OGB, a user can see callout one more time than intended. Bug: b/176955522 Change-Id: I915370948339a8315a5024e79967defe5aa4c46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628743 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843897}
-
Benjamin Beaudry authored
This is a reland of 7d29603f Original change's description: > Expose NameProperty for listitems on UIA > > Elements with the listitem role should always expose their accessible > names with UIA. This was causing an issue with Narrator on Windows when > navigating by list item - Narrator would only announce "element x of N" > when it should actually announce "[listitem name], element x of N". > > This is per spec: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation/ui-automation-support-for-the-listitem-control-type > > Bug: N/A > Change-Id: I4f2d1a999d00cc8f5b23989d3ade90c907764152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610264 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#843553} TBR=nektar@chromium.org TBR=aleventhal@chromium.org TBR=vicfei@microsoft.com Bug: N/A Change-Id: I0e6484ac768c06c21782ec119772659071d60027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628022Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843896}
-
Keishi Hattori authored
Including const-char rewrites added lots of build errors and needs more time to be resolved. Bug: 1069567 Change-Id: Ib862d60d74c8501b937ad8071e3fc78d78b4054d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626691Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843895}
-
Jacques Newman authored
We currently dump when unserialize fails in BrowserAccessibilityManager::Unserialize, but I think having an aggregate count of each unserialization type will aid in catching and debugging these issues. Bug: 1131848 Change-Id: I32a122cfcc9d6f29bad69a4b8e8d022fd1518dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621958 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1164464 Change-Id: I1bc7f4b5aaa1a3d1cf1b484e9e116039458b51c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625975Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843893}
-
Liquan (Max) Gu authored
Motivation: Now, payment handler supports pages of any mime type on Android. This exposes payment handlers to the vulnerabilities of some less maintained mime-types. In order to make payment handlers safer to use, this CL limits the mime types of payment handlers on Android by allowlisting. Changes: * Moved the WebContents user data setting logic into markPaymentHandlerWebContents() to payment_handler_navigation_throttle.cc. * Let both Android & desktop's payment handler coordinators use the method to annotate a payment handler web-contents. * Moved the throttle from //chrome/browser to //components to make it more convenient to depend on. Bug: 1165367, 1159267 Change-Id: Ibc75bad9b47b2586e4222c2556c4bf6fb6bd28cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614918 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843892}
-
Dominic Mazzoni authored
Bug: 1161541 Change-Id: Ie6c0614bc7fc4c53e341639a0b2635dd8414362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622654 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843891}
-
David Black authored
Addresses two issues: 1. When shelf alignment/config changed any previews that were in the process of being removed were appropriately destroyed. However, we failed to call `OnOldItemsRemoved()` after so any new/existing items weren't animated/shifted into position. The result was missing and misplaced previews. 2. The translation calculation in `OnShelfConfigChanged()` was slightly off. Fixed with index based calculation. Bug: 1166804 Change-Id: Ifda6a6a4fa527bfc6753840a7257fc92c9446a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631293Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843890}
-
