- 04 May, 2018 40 commits
-
-
Joel Einbinder authored
Apparently run_layout_tests.py is being moved Change-Id: I2ff85e0203d87d8dde8b0937830593fe1a1fb849 Reviewed-on: https://chromium-review.googlesource.com/1045177Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#556205}
-
Ran Ji authored
Bug: 839964 Change-Id: I4fe48a721a878be716cc3fd2cc38fcf9ac3075a4 Reviewed-on: https://chromium-review.googlesource.com/1044953Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556204}
-
danakj authored
TBR=danakj@chromium.org Change-Id: I2d169b1bdd145e6a3a2471ac81e9cd8d4e7d8e73 Reviewed-on: https://chromium-review.googlesource.com/1045089 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556203}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/53d9b3ced389..870dc3a4f6b3 $ git log 53d9b3ced..870dc3a4f --date=short --no-merges --format='%ad %ae %s' 2018-05-04 dtu [pinpoint] Add `--benchmarks` argument for performance_test_suite. Created with: roll-dep src/third_party/catapult BUG=chromium:836037 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ic8df92913ae7d940a624b339e5cf1048ce54c2ae Reviewed-on: https://chromium-review.googlesource.com/1044778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556202}
-
Raymond Toy authored
These checks aren't needed because the dictionary members are required so the binding layer makes sure they exist before reaching the code. Hence the checks are dead. Bug: 838636 Change-Id: I467639134a813346c8857726de78a463d0468057 Reviewed-on: https://chromium-review.googlesource.com/1038150Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#556201}
-
Ian Vollick authored
In this change, I've moved the code in chrome_public_apk_tmpl from the monochrome to he chrome template and ensured that apk_merger will pass. > Define enable_arcore and add some build rules to use it. > > Bug: 833511 > Change-Id: I716123c2a282d7d123883df81ebbc00a0a883be8 > Reviewed-on: https://chromium-review.googlesource.com/1033580 > Commit-Queue: Ian Vollick <vollick@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Reviewed-by: David Dorwin <ddorwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555174} Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I155d420f3b6606642cdfea43db48840f2c21a0cb Reviewed-on: https://chromium-review.googlesource.com/1040905Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Devlin Cronin authored
ExtensionSyncData::OptionalBoolean was added before base::Optional<> existed. Now that we have base::Optional<>, we should just use that. Bug: None Change-Id: Ibf19830b6d7154be82f6a45f9b645b3055d2da3b Reviewed-on: https://chromium-review.googlesource.com/1044646Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556199}
-
Dave Schuyler authored
This CL removes a calls to hide/show the keyword elements that are no longer needed. It also adds a comment explaining the visibility setting on the enclosing view. Bug: None Change-Id: If97ce9ad97d8f2f0eb775989350306dddc7e07f9 Reviewed-on: https://chromium-review.googlesource.com/1043328Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#556198}
-
Christian Fremerey authored
* Move/rename class content::VideoCaptureGpuJpegDecoder to media::VideoCaptureJpegDecoderImpl and break dependencies to |content| in order to make it reusable for the video capture service. (I was unable to convince Gerrit that this is a move/rename. Sorry for this making it harder to review.) * Split Gpu memory buffer factory methods from interface ui.mojom.Gpu to new interface ui.mojom.GpuMemoryBufferFactory * Update class ui::ClientGpuMemoryBufferManager to depend on only the new interface ui.mojom.GpuMemoryBufferFactory. * Inject dependencies on ui.mojom.GpuMemoryBufferFactory and viz.mojom.GpuService from Browser into video capture service when starting up the service. * Enable the existing-but-disabled test cases for accelerated jpeg decoding in combination with video capture service Design Doc: https://docs.google.com/document/d/169LS3U0DD7hHpqZSli0gpCaCqE1eWN4QXFSIGoruPwQ/edit?usp=sharing Bug: 820608, 720604 Test: content_browsertests --gtest_filter=VideoCaptureBrowserTest.* Change-Id: Ic9860e4f846dc0abfc85fec673b1d9c15b99c7d1 Reviewed-on: https://chromium-review.googlesource.com/971302 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#556197}
-
John Chen authored
Incrase the timeout in ChromeDriverPageLoadTimeoutTest from 1 second to 3 seconds on Mac, due to observed flakiness on the waterfall. Change-Id: Iac63c20fb65a15a2126ecacdca948de38a64f830 Reviewed-on: https://chromium-review.googlesource.com/1042805Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556196}
-
Aldo Culquicondor authored
scrolling. This change will allow to only scroll the portion defined by the UX specs. Extra nit: use a simpler conditional in a shader. Bug: 839488 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ib5603d2b20786ccd07eb9bba0d31056f0ee1c54e Reviewed-on: https://chromium-review.googlesource.com/1044115 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#556195}
-
Kenneth Russell authored
Bug: 838895 Change-Id: I4e51e47ce1470ac2fcd8b8a6b465024d9b28b9b4 Reviewed-on: https://chromium-review.googlesource.com/1044750Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#556194}
-
Dave Schuyler authored
This CL avoids creating the right suggestion placeholder image for non- rich suggestions (where the image won't be shown). It also moves the placeholder code to a more appropriate file. (from OmniboxResultView to OmniboxMatchCellView. Bug: None Change-Id: If90e3ad4d4bd45aa80ae1e67a03b7c23437f616e Reviewed-on: https://chromium-review.googlesource.com/1043220 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
-
Donn Denman authored
Fixes a typo in a recent CL that broke scrolling up when the Overlay is maximized. BUG=835201 Change-Id: If70adb3578094cbd7264fcf5cc21f2ada6f2ef4c Reviewed-on: https://chromium-review.googlesource.com/1044945Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#556192}
-
Andrii Shyshkalov authored
Build has migrated to LUCI. R=danakj@chromium.org Bug: 839600 Change-Id: I15fab6330a0215b4edf14318993ae4608d269dbe Reviewed-on: https://chromium-review.googlesource.com/1044772Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#556191}
-
Raphael Kubo da Costa authored
Recent changes that removed some includes such as a92b7636 ("[MessageLoop] Fix random IWYU preventing message_loop.h cleanup") and 629ba73c ("[MessageLoop] Fix message_loop.h includes") have broken the build with libstdc++, as secure_display_link_tracker.h uses std::find() but relied on it being included implicitly by other headers: In file included from ../../base/memory/weak_ptr.h:77:0, from ../../content/renderer/media/stream/media_stream_video_source.h:13, from ../../content/renderer/media/stream/media_stream_video_source.cc:5: ../../content/renderer/media/stream/secure_display_link_tracker.h: In instantiation of ‘void SecureDisplayLinkTracker<T>::Add(T*, bool) [with T = content::MediaStreamVideoTrack]’: ../../content/renderer/media/stream/media_stream_video_source.cc:55:34: required from here ../../content/renderer/media/stream/secure_display_link_tracker.h:32:19: error: no matching function for call to ‘find(std::vector<content::MediaStreamVideoTrack*>::iterator, std::vector<content::MediaStreamVideoTrack*>::iterator, content::MediaStreamVideoTrack*&)’ DCHECK(std::find(insecure_links_.begin(), insecure_links_.end(), link) == ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:888:54: note: in definition of macro ‘DCHECK’ #define DCHECK(condition) EAT_STREAM_PARAMETERS << !(condition) ^~~~~~~~~ Bug: 819294 Change-Id: I1e747d7e15a7be74460012fbe5f207368744114b Reviewed-on: https://chromium-review.googlesource.com/1043749Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#556190}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15759121361d..142a92ce8b83 $ git log 157591213..142a92ce8 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 tandrii auth: request refresh tokens with expiry <3 minutes. Created with: roll-dep src/third_party/depot_tools BUG=chromium:837087 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Iecb1a28f1e5ffa180639739105193b8f4e5e26d5 Reviewed-on: https://chromium-review.googlesource.com/1044948 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556189}
-
Mikel Astiz authored
An unmapped tab can still have an associated |tab_node_id| (e.g. a foreign tab that has been closed), so the assumption behind the CHECK prior to this patch was wrong, and the implementation buggy. According to the reports we've investigated, this scenario occurs for both local and remote sessions. Bug: 837517 Change-Id: Ic436fe9eacce131fef5d0394bdfff34d9aedc5b3 Reviewed-on: https://chromium-review.googlesource.com/1044211 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556188}
-
Joel Einbinder authored
We were not considering that type attributes in scripts could be wrapped in quotes. Change-Id: Id2fd4859c1e1a68bd28bebe6fea46a62b58e417a Reviewed-on: https://chromium-review.googlesource.com/1043463 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
-
Dave Schuyler authored
This Cl resets the suggestion image so that the entity image is not seen in a non-entity result. Bug: 839578 Change-Id: I398aee581b559dd8a59ad2d55581f5d55cbbfea5 Reviewed-on: https://chromium-review.googlesource.com/1043101Reviewed-by:
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6993d7df263e1ffd1a10a4d11fe3b29a66f20f9c Reviewed-on: https://chromium-review.googlesource.com/1044710 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556185}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05cfcff70ced..b9a1e688fd9c $ git log 05cfcff70..b9a1e688f --date=short --no-merges --format='%ad %ae %s' 2018-05-04 liyuqian Respect SkBitmapDeviceFilteredSurfaceProps in SkThreadedBMPDevice 2018-05-04 benjaminwagner [infra] Move GCE tasks to smaller/larger VMs. 2018-05-04 bungeman Allow finer rotation in Viewer app. 2018-05-04 robertphillips Revert "Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2)" 2018-05-04 bsalomon Remove unused SK_DISABLE_ARC_TO_LINE_TO_CHECK build flag 2018-05-04 bsalomon Remove could not invert matrix SkDebugfs 2018-05-04 mtklein Don't use getDeviceClipBounds() to bound pic ops. 2018-05-02 herb Remove android specific code 2018-05-04 bungeman Avoid drawing BW clipped color glyphs many times. 2018-05-04 fmalita [skottie] Disable on Android Framework builds 2018-05-04 borenet [recipes] Remove core.setup() 2018-05-04 robertphillips Make degenerate kernel in fill_in_2D_gaussian_kernel sum to 1 2018-05-04 robertphillips Fix a bug in SkGpuBlurUtils::GaussianBlur (take 2) 2018-05-04 caryclark Revert "Reland "remove obsolete color defines"" 2018-05-04 bsalomon Make RenderDoc work automatically with GLX viewer Created with: roll-dep src/third_party/skia BUG=chromium:836113 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ia3664eaddce0f59e7cb22413152bbe6375884eec Reviewed-on: https://chromium-review.googlesource.com/1044782 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556184}
-
Peter K. Lee authored
This CL adds small tweaks to the UI and layout to bring infobar closer to Phase 1 design. Bug: 804652 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib8da40c032387eb9f7f06ad60e6c3283dea56bf8 Reviewed-on: https://chromium-review.googlesource.com/1036541 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556183}
-
Jinsuk Kim authored
This CL handles the remaining UI events(scroll/generic motion events) by forwarding them to native first like the others. They are later consumed by content components such as JoystickHandler or converted to other events. ContentUiEventHandler does the conversion when necessary, and sends the events down to the associated RenderWidgetHostViewAndroid rather than putting them back on the view android tree since we are already at the point of having found the event handler that will consume them. Bug: 622847 Change-Id: I8aba396c0545cdc8ae3a6f566da54c2707a460c4 Reviewed-on: https://chromium-review.googlesource.com/999236Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#556182}
-
Toni Barzic authored
Currently, AppLaunchController assumes that AppLaunchSplashScreenView, owned by OobeUI, is around during AppLaunchController destruction. Both AppLaunchController and OobeUI lifetime is controlled by LoginDisplayHost, but OobeUI is technically owned by login window (which gets created by LoginDisplayHost, and closed on LoginDisplayHost destruction). Whether AppLaunchController get deleted before or after AppLaunchSplashScreenView largely depends on how the login window is closed/destroyed - generally the window is destroyed asynchronously when LoginDisplayHost goes out of scope, in which case AppLaunchController is deleted before the splash screen view, but this does not seem to be guaranteed. For example, in AutoLaunchedNonKioskEnabledAppTest.NotLaunched test with mash enabled, oobe_ui gets deleted synchronously when ScopedKeepAlive owned by LoginDisplayHostCommon gets deleted (which happens before the AppLaunchController is deleted) - ScopedKeepAlive going out of scope causes MusClient to start closing all widgets. To work around this have AppLaunchSplashScreenView notify its delegate (i.e. AppLaunchController) when it gets deleted, so the delegate can stop referencing it when that happens. Technically, the linked bug could be fixed by ensuring that app launch controller is deleted before ScopedKeepAlive, but that seems more fragile, and it doesn't necessarily address all concerns (e.g. the case where login window is removed for a reason other than login display host destruction). NOTE: The same applies to the ArcKioskController and ArcKioskSplashScreenView. Bug: 838992 Change-Id: I9b31293e791c1f8980e780e69f6061f87a968095 Reviewed-on: https://chromium-review.googlesource.com/1041485Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#556181}
-
rodmartin authored
The test was taking too much time in debug mode. This CL improves the time needed to test by not editing the session using the UI. Change-Id: I9809dc08b15deb988f3bbc09b00d3f4ba0a5eda8 Reviewed-on: https://chromium-review.googlesource.com/1042998 Commit-Queue: Martin Rodriguez <rodmartin@google.com> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#556180}
-
Min Qin authored
Splits downloadEntry into UkmInfo and InProgressInfo, added new information needed to resume the download item after chrome crashes. Bug: 803135 Change-Id: Ided64d9801a3e8e1d8390a4190d17aa3b58d652c Reviewed-on: https://chromium-review.googlesource.com/1036539 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#556179}
-
Dan Sanders authored
Bug: 522298, 839951 Change-Id: I106c081d21c69b3802d4e50ce8ce74f54f6590b1 Reviewed-on: https://chromium-review.googlesource.com/1043252 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556178}
-
Eric Orth authored
Created as two separate methods, one for reports and one for clients, to avoid polluting the interface with a data_type_mask as is used internally. Also, to avoid dealing with confusing difference between always-true filter and null filter when they should logically be equivalent, cleaned up ReportingCache to explicitly have two separate clear data methods, one that clears everything without filter and one that always assumes it has a valid filter. Bug: 824997 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If8fc3698eb61efbdee566dbd55e649723ff1e3d8 Reviewed-on: https://chromium-review.googlesource.com/1038524 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
TARGET_AND_DESCENDANTS event targeting policy does not work properly under mus/mash. As a result, mouse events are not delivered to the windows under ExoShellSurface in SystemModalContainer even though ExoShellSurface says it does not handle the events. Use DESCENDANTS_ONLY for mus/mash until event dispatching code is fixed to handle such case. Bug: 839521 Change-Id: I8e949164d2cd9666468a8995d0bdb8e29f6b9301 Reviewed-on: https://chromium-review.googlesource.com/1044542 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556176}
-
kylechar authored
Add a manually triggered GPU trybot that runs the same configuration as "Win7 FYI Release (NVIDIA)". Bug: 838895 Change-Id: I2a2f87ee7b452200a860282b01c673493adbea00 Reviewed-on: https://chromium-review.googlesource.com/1044767Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#556175}
-
Wenzhao Zang authored
1) Update the UI to be the same with the web-ui implementation. 2) Add a button to lock_debug_view.cc|h for easy debugging. Bug: 836336 Change-Id: I89143c7db149dea31bc6848de18e6ecc6386f98b Reviewed-on: https://chromium-review.googlesource.com/1044746Reviewed-by:
-
xlai authored
The previous flakiness might be a device-specific issue that is seen in Intel HD 530 but not Intel HD 630. Bug: 690663 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I18b2c9822bf39cfbcd233e2219ac460eb51875b6 Reviewed-on: https://chromium-review.googlesource.com/1044656Reviewed-by:
-
Roger Tawa authored
This CL simply adds the new policies and hooks them up the appropriate local state preferences. A follow up CL will start using the policies to control chrome behaviour. Bug: 834939 Change-Id: If8a0984a118383a375f2a72c71f0b1cf555fbb6a Reviewed-on: https://chromium-review.googlesource.com/1032797Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Robert Shield <robertshield@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#556172}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4135777822e41a928906e5d42308afd36f8ee40f Reviewed-on: https://chromium-review.googlesource.com/1044290 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Serial kernel logging is a deprecated feature of Zircon and should not be used anymore. This uses a long-running SSH invocation of "dlog" to pull the logs over the wire. It works equally well on QEMU and on devices. Created a stream multiplexer using "poll" to merge the kernel log and application log into a single stream, which is passed to the symbolizing filter. Modified the symbolizer regex rules to allow kernel log timestamps. Kernel log timestamps can be omitted from the output, but they seem to be helpful at visually distinguishing kernel output from app output. Bug: 838671 Change-Id: Icd45f902a49983b4e4ee262de474d69fbef56860 Reviewed-on: https://chromium-review.googlesource.com/1038423 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556170}
-
Gabriel Charette authored
I intentionally didn't add "Foreground" to non "Background" workers as they may be used for background tasks in some configurations and I don't want it to be confusing for developers. R=fdoray@chromium.org Bug: 839525 Change-Id: I8c1e928914aa6d2e35fedc1db4e8a639d39116b2 Reviewed-on: https://chromium-review.googlesource.com/1044501 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#556169}
-
Raphael Kubo da Costa authored
https://chromium-review.googlesource.com/c/chromium/src/+/705955 ("base::flat_map was missing defaults for duplication handling") removed them in favor of inheriting them from flat_tree. This can cause problems with GCC due to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84782, and the build has been failing with it since https://chromium-review.googlesource.com/1000393 ("Mojo C++ Bindings: unordered_map => flat_map") with a message like this: gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc: In member function ‘void mojo::test::ObjectUnion::set_f_map_int8(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’: gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:455:30: error: use of deleted function ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’ std::move(f_map_int8)); ^ In file included from ../../mojo/public/cpp/bindings/clone_traits.h:11:0, from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.h:22, from gen/mojo/public/interfaces/bindings/tests/test_unions.mojom.cc:15: ../../base/containers/flat_map.h:152:7: note: ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>::flat_map(const base::flat_map<std::__cxx11::basic_string<char>, signed char>&)’ is implicitly declared as deleted because ‘base::flat_map<std::__cxx11::basic_string<char>, signed char>’ declares a move constructor or move assignment operator class flat_map : public ::base::internal::flat_tree< ^~~~~~~~ Work around it by replacing the inheritance statements with actual constructors and operator=() overloads again. This change does not completely revert https://chromium-review.googlesource.com/1000393, as the constructors maintain their new signature (so that they look like flat_tree's). Bug: 819294, 837221 Change-Id: I8f37a2c8aa269b3c1025cdc009518a7709e95947 Reviewed-on: https://chromium-review.googlesource.com/1038103 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Emircan Uysaler authored
We should set this field to distinguish HW codec implementations of Chromium from SW codecs of WebRTC. googCodecName field already sets VP8/VP9/H264 information, so setting this field to a generic name "HW*coder" should be enough. Bug: 838739 Change-Id: I9936daef9a53b6f004ede357e37fd976ca0d9c9e Reviewed-on: https://chromium-review.googlesource.com/1039023 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
-
Victor Costan authored
Bug: 829893 Change-Id: I245991138fe88d662d374ec2fe45e08424bd1366 Reviewed-on: https://chromium-review.googlesource.com/1036861Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#556166}
-
