- 18 Jul, 2017 40 commits
-
-
Derek Cheng authored
- Replace 2 instances of WeakPtr usage in DialServiceImpl with a CancelableTaskTracker to track thread-hopping calls to obtain network interfaces. - Replace the callbacks bound to DialServiceImpl using WeakPtr passed to DialSocket with a raw pointer DialServiceImpl. This is safe because DialServiceImpl owns DialSockets. - Remove WeakPtrFactory from DialServiceImpl. Bug: 735590 Change-Id: I4965a33a7a706b057ee7d0f4c5cb6fb98b06dbc2 Reviewed-on: https://chromium-review.googlesource.com/574993Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#487595}
-
Mihai Sardarescu authored
If the token service has already a refresh token for the authenticated account before this account is signed in to Chrome, then |OnRefreshTokenAvailable| notification will not be called after |OnActiveAccountLogin|. This CL changes the TiclInvalidationService to handle the case when the refresh token is already present when |OnActiveAccountLogin| is fired. See bug for the link to the design document. Bug: 733226 Change-Id: I205e522ebe75c059b9125e113f451cf328a2f564 Reviewed-on: https://chromium-review.googlesource.com/559537Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#487594}
-
zijiehe authored
After this change, users can define a repeated field in protobuf, message Message { repeated <type> foo; } and use GetParamSize(sizer, p.foo()) WriteParam(m, p.foo()) and ReadParam(m, iter, r->mutable_foo()) to serialize and deserialize the field. Serializing and deserializing a RepeatedField / RepeatedPtrField are needed in change https://codereview.chromium.org/2964613002/. BUG=650926 Review-Url: https://codereview.chromium.org/2968003005 Cr-Commit-Position: refs/heads/master@{#487593}
-
Weidong Guo authored
Changes: 1. Make the dots of pagination switcher centered vertically on AppsGridView no matter their number. Spec: https://screenshot.googleplex.com/QHkyJRGmz46 Screenshot: https://screenshot.googleplex.com/MLduTvsXwcf BUG=741007 Change-Id: I5305267af35b21ba3446424c3bedc8d2eab8615d Reviewed-on: https://chromium-review.googlesource.com/576249Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487592}
-
Eric Roman authored
Only read 64KiB of the events file at a time. Bug: 679030 Change-Id: If063b547d547240f79024350c1cead13e0f6426e Reviewed-on: https://chromium-review.googlesource.com/572185 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487591}
-
mmenke authored
BUG=734199 Review-Url: https://codereview.chromium.org/2978443002 Cr-Commit-Position: refs/heads/master@{#487590}
-
Robert Liao authored
BUG=706512 Change-Id: Ib252b2e692f36494e829eeefdb9664fb82f34909 Reviewed-on: https://chromium-review.googlesource.com/576309Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#487589}
-
Sebastien Marchand authored
zap_timestamp.exe doesn't support the 64-bit binaries. the build_bitness function comes from https://cs.chromium.org/chromium/src/chrome/test/chromedriver/util.py?l=45&rcl=ffe66181996a36f5d64e507dbd3dcd78dc1ebecb Bug: 705133 Change-Id: Ie17e963d62bd3ac508b0de8a853f6d653ef2454b Reviewed-on: https://chromium-review.googlesource.com/576188 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487588}
-
Cheng-Yu Lee authored
easier comparison. Before this change, MemoryKillsMonitor only reports kill events when it happens. So it is hard to compare sessions with kill events and those not. Before this CL, the monitoring starts when session manager starts (e.g., when the login screen is present but not logged in). So simply report a zero kill event at that time is not ideal because it would bloat the actual number of user sessions. In this CL, the monitoring starts when user has logged in. So it reflects actual user sessions. Bug=b:62499558 TEST=manual + cheets_LowMemoryKiller Change-Id: I98cc14e4346e6883dacfe063366c78bc771750cc Reviewed-on: https://chromium-review.googlesource.com/541200 Commit-Queue: Cheng-Yu Lee <cylee@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487587}
-
Benjamin Pastene authored
This includes: mojo_system_unittests mojo_test_apk services_unittests components_unittests (2 shards) content_unittests content_shell_test_apk (3 shards) net_unittests (3 shards) unit_tests (2 shards) ... and also all the dbg browserside-navigation versions of the tests. Increased device pool with https://chrome-internal-review.googlesource.com/c/412868/ Will increase more if needed. Bug: 670879 Change-Id: I6da4efe9588c9eae06eb26d5cbe1d62da4f27a65 Reviewed-on: https://chromium-review.googlesource.com/575360Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#487586}
-
Charles Harrison authored
Bug: 736249 Change-Id: Id69d62b7f0d3f6e7f41bf8d2fe713e3296b6e496 Reviewed-on: https://chromium-review.googlesource.com/567260 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Cr-Commit-Position: refs/heads/master@{#487585}
-
liberato@chromium.org authored
This reverts commit f4c20b08. Now that gles2_cmd_decoder deletes the group before |surface_|, we shouldn't need to handle this case. Bug: 718117 Change-Id: Ia2808674fc91d7b1d43525397d6e598f483d0909 Reviewed-on: https://chromium-review.googlesource.com/576060Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#487584}
-
dpapad authored
Also remove the deprecated files from polymer_resources.grdp since they are not needed anymore. Bug: 744902 Change-Id: I35ab3bbbb2e9d42758430672aba4736393e6056d Reviewed-on: https://chromium-review.googlesource.com/575388 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487583}
-
Jian Li authored
Also add the logic to skip the redirect to itself if such old data was found in the metadata store. BUG=741197 TEST=new tests added Change-Id: I006104b2716baf68303f99c035ea628d45dffdc0 Reviewed-on: https://chromium-review.googlesource.com/572601 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#487582}
-
Bin Zhao authored
- All classes under extensions/browser/api/cast_channel/ use namespace extensions - Auto generated code (cast_channel.h) from cast_channel.idl uses namespace extensions::api Bug: 731189 Change-Id: I8b658f909296ecab8dd9c99e3845adf1ff1389d8 Reviewed-on: https://chromium-review.googlesource.com/574968Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487581}
-
Mathieu Perreault authored
TBR=tedchoc Bug: 744962 Test: browser_tests Change-Id: I3d1c8aa4f782aad1a64b5478095868c3b6704c45 Reviewed-on: https://chromium-review.googlesource.com/575396 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Anthony Vallee-Dubois <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#487580}
-
Chris Harrelson authored
Bug: 742413 Change-Id: I43129261e2c69d32b4e2b31a66d6d4f3bef52a36 Reviewed-on: https://chromium-review.googlesource.com/571417Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487579}
-
Mike Bjorge authored
This test is failing on v1 devices. Disable the test temporarily to get the dashboards green again so this failure doesn't mask other failures. Should get re-enabled once the test issue is resolved. BUG=744777 TEST=midi_unittests Change-Id: I4db7b1fdb7ce9b73f8e9cf161b4080cf9e10f143 Reviewed-on: https://chromium-review.googlesource.com/575197Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#487578}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0aa492d0f47d..c432b0ca8a50 $ git log 0aa492d0f..c432b0ca8 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 ethannicholas fixed use-after-free in sksl switch statements 2017-07-18 mtklein minor fixes to start_pipeline_lowp 2017-07-18 rmistry Do not move over webpage archives, they are needed for capturing SKPs 2017-07-18 csmartdalton Add two test bots for coverage counting path renderer 2017-07-18 bsalomon Revert "Improvements to GPU dither." 2017-07-18 bsalomon Improvements to GPU dither. 2017-07-18 reed guard references to SkColorTable 2017-07-18 halcanary Commit Queue: add Build-Debian9-GCC-arm-Chromecast 2017-07-18 ethannicholas added sksl support for integerSupport cap 2017-07-18 halcanary Revert "Revert "SkPDF: Non-outline glyphs as images"" 2017-07-17 bsalomon Make dither range symmetric about 0 Created with: roll-dep src/third_party/skia BUG=705480 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Id6ec92583056ae097a9c2f3755b844337c5f5a43 Reviewed-on: https://chromium-review.googlesource.com/576075Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487577}
-
Maajid authored
TEST: Unit tested, device tested with --enable-features=EnableFullcreenAppList Bug: 737611 Change-Id: I05727c4266b69ab33f22a09ecc582ac920d8ec8a Reviewed-on: https://chromium-review.googlesource.com/572548 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#487576}
-
Xing Liu authored
Since network change notifier triggers observer call before we can establish connection to server when the device comes online, the first download attempt in download service will always fail. This CL adds a delay to notify download service to do stuff after the device becomes online. Bug: 736046 Change-Id: Ibfb31ed4c993f41a960429b5590e2cc083dbe229 Reviewed-on: https://chromium-review.googlesource.com/567587 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#487575}
-
Eric Roman authored
The directory-based file layout for bounded mode logging is a now an internal detail rather than part of the API contract. The result of logging, whether in bounded mode or unbounded mode, is now a single file using the same format. This makes it possible to use either bounded or unbounded mode and get a compatible result. Bug: 679030 Change-Id: I501911678a98c14a3907d1407a91aabcbfa31d62 Reviewed-on: https://chromium-review.googlesource.com/570887 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#487574}
-
minch authored
Swiping up on the System Tray/ IME/ Stylus/ Notifications buttons in status area should open the associated bubble. Swiping down on the opened bubble should close the associated bubble. Changes: 1.Added the tray_drag_controller to extract the logic of dragging behavior from system_tray. 2.Added help functions in tray_background_view to get the state of associated tray bubble. 3.Added one interface ProcessGestureEventForBubble in TrayBubbleView::Delegate to help process the dragging that happened on the tray bubble. BUG=735994,735996 Review-Url: https://codereview.chromium.org/2961313003 Cr-Commit-Position: refs/heads/master@{#487573}
-
Chris Harrelson authored
software transforms. Bug: 740273 Change-Id: I30bed13de22c3edece852c4bae30870e41c535c6 Reviewed-on: https://chromium-review.googlesource.com/575547Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487572}
-
Justin Carlson authored
Bug: 742487 Change-Id: If9d1b44ee3c967122fb21591c06117ea6709e767 Reviewed-on: https://chromium-review.googlesource.com/574893 Commit-Queue: Justin Carlson <justincarlson@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#487571}
-
Ira Burak authored
Bug:744672 Change-Id: Iccb9cfade3b5e39e489adbeb0c2b6a2509240afc Reviewed-on: https://chromium-review.googlesource.com/576063 Commit-Queue: Ira Burak <iburak@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#487570}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b906454a..d5a706d5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I0589f4395cbd6534dca36ac260f9a7c36fb1c1f6 Reviewed-on: https://chromium-review.googlesource.com/576289Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487569}
-
John Abd-El-Malek authored
Change-Id: Ib6ee2044f8d553bb4e96feab509e0e987976665e Reviewed-on: https://chromium-review.googlesource.com/575911Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#487568}
-
Selim Gurun authored
Add a whitelisting manager for safebrowsing. This code will be plumbed to an Android WebView API so that applications can whitelist (i.e. prevent) domains from being checked by Safebrowsing logic. The main rules are: - if host has a leading ".", it needs to be exact to be whitelisted. - if host does not have a leading ".", subdomains are also whitelisted. Invalid schemes are also ignored. Note that Safebrowsing only works on h ttp/https and in future ws urls. Bug: 726770 Change-Id: Icbffebd87472286508f1902cd6323ce58faee797 Reviewed-on: https://chromium-review.googlesource.com/563520 Commit-Queue: Selim Gurun <sgurun@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487567}
-
Alexei Filippov authored
Bug: 739865 Change-Id: Ifd4d628816afafe5425c4beb6c4311c7a6465c3d Reviewed-on: https://chromium-review.googlesource.com/562560Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487566}
-
Xiaohui Chen authored
BUG=b:62276007 TEST=locally build and flash, start voice interaction before arc ready Change-Id: Ie8d3489f2d4f7b08830dbf7b384e67d0dfab537b Reviewed-on: https://chromium-review.googlesource.com/575524 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487565}
-
David Trainor authored
As part of the effort to build in recovery states to the controller, we need to add a basic state machine so it's possible to control the new set of states: CREATED, INITIALIZED, READY, RECOVERING, and UNAVAILABLE. BUG=736222 Change-Id: I22811afece7f7d491c235247c33ba593f142bbc1 Reviewed-on: https://chromium-review.googlesource.com/567652 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487564}
-
Iulia Harasim authored
This CL adds signin_promo_view and SigninPromoView Java counterpart that are necessary for new signin promos on Android. This view will be wired-up in the following CLs. Bug: 737743 Change-Id: If3c34fc48d6ab91eff5e03ab6de5e1101b3df693 Reviewed-on: https://chromium-review.googlesource.com/566678Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Iulia Harasim <iuliah@google.com> Cr-Commit-Position: refs/heads/master@{#487563}
-
Alexei Filippov authored
TBR=rogerta NOTRY=true Bug: 745899 Change-Id: I04c8e24149b278a16e2cf14762ca965c91b8cec3 Reviewed-on: https://chromium-review.googlesource.com/576381 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487562}
-
Amber Won authored
Create PDF placeholder in ChromeContentRendererClient when the enable_plugins build flag is off. Tested manually on mobile. Bug: 737787 Change-Id: Iddb276b8ce71c92ee7fb626115269f2730b8b943 Reviewed-on: https://chromium-review.googlesource.com/575190 Commit-Queue: Amber Won <amberwon@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#487561}
-
Sergey Ulanov authored
Bug: 737802 Change-Id: I5b1d11793f4edd19e9cb8b0d3435689b3b77f827 Reviewed-on: https://chromium-review.googlesource.com/574891 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#487560}
-
James Cook authored
Historically //ash has been inconsistent in its placement of FooTestApi, TestFooDelegate, MockFoo, etc. Top-level ash OWNERS have decided that this sort of test code should live in the same directory as Foo, not in //ash/test. Move the files, collapse //ash/test/BUILD.gn into //ash/BUILD.gn and add a note to //ash/README.md TBR=reveman@chromium.org Bug: none Test: compiles, ash_unittests Change-Id: I22b556742c37f9a414824d2ce48f3fa261949b71 Reviewed-on: https://chromium-review.googlesource.com/576142 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487559}
-
Bence Béky authored
* Create NetLog event for sending and receiving an HTTP/2 SETTINGS frame with the ACK flag set. * Make BufferedSpdyFramerVisitorInterface an actual interface: all public methods are now pure virtual. * Remove HostPortPair parameter from HTTP2_SESSION_RECV_SETTINGS event: this is leftover from SPDY, but in HTTP/2 it's always the same as the one logged from the constructor. Change-Id: I16b5c226a2e5b167740a8c80f86920647d34c787 Reviewed-on: https://chromium-review.googlesource.com/570620Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487558}
-
Steve Kobes authored
Since r481209, the document creates composited scrolling layers with RLS even if it doesn't overflow. But PaintLayer::GetBackgroundPaintLocation didn't get the memo. Bug: 741858 Change-Id: I1fe09532eecc2bbd1b71c42e171bf86f4a893382 Reviewed-on: https://chromium-review.googlesource.com/570940Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#487557}
-
Scott Violet authored
The DCHECK is because on observer is being added but not removed. Specifically exo's WmHelper installs an observer on WindowTreeHostManager but WmHelper never removes itself (because WindowTreeHostManager is deleted before WmHelper). This patch makes WmHelper be destroyed before WindowTreeHostManager by way of making ChromeBrowserMainExtraPartsAsh create exo related functionality. BUG=none TEST=none Change-Id: I84e7209c817e4687017edbc14db7f75cb1054fbb Reviewed-on: https://chromium-review.googlesource.com/572427 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487556}
-