- 09 Oct, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e078093198e5..fc8f5e0ae349 2020-10-09 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 090102a7 to 77bfcdcd (466 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I59d6f8e54cbe287ba3d0cc3bdfe7e236703e3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815571}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1602179909-18dbc89acedf4f15864b841a6fe7487536bbc059.profdata to chrome-win64-master-1602212356-910f3b9c14ad8fb9eb002bc49aff02d2bc68cf6f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib573b283a4571f70d3962d6cedcc056979fe5a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462583Reviewed-by:
-
Simon Zünd authored
Design doc: http://bit.ly/devtools-trust-tokens The Trust Token API has some parameters that can be passed to a corresponding fetch or XHR request (or iframe). This CL surfaces the parameters as understood by the backend as part of the Network.Request CDP structure. R=sigurds@chromium.org Bug: chromium:1126824 Change-Id: I9cf4b1f17dc3b2f193b900eb26cfc9e11964f56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448370 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#815569}
-
sandromaggi authored
This change adds the non-padded month for credit card expiry to deal with forms where the month is "1" for January (instead of "01"). Bug: b/168227057 Change-Id: Ibf030936e638ea5df57fe8e3da36fe6cf06589ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461314 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#815568}
-
dpapad authored
Specifically removing logic related to handling <if expr> and <include> tags, which seems to only be triggered by tests, and nowhere in prod code. Bug: 1135226 Change-Id: I7d362420e0d94df3c29e6f646cfe25acc5d23e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448658Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815567}
-
Antonio Sartori authored
This CL attaches a PolicyContainer to a NavigationRequest. For a local scheme navigation, the NavigationRequest is initialized with a copy of the initiator's PolicyContainer, it gets a new PolicyContainer. At DidCommitNavigation time, the NavigationRequest's PolicyContainer is moved into the target RenderFrameHostImpl. Change-Id: I66bb4950c9939a9a81227025549d860ec8c461df Bug: 1130587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424147 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815566}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd9afd0a756b..78768c9a86bf 2020-10-09 patrick.brosset@microsoft.com Network: Make the initiator column jump to the right position 2020-10-09 patrick.brosset@microsoft.com Track clicks on var() function links If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124707,chromium:1134064 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id2194f1698799529497ed831f5e6f49b47655bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463179Reviewed-by:
-
Morten Stenshorne authored
Create additional legacy fragmentainer groups when necessary, i.e. when contiguous column content (i.e. without intervening spanners) is laid out over multiple outer fragmentainers. We also need to include block-size consumed in previous outer fragmentainers, since the legacy engine expects everything to be in the flow thread coordinate space. Correct legacy write-back is necessary for position querying DOM APIs, such as offsetLeft and offsetTop. Bug: 829028 Change-Id: If6adaa0d6324376061e66a3fa73403c008559b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450097 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#815564}
-
Kent Tamura authored
Port LayoutTextControlMultiLine::NodeAtPoint() to LayoutNGTextControlMultiLine. - Make LayoutTextControl::HitInnerEditorElement() public and static in order to share it with LayoutNGTextControl*. This CL fixes the following web tests with LayoutNGTextArea flag: - fast/events/inputevents/inputevent-drag-drop.html - fast/forms/input-readonly-select.html - fast/forms/textarea/drag-into-textarea.html - fast/forms/textarea/drag-out-of-textarea.html This CL has no behavior changes. The flag is not enabled yet. Bug: 1040826 Change-Id: Ia369377659d78476302f8c4b7e32532d60f938f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463007 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#815563}
-
Elizabeth Popova authored
Testing of shopping websites in these countries has shown that most address forms do not contain ZIP or State field. It was preventing addresses from being saved. See go/manual-autofill-test-q4-2020. Change-Id: Iee397c8a5bf5f9bfbda0ecce3ef0ed3f1556687f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461732Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#815562}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7c2d888fdffc..2bf76269e147 2020-10-09 treehugger-gerrit@google.com Merge "Added key navigation for flow events" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I0af82dc6dc85d361a213363d5e8cc336062a2b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463176Reviewed-by:
-
Colin Blundell authored
I happened to notice that these are not referenced anywhere (I built chrome_apk and chrome_test_apk as well). Change-Id: I5cfe0bb106880bacaef718d6bb4e382055d47a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461229 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#815560}
-
Tommy Steimel authored
This CL adds a new icons.js file to the Kaleidoscope WebUIDataSource. Bug: b:150614426 Change-Id: Id3f57e4ae61d69bf863c3446b142f0de3ee7c619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460979Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815559}
-
Ben Reich authored
Set callCount to true to capture the number of times a JavaScript code block is invoked during execution. Minor: remove unnecessary blank line. Test: browser_tests --gtest_filter="*FilesApp*" --devtools-code-coverage Bug: 1113941 Change-Id: I6a934708db329f7095146331322c07b7bf631043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462828 Auto-Submit: Ben Reich <benreich@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#815558}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/fc8264854c53..c2553a315f5c 2020-10-09 afdx@google.com spirv-fuzz: Do not expose synonym facts for non-existent ids (#3891) 2020-10-08 afdx@google.com spirv-fuzz: Do not add synonyms involving irrelevant ids (#3890) 2020-10-08 afdx@google.com spirv-fuzz: Do not replace irrelevant ids that are not in blocks (#3892) 2020-10-08 afdx@google.com spirv-fuzz: Wrap OpKill and similar in function calls (#3884) 2020-10-08 dj2@everburning.com Update val to handle reversed instruction sections. (#3887) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: I143ae1774eb7378db1aa9fb8253111d06f6d42bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463175Reviewed-by:
-
Sylvain Defresne authored
Recent refactoring moved this code out of TabModel in multiple object. The navigation_item initialized here is not used. The code using it is in OmniboxGeolocationTabHelper. Bug: none Change-Id: I4ca760b95e6f5882c4783d4e65f1c1036998176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461232Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#815556}
-
Olesia Marukhno authored
Instead of using dark/light theme coloring from MdTextButton, use colors of the omnibox. We need to do this because omnibox follows NTP "Customize" color picker. Bug: 1133851 Change-Id: I2e9bb636f6a724ee5b9ccd1887cf31bda32a70aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442537Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#815555}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ice87171a78fdc852e073d913c87e9e0eba986a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458909Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815554}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: I7971bff40d0fe6f1f567b1aee963d3d5811feb54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459052Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#815553}
-
Leszek Swirski authored
Guard the 'testing' import (and therefore all tests) behind build_with_chromium, so that projects using the chromium absl build (e.g. V8) don't have to add a dependency on 'testing'. Change-Id: Ie4427fe1aebddd14a0c773fa1bc5938e56d6d193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461312 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#815552}
-
Patrick Brosset authored
Now that we have links in var() functions in the Styles panel of DevTools to allow users to jump to where custom properties are defined it becomes more interesting to track if people actually edit those properties. This change adds a new state to the DevToolsAction enum so we can record when users click these links. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2458452/ Bug: 1124707 Change-Id: I07a798ee97a1266787aa0fc8a0bd07278348dd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458766 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#815551}
-
Steven Bennetts authored
Some removal of DictionaryValue and unique_ptr<Value> usage in onc::ReadDictionaryFromJson and related ONC code. Bug: None Change-Id: I92446aca5bc3e1922a5a6bdfb0776e5cd18a242c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453798 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#815550}
-
Omar Morsi authored
Before this CL, PlatformKeysService::GetAllKeys might return keys that belong to the arc-oemcrypto daemon. These are now being explicitly left out. Bug: 1135081 Change-Id: Ie3f321ee789e0dc4d18476d2316897cb4a6514bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448494 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#815549}
-
Zhaoliang Ma authored
This CL replaces memcpy with libyuv::CopyPlane since the copy processing is the same as libyuv::CopyPlane. Bug: None Change-Id: Ib9f4e476ea2e18de5cf99c8c97e665f7ed3d1996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439679Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhaoliang Ma <zhaoliang.ma@intel.com> Cr-Commit-Position: refs/heads/master@{#815548}
-
rbpotter authored
This overrides the file path for the resource (i.e. the |name| property in the GritResourceMap struct) when constructing the resource map, if it is provided. Bug: 1132403 Change-Id: I7ef57c6b037fe6b5c4019da8bc0927e4fac9645b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454631 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#815547}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/952149303d06..51b03d58fb17 2020-10-09 bclayton@google.com SpirvShaderDebugger: Fix store() of arrays 2020-10-09 bclayton@google.com SpirvShaderDebugger: Improve ASSERT() messages If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8239f8698386ccf8183d55249328c1b9b6e7c129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462780Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/898333a6b68f..fd9afd0a756b 2020-10-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-10-09 szuend@chromium.org [ts] Type-check network/EventSourceMessagesView.js with TypeScript 2020-10-09 szuend@chromium.org [ts] Type-check network/ResourceWebSocketFrameView.js with TypeScript 2020-10-09 szuend@chromium.org [ts] Type-check network/NetworkSearchScope.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I270744b07986bc5eb36b4a4294566a442a608886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463163Reviewed-by:
-
Tomasz Tylenda authored
TESTED=build Bug: 730593 Change-Id: Icecb1ce729c82ec02538ed04d642841be12d0799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463025Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#815544}
-
sandromaggi authored
The namespace was in CamelCase by accident. Bug: b/168107066 Change-Id: Id434bc76aebe2d6c548b61a218e01bbd1772e34d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461120Reviewed-by:
Luca Hunkeler <hluca@google.com> Reviewed-by:
-
Jazz Xu authored
This CL fix the issue where volume slider is hidden in CrOS file manager quick view. This CL also removes pointer CSS as it was implemented in native controls. Bug: 945799 Change-Id: I944b6fc921e55d82c9b016a9338420b7f9a17fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462050 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602201537-8720b3c79a1854f8e56100a84c355502c0dbbf4a.profdata to chrome-linux-master-1602223197-364fdfa1722fdc996604dcc9a9de521cd4c0c0ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6b61ba970637d18e90549c254c53266d089a7d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463169Reviewed-by:
-
Victor Costan authored
Chrome used the default SQLite configuration where databases were first opened in the NORMAL (not exclusive) locking mode, and then databases that opt in were switched to the EXCLUSIVE locking mode via a "PRAGMA locking_mode" statement. This CL switches the default. Databases are first opened in EXCLUSIVE mode by changing the SQLITE_DEFAULT_LOCKING_MODE build configuration macro. Databases that don't opt into exclusive mode are switched to the NORMAL locking mode via a "PRAGMA locking_mode" statement. This CL should not introduce any behavior changes in most cases. The result of the "PRAGMA locking_mode" statement was previously ignored, and is now checked. So, if the desired locking mode cannot be set, sql::Database::Open() will now fail. In the long run, Chrome's SQLite usage should be migrated to use the exclusive locking mode, for the benefits outlined in https://crbug.com/1120969. When that happens, the "PRAGMA locking_mode" can go away. Bug: 56559, 1120969 Change-Id: Ia9ac996fae45890bb5ca11168422e15e594087ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460982 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#815540}
-
George Burgess IV authored
This new clang-tidy check complains when param names /*in_comments=*/ don't match up with the actual parameter name they're being passed to. Sometimes this is benign, other times, actual bugs are found. Bug: 1136209 Change-Id: Ib93e421e0b119ca2acb4541d926d73d6bc352996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458910 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#815539}
-
Peter Kasting authored
Bug: 772945 Change-Id: I81d45dbfefbf4b4f0e66ece5a815c729cba01c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461208 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#815538}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602201537-11aed398f2fb6b4c095a189eb8886f38c679c48f.profdata to chrome-mac-master-1602223197-d9c33dbbd5ccae4e4a4bd70010f4c3ef94132fb3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iec61f1b791181451f11445715c1049291849ca21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463165Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5cbb8488..4fe27472 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I92a0a9c32f9e1da7566f17f03343f77c81e8867e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#815536}
-
Aga Wronska authored
This policy allows adding Family Link accounts additionally to accounts listed in DeviceUserAllowlist policy and is dedicated for school use. Bug: 1126155 Change-Id: Ia0f34b97b31dd143db3a0c2d839e2b4a314ac086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448671Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#815535}
-
Anton Bikineev authored
This implements probabilistic conservative heap scanning for normal bucket pool. The CL doesn't include the followings things (they'll be addressed in followup CLs): - scanning and quarantining directly mapped pages; - increasing size of empty page pool for scannable partitions; - zapping. Design doc: https://bit.ly/2RC8f6z Bug: 11297512 Change-Id: I019aa39ee3de73347ff50ee975548ba5a534cae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424285 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#815534}
-
Maggie Chen authored
Bug: 1088820 Change-Id: Ibc8fca88c90bff4699ccaf95296d261d73683a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462724 Auto-Submit: Maggie Chen <magchen@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#815533}
-
Colin Blundell authored
We are targeting the ads blocked infobar for componentization and reuse by WebLayer. To facilitate that componentization this CL eliminates the infobar's dependence on ChromeSubresourceFilterClient. To do so, we make ChromeSubresourceFilterClient::OnReloadRequested() an API on the SubresourceFilterClient interface. There is no behavioral change. In the future we plan to move the *implementation* of ChromeSubresourceFilterClient::OnReloadRequested() into the throttle manager for sharing with //weblayer. However, that is for a later stage, as it is dependent on first bringing awareness of content settings into the component. We have put a TODO in the code to this effect. Bug: 1116095 Change-Id: Iff57d3a3fe382d0371fc983084e75d3eb8fb7909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461006 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#815532}
-
